* [GIT PULL 00/13] perf/core improvements and fixes
@ 2018-09-19 14:25 Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 01/13] perf: Suppress AUX/OVERWRITE records Arnaldo Carvalho de Melo
` (13 more replies)
0 siblings, 14 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin,
Alexey Budankov, Andi Kleen, David Ahern, Ding Xiang,
Hendrik Brueckner, Jeremie Galarneau, Jiri Olsa, Kate Stewart,
Kim Phillips, Markus T Metzger, Namhyung Kim, Naveen N . Rao,
Peter Zijlstra, Ravi Bangoria, Sandipan Das, Stephane Eranian,
Thiago Macieira, Thomas Gleixner, Thomas Richter, Wang Nan,
Will Deacon, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 7f16023bfcc4b1f2bbccf86219dc97473db6e0d6:
Merge remote-tracking branch 'acme/perf/urgent' into perf/core (2018-09-18 17:20:41 -0300)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20180919
for you to fetch changes up to 24ef0fd0a1f389b156e6ef0edd71072728831bd9:
perf python: Use -Wno-redundant-decls to build with PYTHON=python3 (2018-09-19 10:25:13 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
perf test:
- Add watchpoint entry (Ravi Bangoria)
Build fixes:
- Initialize perf_data_file fd field to fix building the CTF (trace format)
converter with with gcc 4.8.4 on Ubuntu 14.04 (Jérémie Galarneau)
- Use -Wno-redundant-decls to build with PYTHON=python3 to
build the python binding, fixing the build in systems such
as Clear Linux (Arnaldo Carvalho de Melo)
Hardware tracing:
- Suppress AUX/OVERWRITE records (Alexander Shishkin)
Infrastructure:
- Adopt PTR_ERR_OR_ZERO from the kernel and use it in
the bpf-loader instead of open coded equivalent (Ding Xiang)
- Improve the event ordering code to make it clear and fix
a bug related to freeing of events when using pipe mode
from 'record' to 'inject' (Jiri Olsa)
- Some prep work to facilitate per-cpu threads to write
record data to per-cpu files (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Alexander Shishkin (1):
perf: Suppress AUX/OVERWRITE records
Arnaldo Carvalho de Melo (1):
perf python: Use -Wno-redundant-decls to build with PYTHON=python3
Ding Xiang (2):
tools include: Adopt PTR_ERR_OR_ZERO from the kernel err.h header
perf bpf-loader: use PTR_ERR_OR_ZERO inetead of return code
Jiri Olsa (7):
perf ordered_events: Add 'struct ordered_events_buffer' layer
perf ordered_events: Prevent crossing max_alloc_size
perf tools: Remove perf_tool from event_op2
perf tools: Remove perf_tool from event_op3
perf auxtrace: Pass struct perf_mmap into mmap__read* functions
perf tools: Add 'struct perf_mmap' arg to record__write()
perf util: Make copyfile_offset() global
Jérémie Galarneau (1):
perf tools: Initialize perf_data_file fd field
Ravi Bangoria (1):
perf test: Add watchpoint test
kernel/events/ring_buffer.c | 14 ++-
tools/include/linux/err.h | 7 ++
tools/perf/builtin-annotate.c | 7 +-
tools/perf/builtin-inject.c | 37 +++---
tools/perf/builtin-record.c | 51 +++++----
tools/perf/builtin-report.c | 9 +-
tools/perf/builtin-script.c | 38 +++----
tools/perf/builtin-stat.c | 23 ++--
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 9 ++
tools/perf/tests/tests.h | 3 +
tools/perf/tests/wp.c | 229 ++++++++++++++++++++++++++++++++++++++
tools/perf/util/auxtrace.c | 30 +++--
tools/perf/util/auxtrace.h | 21 ++--
tools/perf/util/bpf-loader.c | 2 +-
tools/perf/util/data-convert-bt.c | 2 +-
tools/perf/util/header.c | 16 ++-
tools/perf/util/header.h | 15 +--
tools/perf/util/mmap.c | 6 +-
tools/perf/util/mmap.h | 2 +-
tools/perf/util/ordered-events.c | 87 ++++++++++++---
tools/perf/util/ordered-events.h | 37 +++---
tools/perf/util/session.c | 75 ++++++-------
tools/perf/util/session.h | 5 +-
tools/perf/util/setup.py | 2 +-
tools/perf/util/stat.c | 5 +-
tools/perf/util/stat.h | 5 +-
tools/perf/util/tool.h | 7 +-
tools/perf/util/util.c | 2 +-
tools/perf/util/util.h | 2 +
30 files changed, 519 insertions(+), 230 deletions(-)
create mode 100644 tools/perf/tests/wp.c
Test results:
The first ones are container (docker) based builds of tools/perf with
and without libelf support. Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
The Clear Linux container is building with NO_CLANG=1, the problem preventing
its use has been identified and the next builds will build in ClearLinux with
both gcc and clang. This time around only gcc was used.
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0
6 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
7 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
8 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
14 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 8.2.1 20180502
15 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
16 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
17 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
18 debian:experimental : Ok gcc (Debian 8.2.0-7) 8.2.0
19 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0
20 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
21 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0
22 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
23 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
24 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
25 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
26 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
27 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
28 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
29 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
30 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
31 fedora:27 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6)
32 fedora:28 : Ok gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
33 fedora:rawhide : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3)
34 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0
35 mageia:5 : Ok gcc (GCC) 4.9.2
36 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0
37 opensuse:13.2 : Ok gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064]
38 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
39 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
40 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
41 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812]
42 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
43 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1)
44 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
45 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
46 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
47 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
48 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
49 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
50 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
51 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
52 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
53 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
54 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
55 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
56 ubuntu:18.04 : Ok gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
57 ubuntu:18.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
58 ubuntu:18.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
59 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
60 ubuntu:18.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
61 ubuntu:18.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
62 ubuntu:18.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
63 ubuntu:18.04-x-riscv64 : Ok riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
64 ubuntu:18.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
65 ubuntu:18.04-x-sh4 : Ok sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
66 ubuntu:18.04-x-sparc64 : Ok sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
67 ubuntu:18.10 : Ok gcc (Ubuntu 8.2.0-4ubuntu1) 8.2.0
#
# uname -a
Linux seventh 4.19.0-rc2-00176-gdb44bf4b4768 #1 SMP Thu Sep 6 14:38:21 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# git log --oneline -1
29715ae86e6c perf python: Use -Wno-redundant-decls to build with PYTHON=python3
# perf version --build-options
perf version 4.19.rc2.g29715a
dwarf: [ on ] # HAVE_DWARF_SUPPORT
dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
glibc: [ on ] # HAVE_GLIBC_SUPPORT
gtk2: [ on ] # HAVE_GTK2_SUPPORT
syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
libbfd: [ on ] # HAVE_LIBBFD_SUPPORT
libelf: [ on ] # HAVE_LIBELF_SUPPORT
libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT
numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT
libperl: [ on ] # HAVE_LIBPERL_SUPPORT
libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
libslang: [ on ] # HAVE_SLANG_SUPPORT
libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
zlib: [ on ] # HAVE_ZLIB_SUPPORT
lzma: [ on ] # HAVE_LZMA_SUPPORT
get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT
bpf: [ on ] # HAVE_LIBBPF_SUPPORT
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Watchpoint :
22.1: Read Only Watchpoint : Skip
22.2: Write Only Watchpoint : Ok
22.3: Read / Write Watchpoint : Ok
22.4: Modify Watchpoint : Ok
23: Number of exit events of a simple workload : Ok
24: Software clock events period values : Ok
25: Object code reading : Ok
26: Sample parsing : Ok
27: Use a dummy software event to keep tracking : Ok
28: Parse with no sample_id_all bit set : Ok
29: Filter hist entries : Ok
30: Lookup mmap thread : Ok
31: Share thread mg : Ok
32: Sort output of hist entries : Ok
33: Cumulate child hist entries : Ok
34: Track with sched_switch : Ok
35: Filter fds with revents mask in a fdarray : Ok
36: Add fd to a fdarray, making it autogrow : Ok
37: kmod_path__parse : Ok
38: Thread map : Ok
39: LLVM search and compile :
39.1: Basic BPF llvm compile : Ok
39.2: kbuild searching : Ok
39.3: Compile source for BPF prologue generation : Ok
39.4: Compile source for BPF relocation : Ok
40: Session topology : Ok
41: BPF filter :
41.1: Basic BPF filtering : Ok
41.2: BPF pinning : Ok
41.3: BPF prologue generation : Ok
41.4: BPF relocation checker : Ok
42: Synthesize thread map : Ok
43: Remove thread map : Ok
44: Synthesize cpu map : Ok
45: Synthesize stat config : Ok
46: Synthesize stat : Ok
47: Synthesize stat round : Ok
48: Synthesize attr update : Ok
49: Event times : Ok
50: Read backward ring buffer : Ok
51: Print cpu map : Ok
52: Probe SDT events : Ok
53: is_printable_array : Ok
54: Print bitmap : Ok
55: perf hooks : Ok
56: builtin clang support : Skip (not compiled in)
57: unit_number__scnprintf : Ok
58: mem2node : Ok
59: x86 rdpmc : Ok
60: Convert perf time to TSC : Ok
61: DWARF unwind : Ok
62: x86 instruction decoder - new instructions : Ok
63: x86 bp modify : FAILED!
64: probe libc's inet_pton & backtrace it with ping : Ok
65: Check open filename arg using perf trace + vfs_getname: Ok
66: Use vfs_getname probe to get syscall args filenames : Ok
67: Add vfs_getname probe to get syscall args filenames : Ok
# uname -a
Linux seventh 4.19.0-rc2-00176-gdb44bf4b4768 #1 SMP Thu Sep 6 14:38:21 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# git log --oneline -1
29715ae86e6c perf python: Use -Wno-redundant-decls to build with PYTHON=python3
# perf version --build-options
perf version 4.19.rc2.g29715a
dwarf: [ on ] # HAVE_DWARF_SUPPORT
dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
glibc: [ on ] # HAVE_GLIBC_SUPPORT
gtk2: [ on ] # HAVE_GTK2_SUPPORT
syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
libbfd: [ on ] # HAVE_LIBBFD_SUPPORT
libelf: [ on ] # HAVE_LIBELF_SUPPORT
libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT
numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT
libperl: [ on ] # HAVE_LIBPERL_SUPPORT
libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
libslang: [ on ] # HAVE_SLANG_SUPPORT
libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
zlib: [ on ] # HAVE_ZLIB_SUPPORT
lzma: [ on ] # HAVE_LZMA_SUPPORT
get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT
bpf: [ on ] # HAVE_LIBBPF_SUPPORT
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Watchpoint :
22.1: Read Only Watchpoint : Skip
22.2: Write Only Watchpoint : Ok
22.3: Read / Write Watchpoint : Ok
22.4: Modify Watchpoint : Ok
23: Number of exit events of a simple workload : Ok
24: Software clock events period values : Ok
25: Object code reading : Ok
26: Sample parsing : Ok
27: Use a dummy software event to keep tracking : Ok
28: Parse with no sample_id_all bit set : Ok
29: Filter hist entries : Ok
30: Lookup mmap thread : Ok
31: Share thread mg : Ok
32: Sort output of hist entries : Ok
33: Cumulate child hist entries : Ok
34: Track with sched_switch : Ok
35: Filter fds with revents mask in a fdarray : Ok
36: Add fd to a fdarray, making it autogrow : Ok
37: kmod_path__parse : Ok
38: Thread map : Ok
39: LLVM search and compile :
39.1: Basic BPF llvm compile : Ok
39.2: kbuild searching : Ok
39.3: Compile source for BPF prologue generation : Ok
39.4: Compile source for BPF relocation : Ok
40: Session topology : Ok
41: BPF filter :
41.1: Basic BPF filtering : Ok
41.2: BPF pinning : Ok
41.3: BPF prologue generation : Ok
41.4: BPF relocation checker : Ok
42: Synthesize thread map : Ok
43: Remove thread map : Ok
44: Synthesize cpu map : Ok
45: Synthesize stat config : Ok
46: Synthesize stat : Ok
47: Synthesize stat round : Ok
48: Synthesize attr update : Ok
49: Event times : Ok
50: Read backward ring buffer : Ok
51: Print cpu map : Ok
52: Probe SDT events : Ok
53: is_printable_array : Ok
54: Print bitmap : Ok
55: perf hooks : Ok
56: builtin clang support : Skip (not compiled in)
57: unit_number__scnprintf : Ok
58: mem2node : Ok
59: x86 rdpmc : Ok
60: Convert perf time to TSC : Ok
61: DWARF unwind : Ok
62: x86 instruction decoder - new instructions : Ok
63: x86 bp modify : FAILED!
64: probe libc's inet_pton & backtrace it with ping : Ok
65: Check open filename arg using perf trace + vfs_getname: Ok
66: Use vfs_getname probe to get syscall args filenames : Ok
67: Add vfs_getname probe to get syscall args filenames : Ok
[acme@jouet perf]$ time make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_clean_all_O: make clean all
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_static_O: make LDFLAGS=-static
make_no_newt_O: make NO_NEWT=1
make_doc_O: make doc
make_util_map_o_O: make util/map.o
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_gtk2_O: make NO_GTK2=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_tags_O: make tags
make_debug_O: make DEBUG=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_pure_O: make
make_no_libbpf_O: make NO_LIBBPF=1
make_install_prefix_O: make install prefix=/tmp/krava
make_perf_o_O: make perf.o
make_no_demangle_O: make NO_DEMANGLE=1
make_help_O: make help
make_install_O: make install
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_install_bin_O: make install-bin
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libelf_O: make NO_LIBELF=1
make_no_slang_O: make NO_SLANG=1
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 61+ messages in thread
* [PATCH 01/13] perf: Suppress AUX/OVERWRITE records
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 02/13] perf test: Add watchpoint test Arnaldo Carvalho de Melo
` (12 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Alexander Shishkin, Adrian Hunter, Markus T Metzger,
Arnaldo Carvalho de Melo
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
It has been pointed out to me many times that it is useful to be able to
switch off AUX records to save the bandwidth for records that actually
matter, for example, in AUX overwrite mode.
The usefulness of PERF_RECORD_AUX is in some of its flags, like the
TRUNCATED flag that tells the decoder where exactly gaps in the trace
are. The OVERWRITE flag, on the other hand will be set on every single
record in overwrite mode. However, a PERF_RECORD_AUX[flags=OVERWRITE] is
generated on every target task's sched_out, which over time adds up to a
lot of useless information.
If any folks out there have userspace that depends on a constant stream
of OVERWRITE records for a good reason, they'll have to let us know.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Markus T Metzger <markus.t.metzger@intel.com>
Link: http://lkml.kernel.org/r/20180404145323.28651-1-alexander.shishkin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
kernel/events/ring_buffer.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c
index 5d3cf407e374..4a9937076331 100644
--- a/kernel/events/ring_buffer.c
+++ b/kernel/events/ring_buffer.c
@@ -459,10 +459,20 @@ void perf_aux_output_end(struct perf_output_handle *handle, unsigned long size)
if (size || handle->aux_flags) {
/*
* Only send RECORD_AUX if we have something useful to communicate
+ *
+ * Note: the OVERWRITE records by themselves are not considered
+ * useful, as they don't communicate any *new* information,
+ * aside from the short-lived offset, that becomes history at
+ * the next event sched-in and therefore isn't useful.
+ * The userspace that needs to copy out AUX data in overwrite
+ * mode should know to use user_page::aux_head for the actual
+ * offset. So, from now on we don't output AUX records that
+ * have *only* OVERWRITE flag set.
*/
- perf_event_aux_event(handle->event, aux_head, size,
- handle->aux_flags);
+ if (handle->aux_flags & ~(u64)PERF_AUX_FLAG_OVERWRITE)
+ perf_event_aux_event(handle->event, aux_head, size,
+ handle->aux_flags);
}
rb->user_page->aux_head = rb->aux_head;
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 02/13] perf test: Add watchpoint test
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 01/13] perf: Suppress AUX/OVERWRITE records Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 03/13] perf ordered_events: Add 'struct ordered_events_buffer' layer Arnaldo Carvalho de Melo
` (11 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Ravi Bangoria,
Alexander Shishkin, Hendrik Brueckner, Kate Stewart,
Kim Phillips, Namhyung Kim, Naveen N . Rao, Sandipan Das,
Thomas Gleixner, Thomas Richter, Arnaldo Carvalho de Melo
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
We don't have a 'perf test' entry available to test the watchpoint
functionality.
Add a simple set of tests:
- Read only watchpoint
- Write only watchpoint
- Read / Write watchpoint
- Runtime watchpoint modification
Ex.: on powerpc:
$ sudo perf test 22
22: Watchpoint :
22.1: Read Only Watchpoint : Ok
22.2: Write Only Watchpoint : Ok
22.3: Read / Write Watchpoint : Ok
22.4: Modify Watchpoint : Ok
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Hendrik Brueckner <brueckner@linux.ibm.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>
Cc: Kim Phillips <kim.phillips@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Sandipan Das <sandipan@linux.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Link: http://lkml.kernel.org/r/20180912061229.22832-1-ravi.bangoria@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 9 ++
tools/perf/tests/tests.h | 3 +
tools/perf/tests/wp.c | 229 ++++++++++++++++++++++++++++++++++++++++
4 files changed, 242 insertions(+)
create mode 100644 tools/perf/tests/wp.c
diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
index 6c108fa79ae3..0b2b8305c965 100644
--- a/tools/perf/tests/Build
+++ b/tools/perf/tests/Build
@@ -21,6 +21,7 @@ perf-y += python-use.o
perf-y += bp_signal.o
perf-y += bp_signal_overflow.o
perf-y += bp_account.o
+perf-y += wp.o
perf-y += task-exit.o
perf-y += sw-clock.o
perf-y += mmap-thread-lookup.o
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index d7a5e1b9aa6f..54ca7d87236f 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -120,6 +120,15 @@ static struct test generic_tests[] = {
.func = test__bp_accounting,
.is_supported = test__bp_signal_is_supported,
},
+ {
+ .desc = "Watchpoint",
+ .func = test__wp,
+ .subtest = {
+ .skip_if_fail = false,
+ .get_nr = test__wp_subtest_get_nr,
+ .get_desc = test__wp_subtest_get_desc,
+ },
+ },
{
.desc = "Number of exit events of a simple workload",
.func = test__task_exit,
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index a9760e790563..8e26a4148f30 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -59,6 +59,9 @@ int test__python_use(struct test *test, int subtest);
int test__bp_signal(struct test *test, int subtest);
int test__bp_signal_overflow(struct test *test, int subtest);
int test__bp_accounting(struct test *test, int subtest);
+int test__wp(struct test *test, int subtest);
+const char *test__wp_subtest_get_desc(int subtest);
+int test__wp_subtest_get_nr(void);
int test__task_exit(struct test *test, int subtest);
int test__mem(struct test *test, int subtest);
int test__sw_clock_freq(struct test *test, int subtest);
diff --git a/tools/perf/tests/wp.c b/tools/perf/tests/wp.c
new file mode 100644
index 000000000000..017a99317f94
--- /dev/null
+++ b/tools/perf/tests/wp.c
@@ -0,0 +1,229 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <stdlib.h>
+#include <sys/ioctl.h>
+#include <linux/hw_breakpoint.h>
+#include "tests.h"
+#include "debug.h"
+#include "cloexec.h"
+
+#define WP_TEST_ASSERT_VAL(fd, text, val) \
+do { \
+ long long count; \
+ wp_read(fd, &count, sizeof(long long)); \
+ TEST_ASSERT_VAL(text, count == val); \
+} while (0)
+
+volatile u64 data1;
+volatile u8 data2[3];
+
+static int wp_read(int fd, long long *count, int size)
+{
+ int ret = read(fd, count, size);
+
+ if (ret != size) {
+ pr_debug("failed to read: %d\n", ret);
+ return -1;
+ }
+ return 0;
+}
+
+static void get__perf_event_attr(struct perf_event_attr *attr, int wp_type,
+ void *wp_addr, unsigned long wp_len)
+{
+ memset(attr, 0, sizeof(struct perf_event_attr));
+ attr->type = PERF_TYPE_BREAKPOINT;
+ attr->size = sizeof(struct perf_event_attr);
+ attr->config = 0;
+ attr->bp_type = wp_type;
+ attr->bp_addr = (unsigned long)wp_addr;
+ attr->bp_len = wp_len;
+ attr->sample_period = 1;
+ attr->sample_type = PERF_SAMPLE_IP;
+ attr->exclude_kernel = 1;
+ attr->exclude_hv = 1;
+}
+
+static int __event(int wp_type, void *wp_addr, unsigned long wp_len)
+{
+ int fd;
+ struct perf_event_attr attr;
+
+ get__perf_event_attr(&attr, wp_type, wp_addr, wp_len);
+ fd = sys_perf_event_open(&attr, 0, -1, -1,
+ perf_event_open_cloexec_flag());
+ if (fd < 0)
+ pr_debug("failed opening event %x\n", attr.bp_type);
+
+ return fd;
+}
+
+static int wp_ro_test(void)
+{
+ int fd;
+ unsigned long tmp, tmp1 = rand();
+
+ fd = __event(HW_BREAKPOINT_R, (void *)&data1, sizeof(data1));
+ if (fd < 0)
+ return -1;
+
+ tmp = data1;
+ WP_TEST_ASSERT_VAL(fd, "RO watchpoint", 1);
+
+ data1 = tmp1 + tmp;
+ WP_TEST_ASSERT_VAL(fd, "RO watchpoint", 1);
+
+ close(fd);
+ return 0;
+}
+
+static int wp_wo_test(void)
+{
+ int fd;
+ unsigned long tmp, tmp1 = rand();
+
+ fd = __event(HW_BREAKPOINT_W, (void *)&data1, sizeof(data1));
+ if (fd < 0)
+ return -1;
+
+ tmp = data1;
+ WP_TEST_ASSERT_VAL(fd, "WO watchpoint", 0);
+
+ data1 = tmp1 + tmp;
+ WP_TEST_ASSERT_VAL(fd, "WO watchpoint", 1);
+
+ close(fd);
+ return 0;
+}
+
+static int wp_rw_test(void)
+{
+ int fd;
+ unsigned long tmp, tmp1 = rand();
+
+ fd = __event(HW_BREAKPOINT_R | HW_BREAKPOINT_W, (void *)&data1,
+ sizeof(data1));
+ if (fd < 0)
+ return -1;
+
+ tmp = data1;
+ WP_TEST_ASSERT_VAL(fd, "RW watchpoint", 1);
+
+ data1 = tmp1 + tmp;
+ WP_TEST_ASSERT_VAL(fd, "RW watchpoint", 2);
+
+ close(fd);
+ return 0;
+}
+
+static int wp_modify_test(void)
+{
+ int fd, ret;
+ unsigned long tmp = rand();
+ struct perf_event_attr new_attr;
+
+ fd = __event(HW_BREAKPOINT_W, (void *)&data1, sizeof(data1));
+ if (fd < 0)
+ return -1;
+
+ data1 = tmp;
+ WP_TEST_ASSERT_VAL(fd, "Modify watchpoint", 1);
+
+ /* Modify watchpoint with disabled = 1 */
+ get__perf_event_attr(&new_attr, HW_BREAKPOINT_W, (void *)&data2[0],
+ sizeof(u8) * 2);
+ new_attr.disabled = 1;
+ ret = ioctl(fd, PERF_EVENT_IOC_MODIFY_ATTRIBUTES, &new_attr);
+ if (ret < 0) {
+ pr_debug("ioctl(PERF_EVENT_IOC_MODIFY_ATTRIBUTES) failed\n");
+ close(fd);
+ return ret;
+ }
+
+ data2[1] = tmp; /* Not Counted */
+ WP_TEST_ASSERT_VAL(fd, "Modify watchpoint", 1);
+
+ /* Enable the event */
+ ioctl(fd, PERF_EVENT_IOC_ENABLE, 0);
+ if (ret < 0) {
+ pr_debug("Failed to enable event\n");
+ close(fd);
+ return ret;
+ }
+
+ data2[1] = tmp; /* Counted */
+ WP_TEST_ASSERT_VAL(fd, "Modify watchpoint", 2);
+
+ data2[2] = tmp; /* Not Counted */
+ WP_TEST_ASSERT_VAL(fd, "Modify watchpoint", 2);
+
+ close(fd);
+ return 0;
+}
+
+static bool wp_ro_supported(void)
+{
+#if defined (__x86_64__) || defined (__i386__)
+ return false;
+#else
+ return true;
+#endif
+}
+
+static void wp_ro_skip_msg(void)
+{
+#if defined (__x86_64__) || defined (__i386__)
+ pr_debug("Hardware does not support read only watchpoints.\n");
+#endif
+}
+
+static struct {
+ const char *desc;
+ int (*target_func)(void);
+ bool (*is_supported)(void);
+ void (*skip_msg)(void);
+} wp_testcase_table[] = {
+ {
+ .desc = "Read Only Watchpoint",
+ .target_func = &wp_ro_test,
+ .is_supported = &wp_ro_supported,
+ .skip_msg = &wp_ro_skip_msg,
+ },
+ {
+ .desc = "Write Only Watchpoint",
+ .target_func = &wp_wo_test,
+ },
+ {
+ .desc = "Read / Write Watchpoint",
+ .target_func = &wp_rw_test,
+ },
+ {
+ .desc = "Modify Watchpoint",
+ .target_func = &wp_modify_test,
+ },
+};
+
+int test__wp_subtest_get_nr(void)
+{
+ return (int)ARRAY_SIZE(wp_testcase_table);
+}
+
+const char *test__wp_subtest_get_desc(int i)
+{
+ if (i < 0 || i >= (int)ARRAY_SIZE(wp_testcase_table))
+ return NULL;
+ return wp_testcase_table[i].desc;
+}
+
+int test__wp(struct test *test __maybe_unused, int i)
+{
+ if (i < 0 || i >= (int)ARRAY_SIZE(wp_testcase_table))
+ return TEST_FAIL;
+
+ if (wp_testcase_table[i].is_supported &&
+ !wp_testcase_table[i].is_supported()) {
+ wp_testcase_table[i].skip_msg();
+ return TEST_SKIP;
+ }
+
+ return !wp_testcase_table[i].target_func() ? TEST_OK : TEST_FAIL;
+}
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 03/13] perf ordered_events: Add 'struct ordered_events_buffer' layer
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 01/13] perf: Suppress AUX/OVERWRITE records Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 02/13] perf test: Add watchpoint test Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 04/13] perf ordered_events: Prevent crossing max_alloc_size Arnaldo Carvalho de Melo
` (10 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Jiri Olsa,
Alexander Shishkin, Andi Kleen, David Ahern, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
When ordering events, we use preallocated buffers to store separate
events. Those buffers currently don't have their own struct, but since
they are basically an array of 'struct ordered_event' objects, we use
the first event to hold buffers data - list head, that holds all buffers
together:
struct ordered_events {
...
struct ordered_event *buffer;
...
};
struct ordered_event {
u64 timestamp;
u64 file_offset;
union perf_event *event;
struct list_head list;
};
This is quite convoluted and error prone as demonstrated by free-ing
issue discovered and fixed by Stephane in here [1].
This patch adds the 'struct ordered_events_buffer' object, that holds
the buffer data and frees it up properly.
[1] - https://marc.info/?l=linux-kernel&m=153376761329335&w=2
Reported-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Stephane Eranian <eranian@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180907102455.7030-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/ordered-events.c | 83 +++++++++++++++++++++++++++++++++-------
tools/perf/util/ordered-events.h | 37 ++++++++++--------
2 files changed, 91 insertions(+), 29 deletions(-)
diff --git a/tools/perf/util/ordered-events.c b/tools/perf/util/ordered-events.c
index bad9e0296e9a..84ce25272c13 100644
--- a/tools/perf/util/ordered-events.c
+++ b/tools/perf/util/ordered-events.c
@@ -80,14 +80,20 @@ static union perf_event *dup_event(struct ordered_events *oe,
return oe->copy_on_queue ? __dup_event(oe, event) : event;
}
-static void free_dup_event(struct ordered_events *oe, union perf_event *event)
+static void __free_dup_event(struct ordered_events *oe, union perf_event *event)
{
- if (event && oe->copy_on_queue) {
+ if (event) {
oe->cur_alloc_size -= event->header.size;
free(event);
}
}
+static void free_dup_event(struct ordered_events *oe, union perf_event *event)
+{
+ if (oe->copy_on_queue)
+ __free_dup_event(oe, event);
+}
+
#define MAX_SAMPLE_BUFFER (64 * 1024 / sizeof(struct ordered_event))
static struct ordered_event *alloc_event(struct ordered_events *oe,
union perf_event *event)
@@ -100,15 +106,43 @@ static struct ordered_event *alloc_event(struct ordered_events *oe,
if (!new_event)
return NULL;
+ /*
+ * We maintain the following scheme of buffers for ordered
+ * event allocation:
+ *
+ * to_free list -> buffer1 (64K)
+ * buffer2 (64K)
+ * ...
+ *
+ * Each buffer keeps an array of ordered events objects:
+ * buffer -> event[0]
+ * event[1]
+ * ...
+ *
+ * Each allocated ordered event is linked to one of
+ * following lists:
+ * - time ordered list 'events'
+ * - list of currently removed events 'cache'
+ *
+ * Allocation of the ordered event uses the following order
+ * to get the memory:
+ * - use recently removed object from 'cache' list
+ * - use available object in current allocation buffer
+ * - allocate new buffer if the current buffer is full
+ *
+ * Removal of ordered event object moves it from events to
+ * the cache list.
+ */
if (!list_empty(cache)) {
new = list_entry(cache->next, struct ordered_event, list);
list_del(&new->list);
} else if (oe->buffer) {
- new = oe->buffer + oe->buffer_idx;
+ new = &oe->buffer->event[oe->buffer_idx];
if (++oe->buffer_idx == MAX_SAMPLE_BUFFER)
oe->buffer = NULL;
} else if (oe->cur_alloc_size < oe->max_alloc_size) {
- size_t size = MAX_SAMPLE_BUFFER * sizeof(*new);
+ size_t size = sizeof(*oe->buffer) +
+ MAX_SAMPLE_BUFFER * sizeof(*new);
oe->buffer = malloc(size);
if (!oe->buffer) {
@@ -122,11 +156,11 @@ static struct ordered_event *alloc_event(struct ordered_events *oe,
oe->cur_alloc_size += size;
list_add(&oe->buffer->list, &oe->to_free);
- /* First entry is abused to maintain the to_free list. */
- oe->buffer_idx = 2;
- new = oe->buffer + 1;
+ oe->buffer_idx = 1;
+ new = &oe->buffer->event[0];
} else {
pr("allocation limit reached %" PRIu64 "B\n", oe->max_alloc_size);
+ return NULL;
}
new->event = new_event;
@@ -300,15 +334,38 @@ void ordered_events__init(struct ordered_events *oe, ordered_events__deliver_t d
oe->deliver = deliver;
}
+static void
+ordered_events_buffer__free(struct ordered_events_buffer *buffer,
+ unsigned int max, struct ordered_events *oe)
+{
+ if (oe->copy_on_queue) {
+ unsigned int i;
+
+ for (i = 0; i < max; i++)
+ __free_dup_event(oe, buffer->event[i].event);
+ }
+
+ free(buffer);
+}
+
void ordered_events__free(struct ordered_events *oe)
{
- while (!list_empty(&oe->to_free)) {
- struct ordered_event *event;
+ struct ordered_events_buffer *buffer, *tmp;
- event = list_entry(oe->to_free.next, struct ordered_event, list);
- list_del(&event->list);
- free_dup_event(oe, event->event);
- free(event);
+ if (list_empty(&oe->to_free))
+ return;
+
+ /*
+ * Current buffer might not have all the events allocated
+ * yet, we need to free only allocated ones ...
+ */
+ list_del(&oe->buffer->list);
+ ordered_events_buffer__free(oe->buffer, oe->buffer_idx, oe);
+
+ /* ... and continue with the rest */
+ list_for_each_entry_safe(buffer, tmp, &oe->to_free, list) {
+ list_del(&buffer->list);
+ ordered_events_buffer__free(buffer, MAX_SAMPLE_BUFFER, oe);
}
}
diff --git a/tools/perf/util/ordered-events.h b/tools/perf/util/ordered-events.h
index 8c7a2948593e..1338d5c345dc 100644
--- a/tools/perf/util/ordered-events.h
+++ b/tools/perf/util/ordered-events.h
@@ -25,23 +25,28 @@ struct ordered_events;
typedef int (*ordered_events__deliver_t)(struct ordered_events *oe,
struct ordered_event *event);
+struct ordered_events_buffer {
+ struct list_head list;
+ struct ordered_event event[0];
+};
+
struct ordered_events {
- u64 last_flush;
- u64 next_flush;
- u64 max_timestamp;
- u64 max_alloc_size;
- u64 cur_alloc_size;
- struct list_head events;
- struct list_head cache;
- struct list_head to_free;
- struct ordered_event *buffer;
- struct ordered_event *last;
- ordered_events__deliver_t deliver;
- int buffer_idx;
- unsigned int nr_events;
- enum oe_flush last_flush_type;
- u32 nr_unordered_events;
- bool copy_on_queue;
+ u64 last_flush;
+ u64 next_flush;
+ u64 max_timestamp;
+ u64 max_alloc_size;
+ u64 cur_alloc_size;
+ struct list_head events;
+ struct list_head cache;
+ struct list_head to_free;
+ struct ordered_events_buffer *buffer;
+ struct ordered_event *last;
+ ordered_events__deliver_t deliver;
+ int buffer_idx;
+ unsigned int nr_events;
+ enum oe_flush last_flush_type;
+ u32 nr_unordered_events;
+ bool copy_on_queue;
};
int ordered_events__queue(struct ordered_events *oe, union perf_event *event,
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 04/13] perf ordered_events: Prevent crossing max_alloc_size
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 03/13] perf ordered_events: Add 'struct ordered_events_buffer' layer Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 05/13] tools include: Adopt PTR_ERR_OR_ZERO from the kernel err.h header Arnaldo Carvalho de Melo
` (9 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Jiri Olsa,
Alexander Shishkin, Andi Kleen, David Ahern, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
Stephane reported a possible issue in the ordered events code, which
could lead to allocating more memory than guarded by max_alloc_size.
He also suggested the fix to properly check that the new size is below
the max_alloc_size limit.
Reported-by: Stephane Eranian <eranian@google.com>
Suggested-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180907102455.7030-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/ordered-events.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/ordered-events.c b/tools/perf/util/ordered-events.c
index 84ce25272c13..1904e7f6ec84 100644
--- a/tools/perf/util/ordered-events.c
+++ b/tools/perf/util/ordered-events.c
@@ -101,6 +101,7 @@ static struct ordered_event *alloc_event(struct ordered_events *oe,
struct list_head *cache = &oe->cache;
struct ordered_event *new = NULL;
union perf_event *new_event;
+ size_t size;
new_event = dup_event(oe, event);
if (!new_event)
@@ -133,6 +134,8 @@ static struct ordered_event *alloc_event(struct ordered_events *oe,
* Removal of ordered event object moves it from events to
* the cache list.
*/
+ size = sizeof(*oe->buffer) + MAX_SAMPLE_BUFFER * sizeof(*new);
+
if (!list_empty(cache)) {
new = list_entry(cache->next, struct ordered_event, list);
list_del(&new->list);
@@ -140,10 +143,7 @@ static struct ordered_event *alloc_event(struct ordered_events *oe,
new = &oe->buffer->event[oe->buffer_idx];
if (++oe->buffer_idx == MAX_SAMPLE_BUFFER)
oe->buffer = NULL;
- } else if (oe->cur_alloc_size < oe->max_alloc_size) {
- size_t size = sizeof(*oe->buffer) +
- MAX_SAMPLE_BUFFER * sizeof(*new);
-
+ } else if ((oe->cur_alloc_size + size) < oe->max_alloc_size) {
oe->buffer = malloc(size);
if (!oe->buffer) {
free_dup_event(oe, new_event);
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 05/13] tools include: Adopt PTR_ERR_OR_ZERO from the kernel err.h header
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 04/13] perf ordered_events: Prevent crossing max_alloc_size Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 06/13] perf bpf-loader: use PTR_ERR_OR_ZERO inetead of return code Arnaldo Carvalho de Melo
` (8 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Ding Xiang,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Ding Xiang <dingxiang@cmss.chinamobile.com>
Add PTR_ERR_OR_ZERO, so that tools can use it, just like the kernel.
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1536284082-23466-1-git-send-email-dingxiang@cmss.chinamobile.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/include/linux/err.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/include/linux/err.h b/tools/include/linux/err.h
index 7a8b61ad44cb..094649667bae 100644
--- a/tools/include/linux/err.h
+++ b/tools/include/linux/err.h
@@ -52,4 +52,11 @@ static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
return unlikely(!ptr) || IS_ERR_VALUE((unsigned long)ptr);
}
+static inline int __must_check PTR_ERR_OR_ZERO(__force const void *ptr)
+{
+ if (IS_ERR(ptr))
+ return PTR_ERR(ptr);
+ else
+ return 0;
+}
#endif /* _LINUX_ERR_H */
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 06/13] perf bpf-loader: use PTR_ERR_OR_ZERO inetead of return code
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 05/13] tools include: Adopt PTR_ERR_OR_ZERO from the kernel err.h header Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 07/13] perf tools: Remove perf_tool from event_op2 Arnaldo Carvalho de Melo
` (7 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Ding Xiang,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Ding Xiang <dingxiang@cmss.chinamobile.com>
Use PTR_ERR_OR_ZERO() in bpf__setup_stdout() return code instead of open
coded equivalent.
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1536284082-23466-2-git-send-email-dingxiang@cmss.chinamobile.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/bpf-loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c
index 47aac41349a2..f9ae1a993806 100644
--- a/tools/perf/util/bpf-loader.c
+++ b/tools/perf/util/bpf-loader.c
@@ -1615,7 +1615,7 @@ struct perf_evsel *bpf__setup_output_event(struct perf_evlist *evlist, const cha
int bpf__setup_stdout(struct perf_evlist *evlist)
{
struct perf_evsel *evsel = bpf__setup_output_event(evlist, "__bpf_stdout__");
- return IS_ERR(evsel) ? PTR_ERR(evsel) : 0;
+ return PTR_ERR_OR_ZERO(evsel);
}
#define ERRNO_OFFSET(e) ((e) - __BPF_LOADER_ERRNO__START)
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 07/13] perf tools: Remove perf_tool from event_op2
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (5 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 06/13] perf bpf-loader: use PTR_ERR_OR_ZERO inetead of return code Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 08/13] perf tools: Remove perf_tool from event_op3 Arnaldo Carvalho de Melo
` (6 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Jiri Olsa,
Alexander Shishkin, Alexey Budankov, Andi Kleen, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
Now that we keep a perf_tool pointer inside perf_session, there's no
need to have a perf_tool argument in the event_op2 callback. Remove it.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180913125450.21342-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-annotate.c | 7 ++---
tools/perf/builtin-inject.c | 26 +++++++----------
tools/perf/builtin-report.c | 9 +++---
tools/perf/builtin-script.c | 38 ++++++++++++------------
tools/perf/builtin-stat.c | 23 +++++++--------
tools/perf/util/auxtrace.c | 10 +++----
tools/perf/util/auxtrace.h | 10 +++----
| 16 +++++------
| 15 ++++------
tools/perf/util/session.c | 67 ++++++++++++++++++-------------------------
tools/perf/util/session.h | 5 ++--
tools/perf/util/stat.c | 5 ++--
tools/perf/util/stat.h | 5 ++--
tools/perf/util/tool.h | 3 +-
14 files changed, 103 insertions(+), 136 deletions(-)
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 830481b8db26..93d679eaf1f4 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -283,12 +283,11 @@ static int process_sample_event(struct perf_tool *tool,
return ret;
}
-static int process_feature_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session)
+static int process_feature_event(struct perf_session *session,
+ union perf_event *event)
{
if (event->feat.feat_id < HEADER_LAST_FEATURE)
- return perf_event__process_feature(tool, event, session);
+ return perf_event__process_feature(session, event);
return 0;
}
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index a3b346359ba0..d77ed2aea95a 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -86,12 +86,10 @@ static int perf_event__drop_oe(struct perf_tool *tool __maybe_unused,
}
#endif
-static int perf_event__repipe_op2_synth(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session
- __maybe_unused)
+static int perf_event__repipe_op2_synth(struct perf_session *session,
+ union perf_event *event)
{
- return perf_event__repipe_synth(tool, event);
+ return perf_event__repipe_synth(session->tool, event);
}
static int perf_event__repipe_attr(struct perf_tool *tool,
@@ -362,26 +360,24 @@ static int perf_event__repipe_exit(struct perf_tool *tool,
return err;
}
-static int perf_event__repipe_tracing_data(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session)
+static int perf_event__repipe_tracing_data(struct perf_session *session,
+ union perf_event *event)
{
int err;
- perf_event__repipe_synth(tool, event);
- err = perf_event__process_tracing_data(tool, event, session);
+ perf_event__repipe_synth(session->tool, event);
+ err = perf_event__process_tracing_data(session, event);
return err;
}
-static int perf_event__repipe_id_index(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session)
+static int perf_event__repipe_id_index(struct perf_session *session,
+ union perf_event *event)
{
int err;
- perf_event__repipe_synth(tool, event);
- err = perf_event__process_id_index(tool, event, session);
+ perf_event__repipe_synth(session->tool, event);
+ err = perf_event__process_id_index(session, event);
return err;
}
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 76e12bcd1765..7507e4d6dce1 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -201,14 +201,13 @@ static void setup_forced_leader(struct report *report,
perf_evlist__force_leader(evlist);
}
-static int process_feature_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+static int process_feature_event(struct perf_session *session,
+ union perf_event *event)
{
- struct report *rep = container_of(tool, struct report, tool);
+ struct report *rep = container_of(session->tool, struct report, tool);
if (event->feat.feat_id < HEADER_LAST_FEATURE)
- return perf_event__process_feature(tool, event, session);
+ return perf_event__process_feature(session, event);
if (event->feat.feat_id != HEADER_LAST_FEATURE) {
pr_err("failed: wrong feature ID: %" PRIu64 "\n",
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 6176bae177c2..765391b6c88c 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2965,9 +2965,8 @@ static void script__setup_sample_type(struct perf_script *script)
}
}
-static int process_stat_round_event(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+static int process_stat_round_event(struct perf_session *session,
+ union perf_event *event)
{
struct stat_round_event *round = &event->stat_round;
struct perf_evsel *counter;
@@ -2981,9 +2980,8 @@ static int process_stat_round_event(struct perf_tool *tool __maybe_unused,
return 0;
}
-static int process_stat_config_event(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+static int process_stat_config_event(struct perf_session *session __maybe_unused,
+ union perf_event *event)
{
perf_event__read_stat_config(&stat_config, &event->stat_config);
return 0;
@@ -3009,10 +3007,10 @@ static int set_maps(struct perf_script *script)
}
static
-int process_thread_map_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+int process_thread_map_event(struct perf_session *session,
+ union perf_event *event)
{
+ struct perf_tool *tool = session->tool;
struct perf_script *script = container_of(tool, struct perf_script, tool);
if (script->threads) {
@@ -3028,10 +3026,10 @@ int process_thread_map_event(struct perf_tool *tool,
}
static
-int process_cpu_map_event(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+int process_cpu_map_event(struct perf_session *session,
+ union perf_event *event)
{
+ struct perf_tool *tool = session->tool;
struct perf_script *script = container_of(tool, struct perf_script, tool);
if (script->cpus) {
@@ -3046,21 +3044,21 @@ int process_cpu_map_event(struct perf_tool *tool __maybe_unused,
return set_maps(script);
}
-static int process_feature_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session)
+static int process_feature_event(struct perf_session *session,
+ union perf_event *event)
{
if (event->feat.feat_id < HEADER_LAST_FEATURE)
- return perf_event__process_feature(tool, event, session);
+ return perf_event__process_feature(session, event);
return 0;
}
#ifdef HAVE_AUXTRACE_SUPPORT
-static int perf_script__process_auxtrace_info(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session)
+static int perf_script__process_auxtrace_info(struct perf_session *session,
+ union perf_event *event)
{
- int ret = perf_event__process_auxtrace_info(tool, event, session);
+ struct perf_tool *tool = session->tool;
+
+ int ret = perf_event__process_auxtrace_info(session, event);
if (ret == 0) {
struct perf_script *script = container_of(tool, struct perf_script, tool);
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 0b0e3961d511..b86aba1c8028 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1354,9 +1354,8 @@ static int __cmd_record(int argc, const char **argv)
return argc;
}
-static int process_stat_round_event(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+static int process_stat_round_event(struct perf_session *session,
+ union perf_event *event)
{
struct stat_round_event *stat_round = &event->stat_round;
struct perf_evsel *counter;
@@ -1381,10 +1380,10 @@ static int process_stat_round_event(struct perf_tool *tool __maybe_unused,
}
static
-int process_stat_config_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+int process_stat_config_event(struct perf_session *session,
+ union perf_event *event)
{
+ struct perf_tool *tool = session->tool;
struct perf_stat *st = container_of(tool, struct perf_stat, tool);
perf_event__read_stat_config(&stat_config, &event->stat_config);
@@ -1424,10 +1423,10 @@ static int set_maps(struct perf_stat *st)
}
static
-int process_thread_map_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+int process_thread_map_event(struct perf_session *session,
+ union perf_event *event)
{
+ struct perf_tool *tool = session->tool;
struct perf_stat *st = container_of(tool, struct perf_stat, tool);
if (st->threads) {
@@ -1443,10 +1442,10 @@ int process_thread_map_event(struct perf_tool *tool,
}
static
-int process_cpu_map_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+int process_cpu_map_event(struct perf_session *session,
+ union perf_event *event)
{
+ struct perf_tool *tool = session->tool;
struct perf_stat *st = container_of(tool, struct perf_stat, tool);
struct cpu_map *cpus;
diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index db1511359c5e..86f0bc445f93 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -906,9 +906,8 @@ int perf_event__synthesize_auxtrace_info(struct auxtrace_record *itr,
return err;
}
-int perf_event__process_auxtrace_info(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+int perf_event__process_auxtrace_info(struct perf_session *session,
+ union perf_event *event)
{
enum auxtrace_type type = event->auxtrace_info.type;
@@ -1185,9 +1184,8 @@ void events_stats__auxtrace_error_warn(const struct events_stats *stats)
}
}
-int perf_event__process_auxtrace_error(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+int perf_event__process_auxtrace_error(struct perf_session *session,
+ union perf_event *event)
{
if (auxtrace__dont_decode(session))
return 0;
diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
index 71fc3bd74299..97776470a52e 100644
--- a/tools/perf/util/auxtrace.h
+++ b/tools/perf/util/auxtrace.h
@@ -517,15 +517,13 @@ int perf_event__synthesize_auxtrace_info(struct auxtrace_record *itr,
struct perf_tool *tool,
struct perf_session *session,
perf_event__handler_t process);
-int perf_event__process_auxtrace_info(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+int perf_event__process_auxtrace_info(struct perf_session *session,
+ union perf_event *event);
s64 perf_event__process_auxtrace(struct perf_tool *tool,
union perf_event *event,
struct perf_session *session);
-int perf_event__process_auxtrace_error(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+int perf_event__process_auxtrace_error(struct perf_session *session,
+ union perf_event *event);
int itrace_parse_synth_opts(const struct option *opt, const char *str,
int unset);
void itrace_synth_opts__set_default(struct itrace_synth_opts *synth_opts);
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 91e6d9cfd906..c78051ad1fcc 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -3448,10 +3448,10 @@ int perf_event__synthesize_features(struct perf_tool *tool,
return ret;
}
-int perf_event__process_feature(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session __maybe_unused)
+int perf_event__process_feature(struct perf_session *session,
+ union perf_event *event)
{
+ struct perf_tool *tool = session->tool;
struct feat_fd ff = { .fd = 0 };
struct feature_event *fe = (struct feature_event *)event;
int type = fe->header.type;
@@ -3856,9 +3856,8 @@ int perf_event__synthesize_tracing_data(struct perf_tool *tool, int fd,
return aligned_size;
}
-int perf_event__process_tracing_data(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+int perf_event__process_tracing_data(struct perf_session *session,
+ union perf_event *event)
{
ssize_t size_read, padding, size = event->tracing_data.size;
int fd = perf_data__fd(session->data);
@@ -3924,9 +3923,8 @@ int perf_event__synthesize_build_id(struct perf_tool *tool,
return err;
}
-int perf_event__process_build_id(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+int perf_event__process_build_id(struct perf_session *session,
+ union perf_event *event)
{
__event_process_build_id(&event->build_id,
event->build_id.filename,
--git a/tools/perf/util/header.h b/tools/perf/util/header.h
index ff2a1263fb9b..e17903caa71d 100644
--- a/tools/perf/util/header.h
+++ b/tools/perf/util/header.h
@@ -116,9 +116,8 @@ int perf_event__synthesize_extra_attr(struct perf_tool *tool,
perf_event__handler_t process,
bool is_pipe);
-int perf_event__process_feature(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+int perf_event__process_feature(struct perf_session *session,
+ union perf_event *event);
int perf_event__synthesize_attr(struct perf_tool *tool,
struct perf_event_attr *attr, u32 ids, u64 *id,
@@ -148,17 +147,15 @@ size_t perf_event__fprintf_event_update(union perf_event *event, FILE *fp);
int perf_event__synthesize_tracing_data(struct perf_tool *tool,
int fd, struct perf_evlist *evlist,
perf_event__handler_t process);
-int perf_event__process_tracing_data(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+int perf_event__process_tracing_data(struct perf_session *session,
+ union perf_event *event);
int perf_event__synthesize_build_id(struct perf_tool *tool,
struct dso *pos, u16 misc,
perf_event__handler_t process,
struct machine *machine);
-int perf_event__process_build_id(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+int perf_event__process_build_id(struct perf_session *session,
+ union perf_event *event);
bool is_perf_magic(u64 magic);
#define NAME_ALIGN 64
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 8b9369303561..e781cdba845c 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -199,12 +199,10 @@ void perf_session__delete(struct perf_session *session)
free(session);
}
-static int process_event_synth_tracing_data_stub(struct perf_tool *tool
+static int process_event_synth_tracing_data_stub(struct perf_session *session
__maybe_unused,
union perf_event *event
- __maybe_unused,
- struct perf_session *session
- __maybe_unused)
+ __maybe_unused)
{
dump_printf(": unhandled!\n");
return 0;
@@ -288,9 +286,8 @@ static s64 process_event_auxtrace_stub(struct perf_tool *tool __maybe_unused,
return event->auxtrace.size;
}
-static int process_event_op2_stub(struct perf_tool *tool __maybe_unused,
- union perf_event *event __maybe_unused,
- struct perf_session *session __maybe_unused)
+static int process_event_op2_stub(struct perf_session *session __maybe_unused,
+ union perf_event *event __maybe_unused)
{
dump_printf(": unhandled!\n");
return 0;
@@ -298,9 +295,8 @@ static int process_event_op2_stub(struct perf_tool *tool __maybe_unused,
static
-int process_event_thread_map_stub(struct perf_tool *tool __maybe_unused,
- union perf_event *event __maybe_unused,
- struct perf_session *session __maybe_unused)
+int process_event_thread_map_stub(struct perf_session *session __maybe_unused,
+ union perf_event *event __maybe_unused)
{
if (dump_trace)
perf_event__fprintf_thread_map(event, stdout);
@@ -310,9 +306,8 @@ int process_event_thread_map_stub(struct perf_tool *tool __maybe_unused,
}
static
-int process_event_cpu_map_stub(struct perf_tool *tool __maybe_unused,
- union perf_event *event __maybe_unused,
- struct perf_session *session __maybe_unused)
+int process_event_cpu_map_stub(struct perf_session *session __maybe_unused,
+ union perf_event *event __maybe_unused)
{
if (dump_trace)
perf_event__fprintf_cpu_map(event, stdout);
@@ -322,9 +317,8 @@ int process_event_cpu_map_stub(struct perf_tool *tool __maybe_unused,
}
static
-int process_event_stat_config_stub(struct perf_tool *tool __maybe_unused,
- union perf_event *event __maybe_unused,
- struct perf_session *session __maybe_unused)
+int process_event_stat_config_stub(struct perf_session *session __maybe_unused,
+ union perf_event *event __maybe_unused)
{
if (dump_trace)
perf_event__fprintf_stat_config(event, stdout);
@@ -333,10 +327,8 @@ int process_event_stat_config_stub(struct perf_tool *tool __maybe_unused,
return 0;
}
-static int process_stat_stub(struct perf_tool *tool __maybe_unused,
- union perf_event *event __maybe_unused,
- struct perf_session *perf_session
- __maybe_unused)
+static int process_stat_stub(struct perf_session *perf_session __maybe_unused,
+ union perf_event *event)
{
if (dump_trace)
perf_event__fprintf_stat(event, stdout);
@@ -345,10 +337,8 @@ static int process_stat_stub(struct perf_tool *tool __maybe_unused,
return 0;
}
-static int process_stat_round_stub(struct perf_tool *tool __maybe_unused,
- union perf_event *event __maybe_unused,
- struct perf_session *perf_session
- __maybe_unused)
+static int process_stat_round_stub(struct perf_session *perf_session __maybe_unused,
+ union perf_event *event)
{
if (dump_trace)
perf_event__fprintf_stat_round(event, stdout);
@@ -1374,37 +1364,37 @@ static s64 perf_session__process_user_event(struct perf_session *session,
case PERF_RECORD_HEADER_TRACING_DATA:
/* setup for reading amidst mmap */
lseek(fd, file_offset, SEEK_SET);
- return tool->tracing_data(tool, event, session);
+ return tool->tracing_data(session, event);
case PERF_RECORD_HEADER_BUILD_ID:
- return tool->build_id(tool, event, session);
+ return tool->build_id(session, event);
case PERF_RECORD_FINISHED_ROUND:
return tool->finished_round(tool, event, oe);
case PERF_RECORD_ID_INDEX:
- return tool->id_index(tool, event, session);
+ return tool->id_index(session, event);
case PERF_RECORD_AUXTRACE_INFO:
- return tool->auxtrace_info(tool, event, session);
+ return tool->auxtrace_info(session, event);
case PERF_RECORD_AUXTRACE:
/* setup for reading amidst mmap */
lseek(fd, file_offset + event->header.size, SEEK_SET);
return tool->auxtrace(tool, event, session);
case PERF_RECORD_AUXTRACE_ERROR:
perf_session__auxtrace_error_inc(session, event);
- return tool->auxtrace_error(tool, event, session);
+ return tool->auxtrace_error(session, event);
case PERF_RECORD_THREAD_MAP:
- return tool->thread_map(tool, event, session);
+ return tool->thread_map(session, event);
case PERF_RECORD_CPU_MAP:
- return tool->cpu_map(tool, event, session);
+ return tool->cpu_map(session, event);
case PERF_RECORD_STAT_CONFIG:
- return tool->stat_config(tool, event, session);
+ return tool->stat_config(session, event);
case PERF_RECORD_STAT:
- return tool->stat(tool, event, session);
+ return tool->stat(session, event);
case PERF_RECORD_STAT_ROUND:
- return tool->stat_round(tool, event, session);
+ return tool->stat_round(session, event);
case PERF_RECORD_TIME_CONV:
session->time_conv = event->time_conv;
- return tool->time_conv(tool, event, session);
+ return tool->time_conv(session, event);
case PERF_RECORD_HEADER_FEATURE:
- return tool->feature(tool, event, session);
+ return tool->feature(session, event);
default:
return -EINVAL;
}
@@ -2133,9 +2123,8 @@ int __perf_session__set_tracepoints_handlers(struct perf_session *session,
return err;
}
-int perf_event__process_id_index(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+int perf_event__process_id_index(struct perf_session *session,
+ union perf_event *event)
{
struct perf_evlist *evlist = session->evlist;
struct id_index_event *ie = &event->id_index;
diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
index da40b4b380ca..d96eccd7d27f 100644
--- a/tools/perf/util/session.h
+++ b/tools/perf/util/session.h
@@ -120,9 +120,8 @@ int perf_session__deliver_synth_event(struct perf_session *session,
union perf_event *event,
struct perf_sample *sample);
-int perf_event__process_id_index(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+int perf_event__process_id_index(struct perf_session *session,
+ union perf_event *event);
int perf_event__synthesize_id_index(struct perf_tool *tool,
perf_event__handler_t process,
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 5d3172bcc4ae..4d40515307b8 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -374,9 +374,8 @@ int perf_stat_process_counter(struct perf_stat_config *config,
return 0;
}
-int perf_event__process_stat_event(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session)
+int perf_event__process_stat_event(struct perf_session *session,
+ union perf_event *event)
{
struct perf_counts_values count;
struct stat_event *st = &event->stat;
diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
index 3a13a6dc5a62..2f9c9159a364 100644
--- a/tools/perf/util/stat.h
+++ b/tools/perf/util/stat.h
@@ -199,9 +199,8 @@ int perf_stat_process_counter(struct perf_stat_config *config,
struct perf_tool;
union perf_event;
struct perf_session;
-int perf_event__process_stat_event(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+int perf_event__process_stat_event(struct perf_session *session,
+ union perf_event *event);
size_t perf_event__fprintf_stat(union perf_event *event, FILE *fp);
size_t perf_event__fprintf_stat_round(union perf_event *event, FILE *fp);
diff --git a/tools/perf/util/tool.h b/tools/perf/util/tool.h
index 183c91453522..9c7f78d76275 100644
--- a/tools/perf/util/tool.h
+++ b/tools/perf/util/tool.h
@@ -26,8 +26,7 @@ typedef int (*event_attr_op)(struct perf_tool *tool,
union perf_event *event,
struct perf_evlist **pevlist);
-typedef int (*event_op2)(struct perf_tool *tool, union perf_event *event,
- struct perf_session *session);
+typedef int (*event_op2)(struct perf_session *session, union perf_event *event);
typedef int (*event_oe)(struct perf_tool *tool, union perf_event *event,
struct ordered_events *oe);
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 08/13] perf tools: Remove perf_tool from event_op3
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (6 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 07/13] perf tools: Remove perf_tool from event_op2 Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 09/13] perf auxtrace: Pass struct perf_mmap into mmap__read* functions Arnaldo Carvalho de Melo
` (5 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Jiri Olsa,
Alexander Shishkin, Alexey Budankov, Andi Kleen, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
Now that we keep a perf_tool pointer inside perf_session, there's no need
to have a perf_tool argument in the event_op3 callback. Remove it.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180913125450.21342-3-jolsa@kernel.org
[ Fix the builtin-inject.c build for !HAVE_AUXTRACE_SUPPORT ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-inject.c | 11 +++++------
tools/perf/util/auxtrace.c | 7 +++----
tools/perf/util/auxtrace.h | 5 ++---
tools/perf/util/session.c | 8 +++-----
tools/perf/util/tool.h | 4 +---
5 files changed, 14 insertions(+), 21 deletions(-)
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index d77ed2aea95a..b4a29f435b06 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -131,10 +131,10 @@ static int copy_bytes(struct perf_inject *inject, int fd, off_t size)
return 0;
}
-static s64 perf_event__repipe_auxtrace(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session)
+static s64 perf_event__repipe_auxtrace(struct perf_session *session,
+ union perf_event *event)
{
+ struct perf_tool *tool = session->tool;
struct perf_inject *inject = container_of(tool, struct perf_inject,
tool);
int ret;
@@ -172,9 +172,8 @@ static s64 perf_event__repipe_auxtrace(struct perf_tool *tool,
#else
static s64
-perf_event__repipe_auxtrace(struct perf_tool *tool __maybe_unused,
- union perf_event *event __maybe_unused,
- struct perf_session *session __maybe_unused)
+perf_event__repipe_auxtrace(struct perf_session *session __maybe_unused,
+ union perf_event *event __maybe_unused)
{
pr_err("AUX area tracing not supported\n");
return -EINVAL;
diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index 86f0bc445f93..3017b205a157 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -931,9 +931,8 @@ int perf_event__process_auxtrace_info(struct perf_session *session,
}
}
-s64 perf_event__process_auxtrace(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session)
+s64 perf_event__process_auxtrace(struct perf_session *session,
+ union perf_event *event)
{
s64 err;
@@ -949,7 +948,7 @@ s64 perf_event__process_auxtrace(struct perf_tool *tool,
if (!session->auxtrace || event->header.type != PERF_RECORD_AUXTRACE)
return -EINVAL;
- err = session->auxtrace->process_auxtrace_event(session, event, tool);
+ err = session->auxtrace->process_auxtrace_event(session, event, session->tool);
if (err < 0)
return err;
diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
index 97776470a52e..6be89776358c 100644
--- a/tools/perf/util/auxtrace.h
+++ b/tools/perf/util/auxtrace.h
@@ -519,9 +519,8 @@ int perf_event__synthesize_auxtrace_info(struct auxtrace_record *itr,
perf_event__handler_t process);
int perf_event__process_auxtrace_info(struct perf_session *session,
union perf_event *event);
-s64 perf_event__process_auxtrace(struct perf_tool *tool,
- union perf_event *event,
- struct perf_session *session);
+s64 perf_event__process_auxtrace(struct perf_session *session,
+ union perf_event *event);
int perf_event__process_auxtrace_error(struct perf_session *session,
union perf_event *event);
int itrace_parse_synth_opts(const struct option *opt, const char *str,
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index e781cdba845c..7d2c8ce6cfad 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -275,10 +275,8 @@ static int skipn(int fd, off_t n)
return 0;
}
-static s64 process_event_auxtrace_stub(struct perf_tool *tool __maybe_unused,
- union perf_event *event,
- struct perf_session *session
- __maybe_unused)
+static s64 process_event_auxtrace_stub(struct perf_session *session __maybe_unused,
+ union perf_event *event)
{
dump_printf(": unhandled!\n");
if (perf_data__is_pipe(session->data))
@@ -1376,7 +1374,7 @@ static s64 perf_session__process_user_event(struct perf_session *session,
case PERF_RECORD_AUXTRACE:
/* setup for reading amidst mmap */
lseek(fd, file_offset + event->header.size, SEEK_SET);
- return tool->auxtrace(tool, event, session);
+ return tool->auxtrace(session, event);
case PERF_RECORD_AUXTRACE_ERROR:
perf_session__auxtrace_error_inc(session, event);
return tool->auxtrace_error(session, event);
diff --git a/tools/perf/util/tool.h b/tools/perf/util/tool.h
index 9c7f78d76275..56e4ca54020a 100644
--- a/tools/perf/util/tool.h
+++ b/tools/perf/util/tool.h
@@ -27,13 +27,11 @@ typedef int (*event_attr_op)(struct perf_tool *tool,
struct perf_evlist **pevlist);
typedef int (*event_op2)(struct perf_session *session, union perf_event *event);
+typedef s64 (*event_op3)(struct perf_session *session, union perf_event *event);
typedef int (*event_oe)(struct perf_tool *tool, union perf_event *event,
struct ordered_events *oe);
-typedef s64 (*event_op3)(struct perf_tool *tool, union perf_event *event,
- struct perf_session *session);
-
enum show_feature_header {
SHOW_FEAT_NO_HEADER = 0,
SHOW_FEAT_HEADER,
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 09/13] perf auxtrace: Pass struct perf_mmap into mmap__read* functions
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (7 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 08/13] perf tools: Remove perf_tool from event_op3 Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 10/13] perf tools: Add 'struct perf_mmap' arg to record__write() Arnaldo Carvalho de Melo
` (4 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Jiri Olsa,
Alexander Shishkin, Alexey Budankov, Andi Kleen, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
The perf_mmap struct will hold a file pointer to write the mmap's
contents, so we need to propagate it down the stack to record__write
callers instead of its member the auxtrace_mmap struct.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180913125450.21342-4-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 27 +++++++++++++--------------
tools/perf/util/auxtrace.c | 11 ++++++-----
tools/perf/util/auxtrace.h | 5 +++--
3 files changed, 22 insertions(+), 21 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 9853552bcf16..fd8b12c5f4ae 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -207,11 +207,11 @@ static int record__process_auxtrace(struct perf_tool *tool,
}
static int record__auxtrace_mmap_read(struct record *rec,
- struct auxtrace_mmap *mm)
+ struct perf_mmap *map)
{
int ret;
- ret = auxtrace_mmap__read(mm, rec->itr, &rec->tool,
+ ret = auxtrace_mmap__read(map, rec->itr, &rec->tool,
record__process_auxtrace);
if (ret < 0)
return ret;
@@ -223,11 +223,11 @@ static int record__auxtrace_mmap_read(struct record *rec,
}
static int record__auxtrace_mmap_read_snapshot(struct record *rec,
- struct auxtrace_mmap *mm)
+ struct perf_mmap *map)
{
int ret;
- ret = auxtrace_mmap__read_snapshot(mm, rec->itr, &rec->tool,
+ ret = auxtrace_mmap__read_snapshot(map, rec->itr, &rec->tool,
record__process_auxtrace,
rec->opts.auxtrace_snapshot_size);
if (ret < 0)
@@ -245,13 +245,12 @@ static int record__auxtrace_read_snapshot_all(struct record *rec)
int rc = 0;
for (i = 0; i < rec->evlist->nr_mmaps; i++) {
- struct auxtrace_mmap *mm =
- &rec->evlist->mmap[i].auxtrace_mmap;
+ struct perf_mmap *map = &rec->evlist->mmap[i];
- if (!mm->base)
+ if (!map->auxtrace_mmap.base)
continue;
- if (record__auxtrace_mmap_read_snapshot(rec, mm) != 0) {
+ if (record__auxtrace_mmap_read_snapshot(rec, map) != 0) {
rc = -1;
goto out;
}
@@ -295,7 +294,7 @@ static int record__auxtrace_init(struct record *rec)
static inline
int record__auxtrace_mmap_read(struct record *rec __maybe_unused,
- struct auxtrace_mmap *mm __maybe_unused)
+ struct perf_mmap *map __maybe_unused)
{
return 0;
}
@@ -529,17 +528,17 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
return 0;
for (i = 0; i < evlist->nr_mmaps; i++) {
- struct auxtrace_mmap *mm = &maps[i].auxtrace_mmap;
+ struct perf_mmap *map = &maps[i];
- if (maps[i].base) {
- if (perf_mmap__push(&maps[i], rec, record__pushfn) != 0) {
+ if (map->base) {
+ if (perf_mmap__push(map, rec, record__pushfn) != 0) {
rc = -1;
goto out;
}
}
- if (mm->base && !rec->opts.auxtrace_snapshot_mode &&
- record__auxtrace_mmap_read(rec, mm) != 0) {
+ if (map->auxtrace_mmap.base && !rec->opts.auxtrace_snapshot_mode &&
+ record__auxtrace_mmap_read(rec, map) != 0) {
rc = -1;
goto out;
}
diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index 3017b205a157..2fecee57f555 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -1193,11 +1193,12 @@ int perf_event__process_auxtrace_error(struct perf_session *session,
return 0;
}
-static int __auxtrace_mmap__read(struct auxtrace_mmap *mm,
+static int __auxtrace_mmap__read(struct perf_mmap *map,
struct auxtrace_record *itr,
struct perf_tool *tool, process_auxtrace_t fn,
bool snapshot, size_t snapshot_size)
{
+ struct auxtrace_mmap *mm = &map->auxtrace_mmap;
u64 head, old = mm->prev, offset, ref;
unsigned char *data = mm->base;
size_t size, head_off, old_off, len1, len2, padding;
@@ -1303,18 +1304,18 @@ static int __auxtrace_mmap__read(struct auxtrace_mmap *mm,
return 1;
}
-int auxtrace_mmap__read(struct auxtrace_mmap *mm, struct auxtrace_record *itr,
+int auxtrace_mmap__read(struct perf_mmap *map, struct auxtrace_record *itr,
struct perf_tool *tool, process_auxtrace_t fn)
{
- return __auxtrace_mmap__read(mm, itr, tool, fn, false, 0);
+ return __auxtrace_mmap__read(map, itr, tool, fn, false, 0);
}
-int auxtrace_mmap__read_snapshot(struct auxtrace_mmap *mm,
+int auxtrace_mmap__read_snapshot(struct perf_mmap *map,
struct auxtrace_record *itr,
struct perf_tool *tool, process_auxtrace_t fn,
size_t snapshot_size)
{
- return __auxtrace_mmap__read(mm, itr, tool, fn, true, snapshot_size);
+ return __auxtrace_mmap__read(map, itr, tool, fn, true, snapshot_size);
}
/**
diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
index 6be89776358c..7eeb141361b9 100644
--- a/tools/perf/util/auxtrace.h
+++ b/tools/perf/util/auxtrace.h
@@ -33,6 +33,7 @@ union perf_event;
struct perf_session;
struct perf_evlist;
struct perf_tool;
+struct perf_mmap;
struct option;
struct record_opts;
struct auxtrace_info_event;
@@ -437,10 +438,10 @@ typedef int (*process_auxtrace_t)(struct perf_tool *tool,
union perf_event *event, void *data1,
size_t len1, void *data2, size_t len2);
-int auxtrace_mmap__read(struct auxtrace_mmap *mm, struct auxtrace_record *itr,
+int auxtrace_mmap__read(struct perf_mmap *map, struct auxtrace_record *itr,
struct perf_tool *tool, process_auxtrace_t fn);
-int auxtrace_mmap__read_snapshot(struct auxtrace_mmap *mm,
+int auxtrace_mmap__read_snapshot(struct perf_mmap *map,
struct auxtrace_record *itr,
struct perf_tool *tool, process_auxtrace_t fn,
size_t snapshot_size);
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 10/13] perf tools: Add 'struct perf_mmap' arg to record__write()
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (8 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 09/13] perf auxtrace: Pass struct perf_mmap into mmap__read* functions Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 11/13] perf util: Make copyfile_offset() global Arnaldo Carvalho de Melo
` (3 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Jiri Olsa,
Alexander Shishkin, Alexey Budankov, Andi Kleen, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
The struct perf_mmap map argument will hold the file pointer to write
the data to.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180913125450.21342-5-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 24 ++++++++++++++----------
tools/perf/util/auxtrace.c | 2 +-
tools/perf/util/auxtrace.h | 1 +
tools/perf/util/mmap.c | 6 +++---
tools/perf/util/mmap.h | 2 +-
5 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index fd8b12c5f4ae..0980dfe3396b 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -106,9 +106,12 @@ static bool switch_output_time(struct record *rec)
trigger_is_ready(&switch_output_trigger);
}
-static int record__write(struct record *rec, void *bf, size_t size)
+static int record__write(struct record *rec, struct perf_mmap *map __maybe_unused,
+ void *bf, size_t size)
{
- if (perf_data__write(rec->session->data, bf, size) < 0) {
+ struct perf_data_file *file = &rec->session->data->file;
+
+ if (perf_data_file__write(file, bf, size) < 0) {
pr_err("failed to write perf data, error: %m\n");
return -1;
}
@@ -127,15 +130,15 @@ static int process_synthesized_event(struct perf_tool *tool,
struct machine *machine __maybe_unused)
{
struct record *rec = container_of(tool, struct record, tool);
- return record__write(rec, event, event->header.size);
+ return record__write(rec, NULL, event, event->header.size);
}
-static int record__pushfn(void *to, void *bf, size_t size)
+static int record__pushfn(struct perf_mmap *map, void *to, void *bf, size_t size)
{
struct record *rec = to;
rec->samples++;
- return record__write(rec, bf, size);
+ return record__write(rec, map, bf, size);
}
static volatile int done;
@@ -170,6 +173,7 @@ static void record__sig_exit(void)
#ifdef HAVE_AUXTRACE_SUPPORT
static int record__process_auxtrace(struct perf_tool *tool,
+ struct perf_mmap *map,
union perf_event *event, void *data1,
size_t len1, void *data2, size_t len2)
{
@@ -197,11 +201,11 @@ static int record__process_auxtrace(struct perf_tool *tool,
if (padding)
padding = 8 - padding;
- record__write(rec, event, event->header.size);
- record__write(rec, data1, len1);
+ record__write(rec, map, event, event->header.size);
+ record__write(rec, map, data1, len1);
if (len2)
- record__write(rec, data2, len2);
- record__write(rec, &pad, padding);
+ record__write(rec, map, data2, len2);
+ record__write(rec, map, &pad, padding);
return 0;
}
@@ -549,7 +553,7 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
* at least one event.
*/
if (bytes_written != rec->bytes_written)
- rc = record__write(rec, &finished_round_event, sizeof(finished_round_event));
+ rc = record__write(rec, NULL, &finished_round_event, sizeof(finished_round_event));
if (overwrite)
perf_evlist__toggle_bkw_mmap(evlist, BKW_MMAP_EMPTY);
diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index 2fecee57f555..c4617bcfd521 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -1285,7 +1285,7 @@ static int __auxtrace_mmap__read(struct perf_mmap *map,
ev.auxtrace.tid = mm->tid;
ev.auxtrace.cpu = mm->cpu;
- if (fn(tool, &ev, data1, len1, data2, len2))
+ if (fn(tool, map, &ev, data1, len1, data2, len2))
return -1;
mm->prev = head;
diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
index 7eeb141361b9..a86b7eab6673 100644
--- a/tools/perf/util/auxtrace.h
+++ b/tools/perf/util/auxtrace.h
@@ -435,6 +435,7 @@ void auxtrace_mmap_params__set_idx(struct auxtrace_mmap_params *mp,
bool per_cpu);
typedef int (*process_auxtrace_t)(struct perf_tool *tool,
+ struct perf_mmap *map,
union perf_event *event, void *data1,
size_t len1, void *data2, size_t len2);
diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
index 215f69f41672..cdb95b3a1213 100644
--- a/tools/perf/util/mmap.c
+++ b/tools/perf/util/mmap.c
@@ -281,7 +281,7 @@ int perf_mmap__read_init(struct perf_mmap *map)
}
int perf_mmap__push(struct perf_mmap *md, void *to,
- int push(void *to, void *buf, size_t size))
+ int push(struct perf_mmap *map, void *to, void *buf, size_t size))
{
u64 head = perf_mmap__read_head(md);
unsigned char *data = md->base + page_size;
@@ -300,7 +300,7 @@ int perf_mmap__push(struct perf_mmap *md, void *to,
size = md->mask + 1 - (md->start & md->mask);
md->start += size;
- if (push(to, buf, size) < 0) {
+ if (push(md, to, buf, size) < 0) {
rc = -1;
goto out;
}
@@ -310,7 +310,7 @@ int perf_mmap__push(struct perf_mmap *md, void *to,
size = md->end - md->start;
md->start += size;
- if (push(to, buf, size) < 0) {
+ if (push(md, to, buf, size) < 0) {
rc = -1;
goto out;
}
diff --git a/tools/perf/util/mmap.h b/tools/perf/util/mmap.h
index 05a6d47c7956..e603314dc792 100644
--- a/tools/perf/util/mmap.h
+++ b/tools/perf/util/mmap.h
@@ -93,7 +93,7 @@ union perf_event *perf_mmap__read_forward(struct perf_mmap *map);
union perf_event *perf_mmap__read_event(struct perf_mmap *map);
int perf_mmap__push(struct perf_mmap *md, void *to,
- int push(void *to, void *buf, size_t size));
+ int push(struct perf_mmap *map, void *to, void *buf, size_t size));
size_t perf_mmap__mmap_len(struct perf_mmap *map);
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 11/13] perf util: Make copyfile_offset() global
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (9 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 10/13] perf tools: Add 'struct perf_mmap' arg to record__write() Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 12/13] perf tools: Initialize perf_data_file fd field Arnaldo Carvalho de Melo
` (2 subsequent siblings)
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Jiri Olsa,
Alexander Shishkin, Alexey Budankov, Andi Kleen, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
It will be used outside of util object in following patches.
Committer note:
We need to have the header with the definition for loff_t in util.h
since we now use it in the copyfile_offset() signature.
Also move that prototype closer to the other copyfile_ prefixed
functions.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180913125450.21342-10-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/util.c | 2 +-
tools/perf/util/util.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index eac5b858a371..093352e93d50 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -221,7 +221,7 @@ static int slow_copyfile(const char *from, const char *to, struct nsinfo *nsi)
return err;
}
-static int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64 size)
+int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64 size)
{
void *ptr;
loff_t pgoff;
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index dc58254a2b69..14508ee7707a 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -6,6 +6,7 @@
/* glibc 2.20 deprecates _BSD_SOURCE in favour of _DEFAULT_SOURCE */
#define _DEFAULT_SOURCE 1
+#include <fcntl.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdlib.h>
@@ -35,6 +36,7 @@ bool lsdir_no_dot_filter(const char *name, struct dirent *d);
int copyfile(const char *from, const char *to);
int copyfile_mode(const char *from, const char *to, mode_t mode);
int copyfile_ns(const char *from, const char *to, struct nsinfo *nsi);
+int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64 size);
ssize_t readn(int fd, void *buf, size_t n);
ssize_t writen(int fd, const void *buf, size_t n);
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 12/13] perf tools: Initialize perf_data_file fd field
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (10 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 11/13] perf util: Make copyfile_offset() global Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 13/13] perf python: Use -Wno-redundant-decls to build with PYTHON=python3 Arnaldo Carvalho de Melo
2018-09-25 9:21 ` [GIT PULL 00/13] perf/core improvements and fixes Ingo Molnar
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Jérémie Galarneau, Alexander Shishkin, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Building the perf CTF converter fails with gcc 4.8.4 on Ubuntu 14.04
with the following error:
error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
[-Werror=missing-field-initializers]
Per 4b838b0db4e9 ("perf tools: Add compression id into 'struct
kmod_path'") and the ensuing discussion on the mailing list, it appears
that this affects other distributions and gcc versions.
Signed-off-by: Jeremie Galarneau <jeremie.galarneau@efficios.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180829201648.19588-1-jeremie.galarneau@efficios.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/data-convert-bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index abd38abf1d91..f75d4aa612c5 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
{
struct perf_session *session;
struct perf_data data = {
- .file.path = input,
+ .file = { .path = input, .fd = -1 },
.mode = PERF_DATA_MODE_READ,
.force = opts->force,
};
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 13/13] perf python: Use -Wno-redundant-decls to build with PYTHON=python3
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (11 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 12/13] perf tools: Initialize perf_data_file fd field Arnaldo Carvalho de Melo
@ 2018-09-19 14:25 ` Arnaldo Carvalho de Melo
2018-09-25 9:21 ` [GIT PULL 00/13] perf/core improvements and fixes Ingo Molnar
13 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-19 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Arnaldo Carvalho de Melo, Adrian Hunter, David Ahern, Jiri Olsa,
Namhyung Kim, Thiago Macieira, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
When building in ClearLinux using 'make PYTHON=python3' with gcc 8.2.1
it fails with:
GEN /tmp/build/perf/python/perf.so
In file included from /usr/include/python3.7m/Python.h:126,
from /git/linux/tools/perf/util/python.c:2:
/usr/include/python3.7m/import.h:58:24: error: redundant redeclaration of ‘_PyImport_AddModuleObject’ [-Werror=redundant-decls]
PyAPI_FUNC(PyObject *) _PyImport_AddModuleObject(PyObject *, PyObject *);
^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/python3.7m/import.h:47:24: note: previous declaration of ‘_PyImport_AddModuleObject’ was here
PyAPI_FUNC(PyObject *) _PyImport_AddModuleObject(PyObject *name,
^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
error: command 'gcc' failed with exit status 1
And indeed there is a redundant declaration in that Python.h file, one
with parameter names and the other without, so just add
-Wno-error=redundant-decls to the python setup instructions.
Now perf builds with gcc in ClearLinux with the following Dockerfile:
# docker.io/acmel/linux-perf-tools-build-clearlinux:latest
FROM docker.io/clearlinux:latest
MAINTAINER Arnaldo Carvalho de Melo <acme@kernel.org>
RUN swupd update && \
swupd bundle-add sysadmin-basic-dev
RUN mkdir -m 777 -p /git /tmp/build/perf /tmp/build/objtool /tmp/build/linux && \
groupadd -r perfbuilder && \
useradd -m -r -g perfbuilder perfbuilder && \
chown -R perfbuilder.perfbuilder /tmp/build/ /git/
USER perfbuilder
COPY rx_and_build.sh /
ENV EXTRA_MAKE_ARGS=PYTHON=python3
ENTRYPOINT ["/rx_and_build.sh"]
Now to figure out why the build fails with clang, that is present in the
above container as detected by the rx_and_build.sh script:
clang version 6.0.1 (tags/RELEASE_601/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/sbin
make: Entering directory '/git/linux/tools/perf'
BUILD: Doing 'make -j4' parallel build
HOSTCC /tmp/build/perf/fixdep.o
HOSTLD /tmp/build/perf/fixdep-in.o
LINK /tmp/build/perf/fixdep
Auto-detecting system features:
... dwarf: [ OFF ]
... dwarf_getlocations: [ OFF ]
... glibc: [ OFF ]
... gtk2: [ OFF ]
... libaudit: [ OFF ]
... libbfd: [ OFF ]
... libelf: [ OFF ]
... libnuma: [ OFF ]
... numa_num_possible_cpus: [ OFF ]
... libperl: [ OFF ]
... libpython: [ OFF ]
... libslang: [ OFF ]
... libcrypto: [ OFF ]
... libunwind: [ OFF ]
... libdw-dwarf-unwind: [ OFF ]
... zlib: [ OFF ]
... lzma: [ OFF ]
... get_cpuid: [ OFF ]
... bpf: [ OFF ]
Makefile.config:331: *** No gnu/libc-version.h found, please install glibc-dev[el]. Stop.
make[1]: *** [Makefile.perf:206: sub-make] Error 2
make: *** [Makefile:70: all] Error 2
make: Leaving directory '/git/linux/tools/perf'
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Thiago Macieira <thiago.macieira@intel.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-c3khb9ac86s00qxzjrueomme@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
index 97efbcad076e..1942f6dd24f6 100644
--- a/tools/perf/util/setup.py
+++ b/tools/perf/util/setup.py
@@ -35,7 +35,7 @@ class install_lib(_install_lib):
cflags = getenv('CFLAGS', '').split()
# switch off several checks (need to be at the end of cflags list)
-cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter' ]
+cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls' ]
if cc != "clang":
cflags += ['-Wno-cast-function-type' ]
--
2.14.4
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (12 preceding siblings ...)
2018-09-19 14:25 ` [PATCH 13/13] perf python: Use -Wno-redundant-decls to build with PYTHON=python3 Arnaldo Carvalho de Melo
@ 2018-09-25 9:21 ` Ingo Molnar
13 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2018-09-25 9:21 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Alexey Budankov, Andi Kleen, David Ahern,
Ding Xiang, Hendrik Brueckner, Jeremie Galarneau, Jiri Olsa,
Kate Stewart, Kim Phillips, Markus T Metzger, Namhyung Kim,
Naveen N . Rao, Peter Zijlstra, Ravi Bangoria, Sandipan Das,
Stephane Eranian, Thiago Macieira, Thomas Gleixner,
Thomas Richter, Wang Nan, Will Deacon, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 7f16023bfcc4b1f2bbccf86219dc97473db6e0d6:
>
> Merge remote-tracking branch 'acme/perf/urgent' into perf/core (2018-09-18 17:20:41 -0300)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20180919
>
> for you to fetch changes up to 24ef0fd0a1f389b156e6ef0edd71072728831bd9:
>
> perf python: Use -Wno-redundant-decls to build with PYTHON=python3 (2018-09-19 10:25:13 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> perf test:
>
> - Add watchpoint entry (Ravi Bangoria)
>
> Build fixes:
>
> - Initialize perf_data_file fd field to fix building the CTF (trace format)
> converter with with gcc 4.8.4 on Ubuntu 14.04 (Jérémie Galarneau)
>
> - Use -Wno-redundant-decls to build with PYTHON=python3 to
> build the python binding, fixing the build in systems such
> as Clear Linux (Arnaldo Carvalho de Melo)
>
> Hardware tracing:
>
> - Suppress AUX/OVERWRITE records (Alexander Shishkin)
>
> Infrastructure:
>
> - Adopt PTR_ERR_OR_ZERO from the kernel and use it in
> the bpf-loader instead of open coded equivalent (Ding Xiang)
>
> - Improve the event ordering code to make it clear and fix
> a bug related to freeing of events when using pipe mode
> from 'record' to 'inject' (Jiri Olsa)
>
> - Some prep work to facilitate per-cpu threads to write
> record data to per-cpu files (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Alexander Shishkin (1):
> perf: Suppress AUX/OVERWRITE records
>
> Arnaldo Carvalho de Melo (1):
> perf python: Use -Wno-redundant-decls to build with PYTHON=python3
>
> Ding Xiang (2):
> tools include: Adopt PTR_ERR_OR_ZERO from the kernel err.h header
> perf bpf-loader: use PTR_ERR_OR_ZERO inetead of return code
>
> Jiri Olsa (7):
> perf ordered_events: Add 'struct ordered_events_buffer' layer
> perf ordered_events: Prevent crossing max_alloc_size
> perf tools: Remove perf_tool from event_op2
> perf tools: Remove perf_tool from event_op3
> perf auxtrace: Pass struct perf_mmap into mmap__read* functions
> perf tools: Add 'struct perf_mmap' arg to record__write()
> perf util: Make copyfile_offset() global
>
> Jérémie Galarneau (1):
> perf tools: Initialize perf_data_file fd field
>
> Ravi Bangoria (1):
> perf test: Add watchpoint test
>
> kernel/events/ring_buffer.c | 14 ++-
> tools/include/linux/err.h | 7 ++
> tools/perf/builtin-annotate.c | 7 +-
> tools/perf/builtin-inject.c | 37 +++---
> tools/perf/builtin-record.c | 51 +++++----
> tools/perf/builtin-report.c | 9 +-
> tools/perf/builtin-script.c | 38 +++----
> tools/perf/builtin-stat.c | 23 ++--
> tools/perf/tests/Build | 1 +
> tools/perf/tests/builtin-test.c | 9 ++
> tools/perf/tests/tests.h | 3 +
> tools/perf/tests/wp.c | 229 ++++++++++++++++++++++++++++++++++++++
> tools/perf/util/auxtrace.c | 30 +++--
> tools/perf/util/auxtrace.h | 21 ++--
> tools/perf/util/bpf-loader.c | 2 +-
> tools/perf/util/data-convert-bt.c | 2 +-
> tools/perf/util/header.c | 16 ++-
> tools/perf/util/header.h | 15 +--
> tools/perf/util/mmap.c | 6 +-
> tools/perf/util/mmap.h | 2 +-
> tools/perf/util/ordered-events.c | 87 ++++++++++++---
> tools/perf/util/ordered-events.h | 37 +++---
> tools/perf/util/session.c | 75 ++++++-------
> tools/perf/util/session.h | 5 +-
> tools/perf/util/setup.py | 2 +-
> tools/perf/util/stat.c | 5 +-
> tools/perf/util/stat.h | 5 +-
> tools/perf/util/tool.h | 7 +-
> tools/perf/util/util.c | 2 +-
> tools/perf/util/util.h | 2 +
> 30 files changed, 519 insertions(+), 230 deletions(-)
> create mode 100644 tools/perf/tests/wp.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2017-09-04 14:00 Arnaldo Carvalho de Melo
@ 2017-09-05 5:15 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2017-09-05 5:15 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Anton Blanchard,
Flavio Bruno Leitner, Jack Henschel, Jiri Olsa, Kan Liang,
linuxppc-dev, Madhavan Srinivasan, Mark Rutland,
Michael Ellerman, Michael Petlan, Namhyung Kim, Peter Zijlstra,
Ravi Bangoria, Stephane Eranian, Sukadev Bhattiprolu,
Taeung Song, Thomas Gleixner, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 1b2f76d77a277bb70d38ad0991ed7f16bbc115a9:
>
> Merge tag 'perf-core-for-mingo-4.14-20170829' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-08-29 23:13:56 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170901
>
> for you to fetch changes up to eba9fac017617e685d648339e29a1453a30cb065:
>
> perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB (2017-09-01 14:55:40 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Support syscall name glob matching in 'perf trace' (Arnaldo Carvalho de Melo)
>
> e.g.:
>
> # perf trace -e pkey_*
> 32.784 (0.006 ms): pkey/16018 pkey_alloc(init_val: DISABLE_WRITE) = -1 EINVAL Invalid argument
> 32.795 (0.004 ms): pkey/16018 pkey_mprotect(start: 0x7f380d0a6000, len: 4096, prot: READ|WRITE, pkey: -1) = 0
> 32.801 (0.002 ms): pkey/16018 pkey_free(pkey: -1 ) = -1 EINVAL Invalid argument
> ^C#
>
> - Do not auto merge counts for explicitely specified events in
> 'perf stat' (Arnaldo Carvalho de Melo)
>
> - Fix syntax in documentation of .perfconfig intel-pt option (Jack Henschel)
>
> - Calculate the average cycles of iterations for loops detected by the
> branch history support in 'perf report' (Jin Yao)
>
> - Support PERF_SAMPLE_PHYS_ADDR as a sort key "phys_daddr" in the 'script', 'mem',
> 'top' and 'report'. Also add a test entry for it in 'perf test' (Kan Liang)
>
> - Fix 'Object code reading' 'perf test' entry in PowerPC (Ravi Bangoria)
>
> - Remove some duplicate Power9 duplicate vendor events (described in JSON
> files) (Sukadev Bhattiprolu)
>
> - Add help entry in the TUI annotate browser about cycling thru hottest
> instructions with TAB/shift+TAB (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
> perf syscalltbl: Support glob matching on syscall names
> perf trace: Support syscall name globbing
> perf stat: Only auto-merge events that are PMU aliases
> perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB
>
> Jack Henschel (1):
> perf intel-pt: Fix syntax in documentation of config option
>
> Jin Yao (1):
> perf report: Calculate the average cycles of iterations
>
> Kan Liang (5):
> perf tools: Support new sample type for physical address
> perf sort: Add sort option for physical address
> perf mem: Support physical address
> perf script: Support physical address
> perf test: Add test case for PERF_SAMPLE_PHYS_ADDR
>
> Ravi Bangoria (1):
> perf test powerpc: Fix 'Object code reading' test
>
> Sukadev Bhattiprolu (1):
> perf vendor events powerpc: Remove duplicate events
>
> tools/include/uapi/linux/perf_event.h | 4 +-
> tools/perf/Documentation/intel-pt.txt | 2 +-
> tools/perf/Documentation/perf-mem.txt | 4 +
> tools/perf/Documentation/perf-record.txt | 5 +-
> tools/perf/Documentation/perf-report.txt | 1 +
> tools/perf/Documentation/perf-script.txt | 2 +-
> tools/perf/Documentation/perf-trace.txt | 2 +-
> tools/perf/builtin-mem.c | 97 ++++++++++++-----
> tools/perf/builtin-record.c | 2 +
> tools/perf/builtin-script.c | 15 ++-
> tools/perf/builtin-stat.c | 2 +-
> tools/perf/builtin-trace.c | 39 ++++++-
> tools/perf/perf.h | 1 +
> .../pmu-events/arch/powerpc/power9/frontend.json | 7 +-
> .../perf/pmu-events/arch/powerpc/power9/other.json | 120 ---------------------
> .../pmu-events/arch/powerpc/power9/pipeline.json | 7 +-
> tools/perf/pmu-events/arch/powerpc/power9/pmc.json | 7 +-
> tools/perf/tests/code-reading.c | 5 +
> tools/perf/tests/sample-parsing.c | 6 +-
> tools/perf/ui/browsers/annotate.c | 3 +-
> tools/perf/ui/browsers/hists.c | 8 +-
> tools/perf/ui/stdio/hist.c | 10 +-
> tools/perf/util/callchain.c | 49 ++++-----
> tools/perf/util/callchain.h | 9 +-
> tools/perf/util/event.h | 1 +
> tools/perf/util/evsel.c | 19 +++-
> tools/perf/util/evsel.h | 1 +
> tools/perf/util/hist.c | 4 +
> tools/perf/util/hist.h | 1 +
> tools/perf/util/machine.c | 96 ++++++++++-------
> tools/perf/util/parse-events.c | 24 +++--
> tools/perf/util/session.c | 3 +
> tools/perf/util/sort.c | 42 ++++++++
> tools/perf/util/sort.h | 1 +
> tools/perf/util/symbol.h | 1 +
> tools/perf/util/syscalltbl.c | 33 ++++++
> tools/perf/util/syscalltbl.h | 3 +
> 37 files changed, 368 insertions(+), 268 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2017-09-04 14:00 Arnaldo Carvalho de Melo
2017-09-05 5:15 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-09-04 14:00 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, Andi Kleen, Anton Blanchard,
Flavio Bruno Leitner, Jack Henschel, Jiri Olsa, Kan Liang,
linuxppc-dev, Madhavan Srinivasan, Mark Rutland,
Michael Ellerman, Michael Petlan, Namhyung Kim, Peter Zijlstra,
Ravi Bangoria, Stephane Eranian, Sukadev Bhattiprolu,
Taeung Song, Thomas Gleixner, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 1b2f76d77a277bb70d38ad0991ed7f16bbc115a9:
Merge tag 'perf-core-for-mingo-4.14-20170829' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-08-29 23:13:56 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170901
for you to fetch changes up to eba9fac017617e685d648339e29a1453a30cb065:
perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB (2017-09-01 14:55:40 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Support syscall name glob matching in 'perf trace' (Arnaldo Carvalho de Melo)
e.g.:
# perf trace -e pkey_*
32.784 (0.006 ms): pkey/16018 pkey_alloc(init_val: DISABLE_WRITE) = -1 EINVAL Invalid argument
32.795 (0.004 ms): pkey/16018 pkey_mprotect(start: 0x7f380d0a6000, len: 4096, prot: READ|WRITE, pkey: -1) = 0
32.801 (0.002 ms): pkey/16018 pkey_free(pkey: -1 ) = -1 EINVAL Invalid argument
^C#
- Do not auto merge counts for explicitely specified events in
'perf stat' (Arnaldo Carvalho de Melo)
- Fix syntax in documentation of .perfconfig intel-pt option (Jack Henschel)
- Calculate the average cycles of iterations for loops detected by the
branch history support in 'perf report' (Jin Yao)
- Support PERF_SAMPLE_PHYS_ADDR as a sort key "phys_daddr" in the 'script', 'mem',
'top' and 'report'. Also add a test entry for it in 'perf test' (Kan Liang)
- Fix 'Object code reading' 'perf test' entry in PowerPC (Ravi Bangoria)
- Remove some duplicate Power9 duplicate vendor events (described in JSON
files) (Sukadev Bhattiprolu)
- Add help entry in the TUI annotate browser about cycling thru hottest
instructions with TAB/shift+TAB (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
perf syscalltbl: Support glob matching on syscall names
perf trace: Support syscall name globbing
perf stat: Only auto-merge events that are PMU aliases
perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB
Jack Henschel (1):
perf intel-pt: Fix syntax in documentation of config option
Jin Yao (1):
perf report: Calculate the average cycles of iterations
Kan Liang (5):
perf tools: Support new sample type for physical address
perf sort: Add sort option for physical address
perf mem: Support physical address
perf script: Support physical address
perf test: Add test case for PERF_SAMPLE_PHYS_ADDR
Ravi Bangoria (1):
perf test powerpc: Fix 'Object code reading' test
Sukadev Bhattiprolu (1):
perf vendor events powerpc: Remove duplicate events
tools/include/uapi/linux/perf_event.h | 4 +-
tools/perf/Documentation/intel-pt.txt | 2 +-
tools/perf/Documentation/perf-mem.txt | 4 +
tools/perf/Documentation/perf-record.txt | 5 +-
tools/perf/Documentation/perf-report.txt | 1 +
tools/perf/Documentation/perf-script.txt | 2 +-
tools/perf/Documentation/perf-trace.txt | 2 +-
tools/perf/builtin-mem.c | 97 ++++++++++++-----
tools/perf/builtin-record.c | 2 +
tools/perf/builtin-script.c | 15 ++-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-trace.c | 39 ++++++-
tools/perf/perf.h | 1 +
.../pmu-events/arch/powerpc/power9/frontend.json | 7 +-
.../perf/pmu-events/arch/powerpc/power9/other.json | 120 ---------------------
.../pmu-events/arch/powerpc/power9/pipeline.json | 7 +-
tools/perf/pmu-events/arch/powerpc/power9/pmc.json | 7 +-
tools/perf/tests/code-reading.c | 5 +
tools/perf/tests/sample-parsing.c | 6 +-
tools/perf/ui/browsers/annotate.c | 3 +-
tools/perf/ui/browsers/hists.c | 8 +-
tools/perf/ui/stdio/hist.c | 10 +-
tools/perf/util/callchain.c | 49 ++++-----
tools/perf/util/callchain.h | 9 +-
tools/perf/util/event.h | 1 +
tools/perf/util/evsel.c | 19 +++-
tools/perf/util/evsel.h | 1 +
tools/perf/util/hist.c | 4 +
tools/perf/util/hist.h | 1 +
tools/perf/util/machine.c | 96 ++++++++++-------
tools/perf/util/parse-events.c | 24 +++--
tools/perf/util/session.c | 3 +
tools/perf/util/sort.c | 42 ++++++++
tools/perf/util/sort.h | 1 +
tools/perf/util/symbol.h | 1 +
tools/perf/util/syscalltbl.c | 33 ++++++
tools/perf/util/syscalltbl.h | 3 +
37 files changed, 368 insertions(+), 268 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf
commands with a variety of command line event specifications to then
intercept the sys_perf_event syscall to check that the perf_event_attr
fields are set up as expected, among a variety of other unit tests.
The 'perf test' also runs shell scripts exercising the tools, checking
if they affect the system in certain ways, like setting up kprobes and
uprobes, request callchains for well known programs and check that they
are the expected ones, see if 'perf trace' beautifies system call
arguments correctly, etc.
Additionally, a new set of tests, script based, runs the tools in a live system,
setting probes in place that then gets used by 'perf trace', with its output
compared against expected results.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# time dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 archlinux:latest: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: Ok
24 fedora:25: Ok
25 fedora:26: Ok
26 fedora:rawhide: Ok
27 mageia:5: Ok
28 opensuse:13.2: Ok
29 opensuse:42.1: Ok
30 opensuse:42.2: Ok
31 opensuse:42.3: Ok
32 opensuse:tumbleweed: Ok
33 oraclelinux:6: Ok
34 oraclelinux:7: Ok
35 ubuntu:12.04.5: Ok
36 ubuntu:14.04.4: Ok
37 ubuntu:14.04.4-x-linaro-arm64: Ok
38 ubuntu:15.10: Ok
39 ubuntu:16.04: Ok
40 ubuntu:16.04-x-arm: Ok
41 ubuntu:16.04-x-arm64: Ok
42 ubuntu:16.04-x-powerpc: Ok
43 ubuntu:16.04-x-powerpc64: Ok
44 ubuntu:16.04-x-powerpc64el: Ok
45 ubuntu:16.04-x-s390: Ok
46 ubuntu:16.10: Ok
47 ubuntu:17.04: Ok
48 ubuntu:17.10: Ok
#
# uname -a
Linux jouet 4.13.0-rc4+ #2 SMP Fri Aug 11 12:39:09 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Intel cqm nmi context read : Skip
61: Use vfs_getname probe to get syscall args filenames : Ok
62: probe libc's inet_pton & backtrace it with ping : Ok
63: Check open filename arg using perf trace + vfs_getname: Ok
64: Add vfs_getname probe to get syscall args filenames : Ok
#
$ time make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_libbionic_O: make NO_LIBBIONIC=1
make_debug_O: make DEBUG=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_libperl_O: make NO_LIBPERL=1
make_help_O: make help
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_tags_O: make tags
make_no_newt_O: make NO_NEWT=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_gtk2_O: make NO_GTK2=1
make_util_map_o_O: make util/map.o
make_perf_o_O: make perf.o
make_doc_O: make doc
make_static_O: make LDFLAGS=-static
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_install_bin_O: make install-bin
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_pure_O: make
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_libelf_O: make NO_LIBELF=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_install_prefix_O: make install prefix=/tmp/krava
make_install_O: make install
make_clean_all_O: make clean all
make_no_slang_O: make NO_SLANG=1
OK
$
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2017-08-21 19:25 Arnaldo Carvalho de Melo
@ 2017-08-22 10:20 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2017-08-22 10:20 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter, Andi Kleen,
Daniel Díaz, David Ahern, Jiri Olsa, Martin Liška,
Milian Wolff, Namhyung Kim, Peter Zijlstra, Taeung Song,
Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 9881223c6cc0644cc3aeea41e1f19ea7e3041f33:
>
> Merge tag 'perf-core-for-mingo-4.14-20170816' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-08-17 09:41:56 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170821
>
> for you to fetch changes up to 3a555c7799de69d73826eccc9a21948a5775d4d3:
>
> perf annotate browser: Circulate percent, total-period and nr-samples view (2017-08-18 11:23:20 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Support --show-nr-samples in annotate's --stdio and --tui, using
> the existing 't' toggle to circulate 'percent', 'total-period' and
> 'nr-samples' as the first column (Taeung Song)
>
> - Support FCMask and PortMask in JSON vendor events (Andi Kleen)
>
> - Fix off by one string allocation problem in 'perf trace' (Arnaldo Carvalho de Melo)
>
> - Use just one parse events state struct in yyparse(), fixing one
> reported segfault when a routine received a different data struct,
> smaller than the one it expected to use (Arnaldo Carvalho de Melo)
>
> - Remove unused cpu_relax() macros, they stopped being used when
> tools/perf lived in Documentation/ (Arnaldo Carvalho de Melo)
>
> - Fix double file test in libbpf's Makefile (Daniel Díaz):
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf jevents: Support FCMask and PortMask
>
> Arnaldo Carvalho de Melo (7):
> perf trace: Fix off by one string allocation problem
> perf events parse: Remove some needless local variables
> perf events parse: Rename parsing state struct to clearer name
> perf events parse: Use just one parse events state struct
> perf events parse: Rename parse_events_parse arguments
> perf tools: Remove unused cpu_relax() macros
> perf tools: Use default CPUINFO_PROC where it fits
>
> Daniel Díaz (1):
> tools lib bpf: Fix double file test in Makefile
>
> Taeung Song (4):
> perf annotate stdio: Support --show-nr-samples option
> perf annotate: Document --show-total-period option
> perf annotate browser: Support --show-nr-samples option
> perf annotate browser: Circulate percent, total-period and nr-samples view
>
> tools/lib/bpf/Makefile | 4 +-
> tools/perf/Documentation/perf-annotate.txt | 6 ++
> tools/perf/builtin-annotate.c | 16 ++++-
> tools/perf/builtin-trace.c | 2 +-
> tools/perf/perf-sys.h | 28 +--------
> tools/perf/pmu-events/jevents.c | 2 +
> tools/perf/tests/bpf.c | 16 ++---
> tools/perf/ui/browsers/annotate.c | 25 ++++++--
> tools/perf/util/annotate.c | 6 +-
> tools/perf/util/header.c | 3 -
> tools/perf/util/parse-events.c | 96 +++++++++++++++---------------
> tools/perf/util/parse-events.h | 19 +++---
> tools/perf/util/parse-events.y | 94 ++++++++++++++---------------
> 13 files changed, 159 insertions(+), 158 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2017-08-21 19:25 Arnaldo Carvalho de Melo
2017-08-22 10:20 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-08-21 19:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Andi Kleen, Daniel Díaz, David Ahern,
Jiri Olsa, Martin Liška, Milian Wolff, Namhyung Kim,
Peter Zijlstra, Taeung Song, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 9881223c6cc0644cc3aeea41e1f19ea7e3041f33:
Merge tag 'perf-core-for-mingo-4.14-20170816' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-08-17 09:41:56 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170821
for you to fetch changes up to 3a555c7799de69d73826eccc9a21948a5775d4d3:
perf annotate browser: Circulate percent, total-period and nr-samples view (2017-08-18 11:23:20 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Support --show-nr-samples in annotate's --stdio and --tui, using
the existing 't' toggle to circulate 'percent', 'total-period' and
'nr-samples' as the first column (Taeung Song)
- Support FCMask and PortMask in JSON vendor events (Andi Kleen)
- Fix off by one string allocation problem in 'perf trace' (Arnaldo Carvalho de Melo)
- Use just one parse events state struct in yyparse(), fixing one
reported segfault when a routine received a different data struct,
smaller than the one it expected to use (Arnaldo Carvalho de Melo)
- Remove unused cpu_relax() macros, they stopped being used when
tools/perf lived in Documentation/ (Arnaldo Carvalho de Melo)
- Fix double file test in libbpf's Makefile (Daniel Díaz):
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf jevents: Support FCMask and PortMask
Arnaldo Carvalho de Melo (7):
perf trace: Fix off by one string allocation problem
perf events parse: Remove some needless local variables
perf events parse: Rename parsing state struct to clearer name
perf events parse: Use just one parse events state struct
perf events parse: Rename parse_events_parse arguments
perf tools: Remove unused cpu_relax() macros
perf tools: Use default CPUINFO_PROC where it fits
Daniel Díaz (1):
tools lib bpf: Fix double file test in Makefile
Taeung Song (4):
perf annotate stdio: Support --show-nr-samples option
perf annotate: Document --show-total-period option
perf annotate browser: Support --show-nr-samples option
perf annotate browser: Circulate percent, total-period and nr-samples view
tools/lib/bpf/Makefile | 4 +-
tools/perf/Documentation/perf-annotate.txt | 6 ++
tools/perf/builtin-annotate.c | 16 ++++-
tools/perf/builtin-trace.c | 2 +-
tools/perf/perf-sys.h | 28 +--------
tools/perf/pmu-events/jevents.c | 2 +
tools/perf/tests/bpf.c | 16 ++---
tools/perf/ui/browsers/annotate.c | 25 ++++++--
tools/perf/util/annotate.c | 6 +-
tools/perf/util/header.c | 3 -
tools/perf/util/parse-events.c | 96 +++++++++++++++---------------
tools/perf/util/parse-events.h | 19 +++---
tools/perf/util/parse-events.y | 94 ++++++++++++++---------------
13 files changed, 159 insertions(+), 158 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf
commands with a variety of command line event specifications to then
intercept the sys_perf_event syscall to check that the perf_event_attr
fields are set up as expected, among a variety of other unit tests.
The 'perf test' also runs shell scripts exercising the tools, checking
if they affect the system in certain ways, like setting up kprobes and
uprobes, request callchains for well known programs and check that they
are the expected ones, see if 'perf trace' beautifies system call
arguments correctly, etc.
Additionally, a new set of tests, script based, runs the tools in a live system,
setting probes in place that then gets used by 'perf trace', with its output
compared against expected results.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 archlinux:latest: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: Ok
24 fedora:25: Ok
25 fedora:26: Ok
26 fedora:rawhide: Ok
27 mageia:5: Ok
28 opensuse:13.2: Ok
29 opensuse:42.1: Ok
30 opensuse:42.2: Ok
31 opensuse:tumbleweed: Ok
32 oraclelinux:6: Ok
33 oraclelinux:7: Ok
34 ubuntu:12.04.5: Ok
35 ubuntu:14.04.4: Ok
36 ubuntu:14.04.4-x-linaro-arm64: Ok
37 ubuntu:15.10: Ok
38 ubuntu:16.04: Ok
39 ubuntu:16.04-x-arm: Ok
40 ubuntu:16.04-x-arm64: Ok
41 ubuntu:16.04-x-powerpc: Ok
42 ubuntu:16.04-x-powerpc64: Ok
43 ubuntu:16.04-x-powerpc64el: Ok
44 ubuntu:16.04-x-s390: Ok
45 ubuntu:16.10: Ok
46 ubuntu:17.04: Ok
47 ubuntu:17.10: Ok
#
# uname -a
Linux jouet 4.13.0-rc4+ #2 SMP Fri Aug 11 12:39:09 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: Simple expression parser : Ok
7: PERF_RECORD_* events & perf_sample fields : Ok
8: Parse perf pmu format : Ok
9: DSO data read : Ok
10: DSO data cache : Ok
11: DSO data reopen : Ok
12: Roundtrip evsel->name : Ok
13: Parse sched tracepoints fields : Ok
14: syscalls:sys_enter_openat event fields : Ok
15: Setup struct perf_event_attr : Ok
16: Match and link multiple hists : Ok
17: 'import perf' in python : Ok
18: Breakpoint overflow signal handler : Ok
19: Breakpoint overflow sampling : Ok
20: Number of exit events of a simple workload : Ok
21: Software clock events period values : Ok
22: Object code reading : Ok
23: Sample parsing : Ok
24: Use a dummy software event to keep tracking : Ok
25: Parse with no sample_id_all bit set : Ok
26: Filter hist entries : Ok
27: Lookup mmap thread : Ok
28: Share thread mg : Ok
29: Sort output of hist entries : Ok
30: Cumulate child hist entries : Ok
31: Track with sched_switch : Ok
32: Filter fds with revents mask in a fdarray : Ok
33: Add fd to a fdarray, making it autogrow : Ok
34: kmod_path__parse : Ok
35: Thread map : Ok
36: LLVM search and compile :
36.1: Basic BPF llvm compile : Ok
36.2: kbuild searching : Ok
36.3: Compile source for BPF prologue generation : Ok
36.4: Compile source for BPF relocation : Ok
37: Session topology : Ok
38: BPF filter :
38.1: Basic BPF filtering : Ok
38.2: BPF pinning : Ok
38.3: BPF prologue generation : Ok
38.4: BPF relocation checker : Ok
39: Synthesize thread map : Ok
40: Remove thread map : Ok
41: Synthesize cpu map : Ok
42: Synthesize stat config : Ok
43: Synthesize stat : Ok
44: Synthesize stat round : Ok
45: Synthesize attr update : Ok
46: Event times : Ok
47: Read backward ring buffer : Ok
48: Print cpu map : Ok
49: Probe SDT events : Ok
50: is_printable_array : Ok
51: Print bitmap : Ok
52: perf hooks : Ok
53: builtin clang support : Skip (not compiled in)
54: unit_number__scnprintf : Ok
55: x86 rdpmc : Ok
56: Convert perf time to TSC : Ok
57: DWARF unwind : Ok
58: x86 instruction decoder - new instructions : Ok
59: Intel cqm nmi context read : Skip
60: Use vfs_getname probe to get syscall args filenames : Ok
61: probe libc's inet_pton & backtrace it with ping : Ok
62: Check open filename arg using perf trace + vfs_getname: Ok
63: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_util_map_o_O: make util/map.o
make_no_libbionic_O: make NO_LIBBIONIC=1
make_install_O: make install
make_tags_O: make tags
make_pure_O: make
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_libperl_O: make NO_LIBPERL=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_doc_O: make doc
make_no_libelf_O: make NO_LIBELF=1
make_no_slang_O: make NO_SLANG=1
make_help_O: make help
make_no_libaudit_O: make NO_LIBAUDIT=1
make_perf_o_O: make perf.o
make_debug_O: make DEBUG=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_install_prefix_O: make install prefix=/tmp/krava
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libunwind_O: make NO_LIBUNWIND=1
make_install_bin_O: make install-bin
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_gtk2_O: make NO_GTK2=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_clean_all_O: make clean all
make_no_demangle_O: make NO_DEMANGLE=1
make_no_newt_O: make NO_NEWT=1
make_no_backtrace_O: make NO_BACKTRACE=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2017-04-05 0:17 Arnaldo Carvalho de Melo
@ 2017-04-05 5:41 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2017-04-05 5:41 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Alexander Shishkin, Alexis Berlemont, Andi Kleen,
Hemant Kumar, Jiri Olsa, Martin Liska, Masami Hiramatsu,
Michael Ellerman, Namhyung Kim, Naveen N . Rao, Peter Zijlstra,
Ravi Bangoria, Taeung Song, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit fcc309e618c9e9ac4ede010d87522b0689549658:
>
> Merge tag 'perf-core-for-mingo-4.12-20170331' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-04-01 12:43:40 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170404
>
> for you to fetch changes up to 99094a5e941fe88d95cbd594e6a41bee24003ecb:
>
> perf annotate: Fix missing number of samples for source_line_samples (2017-04-04 21:08:00 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Add missing number of samples in 'perf annotate --stdio -l --show-total-period'
> (Taeung Song)
>
> Vendor events updates:
>
> - Add uncore_arb Intel vendor events in JSON format (Andi Kleen)
>
> - Add uncore vendor events for Intel's Sandy Bridge, Ivy Bridge,
> Haswell, Broadwell and Skylake architectures (Andi Kleen)
>
> - Add missing UNC_M_DCLOCKTICKS Intel Broadwell DE uncore vendor event (Andi Kleen)
>
> Infrastructure:
>
> - Remove some more die() calls, avoiding sudden death in library code
> (Arnaldo Carvalho de Melo)
>
> - Add argument support for SDT events in powerpc (Ravi Bangoria)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (8):
> perf vendor events intel: Add missing UNC_M_DCLOCKTICKS for Broadwell DE uncore
> perf vendor events intel: Add uncore events for Sandy Bridge client
> perf vendor events intel: Add uncore events for Ivy Bridge client
> perf vendor events intel: Add uncore events for Haswell client
> perf vendor events intel: Add uncore events for Broadwell client
> perf vendor events intel: Add uncore events for Skylake client
> perf vendor events intel: Add uncore_arb JSON support
> perf vendor events intel: Add missing space in json descriptions
>
> Arnaldo Carvalho de Melo (4):
> Merge branch 'perf/uncore-json-updates-1' of git://git.kernel.org/.../ak/linux-misc into perf/core
> perf tools: Remove die() call
> perf tools: Handle allocation failures gracefully
> perf tools: Don't die on a print function
>
> Ravi Bangoria (1):
> perf sdt powerpc: Add argument support
>
> Taeung Song (1):
> perf annotate: Fix missing number of samples for source_line_samples
>
> tools/perf/arch/powerpc/util/perf_regs.c | 111 ++++++
> tools/perf/perf.c | 3 +-
> .../perf/pmu-events/arch/x86/broadwell/uncore.json | 278 +++++++++++++++
> .../arch/x86/broadwellde/uncore-memory.json | 13 +-
> tools/perf/pmu-events/arch/x86/haswell/uncore.json | 374 +++++++++++++++++++++
> .../perf/pmu-events/arch/x86/ivybridge/uncore.json | 314 +++++++++++++++++
> .../pmu-events/arch/x86/sandybridge/uncore.json | 314 +++++++++++++++++
> tools/perf/pmu-events/arch/x86/skylake/uncore.json | 254 ++++++++++++++
> tools/perf/pmu-events/jevents.c | 2 +
> tools/perf/util/annotate.c | 6 +-
> tools/perf/util/annotate.h | 2 +-
> tools/perf/util/values.c | 63 +++-
> 12 files changed, 1710 insertions(+), 24 deletions(-)
> create mode 100644 tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> create mode 100644 tools/perf/pmu-events/arch/x86/haswell/uncore.json
> create mode 100644 tools/perf/pmu-events/arch/x86/ivybridge/uncore.json
> create mode 100644 tools/perf/pmu-events/arch/x86/sandybridge/uncore.json
> create mode 100644 tools/perf/pmu-events/arch/x86/skylake/uncore.json
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2017-04-05 0:17 Arnaldo Carvalho de Melo
2017-04-05 5:41 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-04-05 0:17 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Alexander Shishkin,
Alexis Berlemont, Andi Kleen, Hemant Kumar, Jiri Olsa,
Martin Liska, Masami Hiramatsu, Michael Ellerman, Namhyung Kim,
Naveen N . Rao, Peter Zijlstra, Ravi Bangoria, Taeung Song,
Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit fcc309e618c9e9ac4ede010d87522b0689549658:
Merge tag 'perf-core-for-mingo-4.12-20170331' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-04-01 12:43:40 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170404
for you to fetch changes up to 99094a5e941fe88d95cbd594e6a41bee24003ecb:
perf annotate: Fix missing number of samples for source_line_samples (2017-04-04 21:08:00 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Add missing number of samples in 'perf annotate --stdio -l --show-total-period'
(Taeung Song)
Vendor events updates:
- Add uncore_arb Intel vendor events in JSON format (Andi Kleen)
- Add uncore vendor events for Intel's Sandy Bridge, Ivy Bridge,
Haswell, Broadwell and Skylake architectures (Andi Kleen)
- Add missing UNC_M_DCLOCKTICKS Intel Broadwell DE uncore vendor event (Andi Kleen)
Infrastructure:
- Remove some more die() calls, avoiding sudden death in library code
(Arnaldo Carvalho de Melo)
- Add argument support for SDT events in powerpc (Ravi Bangoria)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (8):
perf vendor events intel: Add missing UNC_M_DCLOCKTICKS for Broadwell DE uncore
perf vendor events intel: Add uncore events for Sandy Bridge client
perf vendor events intel: Add uncore events for Ivy Bridge client
perf vendor events intel: Add uncore events for Haswell client
perf vendor events intel: Add uncore events for Broadwell client
perf vendor events intel: Add uncore events for Skylake client
perf vendor events intel: Add uncore_arb JSON support
perf vendor events intel: Add missing space in json descriptions
Arnaldo Carvalho de Melo (4):
Merge branch 'perf/uncore-json-updates-1' of git://git.kernel.org/.../ak/linux-misc into perf/core
perf tools: Remove die() call
perf tools: Handle allocation failures gracefully
perf tools: Don't die on a print function
Ravi Bangoria (1):
perf sdt powerpc: Add argument support
Taeung Song (1):
perf annotate: Fix missing number of samples for source_line_samples
tools/perf/arch/powerpc/util/perf_regs.c | 111 ++++++
tools/perf/perf.c | 3 +-
.../perf/pmu-events/arch/x86/broadwell/uncore.json | 278 +++++++++++++++
.../arch/x86/broadwellde/uncore-memory.json | 13 +-
tools/perf/pmu-events/arch/x86/haswell/uncore.json | 374 +++++++++++++++++++++
.../perf/pmu-events/arch/x86/ivybridge/uncore.json | 314 +++++++++++++++++
.../pmu-events/arch/x86/sandybridge/uncore.json | 314 +++++++++++++++++
tools/perf/pmu-events/arch/x86/skylake/uncore.json | 254 ++++++++++++++
tools/perf/pmu-events/jevents.c | 2 +
tools/perf/util/annotate.c | 6 +-
tools/perf/util/annotate.h | 2 +-
tools/perf/util/values.c | 63 +++-
12 files changed, 1710 insertions(+), 24 deletions(-)
create mode 100644 tools/perf/pmu-events/arch/x86/broadwell/uncore.json
create mode 100644 tools/perf/pmu-events/arch/x86/haswell/uncore.json
create mode 100644 tools/perf/pmu-events/arch/x86/ivybridge/uncore.json
create mode 100644 tools/perf/pmu-events/arch/x86/sandybridge/uncore.json
create mode 100644 tools/perf/pmu-events/arch/x86/skylake/uncore.json
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
For this specific pull request the samples/bpf/ was disabled, as 'make headers_install'
is failing with the following error, in this case in fedora:rawhide:
INSTALL usr/include/uapi/ (0 file)
/git/linux/scripts/Makefile.headersinst:62: *** Missing generated UAPI file ./arch/x86/include/generated/uapi/asm/unistd_32.h. Stop.
make[1]: *** [/git/linux/Makefile:1151: headers_install] Error 2
make[1]: Leaving directory '/tmp/build/linux'
make: *** [Makefile:152: sub-make] Error 2
make: Leaving directory '/git/linux'
I'll investigate later, perf and objtool builds just fine, with clang and gcc.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:edge: Ok
4 android-ndk:r12b-arm: Ok
5 archlinux:latest: Ok
6 centos:5: Ok
7 centos:6: Ok
8 centos:7: Ok
9 debian:7: Ok
10 debian:8: Ok
11 debian:9: Ok
12 debian:experimental: Ok
13 debian:experimental-x-arm64: Ok
14 debian:experimental-x-mips: Ok
15 debian:experimental-x-mips64: Ok
16 debian:experimental-x-mipsel: Ok
17 fedora:20: Ok
18 fedora:21: Ok
19 fedora:22: Ok
20 fedora:23: Ok
21 fedora:24: Ok
22 fedora:24-x-ARC-uClibc: Ok
23 fedora:25: Ok
24 fedora:rawhide: Ok
25 mageia:5: Ok
26 opensuse:13.2: Ok
27 opensuse:42.1: Ok
28 opensuse:tumbleweed: Ok
29 ubuntu:12.04.5: Ok
30 ubuntu:14.04.4: Ok
31 ubuntu:14.04.4-x-linaro-arm64: Ok
32 ubuntu:15.10: Ok
33 ubuntu:16.04: Ok
34 ubuntu:16.04-x-arm: Ok
35 ubuntu:16.04-x-arm64: Ok
36 ubuntu:16.04-x-powerpc: Ok
37 ubuntu:16.04-x-powerpc64: Ok
38 ubuntu:16.04-x-s390: Ok
39 ubuntu:16.10: Ok
40 ubuntu:17.04: Ok
#
# uname -a
Linux jouet 4.11.0-rc2+ #5 SMP Mon Mar 20 18:12:29 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# 'perf test tsc' already fixed by peterz in tip, need to update this kernel :-\
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: Simple expression parser : Ok
7: PERF_RECORD_* events & perf_sample fields : Ok
8: Parse perf pmu format : Ok
9: DSO data read : Ok
10: DSO data cache : Ok
11: DSO data reopen : Ok
12: Roundtrip evsel->name : Ok
13: Parse sched tracepoints fields : Ok
14: syscalls:sys_enter_openat event fields : Ok
15: Setup struct perf_event_attr : Ok
16: Match and link multiple hists : Ok
17: 'import perf' in python : Ok
18: Breakpoint overflow signal handler : Ok
19: Breakpoint overflow sampling : Ok
20: Number of exit events of a simple workload : Ok
21: Software clock events period values : Ok
22: Object code reading : Ok
23: Sample parsing : Ok
24: Use a dummy software event to keep tracking: Ok
25: Parse with no sample_id_all bit set : Ok
26: Filter hist entries : Ok
27: Lookup mmap thread : Ok
28: Share thread mg : Ok
29: Sort output of hist entries : Ok
30: Cumulate child hist entries : Ok
31: Track with sched_switch : Ok
32: Filter fds with revents mask in a fdarray : Ok
33: Add fd to a fdarray, making it autogrow : Ok
34: kmod_path__parse : Ok
35: Thread map : Ok
36: LLVM search and compile :
36.1: Basic BPF llvm compile : Ok
36.2: kbuild searching : Ok
36.3: Compile source for BPF prologue generation: Ok
36.4: Compile source for BPF relocation : Ok
37: Session topology : Ok
38: BPF filter :
38.1: Basic BPF filtering : Ok
38.2: BPF pinning : Ok
38.3: BPF prologue generation : Ok
38.4: BPF relocation checker : Ok
39: Synthesize thread map : Ok
40: Remove thread map : Ok
41: Synthesize cpu map : Ok
42: Synthesize stat config : Ok
43: Synthesize stat : Ok
44: Synthesize stat round : Ok
45: Synthesize attr update : Ok
46: Event times : Ok
47: Read backward ring buffer : Ok
48: Print cpu map : Ok
49: Probe SDT events : Ok
50: is_printable_array : Ok
51: Print bitmap : Ok
52: perf hooks : Ok
53: builtin clang support : Skip (not compiled in)
54: unit_number__scnprintf : Ok
55: x86 rdpmc : Ok
56: Convert perf time to TSC : FAILED!
57: DWARF unwind : Ok
58: x86 instruction decoder - new instructions : Ok
59: Intel cqm nmi context read : Skip
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_debug_O: make DEBUG=1
make_no_slang_O: make NO_SLANG=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_help_O: make help
make_tags_O: make tags
make_no_newt_O: make NO_NEWT=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_perf_o_O: make perf.o
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_clean_all_O: make clean all
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libperl_O: make NO_LIBPERL=1
make_pure_O: make
make_no_gtk2_O: make NO_GTK2=1
make_no_libelf_O: make NO_LIBELF=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_install_O: make install
make_no_libaudit_O: make NO_LIBAUDIT=1
make_install_bin_O: make install-bin
make_no_libpython_O: make NO_LIBPYTHON=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_util_map_o_O: make util/map.o
make_no_demangle_O: make NO_DEMANGLE=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_install_prefix_O: make install prefix=/tmp/krava
make_doc_O: make doc
make_no_libbpf_O: make NO_LIBBPF=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_static_O: make LDFLAGS=-static
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2017-01-11 20:21 Arnaldo Carvalho de Melo
@ 2017-01-12 8:25 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2017-01-12 8:25 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin, David Ahern,
Jiri Olsa, Josh Poimboeuf, Ladi Prosek, Laura Abbott,
Masami Hiramatsu, Milian Wolff, Namhyung Kim, Paolo Bonzini,
Peter Zijlstra, Soramichi AKIYAMA, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> * The following description will move to the end in the next pull requests *
>
> The first ones are container (docker) based builds of tools/perf with and
> without libelf support, objtool where it is supported and samples/bpf/, ditto.
>
> Several are cross builds, the ones with -x-ARCH, and the android one, and those
> may not have all the features built, due to lack of multi-arch devel packages,
> available and being used so far on just a few, like
> debian:experimental-x-{arm64,mipsel}.
>
> The 'perf test' one will perform a variety of tests exercising
> tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
> with a variety of command line event specifications to then intercept the
> sys_perf_event syscall to check that the perf_event_attr fields are set up as
> expected, among a variety of other unit tests.
>
> Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
> with a variety of feature sets, exercising the build with an incomplete set of
> features as well as with a complete one. It is planned to have it run on each
> of the containers mentioned above, using some container orchestration
> infrastructure. Get in contact if interested in helping having this in place.
>
> The following changes since commit ad5013d5699d30ded0cdbbc68b93b2aa28222c6e:
>
> perf/x86/intel: Use ULL constant to prevent undefined shift behaviour (2017-01-11 16:43:30 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.11-20170111
>
> for you to fetch changes up to 675f52b23743f396c585fc9d135435be37f320d8:
>
> tools: Sync x86's vmx.h with the kernel (2017-01-11 16:48:02 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Add more triggers to switch the output file (perf.data.TIMESTAMP).
>
> Now, in addition to switching to a different output file when
> receiving a SIGUSR2, one can also specify file size and time based
> triggers:
>
> perf record -a --switch-output=signal
>
> is equivalent to what we had before:
>
> perf record -a --switch-output
>
> While we can also ask for the file to be "sliced" by size, taking
> into account that that will happen only when we get woken up by
> the kernel, i.e. one has to take into account the --mmap-pages (the
> size of the perf mmap ring buffer):
>
> perf record -a --switch-output=2G
>
> will break the perf.data output into multiple files limited to 2GB
> of samples, right when generating the output.
>
> For time based samples, alert() will be used, so to have 1 minute
> limited perf.data output files:
>
> perf record -a --switch-output=1m
>
> (Jiri Olsa)
>
> - Remove the need to use -e only for syscalls and --event only for
> tracepoints/HW/SW/etc events, i.e. now one can use:
>
> perf trace -e nanosleep,futex,sched:sched_switch ./workload
>
> or:
>
> perf trace --event nanosleep,futex,sched:sched_switch ./workload
>
> And have it tracing raw_syscalls:sys_{enter,exit} for the nanosleep
> and futex syscalls, formatting those as strace does while also
> tracing sched:sched_switch, ordering it all into one strace like
> output.
>
> Using '!' as the first character in the -e/--event argument remains
> a way to negate the list of syscalls, i.e. all syscalls except for
> the ones specified, doesn't affect the other kinds of events.
>
> E.g:
>
> [root@jouet ~] # perf trace -e sched:sched_switch,nanosleep usleep 1
> 0.000 ( 0.028 ms): usleep/28150 nanosleep(rqtp: 0x7ffe4201b9f0) ...
> 0.028 ( ): sched:sched_switch:usleep:28150 [120] S ==> swapper/0:0 [120])
> 0.000 ( 0.065 ms): usleep/28150 ... [continued]: nanosleep()) = 0
> [root@jouet ~]#
>
> (Arnaldo Carvalho de Melo)
>
> - 'perf kallsyms' toy tool to look for extended symbol information on
> the running kernel and demonstrate the machine/thread/symbol APIs for
> use in other tools, such as 'perf probe' (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> - Add missing linux/kernel.h include to subcmd.h (Arnaldo Carvalho de Melo)
> tools: Sync x86's vmx.h with the kernel
>
> - Create libdir directory before installing libperf-jvmti.so (Laura Abbott)
>
> - Fix typo in perf_evlist__start_workload() (Soramichi Akiyama)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (5):
> tools lib subcmd: Add missing linux/kernel.h include to subcmd.h
> perf machine: Add a kallsyms loading constructor
> perf kallsyms: Introduce tool to look for extended symbol information on the running kernel
> perf trace: Allow specifying list of syscalls and events in -e/--expr/--event
> tools: Sync x86's vmx.h with the kernel
>
> Jiri Olsa (6):
> perf tools: Add unit_number__scnprintf function
> perf record: Add struct switch_output
> perf record: Change switch-output option to take optional argument
> perf record: Add switch-output size option argument
> perf record: Add switch-output size warning
> perf record: Add switch-output time option argument
>
> Laura Abbott (1):
> perf jvmti: Create libdir directory before installing libperf-jvmti.so
>
> Soramichi Akiyama (1):
> perf evlist: Fix typo in perf_evlist__start_workload()
>
> tools/arch/x86/include/uapi/asm/vmx.h | 5 +
> tools/lib/subcmd/parse-options.h | 1 +
> tools/perf/Build | 1 +
> tools/perf/Documentation/perf-kallsyms.txt | 24 +++++
> tools/perf/Documentation/perf-record.txt | 14 ++-
> tools/perf/Documentation/perf-trace.txt | 8 +-
> tools/perf/Makefile.perf | 1 +
> tools/perf/builtin-help.c | 2 +-
> tools/perf/builtin-kallsyms.c | 67 +++++++++++++
> tools/perf/builtin-record.c | 154 ++++++++++++++++++++++++++---
> tools/perf/builtin-trace.c | 120 ++++++++++++++++------
> tools/perf/builtin.h | 1 +
> tools/perf/command-list.txt | 1 +
> tools/perf/perf.c | 1 +
> tools/perf/tests/Build | 1 +
> tools/perf/tests/builtin-test.c | 4 +
> tools/perf/tests/tests.h | 1 +
> tools/perf/tests/unit_number__scnprintf.c | 37 +++++++
> tools/perf/util/evlist.c | 12 ++-
> tools/perf/util/evlist.h | 2 +
> tools/perf/util/machine.c | 19 ++++
> tools/perf/util/machine.h | 1 +
> tools/perf/util/util.c | 13 +++
> tools/perf/util/util.h | 1 +
> 24 files changed, 439 insertions(+), 52 deletions(-)
> create mode 100644 tools/perf/Documentation/perf-kallsyms.txt
> create mode 100644 tools/perf/builtin-kallsyms.c
> create mode 100644 tools/perf/tests/unit_number__scnprintf.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2017-01-11 20:21 Arnaldo Carvalho de Melo
2017-01-12 8:25 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-01-11 20:21 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, David Ahern, Jiri Olsa, Josh Poimboeuf,
Ladi Prosek, Laura Abbott, Masami Hiramatsu, Milian Wolff,
Namhyung Kim, Paolo Bonzini, Peter Zijlstra, Soramichi AKIYAMA,
Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
* The following description will move to the end in the next pull requests *
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
The following changes since commit ad5013d5699d30ded0cdbbc68b93b2aa28222c6e:
perf/x86/intel: Use ULL constant to prevent undefined shift behaviour (2017-01-11 16:43:30 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.11-20170111
for you to fetch changes up to 675f52b23743f396c585fc9d135435be37f320d8:
tools: Sync x86's vmx.h with the kernel (2017-01-11 16:48:02 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Add more triggers to switch the output file (perf.data.TIMESTAMP).
Now, in addition to switching to a different output file when
receiving a SIGUSR2, one can also specify file size and time based
triggers:
perf record -a --switch-output=signal
is equivalent to what we had before:
perf record -a --switch-output
While we can also ask for the file to be "sliced" by size, taking
into account that that will happen only when we get woken up by
the kernel, i.e. one has to take into account the --mmap-pages (the
size of the perf mmap ring buffer):
perf record -a --switch-output=2G
will break the perf.data output into multiple files limited to 2GB
of samples, right when generating the output.
For time based samples, alert() will be used, so to have 1 minute
limited perf.data output files:
perf record -a --switch-output=1m
(Jiri Olsa)
- Remove the need to use -e only for syscalls and --event only for
tracepoints/HW/SW/etc events, i.e. now one can use:
perf trace -e nanosleep,futex,sched:sched_switch ./workload
or:
perf trace --event nanosleep,futex,sched:sched_switch ./workload
And have it tracing raw_syscalls:sys_{enter,exit} for the nanosleep
and futex syscalls, formatting those as strace does while also
tracing sched:sched_switch, ordering it all into one strace like
output.
Using '!' as the first character in the -e/--event argument remains
a way to negate the list of syscalls, i.e. all syscalls except for
the ones specified, doesn't affect the other kinds of events.
E.g:
[root@jouet ~] # perf trace -e sched:sched_switch,nanosleep usleep 1
0.000 ( 0.028 ms): usleep/28150 nanosleep(rqtp: 0x7ffe4201b9f0) ...
0.028 ( ): sched:sched_switch:usleep:28150 [120] S ==> swapper/0:0 [120])
0.000 ( 0.065 ms): usleep/28150 ... [continued]: nanosleep()) = 0
[root@jouet ~]#
(Arnaldo Carvalho de Melo)
- 'perf kallsyms' toy tool to look for extended symbol information on
the running kernel and demonstrate the machine/thread/symbol APIs for
use in other tools, such as 'perf probe' (Arnaldo Carvalho de Melo)
Infrastructure:
- Add missing linux/kernel.h include to subcmd.h (Arnaldo Carvalho de Melo)
tools: Sync x86's vmx.h with the kernel
- Create libdir directory before installing libperf-jvmti.so (Laura Abbott)
- Fix typo in perf_evlist__start_workload() (Soramichi Akiyama)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
tools lib subcmd: Add missing linux/kernel.h include to subcmd.h
perf machine: Add a kallsyms loading constructor
perf kallsyms: Introduce tool to look for extended symbol information on the running kernel
perf trace: Allow specifying list of syscalls and events in -e/--expr/--event
tools: Sync x86's vmx.h with the kernel
Jiri Olsa (6):
perf tools: Add unit_number__scnprintf function
perf record: Add struct switch_output
perf record: Change switch-output option to take optional argument
perf record: Add switch-output size option argument
perf record: Add switch-output size warning
perf record: Add switch-output time option argument
Laura Abbott (1):
perf jvmti: Create libdir directory before installing libperf-jvmti.so
Soramichi Akiyama (1):
perf evlist: Fix typo in perf_evlist__start_workload()
tools/arch/x86/include/uapi/asm/vmx.h | 5 +
tools/lib/subcmd/parse-options.h | 1 +
tools/perf/Build | 1 +
tools/perf/Documentation/perf-kallsyms.txt | 24 +++++
tools/perf/Documentation/perf-record.txt | 14 ++-
tools/perf/Documentation/perf-trace.txt | 8 +-
tools/perf/Makefile.perf | 1 +
tools/perf/builtin-help.c | 2 +-
tools/perf/builtin-kallsyms.c | 67 +++++++++++++
tools/perf/builtin-record.c | 154 ++++++++++++++++++++++++++---
tools/perf/builtin-trace.c | 120 ++++++++++++++++------
tools/perf/builtin.h | 1 +
tools/perf/command-list.txt | 1 +
tools/perf/perf.c | 1 +
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/tests.h | 1 +
tools/perf/tests/unit_number__scnprintf.c | 37 +++++++
tools/perf/util/evlist.c | 12 ++-
tools/perf/util/evlist.h | 2 +
tools/perf/util/machine.c | 19 ++++
tools/perf/util/machine.h | 1 +
tools/perf/util/util.c | 13 +++
tools/perf/util/util.h | 1 +
24 files changed, 439 insertions(+), 52 deletions(-)
create mode 100644 tools/perf/Documentation/perf-kallsyms.txt
create mode 100644 tools/perf/builtin-kallsyms.c
create mode 100644 tools/perf/tests/unit_number__scnprintf.c
# uname -a
Linux jouet 4.9.0+ #2 SMP Wed Dec 21 11:54:44 BRT 2016 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: PERF_RECORD_* events & perf_sample fields : Ok
7: Parse perf pmu format : Ok
8: DSO data read : Ok
9: DSO data cache : Ok
10: DSO data reopen : Ok
11: Roundtrip evsel->name : Ok
12: Parse sched tracepoints fields : Ok
13: syscalls:sys_enter_openat event fields : Ok
14: Setup struct perf_event_attr : Ok
15: Match and link multiple hists : Ok
16: 'import perf' in python : Ok
17: Breakpoint overflow signal handler : Ok
18: Breakpoint overflow sampling : Ok
19: Number of exit events of a simple workload : Ok
20: Software clock events period values : Ok
21: Object code reading : Ok
22: Sample parsing : Ok
23: Use a dummy software event to keep tracking: Ok
24: Parse with no sample_id_all bit set : Ok
25: Filter hist entries : Ok
26: Lookup mmap thread : Ok
27: Share thread mg : Ok
28: Sort output of hist entries : Ok
29: Cumulate child hist entries : Ok
30: Track with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: kmod_path__parse : Ok
34: Thread map : Ok
35: LLVM search and compile :
35.1: Basic BPF llvm compile : Ok
35.2: kbuild searching : Ok
35.3: Compile source for BPF prologue generation: Ok
35.4: Compile source for BPF relocation : Ok
36: Session topology : Ok
37: BPF filter :
37.1: Basic BPF filtering : Ok
37.2: BPF prologue generation : Ok
37.3: BPF relocation checker : Ok
38: Synthesize thread map : Ok
39: Remove thread map : Ok
40: Synthesize cpu map : Ok
41: Synthesize stat config : Ok
42: Synthesize stat : Ok
43: Synthesize stat round : Ok
44: Synthesize attr update : Ok
45: Event times : Ok
46: Read backward ring buffer : Ok
47: Print cpu map : Ok
48: Probe SDT events : Ok
49: is_printable_array : Ok
50: Print bitmap : Ok
51: perf hooks : Ok
52: builtin clang support : Skip (not compiled in)
53: unit_number__scnprintf : Ok
54: x86 rdpmc : Ok
55: Convert perf time to TSC : Ok
56: DWARF unwind : Ok
57: x86 instruction decoder - new instructions : Ok
58: Intel cqm nmi context read : Skip
#
[root@jouet ~]# dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 debian:experimental-x-arm64: Ok
11 debian:experimental-x-mips64: Ok
12 debian:experimental-x-mipsel: Ok
13 fedora:20: Ok
14 fedora:21: Ok
15 fedora:22: Ok
16 fedora:23: Ok
17 fedora:24: Ok
18 fedora:24-x-ARC-uClibc: Ok
19 fedora:25: Ok
20 fedora:rawhide: Ok
21 mageia:5: Ok
22 opensuse:13.2: Ok
23 opensuse:42.1: Ok
24 opensuse:tumbleweed: Ok
25 ubuntu:12.04.5: Ok
26 ubuntu:14.04.4-x-linaro-arm64: Ok
27 ubuntu:15.10: Ok
28 ubuntu:16.04: Ok
29 ubuntu:16.04-x-arm: Ok
30 ubuntu:16.04-x-arm64: Ok
31 ubuntu:16.04-x-powerpc: Ok
32 ubuntu:16.04-x-powerpc64: Ok
33 ubuntu:16.04-x-powerpc64el: Ok
34 ubuntu:16.04-x-s390: Ok
35 ubuntu:16.10: Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_libaudit_O: make NO_LIBAUDIT=1
make_static_O: make LDFLAGS=-static
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_with_babeltrace_O: make LIBBABELTRACE=1
make_install_prefix_O: make install prefix=/tmp/krava
make_debug_O: make DEBUG=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_help_O: make help
make_doc_O: make doc
make_no_newt_O: make NO_NEWT=1
make_no_demangle_O: make NO_DEMANGLE=1
make_install_bin_O: make install-bin
make_no_libbpf_O: make NO_LIBBPF=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_perf_o_O: make perf.o
make_pure_O: make
make_clean_all_O: make clean all
make_no_libbionic_O: make NO_LIBBIONIC=1
make_install_O: make install
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_util_map_o_O: make util/map.o
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_gtk2_O: make NO_GTK2=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_slang_O: make NO_SLANG=1
make_tags_O: make tags
make_no_libelf_O: make NO_LIBELF=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2016-10-06 16:11 Arnaldo Carvalho de Melo
@ 2016-10-06 22:38 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2016-10-06 22:38 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Linux Weekly News, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov, Andi Kleen, Balbir Singh,
Daniel Borkmann, David Ahern, David S . Miller, Donghyun Kim,
He Kuang, Jiri Olsa, Masami Hiramatsu, Nambong Ha, Namhyung Kim,
Naveen N . Rao, Peter Zijlstra, pi3orama, Ravi Bangoria,
Seonyoung Kim, stable, Steven Rostedt, Sukadev Bhattiprolu,
Taeung Song, Thomas Gleixner, Tony Luck, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Build and test stats at the end of the message.
>
> The following changes since commit 8657355f5b5f657407efc12a2223e8a3a6d658de:
>
> Merge tag 'perf-core-for-mingo-20161003' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-10-04 10:04:47 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161005
>
> for you to fetch changes up to 87095f7ddeff3038a0cf8e6574922f9c11688619:
>
> tools build: Add feature detection for g++ (2016-10-05 19:59:35 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Intel PT timestamp fixes (Adrian Hunter)
>
> - Fix Intel JSON fixed counter conversions (Andi Kleen)
>
> - Sync memcpy, cpufeatures and bpf headers with the kernel (Arnaldo Carvalho de Melo)
>
> - Add some more tool tips (Donghyun Kim, Kim SeonYoung, Nambong Ha)
>
> - Fix libtraceevent's kbuffer_read_at_offset() handling of offsets before or
> equal the first event (Namhyung Kim)
>
> - Fix uretprobe probe placement on ppc64le (Ravi Bangoria)
>
> - Support building C++ source files and add feature detection for g++,
> prep work for supporting a builtin clang/llvm, to remove the need for having
> that toolchain installed to automagically build BPF scriptlets that then
> gets uploaded to the kernel via sys_bpf() (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf intel-pt: Fix estimated timestamps for cycle-accurate mode
> perf intel-pt: Fix MTC timestamp calculation for large MTC periods
>
> Andi Kleen (1):
> perf jevents: Fix Intel JSON fixed counter conversions
>
> Arnaldo Carvalho de Melo (3):
> perf bench mem: Sync memcpy assembly sources with the kernel
> tools: Synchronize tools/arch/x86/include/asm/cpufeatures.h
> tools: Synchronize tools/include/uapi/linux/bpf.h
>
> Donghyun Kim (1):
> perf report/top: Add a tip about system-wide collection from all CPUs
>
> Kim SeonYoung (1):
> perf report/top: Add a tip about source line numbers with overhead
>
> Nambong Ha (1):
> perf top/report: Add tips about a list option
>
> Namhyung Kim (1):
> tools lib traceevent: Fix kbuffer_read_at_offset()
>
> Ravi Bangoria (1):
> perf uretprobe ppc64le: Fix probe location
>
> Wang Nan (2):
> tools build: Support compiling C++ source file
> tools build: Add feature detection for g++
>
> tools/arch/x86/include/asm/cpufeatures.h | 1 -
> tools/arch/x86/lib/memcpy_64.S | 6 ++--
> tools/build/Build.include | 1 +
> tools/build/Makefile.build | 7 ++++
> tools/build/Makefile.feature | 2 +-
> tools/build/feature/Makefile | 10 +++++-
> tools/build/feature/test-cxx.cpp | 15 +++++++++
> tools/include/uapi/linux/bpf.h | 4 +--
> tools/lib/traceevent/kbuffer-parse.c | 1 +
> tools/perf/Documentation/tips.txt | 4 +++
> tools/perf/arch/powerpc/util/sym-handling.c | 3 +-
> tools/perf/pmu-events/jevents.c | 2 ++
> .../perf/util/intel-pt-decoder/intel-pt-decoder.c | 38 ++++++++++++++++++++++
> 13 files changed, 85 insertions(+), 9 deletions(-)
> create mode 100644 tools/build/feature/test-cxx.cpp
>
> [root@jouet ~]# time dm
> 1 alpine:3.4: Ok
> 2 android-ndk:r12b-arm: Ok
> 3 archlinux:latest: Ok
> 4 centos:5: Ok
> 5 centos:6: Ok
> 6 centos:7: Ok
> 7 debian:7: Ok
> 8 debian:8: Ok
> 9 debian:experimental: Ok
> 10 fedora:20: Ok
> 11 fedora:21: Ok
> 12 fedora:22: Ok
> 13 fedora:23: Ok
> 14 fedora:24: Ok
> 15 fedora:24-x-ARC-uClibc: Ok
> 16 fedora:rawhide: Ok
> 17 mageia:5: Ok
> 18 opensuse:13.2: Ok
> 19 opensuse:42.1: Ok
> 20 opensuse:tumbleweed: Ok
> 21 ubuntu:12.04.5: Ok
> 22 ubuntu:14.04: Ok
> 23 ubuntu:14.04.4: Ok
> 24 ubuntu:15.10: Ok
> 25 ubuntu:16.04: Ok
> 26 ubuntu:16.04-x-arm: Ok
> 27 ubuntu:16.04-x-arm64: Ok
> 28 ubuntu:16.04-x-powerpc: Ok
> 29 ubuntu:16.04-x-powerpc64: Ok
> 30 ubuntu:16.04-x-powerpc64el: Ok
> 31 ubuntu:16.04-x-s390: Ok
> 32 ubuntu:16.10: Ok
>
> real 44m58.202s
> user 0m2.864s
> sys 0m1.975s
> [root@jouet ~]#
>
> [acme@jouet linux]$ make -C tools/perf build-test
> make: Entering directory '/home/acme/git/linux/tools/perf'
> tarpkg: ./tests/perf-targz-src-pkg .
> make_static_O: make LDFLAGS=-static
> make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
> make_install_prefix_slash_O: make install prefix=/tmp/krava/
> make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
> make_help_O: make help
> make_no_libpython_O: make NO_LIBPYTHON=1
> make_install_O: make install
> make_install_prefix_O: make install prefix=/tmp/krava
> make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
> make_no_libperl_O: make NO_LIBPERL=1
> make_debug_O: make DEBUG=1
> make_perf_o_O: make perf.o
> make_clean_all_O: make clean all
> make_util_pmu_bison_o_O: make util/pmu-bison.o
> make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1
> make_no_demangle_O: make NO_DEMANGLE=1
> make_no_libunwind_O: make NO_LIBUNWIND=1
> make_with_babeltrace_O: make LIBBABELTRACE=1
> make_no_libnuma_O: make NO_LIBNUMA=1
> make_no_libbpf_O: make NO_LIBBPF=1
> make_install_bin_O: make install-bin
> make_util_map_o_O: make util/map.o
> make_no_libelf_O: make NO_LIBELF=1
> make_no_newt_O: make NO_NEWT=1
> make_no_auxtrace_O: make NO_AUXTRACE=1
> make_no_gtk2_O: make NO_GTK2=1
> make_no_slang_O: make NO_SLANG=1
> make_doc_O: make doc
> make_pure_O: make
> make_no_libbionic_O: make NO_LIBBIONIC=1
> make_no_libaudit_O: make NO_LIBAUDIT=1
> make_tags_O: make tags
> make_no_backtrace_O: make NO_BACKTRACE=1
> OK
>
> [root@jouet ~]# perf test
> 1: vmlinux symtab matches kallsyms : Ok
> 2: detect openat syscall event : Ok
> 3: detect openat syscall event on all cpus : Ok
> 4: read samples using the mmap interface : Ok
> 5: parse events tests : Ok
> 6: Validate PERF_RECORD_* events & perf_sample fields : Ok
> 7: Test perf pmu format parsing : Ok
> 8: Test dso data read : Ok
> 9: Test dso data cache : Ok
> 10: Test dso data reopen : Ok
> 11: roundtrip evsel->name check : Ok
> 12: Check parsing of sched tracepoints fields : Ok
> 13: Generate and check syscalls:sys_enter_openat event fields: Ok
> 14: struct perf_event_attr setup : Ok
> 15: Test matching and linking multiple hists : Ok
> 16: Try 'import perf' in python, checking link problems : Ok
> 17: Test breakpoint overflow signal handler : Ok
> 18: Test breakpoint overflow sampling : Ok
> 19: Test number of exit event of a simple workload : Ok
> 20: Test software clock events have valid period values : Ok
> 21: Test object code reading : Ok
> 22: Test sample parsing : Ok
> 23: Test using a dummy software event to keep tracking : Ok
> 24: Test parsing with no sample_id_all bit set : Ok
> 25: Test filtering hist entries : Ok
> 26: Test mmap thread lookup : Ok
> 27: Test thread mg sharing : Ok
> 28: Test output sorting of hist entries : Ok
> 29: Test cumulation of child hist entries : Ok
> 30: Test tracking with sched_switch : Ok
> 31: Filter fds with revents mask in a fdarray : Ok
> 32: Add fd to a fdarray, making it autogrow : Ok
> 33: Test kmod_path__parse function : Ok
> 34: Test thread map : Ok
> 35: Test LLVM searching and compiling :
> 35.1: Basic BPF llvm compiling test : Ok
> 35.2: Test kbuild searching : Ok
> 35.3: Compile source for BPF prologue generation test : Ok
> 35.4: Compile source for BPF relocation test : Ok
> 36: Test topology in session : Ok
> 37: Test BPF filter :
> 37.1: Test basic BPF filtering : Ok
> 37.2: Test BPF prologue generation : Ok
> 37.3: Test BPF relocation checker : Ok
> 38: Test thread map synthesize : Ok
> 39: Test cpu map synthesize : Ok
> 40: Test stat config synthesize : Ok
> 41: Test stat synthesize : Ok
> 42: Test stat round synthesize : Ok
> 43: Test attr update synthesize : Ok
> 44: Test events times : Ok
> 45: Test backward reading from ring buffer : Ok
> 46: Test cpu map print : Ok
> 47: Test SDT event probing : Ok
> 48: Test is_printable_array function : Ok
> 49: Test bitmap print : Ok
> 50: x86 rdpmc test : Ok
> 51: Test converting perf time to TSC : Ok
> 52: Test dwarf unwind : Ok
> 53: Test x86 instruction decoder - new instructions : Ok
> 54: Test intel cqm nmi context read : Skip
> [root@jouet ~]#
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2016-10-06 16:11 Arnaldo Carvalho de Melo
2016-10-06 22:38 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-10-06 16:11 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Linux Weekly News, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, Alexei Starovoitov,
Andi Kleen, Balbir Singh, Daniel Borkmann, David Ahern,
David S . Miller, Donghyun Kim, He Kuang, Jiri Olsa,
Masami Hiramatsu, Nambong Ha, Namhyung Kim, Naveen N . Rao,
Peter Zijlstra, pi3orama, Ravi Bangoria, Seonyoung Kim, stable,
Steven Rostedt, Sukadev Bhattiprolu, Taeung Song,
Thomas Gleixner, Tony Luck, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Build and test stats at the end of the message.
The following changes since commit 8657355f5b5f657407efc12a2223e8a3a6d658de:
Merge tag 'perf-core-for-mingo-20161003' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-10-04 10:04:47 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161005
for you to fetch changes up to 87095f7ddeff3038a0cf8e6574922f9c11688619:
tools build: Add feature detection for g++ (2016-10-05 19:59:35 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Intel PT timestamp fixes (Adrian Hunter)
- Fix Intel JSON fixed counter conversions (Andi Kleen)
- Sync memcpy, cpufeatures and bpf headers with the kernel (Arnaldo Carvalho de Melo)
- Add some more tool tips (Donghyun Kim, Kim SeonYoung, Nambong Ha)
- Fix libtraceevent's kbuffer_read_at_offset() handling of offsets before or
equal the first event (Namhyung Kim)
- Fix uretprobe probe placement on ppc64le (Ravi Bangoria)
- Support building C++ source files and add feature detection for g++,
prep work for supporting a builtin clang/llvm, to remove the need for having
that toolchain installed to automagically build BPF scriptlets that then
gets uploaded to the kernel via sys_bpf() (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf intel-pt: Fix estimated timestamps for cycle-accurate mode
perf intel-pt: Fix MTC timestamp calculation for large MTC periods
Andi Kleen (1):
perf jevents: Fix Intel JSON fixed counter conversions
Arnaldo Carvalho de Melo (3):
perf bench mem: Sync memcpy assembly sources with the kernel
tools: Synchronize tools/arch/x86/include/asm/cpufeatures.h
tools: Synchronize tools/include/uapi/linux/bpf.h
Donghyun Kim (1):
perf report/top: Add a tip about system-wide collection from all CPUs
Kim SeonYoung (1):
perf report/top: Add a tip about source line numbers with overhead
Nambong Ha (1):
perf top/report: Add tips about a list option
Namhyung Kim (1):
tools lib traceevent: Fix kbuffer_read_at_offset()
Ravi Bangoria (1):
perf uretprobe ppc64le: Fix probe location
Wang Nan (2):
tools build: Support compiling C++ source file
tools build: Add feature detection for g++
tools/arch/x86/include/asm/cpufeatures.h | 1 -
tools/arch/x86/lib/memcpy_64.S | 6 ++--
tools/build/Build.include | 1 +
tools/build/Makefile.build | 7 ++++
tools/build/Makefile.feature | 2 +-
tools/build/feature/Makefile | 10 +++++-
tools/build/feature/test-cxx.cpp | 15 +++++++++
tools/include/uapi/linux/bpf.h | 4 +--
tools/lib/traceevent/kbuffer-parse.c | 1 +
tools/perf/Documentation/tips.txt | 4 +++
tools/perf/arch/powerpc/util/sym-handling.c | 3 +-
tools/perf/pmu-events/jevents.c | 2 ++
.../perf/util/intel-pt-decoder/intel-pt-decoder.c | 38 ++++++++++++++++++++++
13 files changed, 85 insertions(+), 9 deletions(-)
create mode 100644 tools/build/feature/test-cxx.cpp
[root@jouet ~]# time dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 fedora:20: Ok
11 fedora:21: Ok
12 fedora:22: Ok
13 fedora:23: Ok
14 fedora:24: Ok
15 fedora:24-x-ARC-uClibc: Ok
16 fedora:rawhide: Ok
17 mageia:5: Ok
18 opensuse:13.2: Ok
19 opensuse:42.1: Ok
20 opensuse:tumbleweed: Ok
21 ubuntu:12.04.5: Ok
22 ubuntu:14.04: Ok
23 ubuntu:14.04.4: Ok
24 ubuntu:15.10: Ok
25 ubuntu:16.04: Ok
26 ubuntu:16.04-x-arm: Ok
27 ubuntu:16.04-x-arm64: Ok
28 ubuntu:16.04-x-powerpc: Ok
29 ubuntu:16.04-x-powerpc64: Ok
30 ubuntu:16.04-x-powerpc64el: Ok
31 ubuntu:16.04-x-s390: Ok
32 ubuntu:16.10: Ok
real 44m58.202s
user 0m2.864s
sys 0m1.975s
[root@jouet ~]#
[acme@jouet linux]$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
tarpkg: ./tests/perf-targz-src-pkg .
make_static_O: make LDFLAGS=-static
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_help_O: make help
make_no_libpython_O: make NO_LIBPYTHON=1
make_install_O: make install
make_install_prefix_O: make install prefix=/tmp/krava
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libperl_O: make NO_LIBPERL=1
make_debug_O: make DEBUG=1
make_perf_o_O: make perf.o
make_clean_all_O: make clean all
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_libbpf_O: make NO_LIBBPF=1
make_install_bin_O: make install-bin
make_util_map_o_O: make util/map.o
make_no_libelf_O: make NO_LIBELF=1
make_no_newt_O: make NO_NEWT=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_gtk2_O: make NO_GTK2=1
make_no_slang_O: make NO_SLANG=1
make_doc_O: make doc
make_pure_O: make
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_tags_O: make tags
make_no_backtrace_O: make NO_BACKTRACE=1
OK
[root@jouet ~]# perf test
1: vmlinux symtab matches kallsyms : Ok
2: detect openat syscall event : Ok
3: detect openat syscall event on all cpus : Ok
4: read samples using the mmap interface : Ok
5: parse events tests : Ok
6: Validate PERF_RECORD_* events & perf_sample fields : Ok
7: Test perf pmu format parsing : Ok
8: Test dso data read : Ok
9: Test dso data cache : Ok
10: Test dso data reopen : Ok
11: roundtrip evsel->name check : Ok
12: Check parsing of sched tracepoints fields : Ok
13: Generate and check syscalls:sys_enter_openat event fields: Ok
14: struct perf_event_attr setup : Ok
15: Test matching and linking multiple hists : Ok
16: Try 'import perf' in python, checking link problems : Ok
17: Test breakpoint overflow signal handler : Ok
18: Test breakpoint overflow sampling : Ok
19: Test number of exit event of a simple workload : Ok
20: Test software clock events have valid period values : Ok
21: Test object code reading : Ok
22: Test sample parsing : Ok
23: Test using a dummy software event to keep tracking : Ok
24: Test parsing with no sample_id_all bit set : Ok
25: Test filtering hist entries : Ok
26: Test mmap thread lookup : Ok
27: Test thread mg sharing : Ok
28: Test output sorting of hist entries : Ok
29: Test cumulation of child hist entries : Ok
30: Test tracking with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: Test kmod_path__parse function : Ok
34: Test thread map : Ok
35: Test LLVM searching and compiling :
35.1: Basic BPF llvm compiling test : Ok
35.2: Test kbuild searching : Ok
35.3: Compile source for BPF prologue generation test : Ok
35.4: Compile source for BPF relocation test : Ok
36: Test topology in session : Ok
37: Test BPF filter :
37.1: Test basic BPF filtering : Ok
37.2: Test BPF prologue generation : Ok
37.3: Test BPF relocation checker : Ok
38: Test thread map synthesize : Ok
39: Test cpu map synthesize : Ok
40: Test stat config synthesize : Ok
41: Test stat synthesize : Ok
42: Test stat round synthesize : Ok
43: Test attr update synthesize : Ok
44: Test events times : Ok
45: Test backward reading from ring buffer : Ok
46: Test cpu map print : Ok
47: Test SDT event probing : Ok
48: Test is_printable_array function : Ok
49: Test bitmap print : Ok
50: x86 rdpmc test : Ok
51: Test converting perf time to TSC : Ok
52: Test dwarf unwind : Ok
53: Test x86 instruction decoder - new instructions : Ok
54: Test intel cqm nmi context read : Skip
[root@jouet ~]#
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2016-05-11 16:32 Arnaldo Carvalho de Melo
@ 2016-05-12 6:58 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2016-05-12 6:58 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Ananth N Mavinakayanahalli, Andi Kleen,
Brendan Gregg, Chris Phlipot, David Ahern, Ekaterina Tumanova,
He Kuang, Hemant Kumar, Jiri Olsa, Josh Poimboeuf, Kan Liang,
Masami Hiramatsu, Namhyung Kim, Pekka Enberg, Peter Zijlstra,
Stephane Eranian, Sukadev Bhattiprolu, Wang Nan
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 38f5d8b32f36bcac1f54d4511a81e02ed8771a29:
>
> Merge tag 'perf-core-for-mingo-20160510' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-05-11 16:56:58 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160511
>
> for you to fetch changes up to d65444d2fba98dcd4fa028ffada39c36a46f0038:
>
> perf buildid-cache: Use lsdir() for looking up buildid caches (2016-05-11 13:06:08 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix symbol insertion and callchain behavior in db-export (Chris Phlipot)
>
> Infrastructure:
>
> - Add libunwind build test (feature query), working towards supporting
> cross-platform DWARF callchains, starting with arm/arm64 (He Kuang)
>
> - Use lsdir() more extensively (Masami Hiramatsu)
>
> - Use SBUILD_ID_SIZE in places where the equivalent expression was
> being used (Masami Hiramatsu)
>
> - Split some more 'perf trace' syscall arg beautifiers (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf scripting python: Use Py_FatalError instead of die()
> perf trace: Move flock op beautifier to tools/perf/trace/beauty/
> perf trace: Move seccomp args beautifiers to tools/perf/trace/beauty/
>
> Chris Phlipot (4):
> perf symbols: Add dso__insert_symbol function
> perf script: Fix symbol insertion behavior in db-export
> perf script: Fix callchain addresses in db-export
> perf script: Fix export of callchains with recursion in db-export
>
> He Kuang (2):
> perf build: Add build-test for libunwind cross-platforms support
> perf build: Add build-test for debug-frame on arm/arm64
>
> Masami Hiramatsu (4):
> perf tools: Fix lsdir to set errno correctly
> perf tools: Use SBUILD_ID_SIZE where applicable
> perf symbols: Use lsdir() for the search in kcore cache directory
> perf buildid-cache: Use lsdir() for looking up buildid caches
>
> tools/build/Makefile.feature | 8 +-
> tools/build/feature/Makefile | 23 ++++++
> tools/build/feature/test-libunwind-aarch64.c | 26 +++++++
> tools/build/feature/test-libunwind-arm.c | 27 +++++++
> .../feature/test-libunwind-debug-frame-aarch64.c | 16 ++++
> .../build/feature/test-libunwind-debug-frame-arm.c | 16 ++++
> tools/build/feature/test-libunwind-x86.c | 27 +++++++
> tools/build/feature/test-libunwind-x86_64.c | 27 +++++++
> tools/perf/builtin-trace.c | 85 +---------------------
> tools/perf/trace/beauty/flock.c | 31 ++++++++
> tools/perf/trace/beauty/seccomp.c | 52 +++++++++++++
> tools/perf/util/annotate.c | 2 +-
> tools/perf/util/build-id.c | 30 +-------
> tools/perf/util/db-export.c | 12 +--
> tools/perf/util/dso.c | 4 +-
> tools/perf/util/header.c | 2 +-
> tools/perf/util/map.c | 2 +-
> .../util/scripting-engines/trace-event-python.c | 9 ++-
> tools/perf/util/symbol.c | 40 ++++++----
> tools/perf/util/symbol.h | 3 +
> tools/perf/util/util.c | 2 +-
> 21 files changed, 306 insertions(+), 138 deletions(-)
> create mode 100644 tools/build/feature/test-libunwind-aarch64.c
> create mode 100644 tools/build/feature/test-libunwind-arm.c
> create mode 100644 tools/build/feature/test-libunwind-debug-frame-aarch64.c
> create mode 100644 tools/build/feature/test-libunwind-debug-frame-arm.c
> create mode 100644 tools/build/feature/test-libunwind-x86.c
> create mode 100644 tools/build/feature/test-libunwind-x86_64.c
> create mode 100644 tools/perf/trace/beauty/flock.c
> create mode 100644 tools/perf/trace/beauty/seccomp.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2016-05-11 16:32 Arnaldo Carvalho de Melo
2016-05-12 6:58 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-05-11 16:32 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Ananth N Mavinakayanahalli, Andi Kleen,
Brendan Gregg, Chris Phlipot, David Ahern, Ekaterina Tumanova,
He Kuang, Hemant Kumar, Jiri Olsa, Josh Poimboeuf, Kan Liang,
Masami Hiramatsu, Namhyung Kim, Pekka Enberg, Peter Zijlstra,
Stephane Eranian, Sukadev Bhattiprolu, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 38f5d8b32f36bcac1f54d4511a81e02ed8771a29:
Merge tag 'perf-core-for-mingo-20160510' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-05-11 16:56:58 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160511
for you to fetch changes up to d65444d2fba98dcd4fa028ffada39c36a46f0038:
perf buildid-cache: Use lsdir() for looking up buildid caches (2016-05-11 13:06:08 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix symbol insertion and callchain behavior in db-export (Chris Phlipot)
Infrastructure:
- Add libunwind build test (feature query), working towards supporting
cross-platform DWARF callchains, starting with arm/arm64 (He Kuang)
- Use lsdir() more extensively (Masami Hiramatsu)
- Use SBUILD_ID_SIZE in places where the equivalent expression was
being used (Masami Hiramatsu)
- Split some more 'perf trace' syscall arg beautifiers (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf scripting python: Use Py_FatalError instead of die()
perf trace: Move flock op beautifier to tools/perf/trace/beauty/
perf trace: Move seccomp args beautifiers to tools/perf/trace/beauty/
Chris Phlipot (4):
perf symbols: Add dso__insert_symbol function
perf script: Fix symbol insertion behavior in db-export
perf script: Fix callchain addresses in db-export
perf script: Fix export of callchains with recursion in db-export
He Kuang (2):
perf build: Add build-test for libunwind cross-platforms support
perf build: Add build-test for debug-frame on arm/arm64
Masami Hiramatsu (4):
perf tools: Fix lsdir to set errno correctly
perf tools: Use SBUILD_ID_SIZE where applicable
perf symbols: Use lsdir() for the search in kcore cache directory
perf buildid-cache: Use lsdir() for looking up buildid caches
tools/build/Makefile.feature | 8 +-
tools/build/feature/Makefile | 23 ++++++
tools/build/feature/test-libunwind-aarch64.c | 26 +++++++
tools/build/feature/test-libunwind-arm.c | 27 +++++++
.../feature/test-libunwind-debug-frame-aarch64.c | 16 ++++
.../build/feature/test-libunwind-debug-frame-arm.c | 16 ++++
tools/build/feature/test-libunwind-x86.c | 27 +++++++
tools/build/feature/test-libunwind-x86_64.c | 27 +++++++
tools/perf/builtin-trace.c | 85 +---------------------
tools/perf/trace/beauty/flock.c | 31 ++++++++
tools/perf/trace/beauty/seccomp.c | 52 +++++++++++++
tools/perf/util/annotate.c | 2 +-
tools/perf/util/build-id.c | 30 +-------
tools/perf/util/db-export.c | 12 +--
tools/perf/util/dso.c | 4 +-
tools/perf/util/header.c | 2 +-
tools/perf/util/map.c | 2 +-
.../util/scripting-engines/trace-event-python.c | 9 ++-
tools/perf/util/symbol.c | 40 ++++++----
tools/perf/util/symbol.h | 3 +
tools/perf/util/util.c | 2 +-
21 files changed, 306 insertions(+), 138 deletions(-)
create mode 100644 tools/build/feature/test-libunwind-aarch64.c
create mode 100644 tools/build/feature/test-libunwind-arm.c
create mode 100644 tools/build/feature/test-libunwind-debug-frame-aarch64.c
create mode 100644 tools/build/feature/test-libunwind-debug-frame-arm.c
create mode 100644 tools/build/feature/test-libunwind-x86.c
create mode 100644 tools/build/feature/test-libunwind-x86_64.c
create mode 100644 tools/perf/trace/beauty/flock.c
create mode 100644 tools/perf/trace/beauty/seccomp.c
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2016-04-29 14:57 Arnaldo Carvalho de Melo
@ 2016-04-29 19:39 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2016-04-29 19:39 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin,
Alexei Starovoitov, Ananth N Mavinakayanahalli, Brendan Gregg,
David Ahern, Florian Fainelli, Frederic Weisbecker, He Kuang,
Hemant Kumar, Jiri Olsa, Masami Hiramatsu, Milian Wolff,
Namhyung Kim, Peter Zijlstra, pi3orama, Vaishali Thakkar,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling, tested on:
>
> [root@jouet ~]# docker-perf-build-test
> alldeps-fedora-rawhide: Ok
> alldeps-ubuntu-14.04: Ok
> alldeps-ubuntu-16.04: Ok <------------- New image
> alldeps-fedora-20: Ok
> alldeps-ubuntu-12.04: Ok
> minimal-debian-experimental-x-mips64: Ok
> minimal-debian-experimental-x-mips64el: Ok
> minimal-debian-experimental-x-mipsel: Ok
> minimal-ubuntu-x-arm: Ok
> minimal-ubuntu-x-arm64: Ok
> minimal-ubuntu-x-ppc64: Ok
> minimal-ubuntu-x-ppc64el: Ok
> alldeps-debian: Ok
> alldeps-mageia: Ok
> alldeps-rhel7: Ok
> alldeps-centos: Ok
> alldeps-opensuse: Ok
> [root@jouet ~]#
>
> - Arnaldo
>
> The following changes since commit 3521ba1cc351e80488c3f85748c92c3853b75818:
>
> powercap, perf/x86/intel/rapl: Add PSys support (2016-04-28 10:39:19 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160429
>
> for you to fetch changes up to ca7ce82a280a65c377c24c95c29b1dec6e80b428:
>
> perf tests: Do not use sizeof on pointer type (2016-04-28 15:37:52 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Allow generate timestamped suffixed multiple perf.data files upon receiving
> SIGUSR2 in 'perf record', to slice a long running monitoring session, allowing
> to dump uninteresting sessions (Wang Nan)
>
> - Handle ENOMEM for perf_event_max_stack + PERF_SAMPLE_CALLCHAIN
> in perf_evsel__open_strerror(), showing a more informative
> message when the request call stack depth can't be allocated by
> the kernel (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> - Use strbuf for making strings in 'perf probe' (Masami Hiramatsu)
>
> - Do not use sizeof on pointer type, not a problem since its a pointer to
> pointer, fix none the less. Found by Coccinelle (Vaishali Thakkar)
>
> Cleanups:
>
> - Fix for Coverity found issues in the bpf feature build test (Florian Fainelli)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf evsel: Handle ENOMEM for perf_event_max_stack + PERF_SAMPLE_CALLCHAIN
> perf evsel: Remove two extraneous ending newlines in open_strerror()
> perf trace: Move msg_flags beautifier to tools/perf/trace/beauty/
>
> Florian Fainelli (2):
> bpf tools: Remove expression with no effect
> bpf tools: Fix syscall argument
>
> Masami Hiramatsu (1):
> perf probe: Use strbuf for making strings
>
> Vaishali Thakkar (1):
> perf tests: Do not use sizeof on pointer type
>
> Wang Nan (6):
> perf tools: Introduce trigger class
> perf tools: Derive trigger class from auxtrace_snapshot
> perf record: Split output into multiple files via '--switch-output'
> perf record: Force enable --timestamp-filename when --switch-output is provided
> perf record: Disable buildid cache options by default in switch output mode
> perf record: Generate tracking events for process forked by perf
>
> tools/build/feature/test-bpf.c | 3 +-
> tools/perf/Documentation/perf-record.txt | 13 ++
> tools/perf/builtin-record.c | 173 +++++++++++++++-------
> tools/perf/builtin-trace.c | 62 +-------
> tools/perf/tests/dso-data.c | 2 +-
> tools/perf/trace/beauty/msg_flags.c | 62 ++++++++
> tools/perf/util/evsel.c | 12 +-
> tools/perf/util/probe-event.c | 246 +++++++++++--------------------
> tools/perf/util/probe-event.h | 2 +-
> tools/perf/util/probe-finder.c | 14 +-
> tools/perf/util/trigger.h | 94 ++++++++++++
> 11 files changed, 393 insertions(+), 290 deletions(-)
> create mode 100644 tools/perf/trace/beauty/msg_flags.c
> create mode 100644 tools/perf/util/trigger.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2016-04-29 14:57 Arnaldo Carvalho de Melo
2016-04-29 19:39 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-04-29 14:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexei Starovoitov,
Ananth N Mavinakayanahalli, Brendan Gregg, David Ahern,
Florian Fainelli, Frederic Weisbecker, He Kuang, Hemant Kumar,
Jiri Olsa, Masami Hiramatsu, Milian Wolff, Namhyung Kim,
Peter Zijlstra, pi3orama, Vaishali Thakkar, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, tested on:
[root@jouet ~]# docker-perf-build-test
alldeps-fedora-rawhide: Ok
alldeps-ubuntu-14.04: Ok
alldeps-ubuntu-16.04: Ok <------------- New image
alldeps-fedora-20: Ok
alldeps-ubuntu-12.04: Ok
minimal-debian-experimental-x-mips64: Ok
minimal-debian-experimental-x-mips64el: Ok
minimal-debian-experimental-x-mipsel: Ok
minimal-ubuntu-x-arm: Ok
minimal-ubuntu-x-arm64: Ok
minimal-ubuntu-x-ppc64: Ok
minimal-ubuntu-x-ppc64el: Ok
alldeps-debian: Ok
alldeps-mageia: Ok
alldeps-rhel7: Ok
alldeps-centos: Ok
alldeps-opensuse: Ok
[root@jouet ~]#
- Arnaldo
The following changes since commit 3521ba1cc351e80488c3f85748c92c3853b75818:
powercap, perf/x86/intel/rapl: Add PSys support (2016-04-28 10:39:19 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160429
for you to fetch changes up to ca7ce82a280a65c377c24c95c29b1dec6e80b428:
perf tests: Do not use sizeof on pointer type (2016-04-28 15:37:52 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Allow generate timestamped suffixed multiple perf.data files upon receiving
SIGUSR2 in 'perf record', to slice a long running monitoring session, allowing
to dump uninteresting sessions (Wang Nan)
- Handle ENOMEM for perf_event_max_stack + PERF_SAMPLE_CALLCHAIN
in perf_evsel__open_strerror(), showing a more informative
message when the request call stack depth can't be allocated by
the kernel (Arnaldo Carvalho de Melo)
Infrastructure:
- Use strbuf for making strings in 'perf probe' (Masami Hiramatsu)
- Do not use sizeof on pointer type, not a problem since its a pointer to
pointer, fix none the less. Found by Coccinelle (Vaishali Thakkar)
Cleanups:
- Fix for Coverity found issues in the bpf feature build test (Florian Fainelli)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf evsel: Handle ENOMEM for perf_event_max_stack + PERF_SAMPLE_CALLCHAIN
perf evsel: Remove two extraneous ending newlines in open_strerror()
perf trace: Move msg_flags beautifier to tools/perf/trace/beauty/
Florian Fainelli (2):
bpf tools: Remove expression with no effect
bpf tools: Fix syscall argument
Masami Hiramatsu (1):
perf probe: Use strbuf for making strings
Vaishali Thakkar (1):
perf tests: Do not use sizeof on pointer type
Wang Nan (6):
perf tools: Introduce trigger class
perf tools: Derive trigger class from auxtrace_snapshot
perf record: Split output into multiple files via '--switch-output'
perf record: Force enable --timestamp-filename when --switch-output is provided
perf record: Disable buildid cache options by default in switch output mode
perf record: Generate tracking events for process forked by perf
tools/build/feature/test-bpf.c | 3 +-
tools/perf/Documentation/perf-record.txt | 13 ++
tools/perf/builtin-record.c | 173 +++++++++++++++-------
tools/perf/builtin-trace.c | 62 +-------
tools/perf/tests/dso-data.c | 2 +-
tools/perf/trace/beauty/msg_flags.c | 62 ++++++++
tools/perf/util/evsel.c | 12 +-
tools/perf/util/probe-event.c | 246 +++++++++++--------------------
tools/perf/util/probe-event.h | 2 +-
tools/perf/util/probe-finder.c | 14 +-
tools/perf/util/trigger.h | 94 ++++++++++++
11 files changed, 393 insertions(+), 290 deletions(-)
create mode 100644 tools/perf/trace/beauty/msg_flags.c
create mode 100644 tools/perf/util/trigger.h
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2016-02-15 21:01 Arnaldo Carvalho de Melo
@ 2016-02-16 7:48 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2016-02-16 7:48 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Brendan Gregg, Cody P Schafer,
Daniel Borkmann, Dave Jones, He Kuang, Jeremie Galarneau,
Jiri Olsa, Kirill Smelkov, Li Zefan, Masami Hiramatsu,
Namhyung Kim, Peter Zijlstra, pi3orama, Taeung Song, Vinson Lee,
Wang Nan, Will Deacon, Zubair Lutfullah Kakakhel
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit a7636d9ecfa3ab7800a7c04c1f89378229eff609:
>
> kprobes: Optimize hot path by using percpu counter to collect 'nhit' statistics (2016-02-09 11:08:58 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 1ad826bad5bd0b6ccfb203f78c70302b764df0be:
>
> perf tests: Fix build on older systems where 'signal' is reserved (2016-02-15 17:33:26 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Do not print trailing spaces in the hists browser (top, report) to
> avoid line wrapping issues when long C++ demangled functions are
> sampled (Arnaldo Carvalho de Melo)
>
> - Allow 'perf config' to show --system or --user settings (Taeung Song)
>
> - Add better warning about the need to install the audit-lib-python
> package when using perf python scripts (Taeung Song)
>
> - Fix symbol resolution when kernel modules files are only in the
> build id cache (~/.debug) (Wang Nan)
>
> Build fixes:
>
> - Fix 'perf test' build on older systems where 'signal' is reserved (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> - Free the terms list_head in parse_events__free_terms(), also unlink the entries
> when deleting them (Wang Nan)
>
> - Fix releasing event_class in 'perf data' fixing integration with
> libbabeltrace (Wang Nan)
>
> - Add EXTRA_LDFLAGS option to Makefile (Zubair Lutfullah Kakakhel)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (6):
> perf tools: Add comment explaining the repsep_snprintf function
> perf hists: Do column alignment on the format iterator
> perf tools: Introduce parse_events_terms__purge()
> perf tools: Use perf_event_terms__purge() for non-malloced terms
> perf tools: Rename parse_events__free_terms() to parse_events_terms__delete()
> perf tests: Fix build on older systems where 'signal' is reserved
>
> Taeung Song (2):
> perf config: Add '--system' and '--user' options to select which config file is used
> perf python scripting: Append examples to err msg about audit-libs-python
>
> Wang Nan (4):
> perf symbols: Fix symbols searching for module in buildid-cache
> perf tools: Unlink entries from terms list
> perf tools: Free the terms list_head in parse_events__free_terms()
> perf data: Fix releasing event_class
>
> Zubair Lutfullah Kakakhel (1):
> perf build: Add EXTRA_LDFLAGS option to makefile
>
> tools/perf/Documentation/perf-config.txt | 14 ++++++-
> tools/perf/Makefile.perf | 2 +
> tools/perf/arch/x86/util/intel-pt.c | 2 +-
> tools/perf/builtin-config.c | 27 +++++++++++--
> .../python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 5 ++-
> tools/perf/tests/bp_signal.c | 12 +++---
> tools/perf/tests/parse-events.c | 2 +-
> tools/perf/ui/browsers/hists.c | 27 ++++++++-----
> tools/perf/ui/stdio/hist.c | 1 +
> tools/perf/util/build-id.c | 44 ++++++++++++++++++++++
> tools/perf/util/build-id.h | 1 +
> tools/perf/util/cache.h | 3 ++
> tools/perf/util/config.c | 4 +-
> tools/perf/util/data-convert-bt.c | 18 +++++++++
> tools/perf/util/hist.c | 21 +++++++++++
> tools/perf/util/hist.h | 5 +++
> tools/perf/util/parse-events.c | 17 +++++++--
> tools/perf/util/parse-events.h | 3 +-
> tools/perf/util/parse-events.y | 8 ++--
> tools/perf/util/pmu.c | 2 +-
> tools/perf/util/sort.c | 23 +++++------
> tools/perf/util/symbol.c | 4 ++
> 22 files changed, 200 insertions(+), 45 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2016-02-15 21:01 Arnaldo Carvalho de Melo
2016-02-16 7:48 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-15 21:01 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Brendan Gregg, Cody P Schafer,
Daniel Borkmann, Dave Jones, He Kuang, Jeremie Galarneau,
Jiri Olsa, Kirill Smelkov, Li Zefan, Masami Hiramatsu,
Namhyung Kim, Peter Zijlstra, pi3orama, Taeung Song, Vinson Lee,
Wang Nan, Will Deacon, Zubair Lutfullah Kakakhel
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit a7636d9ecfa3ab7800a7c04c1f89378229eff609:
kprobes: Optimize hot path by using percpu counter to collect 'nhit' statistics (2016-02-09 11:08:58 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 1ad826bad5bd0b6ccfb203f78c70302b764df0be:
perf tests: Fix build on older systems where 'signal' is reserved (2016-02-15 17:33:26 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Do not print trailing spaces in the hists browser (top, report) to
avoid line wrapping issues when long C++ demangled functions are
sampled (Arnaldo Carvalho de Melo)
- Allow 'perf config' to show --system or --user settings (Taeung Song)
- Add better warning about the need to install the audit-lib-python
package when using perf python scripts (Taeung Song)
- Fix symbol resolution when kernel modules files are only in the
build id cache (~/.debug) (Wang Nan)
Build fixes:
- Fix 'perf test' build on older systems where 'signal' is reserved (Arnaldo Carvalho de Melo)
Infrastructure:
- Free the terms list_head in parse_events__free_terms(), also unlink the entries
when deleting them (Wang Nan)
- Fix releasing event_class in 'perf data' fixing integration with
libbabeltrace (Wang Nan)
- Add EXTRA_LDFLAGS option to Makefile (Zubair Lutfullah Kakakhel)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (6):
perf tools: Add comment explaining the repsep_snprintf function
perf hists: Do column alignment on the format iterator
perf tools: Introduce parse_events_terms__purge()
perf tools: Use perf_event_terms__purge() for non-malloced terms
perf tools: Rename parse_events__free_terms() to parse_events_terms__delete()
perf tests: Fix build on older systems where 'signal' is reserved
Taeung Song (2):
perf config: Add '--system' and '--user' options to select which config file is used
perf python scripting: Append examples to err msg about audit-libs-python
Wang Nan (4):
perf symbols: Fix symbols searching for module in buildid-cache
perf tools: Unlink entries from terms list
perf tools: Free the terms list_head in parse_events__free_terms()
perf data: Fix releasing event_class
Zubair Lutfullah Kakakhel (1):
perf build: Add EXTRA_LDFLAGS option to makefile
tools/perf/Documentation/perf-config.txt | 14 ++++++-
tools/perf/Makefile.perf | 2 +
tools/perf/arch/x86/util/intel-pt.c | 2 +-
tools/perf/builtin-config.c | 27 +++++++++++--
.../python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 5 ++-
tools/perf/tests/bp_signal.c | 12 +++---
tools/perf/tests/parse-events.c | 2 +-
tools/perf/ui/browsers/hists.c | 27 ++++++++-----
tools/perf/ui/stdio/hist.c | 1 +
tools/perf/util/build-id.c | 44 ++++++++++++++++++++++
tools/perf/util/build-id.h | 1 +
tools/perf/util/cache.h | 3 ++
tools/perf/util/config.c | 4 +-
tools/perf/util/data-convert-bt.c | 18 +++++++++
tools/perf/util/hist.c | 21 +++++++++++
tools/perf/util/hist.h | 5 +++
tools/perf/util/parse-events.c | 17 +++++++--
tools/perf/util/parse-events.h | 3 +-
tools/perf/util/parse-events.y | 8 ++--
tools/perf/util/pmu.c | 2 +-
tools/perf/util/sort.c | 23 +++++------
tools/perf/util/symbol.c | 4 ++
22 files changed, 200 insertions(+), 45 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2015-11-26 20:45 Arnaldo Carvalho de Melo
@ 2015-11-27 7:30 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2015-11-27 7:30 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Yarygin,
Alexei Starovoitov, Andi Kleen, Christian Borntraeger,
David Ahern, Ekaterina Tumanova, Frederic Weisbecker, He Kuang,
Jiri Olsa, Joshua Zhu, Kan Liang, kernel-team, Masami Hiramatsu,
Namhyung Kim, Naveen N . Rao, Peter Zijlstra, pi3orama, Wang Nan,
Yannick Brosseau, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
>
> The following changes since commit a95a49fa0cc5eec730d8703b1544fa7ea6a11dec:
>
> Merge tag 'perf-core-for-mingo-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-11-26 09:13:50 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 43798bf37215fe242e592fd4605d804e2da0781b:
>
> bpf tools: Add helper function for updating bpf maps elements (2015-11-26 17:21:24 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Add 'vmlinux.debug' to the vmlinux seach path (Ekaterina Tumanova)
>
> - Do not show sample_(type|period) in the perf_event_attr dump when using
> -v with 'perf stat' (Jiri Olsa)
>
> - Display the WEIGHT sample bit, when set, in 'perf evlist -v' (Jiri Olsa)
>
> - Honour --hide-unresolved in 'report', will honour it as well in 'top'
> when --hide-unresolved gets supported in that tool (Namhyung Kim)
>
> - Fix freeze wit h--call-graph 'flat/folded' due to not properly
> reinitializing the callchain rb_tree (Namhyumg Kim)
>
> - Set dso->long_name when a module name is passed as a parameter
> to tools like 'perf probe' but the 'struct dso' associated to that module
> still doesn't have the full path for the module, just the '[name]' one
> obtained from /proc/modules (Wang Nan)
>
> - Fix anon_hugepage mmaps detection using scanf on /proc/PID/smaps (Yannick Brosseau)
>
> Infrastructure:
>
> - Add helper function for updating bpf maps elements (He Kuang)
>
> - Fix traceevents plugins build race (Jiri Olsa)
>
> - Add the $OUTPUT path prefix with 'fixdep' (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Ekaterina Tumanova (2):
> perf symbols: Refactor vmlinux_path__init() to ease path additions
> perf symbols: Add the path to vmlinux.debug
>
> He Kuang (1):
> bpf tools: Add helper function for updating bpf maps elements
>
> Jiri Olsa (6):
> perf script: Remove default_scripting_ops
> perf build: Fix traceevent plugins build race
> perf script: Pass perf_script into process_event
> tools build: Use fixdep with OUTPUT path prefix
> perf stat: Clear sample_(type|period) for counting
> perf evlist: Display WEIGHT sample type bit
>
> Namhyung Kim (2):
> perf callchain: Honor hide_unresolved
> perf top: Fix freeze on --call-graph flat/folded
>
> Wang Nan (1):
> perf machine: Adjust dso->long_name for offline module
>
> Yannick Brosseau (1):
> perf tools: Correctly identify anon_hugepage when generating map (v2)
>
> tools/build/Makefile | 2 +-
> tools/build/Makefile.include | 2 +-
> tools/lib/bpf/bpf.c | 14 +++++++++
> tools/lib/bpf/bpf.h | 2 ++
> tools/perf/Makefile.perf | 2 +-
> tools/perf/builtin-report.c | 7 ++---
> tools/perf/builtin-script.c | 67 +++++++++++++-------------------------------
> tools/perf/builtin-stat.c | 7 +++++
> tools/perf/util/callchain.c | 1 +
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/machine.c | 32 ++++++++++++++++++++-
> tools/perf/util/map.c | 4 +--
> tools/perf/util/symbol.c | 65 ++++++++++++++++++++++--------------------
> tools/perf/util/symbol.h | 3 +-
> 14 files changed, 120 insertions(+), 89 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2015-11-26 20:45 Arnaldo Carvalho de Melo
2015-11-27 7:30 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-11-26 20:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Yarygin, Alexei Starovoitov, Andi Kleen,
Christian Borntraeger, David Ahern, Ekaterina Tumanova,
Frederic Weisbecker, He Kuang, Jiri Olsa, Joshua Zhu, Kan Liang,
kernel-team, Masami Hiramatsu, Namhyung Kim, Naveen N . Rao,
Peter Zijlstra, pi3orama, Wang Nan, Yannick Brosseau, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit a95a49fa0cc5eec730d8703b1544fa7ea6a11dec:
Merge tag 'perf-core-for-mingo-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-11-26 09:13:50 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 43798bf37215fe242e592fd4605d804e2da0781b:
bpf tools: Add helper function for updating bpf maps elements (2015-11-26 17:21:24 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Add 'vmlinux.debug' to the vmlinux seach path (Ekaterina Tumanova)
- Do not show sample_(type|period) in the perf_event_attr dump when using
-v with 'perf stat' (Jiri Olsa)
- Display the WEIGHT sample bit, when set, in 'perf evlist -v' (Jiri Olsa)
- Honour --hide-unresolved in 'report', will honour it as well in 'top'
when --hide-unresolved gets supported in that tool (Namhyung Kim)
- Fix freeze wit h--call-graph 'flat/folded' due to not properly
reinitializing the callchain rb_tree (Namhyumg Kim)
- Set dso->long_name when a module name is passed as a parameter
to tools like 'perf probe' but the 'struct dso' associated to that module
still doesn't have the full path for the module, just the '[name]' one
obtained from /proc/modules (Wang Nan)
- Fix anon_hugepage mmaps detection using scanf on /proc/PID/smaps (Yannick Brosseau)
Infrastructure:
- Add helper function for updating bpf maps elements (He Kuang)
- Fix traceevents plugins build race (Jiri Olsa)
- Add the $OUTPUT path prefix with 'fixdep' (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Ekaterina Tumanova (2):
perf symbols: Refactor vmlinux_path__init() to ease path additions
perf symbols: Add the path to vmlinux.debug
He Kuang (1):
bpf tools: Add helper function for updating bpf maps elements
Jiri Olsa (6):
perf script: Remove default_scripting_ops
perf build: Fix traceevent plugins build race
perf script: Pass perf_script into process_event
tools build: Use fixdep with OUTPUT path prefix
perf stat: Clear sample_(type|period) for counting
perf evlist: Display WEIGHT sample type bit
Namhyung Kim (2):
perf callchain: Honor hide_unresolved
perf top: Fix freeze on --call-graph flat/folded
Wang Nan (1):
perf machine: Adjust dso->long_name for offline module
Yannick Brosseau (1):
perf tools: Correctly identify anon_hugepage when generating map (v2)
tools/build/Makefile | 2 +-
tools/build/Makefile.include | 2 +-
tools/lib/bpf/bpf.c | 14 +++++++++
tools/lib/bpf/bpf.h | 2 ++
tools/perf/Makefile.perf | 2 +-
tools/perf/builtin-report.c | 7 ++---
tools/perf/builtin-script.c | 67 +++++++++++++-------------------------------
tools/perf/builtin-stat.c | 7 +++++
tools/perf/util/callchain.c | 1 +
tools/perf/util/evsel.c | 1 +
tools/perf/util/machine.c | 32 ++++++++++++++++++++-
tools/perf/util/map.c | 4 +--
tools/perf/util/symbol.c | 65 ++++++++++++++++++++++--------------------
tools/perf/util/symbol.h | 3 +-
14 files changed, 120 insertions(+), 89 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2015-08-12 16:39 Arnaldo Carvalho de Melo
@ 2015-08-13 7:25 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2015-08-13 7:25 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Borislav Petkov,
David Ahern, Frederic Weisbecker, Jiri Olsa, Kan Liang,
Masami Hiramatsu, Milian Wolff, Namhyung Kim, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider applying,
>
> - Arnaldo
>
> The following changes since commit 5f1230c9b80b89f404938ff88dfa64a963f74f2c:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-08-12 12:16:11 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 71ef150ee06df29c5b427307dc0bacfe06a8baea:
>
> perf tests: Add tests to callgraph and time parse (2015-08-12 13:20:29 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Allow selecting the type of callchains per event, including disabling
> callchains in all but one entry in an event list, to save space, and also
> to ask for the callchains collected in one event to be used in other
> events (Kan Liang)
>
> - Beautify more syscall arguments in 'perf trace': (Arnaldo Carvalho de Melo)
> - A bunch more translate file/pathnames from pointers to strings
> - Convert numbers to strings for the 'keyctl' syscall 'option' arg.
> - Add missing 'clockid' entries
>
> - Fix 'perf probe -L sys_*' as it was not showing all the source code for
> syscall functions in the kernel (Masami Hiramatsu)
>
> - Make ESC unzoom as well in the hists browser, i.e. in 'report' and 'top',
> as we're considering repurposing the right and left arrow keys to use in
> horizontal scrolling, i.e. leave just ESC to be used for what <- works
> now, and ENTER for what -> does (they are already aliases for ages)
> (Arnaldo Carvalho de Melo)
>
> Infrastructure fixes:
>
> - Check for SRCLINE_UNKNOWN case in "srcfile" processing (Andi Kleen)
>
> - Wrap the slsmg_{printf,write_nstring} slang functions behing ui_browser, so
> that we can make the ui_browser based browsers (annotate, menus, hists, etc) UI
> library agnostic and usable with multiple backends (slang now, GTK+ and others
> in the future, maybe) (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf sort: Check for SRCLINE_UNKNOWN case in "srcfile" processing
>
> Arnaldo Carvalho de Melo (7):
> perf trace: Associate some more syscall args with the getname beautifier
> perf trace: Add missing clockid entries
> perf trace: Use the FD beautifier for socket syscall fds
> perf trace: Beautify keyctl's option arg
> perf ui browser: Introduce ui_browser__write_nstring()
> perf ui browser: Introduce ui_browser__printf()
> perf hists browser: Make ESC unzoom as well
>
> Kan Liang (4):
> perf callchain: Per-event type selection support
> perf callchain: Allow disabling call graphs per event
> perf report: Show call graph from reference events
> perf tests: Add tests to callgraph and time parse
>
> Masami Hiramatsu (1):
> perf probe: Fix to show lines of sys_ functions correctly
>
> tools/perf/Documentation/perf-record.txt | 4 ++
> tools/perf/Documentation/perf-report.txt | 11 ++++++
> tools/perf/builtin-annotate.c | 2 +
> tools/perf/builtin-diff.c | 3 ++
> tools/perf/builtin-report.c | 7 ++++
> tools/perf/builtin-trace.c | 54 +++++++++++++++++++------
> tools/perf/tests/hists_cumulate.c | 4 ++
> tools/perf/tests/parse-events.c | 38 ++++++++++++++++++
> tools/perf/ui/browser.c | 17 +++++++-
> tools/perf/ui/browser.h | 3 ++
> tools/perf/ui/browsers/annotate.c | 43 ++++++++++----------
> tools/perf/ui/browsers/header.c | 2 +-
> tools/perf/ui/browsers/hists.c | 54 ++++++++++++-------------
> tools/perf/ui/browsers/map.c | 11 +++---
> tools/perf/ui/browsers/scripts.c | 2 +-
> tools/perf/ui/libslang.h | 3 ++
> tools/perf/ui/tui/util.c | 2 +-
> tools/perf/util/dwarf-aux.c | 18 ++++++---
> tools/perf/util/evsel.c | 67 +++++++++++++++++++++++++++++++-
> tools/perf/util/evsel.h | 4 ++
> tools/perf/util/hist.c | 14 +++++--
> tools/perf/util/parse-events.c | 12 ++++++
> tools/perf/util/parse-events.h | 2 +
> tools/perf/util/parse-events.l | 2 +
> tools/perf/util/pmu.c | 4 +-
> tools/perf/util/sort.c | 2 +
> tools/perf/util/symbol.h | 3 +-
> 27 files changed, 307 insertions(+), 81 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2015-08-12 16:39 Arnaldo Carvalho de Melo
2015-08-13 7:25 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-08-12 16:39 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, David Ahern, Frederic Weisbecker,
Jiri Olsa, Kan Liang, Masami Hiramatsu, Milian Wolff,
Namhyung Kim, Stephane Eranian, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider applying,
- Arnaldo
The following changes since commit 5f1230c9b80b89f404938ff88dfa64a963f74f2c:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-08-12 12:16:11 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 71ef150ee06df29c5b427307dc0bacfe06a8baea:
perf tests: Add tests to callgraph and time parse (2015-08-12 13:20:29 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Allow selecting the type of callchains per event, including disabling
callchains in all but one entry in an event list, to save space, and also
to ask for the callchains collected in one event to be used in other
events (Kan Liang)
- Beautify more syscall arguments in 'perf trace': (Arnaldo Carvalho de Melo)
- A bunch more translate file/pathnames from pointers to strings
- Convert numbers to strings for the 'keyctl' syscall 'option' arg.
- Add missing 'clockid' entries
- Fix 'perf probe -L sys_*' as it was not showing all the source code for
syscall functions in the kernel (Masami Hiramatsu)
- Make ESC unzoom as well in the hists browser, i.e. in 'report' and 'top',
as we're considering repurposing the right and left arrow keys to use in
horizontal scrolling, i.e. leave just ESC to be used for what <- works
now, and ENTER for what -> does (they are already aliases for ages)
(Arnaldo Carvalho de Melo)
Infrastructure fixes:
- Check for SRCLINE_UNKNOWN case in "srcfile" processing (Andi Kleen)
- Wrap the slsmg_{printf,write_nstring} slang functions behing ui_browser, so
that we can make the ui_browser based browsers (annotate, menus, hists, etc) UI
library agnostic and usable with multiple backends (slang now, GTK+ and others
in the future, maybe) (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf sort: Check for SRCLINE_UNKNOWN case in "srcfile" processing
Arnaldo Carvalho de Melo (7):
perf trace: Associate some more syscall args with the getname beautifier
perf trace: Add missing clockid entries
perf trace: Use the FD beautifier for socket syscall fds
perf trace: Beautify keyctl's option arg
perf ui browser: Introduce ui_browser__write_nstring()
perf ui browser: Introduce ui_browser__printf()
perf hists browser: Make ESC unzoom as well
Kan Liang (4):
perf callchain: Per-event type selection support
perf callchain: Allow disabling call graphs per event
perf report: Show call graph from reference events
perf tests: Add tests to callgraph and time parse
Masami Hiramatsu (1):
perf probe: Fix to show lines of sys_ functions correctly
tools/perf/Documentation/perf-record.txt | 4 ++
tools/perf/Documentation/perf-report.txt | 11 ++++++
tools/perf/builtin-annotate.c | 2 +
tools/perf/builtin-diff.c | 3 ++
tools/perf/builtin-report.c | 7 ++++
tools/perf/builtin-trace.c | 54 +++++++++++++++++++------
tools/perf/tests/hists_cumulate.c | 4 ++
tools/perf/tests/parse-events.c | 38 ++++++++++++++++++
tools/perf/ui/browser.c | 17 +++++++-
tools/perf/ui/browser.h | 3 ++
tools/perf/ui/browsers/annotate.c | 43 ++++++++++----------
tools/perf/ui/browsers/header.c | 2 +-
tools/perf/ui/browsers/hists.c | 54 ++++++++++++-------------
tools/perf/ui/browsers/map.c | 11 +++---
tools/perf/ui/browsers/scripts.c | 2 +-
tools/perf/ui/libslang.h | 3 ++
tools/perf/ui/tui/util.c | 2 +-
tools/perf/util/dwarf-aux.c | 18 ++++++---
tools/perf/util/evsel.c | 67 +++++++++++++++++++++++++++++++-
tools/perf/util/evsel.h | 4 ++
tools/perf/util/hist.c | 14 +++++--
tools/perf/util/parse-events.c | 12 ++++++
tools/perf/util/parse-events.h | 2 +
tools/perf/util/parse-events.l | 2 +
tools/perf/util/pmu.c | 4 +-
tools/perf/util/sort.c | 2 +
tools/perf/util/symbol.h | 3 +-
27 files changed, 307 insertions(+), 81 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2015-07-20 20:58 Arnaldo Carvalho de Melo
@ 2015-07-21 6:00 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2015-07-21 6:00 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Borislav Petkov,
Brendan Gregg, David Ahern, Davidlohr Bueso, Frederic Weisbecker,
Hemant Kumar, Jiri Olsa, Kan Liang, Masami Hiramatsu, Mel Gorman,
Milian Wolff, Namhyung Kim, Peter Zijlstra, pi3orama,
Sergei Trofimovich, Stephane Eranian, Steven Rostedt, Wang Nan,
Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 60cd37eb100c4880b28078a47f3062fac7572095:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-07-06 17:46:15 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to d2f3f5d2e9cae6e73f9642a5ddc8c8a07c35e79b:
>
> perf bench futex: Add lock_pi stresser (2015-07-20 17:49:51 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Allow filtering perf's pid via 'perf record --exclude-perf' (Wang Nan)
>
> - 'perf trace' now supports syscall groups, like strace, i.e:
>
> $ trace -e file touch file
>
> Will expand 'file' into multiple, file related, syscalls. More work needed to
> add extra groups for other syscall groups, and also to complement what was
> added for the 'file' group, included as a proof of concept. (Arnaldo Carvalho de Melo)
>
> - Add lock_pi stresser to 'perf bench futex', to test the kernel code
> related to FUTEX_(UN)LOCK_PI (Davidlohr Bueso)
>
> User visible fixes:
>
> - Apply --filter to all events in a glob matching, not just the last one (Wang Nan)
>
> Documentation:
>
> - Document setting '-e pmu/period=N/' in the 'perf record' man page (Kan Liang)
>
> Infrastructure:
>
> - 'perf probe' code simplifications and movements to separate files (Masami Hiramatsu)
>
> - Fix makefile generation under 'dash' (Sergei Trofimovich)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (5):
> perf strlist: load() should return a negative errno
> perf strlist: Make dupstr be the default and part of an extensible config parm
> perf strlist: Allow substitutions from file contents in a given directory
> perf strlist: Make parse_list() private
> perf trace: Support 'strace' syscall event groups
>
> Davidlohr Bueso (1):
> perf bench futex: Add lock_pi stresser
>
> Kan Liang (1):
> perf record: Document setting '-e pmu/period=N/' in man page
>
> Masami Hiramatsu (3):
> perf probe: Simplify __add_probe_trace_events code
> perf probe: Move ftrace probe-event operations to probe-file.c
> perf buildid: Use SBUILD_ID_SIZE macro
>
> Sergei Trofimovich (1):
> perf tools: Fix makefile generation under dash
>
> Wang Nan (2):
> perf record: Apply filter to all events in a glob matching
> perf record: Allow filtering perf's pid via --exclude-perf
>
> tools/perf/Build | 1 +
> tools/perf/Documentation/perf-bench.txt | 4 +
> tools/perf/Documentation/perf-record.txt | 19 +-
> tools/perf/Makefile.perf | 5 +
> tools/perf/bench/Build | 1 +
> tools/perf/bench/bench.h | 2 +
> tools/perf/bench/futex-lock-pi.c | 219 +++++++++++++++++
> tools/perf/bench/futex.h | 20 ++
> tools/perf/builtin-bench.c | 2 +
> tools/perf/builtin-buildid-cache.c | 16 +-
> tools/perf/builtin-buildid-list.c | 4 +-
> tools/perf/builtin-record.c | 3 +
> tools/perf/builtin-trace.c | 6 +-
> tools/perf/config/Makefile | 8 +-
> tools/perf/trace/strace/groups/file | 18 ++
> tools/perf/util/Build | 1 +
> tools/perf/util/build-id.c | 6 +-
> tools/perf/util/build-id.h | 3 +-
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/evsel.h | 1 +
> tools/perf/util/machine.c | 2 +-
> tools/perf/util/parse-events.c | 81 ++++++-
> tools/perf/util/parse-events.h | 1 +
> tools/perf/util/probe-event.c | 388 ++++++-------------------------
> tools/perf/util/probe-event.h | 7 +
> tools/perf/util/probe-file.c | 301 ++++++++++++++++++++++++
> tools/perf/util/probe-file.h | 18 ++
> tools/perf/util/probe-finder.c | 2 +-
> tools/perf/util/strlist.c | 43 +++-
> tools/perf/util/strlist.h | 9 +-
> tools/perf/util/symbol.c | 2 +-
> tools/perf/util/thread_map.c | 6 +-
> 32 files changed, 842 insertions(+), 358 deletions(-)
> create mode 100644 tools/perf/bench/futex-lock-pi.c
> create mode 100644 tools/perf/trace/strace/groups/file
> create mode 100644 tools/perf/util/probe-file.c
> create mode 100644 tools/perf/util/probe-file.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2015-07-20 20:58 Arnaldo Carvalho de Melo
2015-07-21 6:00 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-07-20 20:58 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, Brendan Gregg, David Ahern,
Davidlohr Bueso, Frederic Weisbecker, Hemant Kumar, Jiri Olsa,
Kan Liang, Masami Hiramatsu, Mel Gorman, Milian Wolff,
Namhyung Kim, Peter Zijlstra, pi3orama, Sergei Trofimovich,
Stephane Eranian, Steven Rostedt, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 60cd37eb100c4880b28078a47f3062fac7572095:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-07-06 17:46:15 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to d2f3f5d2e9cae6e73f9642a5ddc8c8a07c35e79b:
perf bench futex: Add lock_pi stresser (2015-07-20 17:49:51 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Allow filtering perf's pid via 'perf record --exclude-perf' (Wang Nan)
- 'perf trace' now supports syscall groups, like strace, i.e:
$ trace -e file touch file
Will expand 'file' into multiple, file related, syscalls. More work needed to
add extra groups for other syscall groups, and also to complement what was
added for the 'file' group, included as a proof of concept. (Arnaldo Carvalho de Melo)
- Add lock_pi stresser to 'perf bench futex', to test the kernel code
related to FUTEX_(UN)LOCK_PI (Davidlohr Bueso)
User visible fixes:
- Apply --filter to all events in a glob matching, not just the last one (Wang Nan)
Documentation:
- Document setting '-e pmu/period=N/' in the 'perf record' man page (Kan Liang)
Infrastructure:
- 'perf probe' code simplifications and movements to separate files (Masami Hiramatsu)
- Fix makefile generation under 'dash' (Sergei Trofimovich)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
perf strlist: load() should return a negative errno
perf strlist: Make dupstr be the default and part of an extensible config parm
perf strlist: Allow substitutions from file contents in a given directory
perf strlist: Make parse_list() private
perf trace: Support 'strace' syscall event groups
Davidlohr Bueso (1):
perf bench futex: Add lock_pi stresser
Kan Liang (1):
perf record: Document setting '-e pmu/period=N/' in man page
Masami Hiramatsu (3):
perf probe: Simplify __add_probe_trace_events code
perf probe: Move ftrace probe-event operations to probe-file.c
perf buildid: Use SBUILD_ID_SIZE macro
Sergei Trofimovich (1):
perf tools: Fix makefile generation under dash
Wang Nan (2):
perf record: Apply filter to all events in a glob matching
perf record: Allow filtering perf's pid via --exclude-perf
tools/perf/Build | 1 +
tools/perf/Documentation/perf-bench.txt | 4 +
tools/perf/Documentation/perf-record.txt | 19 +-
tools/perf/Makefile.perf | 5 +
tools/perf/bench/Build | 1 +
tools/perf/bench/bench.h | 2 +
tools/perf/bench/futex-lock-pi.c | 219 +++++++++++++++++
tools/perf/bench/futex.h | 20 ++
tools/perf/builtin-bench.c | 2 +
tools/perf/builtin-buildid-cache.c | 16 +-
tools/perf/builtin-buildid-list.c | 4 +-
tools/perf/builtin-record.c | 3 +
tools/perf/builtin-trace.c | 6 +-
tools/perf/config/Makefile | 8 +-
tools/perf/trace/strace/groups/file | 18 ++
tools/perf/util/Build | 1 +
tools/perf/util/build-id.c | 6 +-
tools/perf/util/build-id.h | 3 +-
tools/perf/util/evsel.c | 1 +
tools/perf/util/evsel.h | 1 +
tools/perf/util/machine.c | 2 +-
tools/perf/util/parse-events.c | 81 ++++++-
tools/perf/util/parse-events.h | 1 +
tools/perf/util/probe-event.c | 388 ++++++-------------------------
tools/perf/util/probe-event.h | 7 +
tools/perf/util/probe-file.c | 301 ++++++++++++++++++++++++
tools/perf/util/probe-file.h | 18 ++
tools/perf/util/probe-finder.c | 2 +-
tools/perf/util/strlist.c | 43 +++-
tools/perf/util/strlist.h | 9 +-
tools/perf/util/symbol.c | 2 +-
tools/perf/util/thread_map.c | 6 +-
32 files changed, 842 insertions(+), 358 deletions(-)
create mode 100644 tools/perf/bench/futex-lock-pi.c
create mode 100644 tools/perf/trace/strace/groups/file
create mode 100644 tools/perf/util/probe-file.c
create mode 100644 tools/perf/util/probe-file.h
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2015-06-25 7:31 ` Ingo Molnar
@ 2015-06-25 13:48 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-06-25 13:48 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Andi Kleen, David Ahern, He Kuang,
Jiri Olsa, linuxppc-dev, Lukas Wunner, Madhavan Srinivasan,
Masami Hiramatsu, Michael Ellerman, Namhyung Kim, Peter Zijlstra,
Stephane Eranian, Sukadev Bhattiprolu, Wang Nan
Em Thu, Jun 25, 2015 at 09:31:41AM +0200, Ingo Molnar escreveu:
> Pulled, thanks a lot Arnaldo!
>
> Btw., one small thing I noticed about the status line in perf top: if I ever use
> 'f' to freeze/unfreeze events, the following message:
>
> Press 'f' to disable the events or 'h' to see other hotkeys
>
> sticks around forever, even after I look into annotation and exit it, etc.
> So I don't mind some default, helpful message there (such as 'Press 'h' to see
> hotkeys'), but it appears this particular message is context and usage sensitive,
> which wasn't really the goal, right?
Agreed, some more work is needed to change that message in more places,
will do it eventually.
- Arnaldo
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2015-06-23 21:47 Arnaldo Carvalho de Melo
@ 2015-06-25 7:31 ` Ingo Molnar
2015-06-25 13:48 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 61+ messages in thread
From: Ingo Molnar @ 2015-06-25 7:31 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, David Ahern, He Kuang,
Jiri Olsa, linuxppc-dev, Lukas Wunner, Madhavan Srinivasan,
Masami Hiramatsu, Michael Ellerman, Namhyung Kim, Peter Zijlstra,
Stephane Eranian, Sukadev Bhattiprolu, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit a9a3cd900fbbcbf837d65653105e7bfc583ced09:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-06-20 01:11:11 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 83b2ea257eb1d43e52f76d756722aeb899a2852c:
>
> perf tools: Allow auxtrace data alignment (2015-06-23 18:28:37 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Move toggling event logic from 'perf top' and into hists browser, allowing
> freeze/unfreeze with event lists with more than one entry (Namhyung Kim)
>
> - Add missing newlines when dumping PERF_RECORD_FINISHED_ROUND and
> showing the Aggregated stats in 'perf report -D' (Adrian Hunter)
>
> Infrastructure:
>
> - Allow auxtrace data alignment (Adrian Hunter)
>
> - Allow events with dot (Andi Kleen)
>
> - Fix failure to 'perf probe' events on arm (He Kuang)
>
> - Add testing for Makefile.perf (Jiri Olsa)
>
> - Add test for make install with prefix (Jiri Olsa)
>
> - Fix single target build dependency check (Jiri Olsa)
>
> - Access thread_map entries via accessors, prep patch to hold more info per
> entry, for ongoing 'perf stat --per-thread' work (Jiri Olsa)
>
> - Use __weak definition from compiler.h (Sukadev Bhattiprolu)
>
> - Split perf_pmu__new_alias() (Sukadev Bhattiprolu)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (3):
> perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND
> perf tools: Print a newline before dumping Aggregated stats
> perf tools: Allow auxtrace data alignment
>
> Andi Kleen (1):
> perf tools: Allow events with dot
>
> He Kuang (1):
> perf probe: Fix failure to probe events on arm
>
> Jiri Olsa (5):
> perf tests: Add testing for Makefile.perf
> perf tests: Add test for make install with prefix
> perf build: Fix single target build dependency check
> perf thread_map: Don't access the array entries directly
> perf thread_map: Change map entries into a struct
>
> Namhyung Kim (1):
> perf top: Move toggling event logic into hists browser
>
> Sukadev Bhattiprolu (2):
> perf pmu: Use __weak definition from <linux/compiler.h>
> perf pmu: Split perf_pmu__new_alias()
>
> tools/perf/Makefile | 4 +--
> tools/perf/builtin-top.c | 24 ++-------------
> tools/perf/builtin-trace.c | 4 +--
> tools/perf/tests/make | 31 ++++++++++++++++++--
> tools/perf/tests/openat-syscall-tp-fields.c | 2 +-
> tools/perf/ui/browsers/hists.c | 19 ++++++++++--
> tools/perf/util/auxtrace.c | 11 +++++--
> tools/perf/util/auxtrace.h | 1 +
> tools/perf/util/event.c | 6 ++--
> tools/perf/util/evlist.c | 4 +--
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/parse-events.l | 5 ++--
> tools/perf/util/pmu.c | 45 +++++++++++++++++++----------
> tools/perf/util/probe-event.c | 6 +++-
> tools/perf/util/session.c | 4 ++-
> tools/perf/util/thread_map.c | 24 ++++++++-------
> tools/perf/util/thread_map.h | 16 +++++++++-
> 17 files changed, 136 insertions(+), 72 deletions(-)
Pulled, thanks a lot Arnaldo!
Btw., one small thing I noticed about the status line in perf top: if I ever use
'f' to freeze/unfreeze events, the following message:
Press 'f' to disable the events or 'h' to see other hotkeys
sticks around forever, even after I look into annotation and exit it, etc.
So I don't mind some default, helpful message there (such as 'Press 'h' to see
hotkeys'), but it appears this particular message is context and usage sensitive,
which wasn't really the goal, right?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2015-06-23 21:47 Arnaldo Carvalho de Melo
2015-06-25 7:31 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-06-23 21:47 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, David Ahern, He Kuang, Jiri Olsa, linuxppc-dev,
Lukas Wunner, Madhavan Srinivasan, Masami Hiramatsu,
Michael Ellerman, Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Sukadev Bhattiprolu, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit a9a3cd900fbbcbf837d65653105e7bfc583ced09:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-06-20 01:11:11 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 83b2ea257eb1d43e52f76d756722aeb899a2852c:
perf tools: Allow auxtrace data alignment (2015-06-23 18:28:37 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Move toggling event logic from 'perf top' and into hists browser, allowing
freeze/unfreeze with event lists with more than one entry (Namhyung Kim)
- Add missing newlines when dumping PERF_RECORD_FINISHED_ROUND and
showing the Aggregated stats in 'perf report -D' (Adrian Hunter)
Infrastructure:
- Allow auxtrace data alignment (Adrian Hunter)
- Allow events with dot (Andi Kleen)
- Fix failure to 'perf probe' events on arm (He Kuang)
- Add testing for Makefile.perf (Jiri Olsa)
- Add test for make install with prefix (Jiri Olsa)
- Fix single target build dependency check (Jiri Olsa)
- Access thread_map entries via accessors, prep patch to hold more info per
entry, for ongoing 'perf stat --per-thread' work (Jiri Olsa)
- Use __weak definition from compiler.h (Sukadev Bhattiprolu)
- Split perf_pmu__new_alias() (Sukadev Bhattiprolu)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (3):
perf session: Print a newline when dumping PERF_RECORD_FINISHED_ROUND
perf tools: Print a newline before dumping Aggregated stats
perf tools: Allow auxtrace data alignment
Andi Kleen (1):
perf tools: Allow events with dot
He Kuang (1):
perf probe: Fix failure to probe events on arm
Jiri Olsa (5):
perf tests: Add testing for Makefile.perf
perf tests: Add test for make install with prefix
perf build: Fix single target build dependency check
perf thread_map: Don't access the array entries directly
perf thread_map: Change map entries into a struct
Namhyung Kim (1):
perf top: Move toggling event logic into hists browser
Sukadev Bhattiprolu (2):
perf pmu: Use __weak definition from <linux/compiler.h>
perf pmu: Split perf_pmu__new_alias()
tools/perf/Makefile | 4 +--
tools/perf/builtin-top.c | 24 ++-------------
tools/perf/builtin-trace.c | 4 +--
tools/perf/tests/make | 31 ++++++++++++++++++--
tools/perf/tests/openat-syscall-tp-fields.c | 2 +-
tools/perf/ui/browsers/hists.c | 19 ++++++++++--
tools/perf/util/auxtrace.c | 11 +++++--
tools/perf/util/auxtrace.h | 1 +
tools/perf/util/event.c | 6 ++--
tools/perf/util/evlist.c | 4 +--
tools/perf/util/evsel.c | 2 +-
tools/perf/util/parse-events.l | 5 ++--
tools/perf/util/pmu.c | 45 +++++++++++++++++++----------
tools/perf/util/probe-event.c | 6 +++-
tools/perf/util/session.c | 4 ++-
tools/perf/util/thread_map.c | 24 ++++++++-------
tools/perf/util/thread_map.h | 16 +++++++++-
17 files changed, 136 insertions(+), 72 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 19:08 ` Arnaldo Carvalho de Melo
@ 2014-09-10 13:19 ` Adrian Hunter
0 siblings, 0 replies; 61+ messages in thread
From: Adrian Hunter @ 2014-09-10 13:19 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, linux-kernel, Alexander Shishkin, Alexander Yarygin,
Anton Blanchard, Christian Borntraeger, Corey Ashford,
David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa,
Kyle McMartin, Michael Ellerman, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Sukadev Bhattiprolu
On 09/09/2014 10:08 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Sep 09, 2014 at 11:48:20AM +0300, Adrian Hunter escreveu:
>> On 09/09/2014 12:17 AM, Arnaldo Carvalho de Melo wrote:
>>> Hi Ingo,
>>>
>>> Please consider pulling,
>>>
>>> - Arnaldo
>>
>> I am very sorry Arnaldo but 2 patches are older versions, namely:
>>
>> perf tools: Build programs to copy 32-bit compatibility VDSOs
>> perf tools: Add support for 32-bit compatibility VDSOs
>>
>> Up-to-date versions can be found from 15 August:
>>
>> patchwork:
>>
>> https://patchwork.kernel.org/patch/4729131/
>> https://patchwork.kernel.org/patch/4729111/
>
> Ok, those don't apply, as it expects other stuff, that you sent before,
> but were not processed yet, to be in place, I'm fixing it up.
>
Something like this might prevent Ingo's error message:
From: Adrian Hunter <adrian.hunter@intel.com>
Date: Wed, 10 Sep 2014 16:14:50 +0300
Subject: [PATCH] perf tools: Do not attempt to run perf-read-vdso32 if it
wasn't built
popen() causes an error message to print if perf-read-vdso32
does not run. Avoid that by not trying to run it if it was
not built. Ditto perf-read-vdsox32.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/config/Makefile | 8 ++++++--
tools/perf/util/vdso.c | 10 ++++++++++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 3ba2382..71264e4 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -627,7 +627,9 @@ endif
ifeq (${IS_64_BIT}, 1)
ifndef NO_PERF_READ_VDSO32
$(call feature_check,compile-32)
- ifneq ($(feature-compile-32), 1)
+ ifeq ($(feature-compile-32), 1)
+ CFLAGS += -DHAVE_PERF_READ_VDSO32
+ else
NO_PERF_READ_VDSO32 := 1
endif
endif
@@ -636,7 +638,9 @@ ifeq (${IS_64_BIT}, 1)
endif
ifndef NO_PERF_READ_VDSOX32
$(call feature_check,compile-x32)
- ifneq ($(feature-compile-x32), 1)
+ ifeq ($(feature-compile-x32), 1)
+ CFLAGS += -DHAVE_PERF_READ_VDSOX32
+ else
NO_PERF_READ_VDSOX32 := 1
endif
endif
diff --git a/tools/perf/util/vdso.c b/tools/perf/util/vdso.c
index 69daef6..5c7dd79 100644
--- a/tools/perf/util/vdso.c
+++ b/tools/perf/util/vdso.c
@@ -255,6 +255,16 @@ static int vdso__dso_findnew_compat(struct machine
*machine,
enum dso_type dso_type;
dso_type = machine__thread_dso_type(machine, thread);
+
+#ifndef HAVE_PERF_READ_VDSO32
+ if (dso_type == DSO__TYPE_32BIT)
+ return 0;
+#endif
+#ifndef HAVE_PERF_READ_VDSOX32
+ if (dso_type == DSO__TYPE_X32BIT)
+ return 0;
+#endif
+
switch (dso_type) {
case DSO__TYPE_32BIT:
*dso = vdso__findnew_compat(machine, &vdso_info->vdso32);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 8:48 ` Adrian Hunter
2014-09-09 13:12 ` Arnaldo Carvalho de Melo
@ 2014-09-09 19:08 ` Arnaldo Carvalho de Melo
2014-09-10 13:19 ` Adrian Hunter
1 sibling, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-09-09 19:08 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ingo Molnar, linux-kernel, Alexander Shishkin, Alexander Yarygin,
Anton Blanchard, Christian Borntraeger, Corey Ashford,
David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa,
Kyle McMartin, Michael Ellerman, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Sukadev Bhattiprolu
Em Tue, Sep 09, 2014 at 11:48:20AM +0300, Adrian Hunter escreveu:
> On 09/09/2014 12:17 AM, Arnaldo Carvalho de Melo wrote:
> > Hi Ingo,
> >
> > Please consider pulling,
> >
> > - Arnaldo
>
> I am very sorry Arnaldo but 2 patches are older versions, namely:
>
> perf tools: Build programs to copy 32-bit compatibility VDSOs
> perf tools: Add support for 32-bit compatibility VDSOs
>
> Up-to-date versions can be found from 15 August:
>
> patchwork:
>
> https://patchwork.kernel.org/patch/4729131/
> https://patchwork.kernel.org/patch/4729111/
Ok, those don't apply, as it expects other stuff, that you sent before,
but were not processed yet, to be in place, I'm fixing it up.
- Arnaldo
> marc.info:
>
> http://marc.info/?l=linux-kernel&m=140812995414607&w=4
> http://marc.info/?l=linux-kernel&m=140812993814585&w=4
>
> It looks like I reposted older versions by mistake on 31 July.
> Very sorry :-(
>
> The originals were changed as described here:
>
> http://marc.info/?l=linux-kernel&m=140621020918615
> http://marc.info/?l=linux-kernel&m=140618721010170
>
> >
> > The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
> >
> > Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
> >
> > are available in the git repository at:
> >
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> >
> > for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
> >
> > perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
> >
> > ----------------------------------------------------------------
> > perf/core improvements and fixes:
> >
> > User visible:
> >
> > o Add +field argument support for --sort option (Jiri Olsa)
> >
> > Infrastructure:
> >
> > o More intel PT prep work, from Adrian Hunter, including:
> >
> > - Let a user specify a PMU event without any config terms
> > - Add perf-with-kcore script
> > - Build programs to copy 32-bit compatibility VDSOs
> > - Add support for 32-bit compatibility VDSOs
> > - Let default config be defined for a PMU
> > - Add perf_pmu__scan_file()
> >
> > o Add feature checks to .gitignore (Alexander Shishkin)
> >
> > o "perf kvm stat report" improvements by Alexander Yarygin:
> > o Save pid string in opts.target.pid
> > o Enable the target.system_wide flag
> > o Unify the title bar output
> >
> > o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
> >
> > o Allow to specify lib compile variable for spec usage (Jiri Olsa)
> >
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > ----------------------------------------------------------------
> > Adrian Hunter (6):
> > perf tools: Let a user specify a PMU event without any config terms
> > perf tools: Add perf-with-kcore script
> > perf tools: Build programs to copy 32-bit compatibility VDSOs
> > perf tools: Add support for 32-bit compatibility VDSOs
> > perf tools: Let default config be defined for a PMU
> > perf tools: Add perf_pmu__scan_file()
> >
> > Alexander Shishkin (1):
> > perf tools: Add feature checks to .gitignore
> >
> > Alexander Yarygin (3):
> > perf kvm stat report: Save pid string in opts.target.pid
> > perf kvm stat report: Enable the target.system_wide flag
> > perf kvm stat report: Unify the title bar output
> >
> > Anton Blanchard (1):
> > perf tools powerpc: Fix build issue when DWARF support is disabled
> >
> > Jiri Olsa (2):
> > perf tools: Add +field argument support for --sort option
> > perf tools: Allow to specify lib compile variable for spec usage
> >
> > tools/perf/.gitignore | 2 +
> > tools/perf/Makefile.perf | 42 ++++++-
> > tools/perf/arch/powerpc/Makefile | 2 +-
> > tools/perf/builtin-kvm.c | 23 ++--
> > tools/perf/config/Makefile | 33 ++++-
> > tools/perf/config/Makefile.arch | 8 ++
> > tools/perf/perf-read-vdso.c | 59 +++++++++
> > tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
> > tools/perf/tests/pmu.c | 2 +-
> > tools/perf/util/kvm-stat.h | 1 -
> > tools/perf/util/parse-events.c | 13 +-
> > tools/perf/util/parse-events.y | 10 ++
> > tools/perf/util/pmu.c | 79 +++++++++---
> > tools/perf/util/pmu.h | 12 +-
> > tools/perf/util/sort.c | 37 +++++-
> > tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
> > tools/perf/util/vdso.h | 4 +-
> > 17 files changed, 712 insertions(+), 44 deletions(-)
> > create mode 100644 tools/perf/perf-read-vdso.c
> > create mode 100644 tools/perf/perf-with-kcore.sh
> >
> >
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 14:54 ` Ingo Molnar
@ 2014-09-09 15:59 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-09-09 15:59 UTC (permalink / raw)
To: Ingo Molnar
Cc: Adrian Hunter, linux-kernel, Alexander Shishkin,
Alexander Yarygin, Anton Blanchard, Christian Borntraeger,
Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet,
Jiri Olsa, Kyle McMartin, Michael Ellerman, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Sukadev Bhattiprolu
Em Tue, Sep 09, 2014 at 04:54:49PM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Tue, Sep 09, 2014 at 11:48:20AM +0300, Adrian Hunter escreveu:
> > > It looks like I reposted older versions by mistake on 31 July.
> > > Very sorry :-(
> > > The originals were changed as described here:
> > > http://marc.info/?l=linux-kernel&m=140621020918615
> > > http://marc.info/?l=linux-kernel&m=140618721010170
> > No problem, the good thing is that we're almost getting it all
> > in. I'll rework the branch and resubmit, Ingo, is that OK with
> > you? [...]
> Yeah, that's perfectly OK.
> > [...] Or have you already pulled and we should instead send a
> > patch on top, fixing the problem?
> I pulled it locally then unpulled as it didn't pass my (very
> simple) tests and it looked like there's something fishy going
> on.
Yeah, I should've tested this more, will make sure I test these things
this time.
Having a requirement that for each new feature we need an entry in 'perf
test' and/or in make -C tools/perf build-test seems a bit harsh, but
would be ideal, hook that to 'git request-pull' and this would hopefully
only happen every celestial aligment nights or so :-\
- Arnaldo
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 13:12 ` Arnaldo Carvalho de Melo
@ 2014-09-09 14:54 ` Ingo Molnar
2014-09-09 15:59 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 61+ messages in thread
From: Ingo Molnar @ 2014-09-09 14:54 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Adrian Hunter, linux-kernel, Alexander Shishkin,
Alexander Yarygin, Anton Blanchard, Christian Borntraeger,
Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet,
Jiri Olsa, Kyle McMartin, Michael Ellerman, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Sukadev Bhattiprolu
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Tue, Sep 09, 2014 at 11:48:20AM +0300, Adrian Hunter escreveu:
> > It looks like I reposted older versions by mistake on 31 July.
> > Very sorry :-(
> >
> > The originals were changed as described here:
> >
> > http://marc.info/?l=linux-kernel&m=140621020918615
> > http://marc.info/?l=linux-kernel&m=140618721010170
>
> No problem, the good thing is that we're almost getting it all
> in. I'll rework the branch and resubmit, Ingo, is that OK with
> you? [...]
Yeah, that's perfectly OK.
> [...] Or have you already pulled and we should instead send a
> patch on top, fixing the problem?
I pulled it locally then unpulled as it didn't pass my (very
simple) tests and it looked like there's something fishy going
on.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 7:14 ` Adrian Hunter
2014-09-09 7:45 ` Stephane Eranian
@ 2014-09-09 14:53 ` Ingo Molnar
1 sibling, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2014-09-09 14:53 UTC (permalink / raw)
To: Adrian Hunter
Cc: Arnaldo Carvalho de Melo, linux-kernel, Alexander Shishkin,
Alexander Yarygin, Anton Blanchard, Christian Borntraeger,
Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet,
Jiri Olsa, Kyle McMartin, Michael Ellerman, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Sukadev Bhattiprolu, Arnaldo Carvalho de Melo
* Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 09/09/2014 07:59 AM, Ingo Molnar wrote:
> >
> > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> >> Hi Ingo,
> >>
> >> Please consider pulling,
> >>
> >> - Arnaldo
> >>
> >> The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
> >>
> >> Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
> >>
> >> are available in the git repository at:
> >>
> >>
> >> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> >>
> >> for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
> >>
> >> perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
> >>
> >> ----------------------------------------------------------------
> >> perf/core improvements and fixes:
> >>
> >> User visible:
> >>
> >> o Add +field argument support for --sort option (Jiri Olsa)
> >>
> >> Infrastructure:
> >>
> >> o More intel PT prep work, from Adrian Hunter, including:
> >>
> >> - Let a user specify a PMU event without any config terms
> >> - Add perf-with-kcore script
> >> - Build programs to copy 32-bit compatibility VDSOs
> >> - Add support for 32-bit compatibility VDSOs
> >> - Let default config be defined for a PMU
> >> - Add perf_pmu__scan_file()
> >>
> >> o Add feature checks to .gitignore (Alexander Shishkin)
> >>
> >> o "perf kvm stat report" improvements by Alexander Yarygin:
> >> o Save pid string in opts.target.pid
> >> o Enable the target.system_wide flag
> >> o Unify the title bar output
> >>
> >> o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
> >>
> >> o Allow to specify lib compile variable for spec usage (Jiri Olsa)
> >>
> >> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>
> >> ----------------------------------------------------------------
> >> Adrian Hunter (6):
> >> perf tools: Let a user specify a PMU event without any config terms
> >> perf tools: Add perf-with-kcore script
> >> perf tools: Build programs to copy 32-bit compatibility VDSOs
> >> perf tools: Add support for 32-bit compatibility VDSOs
> >> perf tools: Let default config be defined for a PMU
> >> perf tools: Add perf_pmu__scan_file()
> >>
> >> Alexander Shishkin (1):
> >> perf tools: Add feature checks to .gitignore
> >>
> >> Alexander Yarygin (3):
> >> perf kvm stat report: Save pid string in opts.target.pid
> >> perf kvm stat report: Enable the target.system_wide flag
> >> perf kvm stat report: Unify the title bar output
> >>
> >> Anton Blanchard (1):
> >> perf tools powerpc: Fix build issue when DWARF support is disabled
> >>
> >> Jiri Olsa (2):
> >> perf tools: Add +field argument support for --sort option
> >> perf tools: Allow to specify lib compile variable for spec usage
> >>
> >> tools/perf/.gitignore | 2 +
> >> tools/perf/Makefile.perf | 42 ++++++-
> >> tools/perf/arch/powerpc/Makefile | 2 +-
> >> tools/perf/builtin-kvm.c | 23 ++--
> >> tools/perf/config/Makefile | 33 ++++-
> >> tools/perf/config/Makefile.arch | 8 ++
> >> tools/perf/perf-read-vdso.c | 59 +++++++++
> >> tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
> >> tools/perf/tests/pmu.c | 2 +-
> >> tools/perf/util/kvm-stat.h | 1 -
> >> tools/perf/util/parse-events.c | 13 +-
> >> tools/perf/util/parse-events.y | 10 ++
> >> tools/perf/util/pmu.c | 79 +++++++++---
> >> tools/perf/util/pmu.h | 12 +-
> >> tools/perf/util/sort.c | 37 +++++-
> >> tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
> >> tools/perf/util/vdso.h | 4 +-
> >> 17 files changed, 712 insertions(+), 44 deletions(-)
> >> create mode 100644 tools/perf/perf-read-vdso.c
> >> create mode 100644 tools/perf/perf-with-kcore.sh
> >
> > Hm, so I'm getting this error, when trying to profile a 32-bit
> > ELF binary on a 64-bit kernel, on a testbox:
> >
> > $ perf record ~/hackbench 10
> > Time: 0.115
> > [ perf record: Woken up 1 times to write data ]
> > [ perf record: Captured and wrote 0.373 MB perf.data (~16279 samples) ]
> > sh: perf-read-vdso32: command not found
>
> Presumably perf-read-vdso32 is not in the PATH. Did you 'make install'?
I did 'make install' as usual - that's the only thing that I type
to install a new version of perf tooling.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 8:48 ` Adrian Hunter
@ 2014-09-09 13:12 ` Arnaldo Carvalho de Melo
2014-09-09 14:54 ` Ingo Molnar
2014-09-09 19:08 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-09-09 13:12 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ingo Molnar, linux-kernel, Alexander Shishkin, Alexander Yarygin,
Anton Blanchard, Christian Borntraeger, Corey Ashford,
David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa,
Kyle McMartin, Michael Ellerman, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Sukadev Bhattiprolu
Em Tue, Sep 09, 2014 at 11:48:20AM +0300, Adrian Hunter escreveu:
> It looks like I reposted older versions by mistake on 31 July.
> Very sorry :-(
>
> The originals were changed as described here:
>
> http://marc.info/?l=linux-kernel&m=140621020918615
> http://marc.info/?l=linux-kernel&m=140618721010170
No problem, the good thing is that we're almost getting it all in. I'll
rework the branch and resubmit, Ingo, is that OK with you? Or have you
already pulled and we should instead send a patch on top, fixing the
problem?
- Arnaldo
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-08 21:17 Arnaldo Carvalho de Melo
2014-09-09 4:59 ` Ingo Molnar
@ 2014-09-09 8:48 ` Adrian Hunter
2014-09-09 13:12 ` Arnaldo Carvalho de Melo
2014-09-09 19:08 ` Arnaldo Carvalho de Melo
1 sibling, 2 replies; 61+ messages in thread
From: Adrian Hunter @ 2014-09-09 8:48 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Arnaldo Carvalho de Melo
Cc: Ingo Molnar, linux-kernel, Alexander Shishkin, Alexander Yarygin,
Anton Blanchard, Christian Borntraeger, Corey Ashford,
David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa,
Kyle McMartin, Michael Ellerman, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Sukadev Bhattiprolu
On 09/09/2014 12:17 AM, Arnaldo Carvalho de Melo wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
I am very sorry Arnaldo but 2 patches are older versions, namely:
perf tools: Build programs to copy 32-bit compatibility VDSOs
perf tools: Add support for 32-bit compatibility VDSOs
Up-to-date versions can be found from 15 August:
patchwork:
https://patchwork.kernel.org/patch/4729131/
https://patchwork.kernel.org/patch/4729111/
marc.info:
http://marc.info/?l=linux-kernel&m=140812995414607&w=4
http://marc.info/?l=linux-kernel&m=140812993814585&w=4
It looks like I reposted older versions by mistake on 31 July.
Very sorry :-(
The originals were changed as described here:
http://marc.info/?l=linux-kernel&m=140621020918615
http://marc.info/?l=linux-kernel&m=140618721010170
>
> The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
>
> Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
>
> perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> o Add +field argument support for --sort option (Jiri Olsa)
>
> Infrastructure:
>
> o More intel PT prep work, from Adrian Hunter, including:
>
> - Let a user specify a PMU event without any config terms
> - Add perf-with-kcore script
> - Build programs to copy 32-bit compatibility VDSOs
> - Add support for 32-bit compatibility VDSOs
> - Let default config be defined for a PMU
> - Add perf_pmu__scan_file()
>
> o Add feature checks to .gitignore (Alexander Shishkin)
>
> o "perf kvm stat report" improvements by Alexander Yarygin:
> o Save pid string in opts.target.pid
> o Enable the target.system_wide flag
> o Unify the title bar output
>
> o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
>
> o Allow to specify lib compile variable for spec usage (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (6):
> perf tools: Let a user specify a PMU event without any config terms
> perf tools: Add perf-with-kcore script
> perf tools: Build programs to copy 32-bit compatibility VDSOs
> perf tools: Add support for 32-bit compatibility VDSOs
> perf tools: Let default config be defined for a PMU
> perf tools: Add perf_pmu__scan_file()
>
> Alexander Shishkin (1):
> perf tools: Add feature checks to .gitignore
>
> Alexander Yarygin (3):
> perf kvm stat report: Save pid string in opts.target.pid
> perf kvm stat report: Enable the target.system_wide flag
> perf kvm stat report: Unify the title bar output
>
> Anton Blanchard (1):
> perf tools powerpc: Fix build issue when DWARF support is disabled
>
> Jiri Olsa (2):
> perf tools: Add +field argument support for --sort option
> perf tools: Allow to specify lib compile variable for spec usage
>
> tools/perf/.gitignore | 2 +
> tools/perf/Makefile.perf | 42 ++++++-
> tools/perf/arch/powerpc/Makefile | 2 +-
> tools/perf/builtin-kvm.c | 23 ++--
> tools/perf/config/Makefile | 33 ++++-
> tools/perf/config/Makefile.arch | 8 ++
> tools/perf/perf-read-vdso.c | 59 +++++++++
> tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
> tools/perf/tests/pmu.c | 2 +-
> tools/perf/util/kvm-stat.h | 1 -
> tools/perf/util/parse-events.c | 13 +-
> tools/perf/util/parse-events.y | 10 ++
> tools/perf/util/pmu.c | 79 +++++++++---
> tools/perf/util/pmu.h | 12 +-
> tools/perf/util/sort.c | 37 +++++-
> tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
> tools/perf/util/vdso.h | 4 +-
> 17 files changed, 712 insertions(+), 44 deletions(-)
> create mode 100644 tools/perf/perf-read-vdso.c
> create mode 100644 tools/perf/perf-with-kcore.sh
>
>
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 7:45 ` Stephane Eranian
@ 2014-09-09 7:55 ` Adrian Hunter
0 siblings, 0 replies; 61+ messages in thread
From: Adrian Hunter @ 2014-09-09 7:55 UTC (permalink / raw)
To: Stephane Eranian
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, LKML, Alexander Shishkin,
Alexander Yarygin, Anton Blanchard, Christian Borntraeger,
Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet,
Jiri Olsa, Kyle McMartin, Michael Ellerman, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Sukadev Bhattiprolu,
Arnaldo Carvalho de Melo
On 09/09/2014 10:45 AM, Stephane Eranian wrote:
> On Tue, Sep 9, 2014 at 9:14 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> On 09/09/2014 07:59 AM, Ingo Molnar wrote:
>>>
>>> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>>>
>>>> Hi Ingo,
>>>>
>>>> Please consider pulling,
>>>>
>>>> - Arnaldo
>>>>
>>>> The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
>>>>
>>>> Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>>>>
>>>> for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
>>>>
>>>> perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
>>>>
>>>> ----------------------------------------------------------------
>>>> perf/core improvements and fixes:
>>>>
>>>> User visible:
>>>>
>>>> o Add +field argument support for --sort option (Jiri Olsa)
>>>>
>>>> Infrastructure:
>>>>
>>>> o More intel PT prep work, from Adrian Hunter, including:
>>>>
>>>> - Let a user specify a PMU event without any config terms
>>>> - Add perf-with-kcore script
>>>> - Build programs to copy 32-bit compatibility VDSOs
>>>> - Add support for 32-bit compatibility VDSOs
>>>> - Let default config be defined for a PMU
>>>> - Add perf_pmu__scan_file()
>>>>
>>>> o Add feature checks to .gitignore (Alexander Shishkin)
>>>>
>>>> o "perf kvm stat report" improvements by Alexander Yarygin:
>>>> o Save pid string in opts.target.pid
>>>> o Enable the target.system_wide flag
>>>> o Unify the title bar output
>>>>
>>>> o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
>>>>
>>>> o Allow to specify lib compile variable for spec usage (Jiri Olsa)
>>>>
>>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>>>
>>>> ----------------------------------------------------------------
>>>> Adrian Hunter (6):
>>>> perf tools: Let a user specify a PMU event without any config terms
>>>> perf tools: Add perf-with-kcore script
>>>> perf tools: Build programs to copy 32-bit compatibility VDSOs
>>>> perf tools: Add support for 32-bit compatibility VDSOs
>>>> perf tools: Let default config be defined for a PMU
>>>> perf tools: Add perf_pmu__scan_file()
>>>>
>>>> Alexander Shishkin (1):
>>>> perf tools: Add feature checks to .gitignore
>>>>
>>>> Alexander Yarygin (3):
>>>> perf kvm stat report: Save pid string in opts.target.pid
>>>> perf kvm stat report: Enable the target.system_wide flag
>>>> perf kvm stat report: Unify the title bar output
>>>>
>>>> Anton Blanchard (1):
>>>> perf tools powerpc: Fix build issue when DWARF support is disabled
>>>>
>>>> Jiri Olsa (2):
>>>> perf tools: Add +field argument support for --sort option
>>>> perf tools: Allow to specify lib compile variable for spec usage
>>>>
>>>> tools/perf/.gitignore | 2 +
>>>> tools/perf/Makefile.perf | 42 ++++++-
>>>> tools/perf/arch/powerpc/Makefile | 2 +-
>>>> tools/perf/builtin-kvm.c | 23 ++--
>>>> tools/perf/config/Makefile | 33 ++++-
>>>> tools/perf/config/Makefile.arch | 8 ++
>>>> tools/perf/perf-read-vdso.c | 59 +++++++++
>>>> tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
>>>> tools/perf/tests/pmu.c | 2 +-
>>>> tools/perf/util/kvm-stat.h | 1 -
>>>> tools/perf/util/parse-events.c | 13 +-
>>>> tools/perf/util/parse-events.y | 10 ++
>>>> tools/perf/util/pmu.c | 79 +++++++++---
>>>> tools/perf/util/pmu.h | 12 +-
>>>> tools/perf/util/sort.c | 37 +++++-
>>>> tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
>>>> tools/perf/util/vdso.h | 4 +-
>>>> 17 files changed, 712 insertions(+), 44 deletions(-)
>>>> create mode 100644 tools/perf/perf-read-vdso.c
>>>> create mode 100644 tools/perf/perf-with-kcore.sh
>>>
>>> Hm, so I'm getting this error, when trying to profile a 32-bit
>>> ELF binary on a 64-bit kernel, on a testbox:
>>>
>>> $ perf record ~/hackbench 10
>>> Time: 0.115
>>> [ perf record: Woken up 1 times to write data ]
>>> [ perf record: Captured and wrote 0.373 MB perf.data (~16279 samples) ]
>>> sh: perf-read-vdso32: command not found
>>
>> Presumably perf-read-vdso32 is not in the PATH. Did you 'make install'?
>>
> Why are we relying on an external command now in perf record?
We are not relying on it in the sense the 'record' works without it.
There is more explanation in "perf tools: Build programs to copy 32-bit
compatibility VDSOs" and "perf tools: Add support for 32-bit compatibility
VDSOs" (although those are the wrong versions of those patches - I will send
another email about that in a moment).
>
>>>
>>> comet:~/tip> file ~/hackbench
>>> /home/mingo/hackbench: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.2.5, not stripped
>>>
>>> 64-bit executables work fine:
>>>
>>> $ perf record perf bench sched pipe
>>> # Running 'sched/pipe' benchmark:
>>> # Executed 1000000 pipe operations between two processes
>>>
>>> Total time: 13.374 [sec]
>>>
>>> 13.374352 usecs/op
>>> 74769 ops/sec
>>> [ perf record: Woken up 14 times to write data ]
>>> [ perf record: Captured and wrote 3.602 MB perf.data (~157354 samples) ]
>>>
>>> The kernel is an older one:
>>>
>>> $ uname -a
>>> Linux comet 3.14.17-100.fc19.x86_64 #1 SMP Thu Aug 14 17:17:26
>>> UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
>>>
>>> Thanks,
>>>
>>> Ingo
>>>
>>>
>>
>
>
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 7:14 ` Adrian Hunter
@ 2014-09-09 7:45 ` Stephane Eranian
2014-09-09 7:55 ` Adrian Hunter
2014-09-09 14:53 ` Ingo Molnar
1 sibling, 1 reply; 61+ messages in thread
From: Stephane Eranian @ 2014-09-09 7:45 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, LKML, Alexander Shishkin,
Alexander Yarygin, Anton Blanchard, Christian Borntraeger,
Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet,
Jiri Olsa, Kyle McMartin, Michael Ellerman, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Sukadev Bhattiprolu,
Arnaldo Carvalho de Melo
On Tue, Sep 9, 2014 at 9:14 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 09/09/2014 07:59 AM, Ingo Molnar wrote:
>>
>> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>>
>>> Hi Ingo,
>>>
>>> Please consider pulling,
>>>
>>> - Arnaldo
>>>
>>> The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
>>>
>>> Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
>>>
>>> are available in the git repository at:
>>>
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>>>
>>> for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
>>>
>>> perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
>>>
>>> ----------------------------------------------------------------
>>> perf/core improvements and fixes:
>>>
>>> User visible:
>>>
>>> o Add +field argument support for --sort option (Jiri Olsa)
>>>
>>> Infrastructure:
>>>
>>> o More intel PT prep work, from Adrian Hunter, including:
>>>
>>> - Let a user specify a PMU event without any config terms
>>> - Add perf-with-kcore script
>>> - Build programs to copy 32-bit compatibility VDSOs
>>> - Add support for 32-bit compatibility VDSOs
>>> - Let default config be defined for a PMU
>>> - Add perf_pmu__scan_file()
>>>
>>> o Add feature checks to .gitignore (Alexander Shishkin)
>>>
>>> o "perf kvm stat report" improvements by Alexander Yarygin:
>>> o Save pid string in opts.target.pid
>>> o Enable the target.system_wide flag
>>> o Unify the title bar output
>>>
>>> o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
>>>
>>> o Allow to specify lib compile variable for spec usage (Jiri Olsa)
>>>
>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>>
>>> ----------------------------------------------------------------
>>> Adrian Hunter (6):
>>> perf tools: Let a user specify a PMU event without any config terms
>>> perf tools: Add perf-with-kcore script
>>> perf tools: Build programs to copy 32-bit compatibility VDSOs
>>> perf tools: Add support for 32-bit compatibility VDSOs
>>> perf tools: Let default config be defined for a PMU
>>> perf tools: Add perf_pmu__scan_file()
>>>
>>> Alexander Shishkin (1):
>>> perf tools: Add feature checks to .gitignore
>>>
>>> Alexander Yarygin (3):
>>> perf kvm stat report: Save pid string in opts.target.pid
>>> perf kvm stat report: Enable the target.system_wide flag
>>> perf kvm stat report: Unify the title bar output
>>>
>>> Anton Blanchard (1):
>>> perf tools powerpc: Fix build issue when DWARF support is disabled
>>>
>>> Jiri Olsa (2):
>>> perf tools: Add +field argument support for --sort option
>>> perf tools: Allow to specify lib compile variable for spec usage
>>>
>>> tools/perf/.gitignore | 2 +
>>> tools/perf/Makefile.perf | 42 ++++++-
>>> tools/perf/arch/powerpc/Makefile | 2 +-
>>> tools/perf/builtin-kvm.c | 23 ++--
>>> tools/perf/config/Makefile | 33 ++++-
>>> tools/perf/config/Makefile.arch | 8 ++
>>> tools/perf/perf-read-vdso.c | 59 +++++++++
>>> tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
>>> tools/perf/tests/pmu.c | 2 +-
>>> tools/perf/util/kvm-stat.h | 1 -
>>> tools/perf/util/parse-events.c | 13 +-
>>> tools/perf/util/parse-events.y | 10 ++
>>> tools/perf/util/pmu.c | 79 +++++++++---
>>> tools/perf/util/pmu.h | 12 +-
>>> tools/perf/util/sort.c | 37 +++++-
>>> tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
>>> tools/perf/util/vdso.h | 4 +-
>>> 17 files changed, 712 insertions(+), 44 deletions(-)
>>> create mode 100644 tools/perf/perf-read-vdso.c
>>> create mode 100644 tools/perf/perf-with-kcore.sh
>>
>> Hm, so I'm getting this error, when trying to profile a 32-bit
>> ELF binary on a 64-bit kernel, on a testbox:
>>
>> $ perf record ~/hackbench 10
>> Time: 0.115
>> [ perf record: Woken up 1 times to write data ]
>> [ perf record: Captured and wrote 0.373 MB perf.data (~16279 samples) ]
>> sh: perf-read-vdso32: command not found
>
> Presumably perf-read-vdso32 is not in the PATH. Did you 'make install'?
>
Why are we relying on an external command now in perf record?
>>
>> comet:~/tip> file ~/hackbench
>> /home/mingo/hackbench: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.2.5, not stripped
>>
>> 64-bit executables work fine:
>>
>> $ perf record perf bench sched pipe
>> # Running 'sched/pipe' benchmark:
>> # Executed 1000000 pipe operations between two processes
>>
>> Total time: 13.374 [sec]
>>
>> 13.374352 usecs/op
>> 74769 ops/sec
>> [ perf record: Woken up 14 times to write data ]
>> [ perf record: Captured and wrote 3.602 MB perf.data (~157354 samples) ]
>>
>> The kernel is an older one:
>>
>> $ uname -a
>> Linux comet 3.14.17-100.fc19.x86_64 #1 SMP Thu Aug 14 17:17:26
>> UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
>>
>> Thanks,
>>
>> Ingo
>>
>>
>
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-09 4:59 ` Ingo Molnar
@ 2014-09-09 7:14 ` Adrian Hunter
2014-09-09 7:45 ` Stephane Eranian
2014-09-09 14:53 ` Ingo Molnar
0 siblings, 2 replies; 61+ messages in thread
From: Adrian Hunter @ 2014-09-09 7:14 UTC (permalink / raw)
To: Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-kernel, Alexander Shishkin, Alexander Yarygin,
Anton Blanchard, Christian Borntraeger, Corey Ashford,
David Ahern, Frederic Weisbecker, Jean Pihet, Jiri Olsa,
Kyle McMartin, Michael Ellerman, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Sukadev Bhattiprolu,
Arnaldo Carvalho de Melo
On 09/09/2014 07:59 AM, Ingo Molnar wrote:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
>> Hi Ingo,
>>
>> Please consider pulling,
>>
>> - Arnaldo
>>
>> The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
>>
>> Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
>>
>> are available in the git repository at:
>>
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>>
>> for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
>>
>> perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
>>
>> ----------------------------------------------------------------
>> perf/core improvements and fixes:
>>
>> User visible:
>>
>> o Add +field argument support for --sort option (Jiri Olsa)
>>
>> Infrastructure:
>>
>> o More intel PT prep work, from Adrian Hunter, including:
>>
>> - Let a user specify a PMU event without any config terms
>> - Add perf-with-kcore script
>> - Build programs to copy 32-bit compatibility VDSOs
>> - Add support for 32-bit compatibility VDSOs
>> - Let default config be defined for a PMU
>> - Add perf_pmu__scan_file()
>>
>> o Add feature checks to .gitignore (Alexander Shishkin)
>>
>> o "perf kvm stat report" improvements by Alexander Yarygin:
>> o Save pid string in opts.target.pid
>> o Enable the target.system_wide flag
>> o Unify the title bar output
>>
>> o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
>>
>> o Allow to specify lib compile variable for spec usage (Jiri Olsa)
>>
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>
>> ----------------------------------------------------------------
>> Adrian Hunter (6):
>> perf tools: Let a user specify a PMU event without any config terms
>> perf tools: Add perf-with-kcore script
>> perf tools: Build programs to copy 32-bit compatibility VDSOs
>> perf tools: Add support for 32-bit compatibility VDSOs
>> perf tools: Let default config be defined for a PMU
>> perf tools: Add perf_pmu__scan_file()
>>
>> Alexander Shishkin (1):
>> perf tools: Add feature checks to .gitignore
>>
>> Alexander Yarygin (3):
>> perf kvm stat report: Save pid string in opts.target.pid
>> perf kvm stat report: Enable the target.system_wide flag
>> perf kvm stat report: Unify the title bar output
>>
>> Anton Blanchard (1):
>> perf tools powerpc: Fix build issue when DWARF support is disabled
>>
>> Jiri Olsa (2):
>> perf tools: Add +field argument support for --sort option
>> perf tools: Allow to specify lib compile variable for spec usage
>>
>> tools/perf/.gitignore | 2 +
>> tools/perf/Makefile.perf | 42 ++++++-
>> tools/perf/arch/powerpc/Makefile | 2 +-
>> tools/perf/builtin-kvm.c | 23 ++--
>> tools/perf/config/Makefile | 33 ++++-
>> tools/perf/config/Makefile.arch | 8 ++
>> tools/perf/perf-read-vdso.c | 59 +++++++++
>> tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
>> tools/perf/tests/pmu.c | 2 +-
>> tools/perf/util/kvm-stat.h | 1 -
>> tools/perf/util/parse-events.c | 13 +-
>> tools/perf/util/parse-events.y | 10 ++
>> tools/perf/util/pmu.c | 79 +++++++++---
>> tools/perf/util/pmu.h | 12 +-
>> tools/perf/util/sort.c | 37 +++++-
>> tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
>> tools/perf/util/vdso.h | 4 +-
>> 17 files changed, 712 insertions(+), 44 deletions(-)
>> create mode 100644 tools/perf/perf-read-vdso.c
>> create mode 100644 tools/perf/perf-with-kcore.sh
>
> Hm, so I'm getting this error, when trying to profile a 32-bit
> ELF binary on a 64-bit kernel, on a testbox:
>
> $ perf record ~/hackbench 10
> Time: 0.115
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.373 MB perf.data (~16279 samples) ]
> sh: perf-read-vdso32: command not found
Presumably perf-read-vdso32 is not in the PATH. Did you 'make install'?
>
> comet:~/tip> file ~/hackbench
> /home/mingo/hackbench: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.2.5, not stripped
>
> 64-bit executables work fine:
>
> $ perf record perf bench sched pipe
> # Running 'sched/pipe' benchmark:
> # Executed 1000000 pipe operations between two processes
>
> Total time: 13.374 [sec]
>
> 13.374352 usecs/op
> 74769 ops/sec
> [ perf record: Woken up 14 times to write data ]
> [ perf record: Captured and wrote 3.602 MB perf.data (~157354 samples) ]
>
> The kernel is an older one:
>
> $ uname -a
> Linux comet 3.14.17-100.fc19.x86_64 #1 SMP Thu Aug 14 17:17:26
> UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
>
> Thanks,
>
> Ingo
>
>
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-09-08 21:17 Arnaldo Carvalho de Melo
@ 2014-09-09 4:59 ` Ingo Molnar
2014-09-09 7:14 ` Adrian Hunter
2014-09-09 8:48 ` Adrian Hunter
1 sibling, 1 reply; 61+ messages in thread
From: Ingo Molnar @ 2014-09-09 4:59 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin,
Alexander Yarygin, Anton Blanchard, Christian Borntraeger,
Corey Ashford, David Ahern, Frederic Weisbecker, Jean Pihet,
Jiri Olsa, Kyle McMartin, Michael Ellerman, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Sukadev Bhattiprolu, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
>
> Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
>
> perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> o Add +field argument support for --sort option (Jiri Olsa)
>
> Infrastructure:
>
> o More intel PT prep work, from Adrian Hunter, including:
>
> - Let a user specify a PMU event without any config terms
> - Add perf-with-kcore script
> - Build programs to copy 32-bit compatibility VDSOs
> - Add support for 32-bit compatibility VDSOs
> - Let default config be defined for a PMU
> - Add perf_pmu__scan_file()
>
> o Add feature checks to .gitignore (Alexander Shishkin)
>
> o "perf kvm stat report" improvements by Alexander Yarygin:
> o Save pid string in opts.target.pid
> o Enable the target.system_wide flag
> o Unify the title bar output
>
> o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
>
> o Allow to specify lib compile variable for spec usage (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (6):
> perf tools: Let a user specify a PMU event without any config terms
> perf tools: Add perf-with-kcore script
> perf tools: Build programs to copy 32-bit compatibility VDSOs
> perf tools: Add support for 32-bit compatibility VDSOs
> perf tools: Let default config be defined for a PMU
> perf tools: Add perf_pmu__scan_file()
>
> Alexander Shishkin (1):
> perf tools: Add feature checks to .gitignore
>
> Alexander Yarygin (3):
> perf kvm stat report: Save pid string in opts.target.pid
> perf kvm stat report: Enable the target.system_wide flag
> perf kvm stat report: Unify the title bar output
>
> Anton Blanchard (1):
> perf tools powerpc: Fix build issue when DWARF support is disabled
>
> Jiri Olsa (2):
> perf tools: Add +field argument support for --sort option
> perf tools: Allow to specify lib compile variable for spec usage
>
> tools/perf/.gitignore | 2 +
> tools/perf/Makefile.perf | 42 ++++++-
> tools/perf/arch/powerpc/Makefile | 2 +-
> tools/perf/builtin-kvm.c | 23 ++--
> tools/perf/config/Makefile | 33 ++++-
> tools/perf/config/Makefile.arch | 8 ++
> tools/perf/perf-read-vdso.c | 59 +++++++++
> tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
> tools/perf/tests/pmu.c | 2 +-
> tools/perf/util/kvm-stat.h | 1 -
> tools/perf/util/parse-events.c | 13 +-
> tools/perf/util/parse-events.y | 10 ++
> tools/perf/util/pmu.c | 79 +++++++++---
> tools/perf/util/pmu.h | 12 +-
> tools/perf/util/sort.c | 37 +++++-
> tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
> tools/perf/util/vdso.h | 4 +-
> 17 files changed, 712 insertions(+), 44 deletions(-)
> create mode 100644 tools/perf/perf-read-vdso.c
> create mode 100644 tools/perf/perf-with-kcore.sh
Hm, so I'm getting this error, when trying to profile a 32-bit
ELF binary on a 64-bit kernel, on a testbox:
$ perf record ~/hackbench 10
Time: 0.115
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.373 MB perf.data (~16279 samples) ]
sh: perf-read-vdso32: command not found
comet:~/tip> file ~/hackbench
/home/mingo/hackbench: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.2.5, not stripped
64-bit executables work fine:
$ perf record perf bench sched pipe
# Running 'sched/pipe' benchmark:
# Executed 1000000 pipe operations between two processes
Total time: 13.374 [sec]
13.374352 usecs/op
74769 ops/sec
[ perf record: Woken up 14 times to write data ]
[ perf record: Captured and wrote 3.602 MB perf.data (~157354 samples) ]
The kernel is an older one:
$ uname -a
Linux comet 3.14.17-100.fc19.x86_64 #1 SMP Thu Aug 14 17:17:26
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
Thanks,
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2014-09-08 21:17 Arnaldo Carvalho de Melo
2014-09-09 4:59 ` Ingo Molnar
2014-09-09 8:48 ` Adrian Hunter
0 siblings, 2 replies; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-09-08 21:17 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexander Yarygin, Anton Blanchard,
Christian Borntraeger, Corey Ashford, David Ahern,
Frederic Weisbecker, Jean Pihet, Jiri Olsa, Kyle McMartin,
Michael Ellerman, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Sukadev Bhattiprolu, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 39b5a56ec0be5effe9b7d0f18cb27724bf2e5d47:
Merge branch 'rfc/perf' into perf/core, because it's ready for inclusion (2014-08-24 22:35:42 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to fa3480cb0a96c8af9ded1a8c836c91bd5704bda1:
perf tools: Add perf_pmu__scan_file() (2014-09-08 17:16:06 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
o Add +field argument support for --sort option (Jiri Olsa)
Infrastructure:
o More intel PT prep work, from Adrian Hunter, including:
- Let a user specify a PMU event without any config terms
- Add perf-with-kcore script
- Build programs to copy 32-bit compatibility VDSOs
- Add support for 32-bit compatibility VDSOs
- Let default config be defined for a PMU
- Add perf_pmu__scan_file()
o Add feature checks to .gitignore (Alexander Shishkin)
o "perf kvm stat report" improvements by Alexander Yarygin:
o Save pid string in opts.target.pid
o Enable the target.system_wide flag
o Unify the title bar output
o Fix build issue on powerpc when DWARF support is disabled (Anton Blanchard)
o Allow to specify lib compile variable for spec usage (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (6):
perf tools: Let a user specify a PMU event without any config terms
perf tools: Add perf-with-kcore script
perf tools: Build programs to copy 32-bit compatibility VDSOs
perf tools: Add support for 32-bit compatibility VDSOs
perf tools: Let default config be defined for a PMU
perf tools: Add perf_pmu__scan_file()
Alexander Shishkin (1):
perf tools: Add feature checks to .gitignore
Alexander Yarygin (3):
perf kvm stat report: Save pid string in opts.target.pid
perf kvm stat report: Enable the target.system_wide flag
perf kvm stat report: Unify the title bar output
Anton Blanchard (1):
perf tools powerpc: Fix build issue when DWARF support is disabled
Jiri Olsa (2):
perf tools: Add +field argument support for --sort option
perf tools: Allow to specify lib compile variable for spec usage
tools/perf/.gitignore | 2 +
tools/perf/Makefile.perf | 42 ++++++-
tools/perf/arch/powerpc/Makefile | 2 +-
tools/perf/builtin-kvm.c | 23 ++--
tools/perf/config/Makefile | 33 ++++-
tools/perf/config/Makefile.arch | 8 ++
tools/perf/perf-read-vdso.c | 59 +++++++++
tools/perf/perf-with-kcore.sh | 259 +++++++++++++++++++++++++++++++++++++++
tools/perf/tests/pmu.c | 2 +-
tools/perf/util/kvm-stat.h | 1 -
tools/perf/util/parse-events.c | 13 +-
tools/perf/util/parse-events.y | 10 ++
tools/perf/util/pmu.c | 79 +++++++++---
tools/perf/util/pmu.h | 12 +-
tools/perf/util/sort.c | 37 +++++-
tools/perf/util/vdso.c | 170 ++++++++++++++++++++++++-
tools/perf/util/vdso.h | 4 +-
17 files changed, 712 insertions(+), 44 deletions(-)
create mode 100644 tools/perf/perf-read-vdso.c
create mode 100644 tools/perf/perf-with-kcore.sh
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2014-07-16 20:02 Jiri Olsa
0 siblings, 0 replies; 61+ messages in thread
From: Jiri Olsa @ 2014-07-16 20:02 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Andi Kleen,
Corey Ashford, David Ahern, Frederic Weisbecker, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stanislav Fomichev,
Yann Droneaud, Jiri Olsa
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit ff2ebe46e15bd49d52b9c2f3fc77f3a9d94eac7b:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-07-16 13:48:13 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to 5ce0a7940a89ad7028dfada935b0cc64d307ea3f:
perf tools: Add a --no-desc flag to perf list (2014-07-16 21:35:07 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Add support for full Intel event lists (Andi Kleen)
. Update attr test with PERF_FLAG_FD_CLOEXEC flag (Jiri Olsa)
. Enable close-on-exec flag on perf file descriptor (Yann Droneaud)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Andi Kleen (11):
perf tools: Add jsmn `jasmine' JSON parser
perf tools: Add support for text descriptions of events and alias add
perf tools: Update perf list to output descriptions
perf tools: Allow events with dot
perf tools: Add support for reading JSON event files
perf tools: Automatically look for event file name for cpu
perf tools: Add perf download to download event files
perf tools: Query terminal width and use in perf list
perf tools: Add a new pmu interface to iterate over all events
perf tests: Add test case for alias and JSON parsing
perf tools: Add a --no-desc flag to perf list
Jiri Olsa (1):
perf tests: Update attr test with PERF_FLAG_FD_CLOEXEC flag
Yann Droneaud (1):
perf tools: Enable close-on-exec flag on perf file descriptor
tools/perf/Documentation/perf-download.txt | 31 +++
tools/perf/Documentation/perf-list.txt | 29 ++-
tools/perf/Documentation/perf-record.txt | 8 +-
tools/perf/Documentation/perf-stat.txt | 8 +-
tools/perf/Makefile.perf | 13 +-
tools/perf/arch/x86/util/header.c | 19 +-
tools/perf/bench/mem-memcpy.c | 4 +-
tools/perf/bench/mem-memset.c | 4 +-
tools/perf/builtin-list.c | 16 +-
tools/perf/builtin-record.c | 3 +
tools/perf/builtin-sched.c | 4 +-
tools/perf/builtin-stat.c | 2 +
tools/perf/perf-download.sh | 56 ++++++
tools/perf/tests/aliases.c | 58 ++++++
tools/perf/tests/attr/base-record | 3 +-
tools/perf/tests/attr/base-stat | 3 +-
tools/perf/tests/bp_signal.c | 4 +-
tools/perf/tests/bp_signal_overflow.c | 4 +-
tools/perf/tests/builtin-test.c | 4 +
tools/perf/tests/rdpmc.c | 4 +-
tools/perf/tests/tests.h | 1 +
tools/perf/util/cache.h | 1 +
tools/perf/util/cloexec.c | 57 ++++++
tools/perf/util/cloexec.h | 6 +
tools/perf/util/evsel.c | 12 +-
tools/perf/util/jevents.c | 286 ++++++++++++++++++++++++++
tools/perf/util/jevents.h | 9 +
tools/perf/util/jsmn.c | 313 +++++++++++++++++++++++++++++
tools/perf/util/jsmn.h | 67 ++++++
tools/perf/util/json.c | 155 ++++++++++++++
tools/perf/util/json.h | 13 ++
tools/perf/util/pager.c | 15 ++
tools/perf/util/parse-events.c | 4 +-
tools/perf/util/parse-events.h | 2 +-
tools/perf/util/parse-events.l | 3 +-
tools/perf/util/pmu.c | 153 +++++++++++---
tools/perf/util/pmu.h | 6 +-
tools/perf/util/record.c | 9 +-
38 files changed, 1324 insertions(+), 65 deletions(-)
create mode 100644 tools/perf/Documentation/perf-download.txt
create mode 100755 tools/perf/perf-download.sh
create mode 100644 tools/perf/tests/aliases.c
create mode 100644 tools/perf/util/cloexec.c
create mode 100644 tools/perf/util/cloexec.h
create mode 100644 tools/perf/util/jevents.c
create mode 100644 tools/perf/util/jevents.h
create mode 100644 tools/perf/util/jsmn.c
create mode 100644 tools/perf/util/jsmn.h
create mode 100644 tools/perf/util/json.c
create mode 100644 tools/perf/util/json.h
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-03-18 21:25 Arnaldo Carvalho de Melo
@ 2014-03-19 7:07 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2014-03-19 7:07 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Don Zickus,
Frederic Weisbecker, Jiri Olsa, Joe Mario, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Ramkumar Ramachandra, Stanislav Fomichev, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 0afd2d51029961281572d02545c7bde1b3f4292c:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-03-18 09:23:09 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to a51e87cb5a0fbebee15a3373d951dbf6f59a76c2:
>
> perf tools: Remove unused simple_strtoul() function (2014-03-18 18:17:07 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> . Fixup header alignment in 'perf sched latency' output (Ramkumar Ramachandra)
>
> . Fix off-by-one error in 'perf timechart record' argv handling (Ramkumar Ramachandra)
>
> . Print the evsel name in the annotate stdio output, prep to fix support
> outputting annotation for multiple events, not just for the first one
> (Arnaldo Carvalho de Melo)
>
> Internals:
>
> . Use tid in mmap/mmap2 events to find maps (Don Zickus)
>
> . Record the reason for filtering an address_location (Namhyung Kim)
>
> . Apply all filters to an addr_location (Namhyung Kim)
>
> . Merge al->filtered with hist_entry->filtered in report/hists (Namhyung Kim)
>
> . Fix memory leak when synthesizing thread records (Namhyung Kim)
>
> . Use ui__has_annotation() in 'report' (Namhyung Kim)
>
> Cleanups:
>
> . Remove unused thread__find_map function (Jiri Olsa)
>
> . Remove unused simple_strtoul() function (Ramkumar Ramachandra)
>
> Documentation:
>
> . Update function names in debug messages (Ramkumar Ramachandra)
>
> . Update some code references in design.txt (Ramkumar Ramachandra)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf annotate: Print the evsel name in the stdio output
>
> Don Zickus (1):
> perf tools: Use tid in mmap/mmap2 events to find maps
>
> Jiri Olsa (1):
> perf tools: Remove thread__find_map function
>
> Namhyung Kim (5):
> perf symbols: Record the reason for filtering an address_location
> perf symbols: Apply all filters to an addr_location
> perf report: Merge al->filtered with hist_entry->filtered
> perf tools: Fix memory leak when synthesizing thread records
> perf report: Use ui__has_annotation()
>
> Ramkumar Ramachandra (5):
> perf timechart: Fix off-by-one error in 'record' argv handling
> perf sched: Fixup header alignment in 'latency' output
> perf evsel: Update function names in debug messages
> perf tools: Update some code references in design.txt
> perf tools: Remove unused simple_strtoul() function
>
> tools/perf/builtin-report.c | 4 ++--
> tools/perf/builtin-sched.c | 10 +++++-----
> tools/perf/builtin-timechart.c | 4 ++--
> tools/perf/design.txt | 12 ++++++------
> tools/perf/tests/hists_link.c | 1 +
> tools/perf/util/annotate.c | 14 +++++++++-----
> tools/perf/util/event.c | 34 +++++++++++++++++-----------------
> tools/perf/util/evsel.c | 4 ++--
> tools/perf/util/hist.c | 9 +--------
> tools/perf/util/hist.h | 9 +++++++++
> tools/perf/util/include/linux/kernel.h | 6 ------
> tools/perf/util/machine.c | 6 +++---
> tools/perf/util/symbol.h | 2 +-
> tools/perf/util/thread.h | 6 ------
> 14 files changed, 58 insertions(+), 63 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2014-03-18 21:25 Arnaldo Carvalho de Melo
2014-03-19 7:07 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-03-18 21:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Don Zickus,
Frederic Weisbecker, Jiri Olsa, Joe Mario, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Ramkumar Ramachandra, Stanislav Fomichev, Stephane Eranian,
Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 0afd2d51029961281572d02545c7bde1b3f4292c:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-03-18 09:23:09 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to a51e87cb5a0fbebee15a3373d951dbf6f59a76c2:
perf tools: Remove unused simple_strtoul() function (2014-03-18 18:17:07 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
. Fixup header alignment in 'perf sched latency' output (Ramkumar Ramachandra)
. Fix off-by-one error in 'perf timechart record' argv handling (Ramkumar Ramachandra)
. Print the evsel name in the annotate stdio output, prep to fix support
outputting annotation for multiple events, not just for the first one
(Arnaldo Carvalho de Melo)
Internals:
. Use tid in mmap/mmap2 events to find maps (Don Zickus)
. Record the reason for filtering an address_location (Namhyung Kim)
. Apply all filters to an addr_location (Namhyung Kim)
. Merge al->filtered with hist_entry->filtered in report/hists (Namhyung Kim)
. Fix memory leak when synthesizing thread records (Namhyung Kim)
. Use ui__has_annotation() in 'report' (Namhyung Kim)
Cleanups:
. Remove unused thread__find_map function (Jiri Olsa)
. Remove unused simple_strtoul() function (Ramkumar Ramachandra)
Documentation:
. Update function names in debug messages (Ramkumar Ramachandra)
. Update some code references in design.txt (Ramkumar Ramachandra)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf annotate: Print the evsel name in the stdio output
Don Zickus (1):
perf tools: Use tid in mmap/mmap2 events to find maps
Jiri Olsa (1):
perf tools: Remove thread__find_map function
Namhyung Kim (5):
perf symbols: Record the reason for filtering an address_location
perf symbols: Apply all filters to an addr_location
perf report: Merge al->filtered with hist_entry->filtered
perf tools: Fix memory leak when synthesizing thread records
perf report: Use ui__has_annotation()
Ramkumar Ramachandra (5):
perf timechart: Fix off-by-one error in 'record' argv handling
perf sched: Fixup header alignment in 'latency' output
perf evsel: Update function names in debug messages
perf tools: Update some code references in design.txt
perf tools: Remove unused simple_strtoul() function
tools/perf/builtin-report.c | 4 ++--
tools/perf/builtin-sched.c | 10 +++++-----
tools/perf/builtin-timechart.c | 4 ++--
tools/perf/design.txt | 12 ++++++------
tools/perf/tests/hists_link.c | 1 +
tools/perf/util/annotate.c | 14 +++++++++-----
tools/perf/util/event.c | 34 +++++++++++++++++-----------------
tools/perf/util/evsel.c | 4 ++--
tools/perf/util/hist.c | 9 +--------
tools/perf/util/hist.h | 9 +++++++++
tools/perf/util/include/linux/kernel.h | 6 ------
tools/perf/util/machine.c | 6 +++---
tools/perf/util/symbol.h | 2 +-
tools/perf/util/thread.h | 6 ------
14 files changed, 58 insertions(+), 63 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2014-01-15 20:32 Arnaldo Carvalho de Melo
@ 2014-01-16 8:36 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2014-01-16 8:36 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Arun Sharma, David Ahern, Frederic Weisbecker,
Jiri Olsa, Mark Rutland, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Rodrigo Campos, Stephane Eranian,
Steven Rostedt, Will Deacon, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 197749981e539c1eb5863f417de6dd4e2c02b76c:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-01-14 17:25:12 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to 0e9e79a13ab9d56b86db6538305babc23b1445cc:
>
> tools lib traceevent: fix pointer-integer size mismatch (2014-01-15 17:04:38 -0300)
>
> ----------------------------------------------------------------
> Changes in user visible interfaces:
>
> . Rename 'record's --no-delay option to --no-buffering, better reflecting its
> purpose and freeing up '--delay' to take the place of '--initial-delay', so that
> 'record' and 'stat' are consistent.
>
> Refactorings:
>
> . Get rid of die() and friends (good riddance!) in libtraceevent (Namhyung Kim)
>
> Developer stuff:
>
> . Fix cross build problems related to pkgconfig and CROSS_COMPILE not being
> propagated to the feature tests, leading to features being tested in the
> host and then being enabled on the target. (Mark Rutland)
>
> . Fix pointer-integer size mismatch in some libtraceevent plugins (Mark Rutland)
>
> . Fix build error due to zfree() cast (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf record: Rename --no-delay to --no-buffering
> perf record: Rename --initial-delay to --delay
>
> Mark Rutland (2):
> perf: tools: Fix cross building
> tools lib traceevent: fix pointer-integer size mismatch
>
> Namhyung Kim (9):
> perf tools: Fix build error due to zfree() cast
> tools lib traceevent: Add state member to struct trace_seq
> tools lib traceevent: Check return value of realloc()
> tools lib traceevent: Get rid of malloc_or_die() in trace_seq_init()
> tools lib traceevent: Get rid of die() finally!!
> tools lib traceevent: Make plugin unload function receive pevent
> perf tools: Remove symbol_conf.use_callchain check
> perf tools: Factor out sample__resolve_callchain()
> perf hists: Convert hist entry functions to use struct he_stat
>
> tools/lib/traceevent/Makefile | 2 +-
> tools/lib/traceevent/event-parse.h | 14 +++++--
> tools/lib/traceevent/event-plugin.c | 4 +-
> tools/lib/traceevent/event-utils.h | 4 --
> tools/lib/traceevent/parse-utils.c | 44 --------------------
> tools/lib/traceevent/plugin_cfg80211.c | 2 +-
> tools/lib/traceevent/plugin_function.c | 2 +-
> tools/lib/traceevent/plugin_scsi.c | 2 +-
> tools/lib/traceevent/trace-seq.c | 67 ++++++++++++++++++++++++-------
> tools/perf/Documentation/perf-record.txt | 6 +--
> tools/perf/Makefile.perf | 1 +
> tools/perf/builtin-record.c | 4 +-
> tools/perf/builtin-report.c | 24 ++---------
> tools/perf/builtin-top.c | 22 ++++------
> tools/perf/builtin-trace.c | 2 +-
> tools/perf/config/Makefile | 6 +--
> tools/perf/config/feature-checks/Makefile | 9 +++--
> tools/perf/perf.h | 2 +-
> tools/perf/tests/open-syscall-tp-fields.c | 8 ++--
> tools/perf/tests/perf-record.c | 6 +--
> tools/perf/util/callchain.c | 23 +++++++++++
> tools/perf/util/callchain.h | 6 +++
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/hist.c | 22 +++++-----
> tools/perf/util/machine.c | 2 -
> tools/perf/util/srcline.c | 4 +-
> tools/perf/util/strlist.c | 2 +-
> tools/perf/util/trace-event.c | 2 +-
> 28 files changed, 147 insertions(+), 147 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2014-01-15 20:32 Arnaldo Carvalho de Melo
2014-01-16 8:36 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-01-15 20:32 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Arun Sharma, David Ahern, Frederic Weisbecker,
Jiri Olsa, Mark Rutland, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Rodrigo Campos, Stephane Eranian,
Steven Rostedt, Will Deacon, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 197749981e539c1eb5863f417de6dd4e2c02b76c:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-01-14 17:25:12 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to 0e9e79a13ab9d56b86db6538305babc23b1445cc:
tools lib traceevent: fix pointer-integer size mismatch (2014-01-15 17:04:38 -0300)
----------------------------------------------------------------
Changes in user visible interfaces:
. Rename 'record's --no-delay option to --no-buffering, better reflecting its
purpose and freeing up '--delay' to take the place of '--initial-delay', so that
'record' and 'stat' are consistent.
Refactorings:
. Get rid of die() and friends (good riddance!) in libtraceevent (Namhyung Kim)
Developer stuff:
. Fix cross build problems related to pkgconfig and CROSS_COMPILE not being
propagated to the feature tests, leading to features being tested in the
host and then being enabled on the target. (Mark Rutland)
. Fix pointer-integer size mismatch in some libtraceevent plugins (Mark Rutland)
. Fix build error due to zfree() cast (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf record: Rename --no-delay to --no-buffering
perf record: Rename --initial-delay to --delay
Mark Rutland (2):
perf: tools: Fix cross building
tools lib traceevent: fix pointer-integer size mismatch
Namhyung Kim (9):
perf tools: Fix build error due to zfree() cast
tools lib traceevent: Add state member to struct trace_seq
tools lib traceevent: Check return value of realloc()
tools lib traceevent: Get rid of malloc_or_die() in trace_seq_init()
tools lib traceevent: Get rid of die() finally!!
tools lib traceevent: Make plugin unload function receive pevent
perf tools: Remove symbol_conf.use_callchain check
perf tools: Factor out sample__resolve_callchain()
perf hists: Convert hist entry functions to use struct he_stat
tools/lib/traceevent/Makefile | 2 +-
tools/lib/traceevent/event-parse.h | 14 +++++--
tools/lib/traceevent/event-plugin.c | 4 +-
tools/lib/traceevent/event-utils.h | 4 --
tools/lib/traceevent/parse-utils.c | 44 --------------------
tools/lib/traceevent/plugin_cfg80211.c | 2 +-
tools/lib/traceevent/plugin_function.c | 2 +-
tools/lib/traceevent/plugin_scsi.c | 2 +-
tools/lib/traceevent/trace-seq.c | 67 ++++++++++++++++++++++++-------
tools/perf/Documentation/perf-record.txt | 6 +--
tools/perf/Makefile.perf | 1 +
tools/perf/builtin-record.c | 4 +-
tools/perf/builtin-report.c | 24 ++---------
tools/perf/builtin-top.c | 22 ++++------
tools/perf/builtin-trace.c | 2 +-
tools/perf/config/Makefile | 6 +--
tools/perf/config/feature-checks/Makefile | 9 +++--
tools/perf/perf.h | 2 +-
tools/perf/tests/open-syscall-tp-fields.c | 8 ++--
tools/perf/tests/perf-record.c | 6 +--
tools/perf/util/callchain.c | 23 +++++++++++
tools/perf/util/callchain.h | 6 +++
tools/perf/util/evsel.c | 2 +-
tools/perf/util/hist.c | 22 +++++-----
tools/perf/util/machine.c | 2 -
tools/perf/util/srcline.c | 4 +-
tools/perf/util/strlist.c | 2 +-
tools/perf/util/trace-event.c | 2 +-
28 files changed, 147 insertions(+), 147 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2013-11-12 20:46 Arnaldo Carvalho de Melo
@ 2013-11-12 20:50 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2013-11-12 20:50 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Pekka Enberg, Peter Zijlstra,
Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 67c1e4a53b17894e6a24f95057cc374c4be051cb:
>
> perf tests: Use lower sample_freq in sw clock event period test (2013-11-11 16:43:34 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to 0497a9ebaf7ae4d573497b3e053ad4c3d5c9921d:
>
> tools lib traceevent: Add direct access to dynamic arrays (2013-11-12 17:23:44 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Add summary only option to 'perf trace', suppressing the decoding of
> events, from David Ahern
>
> . 'perf trace --summary' formatting simplifications, from Pekka Emberg.
>
> . Beautify fifth argument of mmap() as fd, in 'perf trace', from Namhyung Kim.
>
> . Fix segfault on perf trace -i perf.data, from Namhyung Kim.
>
> . Fix segfault with --no-mmap-pages, from David Ahern.
>
> . Round mmap pages to power 2, from David Ahern.
>
> . Add direct access to dynamic arrays in libtraceevent, from Steven Rostedt.
>
> . Handle throttle events in 'object code reading' test, fix from Adrian Hunter.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf tests: Compensate lower sample freq with longer test loop
> perf tests: Handle throttle events in 'object code reading' test
>
> Arnaldo Carvalho de Melo (1):
> perf target: Shorten perf_target__ to target__
>
> David Ahern (4):
> perf trace: Add summary only option
> perf record: Fix segfault with --no-mmap-pages
> perf evlist: Round mmap pages to power 2 - v2
> perf evlist: Refactor mmap_pages parsing
>
> Namhyung Kim (3):
> perf trace: Beautify fifth argument of mmap() as fd
> perf trace: Separate tp syscall field caching into init routine to be reused
> perf trace: Fix segfault on perf trace -i perf.data
>
> Pekka Enberg (2):
> perf trace: Change syscall summary duration order
> perf trace: Simplify '--summary' output
>
> Steven Rostedt (1):
> tools lib traceevent: Add direct access to dynamic arrays
>
> tools/lib/traceevent/event-parse.c | 13 ++++
> tools/perf/Documentation/perf-trace.txt | 10 ++-
> tools/perf/builtin-kvm.c | 6 +-
> tools/perf/builtin-record.c | 14 ++--
> tools/perf/builtin-stat.c | 21 +++---
> tools/perf/builtin-top.c | 14 ++--
> tools/perf/builtin-trace.c | 121 +++++++++++++++++++-------------
> tools/perf/perf.h | 2 +-
> tools/perf/tests/code-reading.c | 15 +++-
> tools/perf/tests/sw-clock.c | 2 +-
> tools/perf/tests/task-exit.c | 2 +-
> tools/perf/util/evlist.c | 64 ++++++++++-------
> tools/perf/util/evlist.h | 5 +-
> tools/perf/util/evsel.c | 9 ++-
> tools/perf/util/evsel.h | 3 +-
> tools/perf/util/machine.c | 6 +-
> tools/perf/util/machine.h | 4 +-
> tools/perf/util/target.c | 54 +++++++-------
> tools/perf/util/target.h | 44 ++++++------
> tools/perf/util/top.c | 2 +-
> 20 files changed, 236 insertions(+), 175 deletions(-)
Pulled, including yesterday's bits as well - thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2013-11-12 20:46 Arnaldo Carvalho de Melo
2013-11-12 20:50 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-11-12 20:46 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Pekka Enberg, Peter Zijlstra,
Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 67c1e4a53b17894e6a24f95057cc374c4be051cb:
perf tests: Use lower sample_freq in sw clock event period test (2013-11-11 16:43:34 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to 0497a9ebaf7ae4d573497b3e053ad4c3d5c9921d:
tools lib traceevent: Add direct access to dynamic arrays (2013-11-12 17:23:44 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
. Add summary only option to 'perf trace', suppressing the decoding of
events, from David Ahern
. 'perf trace --summary' formatting simplifications, from Pekka Emberg.
. Beautify fifth argument of mmap() as fd, in 'perf trace', from Namhyung Kim.
. Fix segfault on perf trace -i perf.data, from Namhyung Kim.
. Fix segfault with --no-mmap-pages, from David Ahern.
. Round mmap pages to power 2, from David Ahern.
. Add direct access to dynamic arrays in libtraceevent, from Steven Rostedt.
. Handle throttle events in 'object code reading' test, fix from Adrian Hunter.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf tests: Compensate lower sample freq with longer test loop
perf tests: Handle throttle events in 'object code reading' test
Arnaldo Carvalho de Melo (1):
perf target: Shorten perf_target__ to target__
David Ahern (4):
perf trace: Add summary only option
perf record: Fix segfault with --no-mmap-pages
perf evlist: Round mmap pages to power 2 - v2
perf evlist: Refactor mmap_pages parsing
Namhyung Kim (3):
perf trace: Beautify fifth argument of mmap() as fd
perf trace: Separate tp syscall field caching into init routine to be reused
perf trace: Fix segfault on perf trace -i perf.data
Pekka Enberg (2):
perf trace: Change syscall summary duration order
perf trace: Simplify '--summary' output
Steven Rostedt (1):
tools lib traceevent: Add direct access to dynamic arrays
tools/lib/traceevent/event-parse.c | 13 ++++
tools/perf/Documentation/perf-trace.txt | 10 ++-
tools/perf/builtin-kvm.c | 6 +-
tools/perf/builtin-record.c | 14 ++--
tools/perf/builtin-stat.c | 21 +++---
tools/perf/builtin-top.c | 14 ++--
tools/perf/builtin-trace.c | 121 +++++++++++++++++++-------------
tools/perf/perf.h | 2 +-
tools/perf/tests/code-reading.c | 15 +++-
tools/perf/tests/sw-clock.c | 2 +-
tools/perf/tests/task-exit.c | 2 +-
tools/perf/util/evlist.c | 64 ++++++++++-------
tools/perf/util/evlist.h | 5 +-
tools/perf/util/evsel.c | 9 ++-
tools/perf/util/evsel.h | 3 +-
tools/perf/util/machine.c | 6 +-
tools/perf/util/machine.h | 4 +-
tools/perf/util/target.c | 54 +++++++-------
tools/perf/util/target.h | 44 ++++++------
tools/perf/util/top.c | 2 +-
20 files changed, 236 insertions(+), 175 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [GIT PULL 00/13] perf/core improvements and fixes
2012-09-08 2:06 Arnaldo Carvalho de Melo
@ 2012-09-08 11:28 ` Ingo Molnar
0 siblings, 0 replies; 61+ messages in thread
From: Ingo Molnar @ 2012-09-08 11:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Andrew Morton,
Corey Ashford, David Ahern, Frederic Weisbecker, Irina Tirdea,
Jiri Olsa, linux-mm, Michel Lespinasse, Namhyung Kim,
Namhyung Kim, Paul E. McKenney, Paul Mackerras, Peter Zijlstra,
Steven Rostedt, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 479d875835a49e849683743ec50c30b6a429696b:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2012-09-07 07:36:59 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to b155a09015135cf59ada8d48109ccbd9891c1b42:
>
> perf tools: Fix build for another rbtree.c change (2012-09-07 22:21:59 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes
>
> . Fix build for another rbtree.c change, from Adrian Hunter.
>
> . Fixes for perf to build on Android, from Irina Tirdea.
>
> . Make 'perf diff' command work with evsel hists, from Jiri Olsa.
>
> . Use the only field_sep var that is set up: symbol_conf.field_sep,
> fix from Jiri Olsa.
>
> . .gitignore compiled python binaries, from Namhyung Kim.
>
> . Get rid of die() in more libtraceevent places, from Namhyung Kim.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (1):
> perf tools: Fix build for another rbtree.c change
>
> Irina Tirdea (6):
> perf tools: include basename for non-glibc systems
> perf tools: fix missing winsize definition
> perf tools: include missing pthread.h header
> perf tools: replace mkostemp with mkstemp
> tools lib traceevent: replace mempcpy with memcpy
> perf tools: add NO_BACKTRACE for application self-debugging
>
> Jiri Olsa (2):
> perf diff: Make diff command work with evsel hists
> perf tools: Replace sort's standalone field_sep with symbol_conf.field_sep
>
> Namhyung Kim (4):
> perf tools: Ignore compiled python binaries
> tools lib traceevent: Get rid of die() from pretty_print()
> tools lib traceevent: Get rid of die() from pevent_register_event_handler
> tools lib traceevent: Get rid of die() from pevent_register_print_function
>
> tools/lib/traceevent/event-parse.c | 86 +++++++++++++++++++++--------
> tools/lib/traceevent/event-parse.h | 3 +-
> tools/perf/.gitignore | 2 +
> tools/perf/Documentation/perf-diff.txt | 3 ++
> tools/perf/Makefile | 8 +++
> tools/perf/builtin-diff.c | 93 +++++++++++++++++++++-----------
> tools/perf/config/feature-tests.mak | 14 +++++
> tools/perf/perf.c | 1 +
> tools/perf/util/annotate.h | 1 +
> tools/perf/util/dso-test-data.c | 2 +-
> tools/perf/util/evsel.h | 7 +++
> tools/perf/util/help.c | 1 +
> tools/perf/util/include/linux/rbtree.h | 1 +
> tools/perf/util/session.h | 4 +-
> tools/perf/util/sort.c | 6 +--
> tools/perf/util/sort.h | 1 -
> tools/perf/util/symbol.h | 3 ++
> tools/perf/util/top.h | 1 +
> tools/perf/util/util.c | 6 +++
> 19 files changed, 180 insertions(+), 63 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 61+ messages in thread
* [GIT PULL 00/13] perf/core improvements and fixes
@ 2012-09-08 2:06 Arnaldo Carvalho de Melo
2012-09-08 11:28 ` Ingo Molnar
0 siblings, 1 reply; 61+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-09-08 2:06 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Andrew Morton, Corey Ashford, David Ahern,
Frederic Weisbecker, Irina Tirdea, Jiri Olsa, linux-mm,
Michel Lespinasse, Namhyung Kim, Namhyung Kim, Paul E. McKenney,
Paul Mackerras, Peter Zijlstra, Steven Rostedt,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 479d875835a49e849683743ec50c30b6a429696b:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2012-09-07 07:36:59 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to b155a09015135cf59ada8d48109ccbd9891c1b42:
perf tools: Fix build for another rbtree.c change (2012-09-07 22:21:59 -0300)
----------------------------------------------------------------
perf/core improvements and fixes
. Fix build for another rbtree.c change, from Adrian Hunter.
. Fixes for perf to build on Android, from Irina Tirdea.
. Make 'perf diff' command work with evsel hists, from Jiri Olsa.
. Use the only field_sep var that is set up: symbol_conf.field_sep,
fix from Jiri Olsa.
. .gitignore compiled python binaries, from Namhyung Kim.
. Get rid of die() in more libtraceevent places, from Namhyung Kim.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (1):
perf tools: Fix build for another rbtree.c change
Irina Tirdea (6):
perf tools: include basename for non-glibc systems
perf tools: fix missing winsize definition
perf tools: include missing pthread.h header
perf tools: replace mkostemp with mkstemp
tools lib traceevent: replace mempcpy with memcpy
perf tools: add NO_BACKTRACE for application self-debugging
Jiri Olsa (2):
perf diff: Make diff command work with evsel hists
perf tools: Replace sort's standalone field_sep with symbol_conf.field_sep
Namhyung Kim (4):
perf tools: Ignore compiled python binaries
tools lib traceevent: Get rid of die() from pretty_print()
tools lib traceevent: Get rid of die() from pevent_register_event_handler
tools lib traceevent: Get rid of die() from pevent_register_print_function
tools/lib/traceevent/event-parse.c | 86 +++++++++++++++++++++--------
tools/lib/traceevent/event-parse.h | 3 +-
tools/perf/.gitignore | 2 +
tools/perf/Documentation/perf-diff.txt | 3 ++
tools/perf/Makefile | 8 +++
tools/perf/builtin-diff.c | 93 +++++++++++++++++++++-----------
tools/perf/config/feature-tests.mak | 14 +++++
tools/perf/perf.c | 1 +
tools/perf/util/annotate.h | 1 +
tools/perf/util/dso-test-data.c | 2 +-
tools/perf/util/evsel.h | 7 +++
tools/perf/util/help.c | 1 +
tools/perf/util/include/linux/rbtree.h | 1 +
tools/perf/util/session.h | 4 +-
tools/perf/util/sort.c | 6 +--
tools/perf/util/sort.h | 1 -
tools/perf/util/symbol.h | 3 ++
tools/perf/util/top.h | 1 +
tools/perf/util/util.c | 6 +++
19 files changed, 180 insertions(+), 63 deletions(-)
^ permalink raw reply [flat|nested] 61+ messages in thread
end of thread, other threads:[~2018-09-25 9:21 UTC | newest]
Thread overview: 61+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 14:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 01/13] perf: Suppress AUX/OVERWRITE records Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 02/13] perf test: Add watchpoint test Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 03/13] perf ordered_events: Add 'struct ordered_events_buffer' layer Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 04/13] perf ordered_events: Prevent crossing max_alloc_size Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 05/13] tools include: Adopt PTR_ERR_OR_ZERO from the kernel err.h header Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 06/13] perf bpf-loader: use PTR_ERR_OR_ZERO inetead of return code Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 07/13] perf tools: Remove perf_tool from event_op2 Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 08/13] perf tools: Remove perf_tool from event_op3 Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 09/13] perf auxtrace: Pass struct perf_mmap into mmap__read* functions Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 10/13] perf tools: Add 'struct perf_mmap' arg to record__write() Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 11/13] perf util: Make copyfile_offset() global Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 12/13] perf tools: Initialize perf_data_file fd field Arnaldo Carvalho de Melo
2018-09-19 14:25 ` [PATCH 13/13] perf python: Use -Wno-redundant-decls to build with PYTHON=python3 Arnaldo Carvalho de Melo
2018-09-25 9:21 ` [GIT PULL 00/13] perf/core improvements and fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2017-09-04 14:00 Arnaldo Carvalho de Melo
2017-09-05 5:15 ` Ingo Molnar
2017-08-21 19:25 Arnaldo Carvalho de Melo
2017-08-22 10:20 ` Ingo Molnar
2017-04-05 0:17 Arnaldo Carvalho de Melo
2017-04-05 5:41 ` Ingo Molnar
2017-01-11 20:21 Arnaldo Carvalho de Melo
2017-01-12 8:25 ` Ingo Molnar
2016-10-06 16:11 Arnaldo Carvalho de Melo
2016-10-06 22:38 ` Ingo Molnar
2016-05-11 16:32 Arnaldo Carvalho de Melo
2016-05-12 6:58 ` Ingo Molnar
2016-04-29 14:57 Arnaldo Carvalho de Melo
2016-04-29 19:39 ` Ingo Molnar
2016-02-15 21:01 Arnaldo Carvalho de Melo
2016-02-16 7:48 ` Ingo Molnar
2015-11-26 20:45 Arnaldo Carvalho de Melo
2015-11-27 7:30 ` Ingo Molnar
2015-08-12 16:39 Arnaldo Carvalho de Melo
2015-08-13 7:25 ` Ingo Molnar
2015-07-20 20:58 Arnaldo Carvalho de Melo
2015-07-21 6:00 ` Ingo Molnar
2015-06-23 21:47 Arnaldo Carvalho de Melo
2015-06-25 7:31 ` Ingo Molnar
2015-06-25 13:48 ` Arnaldo Carvalho de Melo
2014-09-08 21:17 Arnaldo Carvalho de Melo
2014-09-09 4:59 ` Ingo Molnar
2014-09-09 7:14 ` Adrian Hunter
2014-09-09 7:45 ` Stephane Eranian
2014-09-09 7:55 ` Adrian Hunter
2014-09-09 14:53 ` Ingo Molnar
2014-09-09 8:48 ` Adrian Hunter
2014-09-09 13:12 ` Arnaldo Carvalho de Melo
2014-09-09 14:54 ` Ingo Molnar
2014-09-09 15:59 ` Arnaldo Carvalho de Melo
2014-09-09 19:08 ` Arnaldo Carvalho de Melo
2014-09-10 13:19 ` Adrian Hunter
2014-07-16 20:02 Jiri Olsa
2014-03-18 21:25 Arnaldo Carvalho de Melo
2014-03-19 7:07 ` Ingo Molnar
2014-01-15 20:32 Arnaldo Carvalho de Melo
2014-01-16 8:36 ` Ingo Molnar
2013-11-12 20:46 Arnaldo Carvalho de Melo
2013-11-12 20:50 ` Ingo Molnar
2012-09-08 2:06 Arnaldo Carvalho de Melo
2012-09-08 11:28 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).