From: Joe Hershberger <joe.hershberger@ni.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>,
"edgari@xilinx.com" <edgari@xilinx.com>,
Joseph Hershberger <joseph.hershberger@ni.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
u-boot <u-boot@lists.denx.de>
Subject: Re: [U-Boot] [PATCH] net: macb: Clean 64b dma addresses if they are not detected
Date: Wed, 19 Sep 2018 17:17:49 +0000 [thread overview]
Message-ID: <CANr=Z=boufs6AGj5iircB3bj00ZPE+RsXgPrqGRZSc-2j1fTiw@mail.gmail.com> (raw)
Message-ID: <20180919171749.KwhyOF9SYP6Zn2HE-_9xDbnOOL1_mY-IhUG3CkNs_ok@z> (raw)
In-Reply-To: <0997a0e77b5e5c04c9a4d277d702d93a1a8a7448.1537373294.git.michal.simek@xilinx.com>
On Wed, Sep 19, 2018 at 11:08 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B
> is not detected on 64bit system.
> The issue was observed when bootloader(u-boot) does not check macb
> feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma support
> by default. Then macb driver is reading DMACFG register back and only
> adding 64bit dma configuration but not cleaning it out.
>
> This is also align with other features which are also cleared if they are not
> present.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
next prev parent reply other threads:[~2018-09-19 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 16:08 [PATCH] net: macb: Clean 64b dma addresses if they are not detected Michal Simek
2018-09-19 17:11 ` Joe Hershberger [this message]
2018-09-19 17:11 ` [U-Boot] " Joe Hershberger
2018-09-19 17:11 ` Joe Hershberger
2018-09-19 17:17 ` Joe Hershberger
2018-09-19 17:17 ` Joe Hershberger
2018-09-19 18:08 ` Edgar E. Iglesias
2018-09-20 6:23 ` Michal Simek
2018-09-21 12:38 ` Nicolas Ferre
2018-09-25 6:34 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANr=Z=boufs6AGj5iircB3bj00ZPE+RsXgPrqGRZSc-2j1fTiw@mail.gmail.com' \
--to=joe.hershberger@ni.com \
--cc=davem@davemloft.net \
--cc=edgari@xilinx.com \
--cc=joseph.hershberger@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).