* [PATCH] Don't hardcode path as it is architecture dependent
@ 2018-09-20 6:26 Ritesh Raj Sarraf
2018-09-20 19:05 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Ritesh Raj Sarraf @ 2018-09-20 6:26 UTC (permalink / raw)
To: Richard Weinberger
Cc: Ritesh Raj Sarraf, Ritesh Raj Sarraf, Jeff Dike, linux-um, linux-kernel
The current code fails to run on amd64 because of hardcoded reference to
i386
Signed-off-by: Ritesh Raj Sarraf <rrs@researchut.com>
---
arch/um/drivers/port_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c
index 9a8e1b64c22e..5f56d11b886f 100644
--- a/arch/um/drivers/port_user.c
+++ b/arch/um/drivers/port_user.c
@@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out)
{
int new, err;
char *argv[] = { "/usr/sbin/in.telnetd", "-L",
- "/usr/lib/uml/port-helper", NULL };
+ OS_LIB_PATH "/uml/port-helper", NULL };
struct port_pre_exec_data data;
new = accept(fd, NULL, 0);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Don't hardcode path as it is architecture dependent
2018-09-20 6:26 [PATCH] Don't hardcode path as it is architecture dependent Ritesh Raj Sarraf
@ 2018-09-20 19:05 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2018-09-20 19:05 UTC (permalink / raw)
To: Ritesh Raj Sarraf; +Cc: Ritesh Raj Sarraf, Jeff Dike, linux-um, linux-kernel
Am Donnerstag, 20. September 2018, 08:26:38 CEST schrieb Ritesh Raj Sarraf:
> The current code fails to run on amd64 because of hardcoded reference to
> i386
>
> Signed-off-by: Ritesh Raj Sarraf <rrs@researchut.com>
Thanks for spotting this!
> ---
> arch/um/drivers/port_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c
> index 9a8e1b64c22e..5f56d11b886f 100644
> --- a/arch/um/drivers/port_user.c
> +++ b/arch/um/drivers/port_user.c
> @@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out)
> {
> int new, err;
> char *argv[] = { "/usr/sbin/in.telnetd", "-L",
> - "/usr/lib/uml/port-helper", NULL };
> + OS_LIB_PATH "/uml/port-helper", NULL };
> struct port_pre_exec_data data;
>
> new = accept(fd, NULL, 0);
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-20 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-20 6:26 [PATCH] Don't hardcode path as it is architecture dependent Ritesh Raj Sarraf
2018-09-20 19:05 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).