From: Bjorn Helgaas <helgaas@kernel.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-block@vger.kernel.org,
"Stephen Bates" <sbates@raithlin.com>,
"Christoph Hellwig" <hch@lst.de>,
"Keith Busch" <keith.busch@intel.com>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jason Gunthorpe" <jgg@mellanox.com>,
"Max Gurtovoy" <maxg@mellanox.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Christian König" <christian.koenig@amd.com>,
"Jens Axboe" <axboe@kernel.dk>
Subject: Re: [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory
Date: Thu, 20 Sep 2018 17:38:29 -0500 [thread overview]
Message-ID: <20180920223829.GD224714@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180913001156.4115-2-logang@deltatee.com>
On Wed, Sep 12, 2018 at 06:11:44PM -0600, Logan Gunthorpe wrote:
> Some PCI devices may have memory mapped in a BAR space that's
> intended for use in peer-to-peer transactions. In order to enable
> such transactions the memory must be registered with ZONE_DEVICE pages
> so it can be used by DMA interfaces in existing drivers.
>
> Add an interface for other subsystems to find and allocate chunks of P2P
> memory as necessary to facilitate transfers between two PCI peers:
>
> int pci_p2pdma_add_client();
> struct pci_dev *pci_p2pmem_find();
> void *pci_alloc_p2pmem();
>
> The new interface requires a driver to collect a list of client devices
> involved in the transaction with the pci_p2pmem_add_client*() functions
> then call pci_p2pmem_find() to obtain any suitable P2P memory. Once
> this is done the list is bound to the memory and the calling driver is
> free to add and remove clients as necessary (adding incompatible clients
> will fail). With a suitable p2pmem device, memory can then be
> allocated with pci_alloc_p2pmem() for use in DMA transactions.
>
> Depending on hardware, using peer-to-peer memory may reduce the bandwidth
> of the transfer but can significantly reduce pressure on system memory.
> This may be desirable in many cases: for example a system could be designed
> with a small CPU connected to a PCIe switch by a small number of lanes
> which would maximize the number of lanes available to connect to NVMe
> devices.
>
> The code is designed to only utilize the p2pmem device if all the devices
> involved in a transfer are behind the same PCI bridge. This is because we
> have no way of knowing whether peer-to-peer routing between PCIe Root Ports
> is supported (PCIe r4.0, sec 1.3.1). Additionally, the benefits of P2P
> transfers that go through the RC is limited to only reducing DRAM usage
> and, in some cases, coding convenience. The PCI-SIG may be exploring
> adding a new capability bit to advertise whether this is possible for
> future hardware.
>
> This commit includes significant rework and feedback from Christoph
> Hellwig.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> # PCI pieces
Mostly trivial comments below. Thanks for persevering with this!
> ---
> drivers/pci/Kconfig | 17 +
> drivers/pci/Makefile | 1 +
> drivers/pci/p2pdma.c | 761 +++++++++++++++++++++++++++++++++++++
> include/linux/memremap.h | 5 +
> include/linux/mm.h | 18 +
> include/linux/pci-p2pdma.h | 102 +++++
> include/linux/pci.h | 4 +
> 7 files changed, 908 insertions(+)
> create mode 100644 drivers/pci/p2pdma.c
> create mode 100644 include/linux/pci-p2pdma.h
> +#define pr_fmt(fmt) "pci-p2pdma: " fmt
Is pr_fmt() actually used anywhere?
> + * Check if a PCI bridge has it's ACS redirection bits set to redirect P2P
s/it's/its/
> + * TLPs upstream via ACS. Returns 1 if the packets will be redirected
> + * upstream, 0 otherwise.
> + */
> +static int pci_bridge_has_acs_redir(struct pci_dev *dev)
Most of your code uses "pdev" for a struct pci_dev *.
> +static void seq_buf_print_bus_devfn(struct seq_buf *buf, struct pci_dev *dev)
> +{
> + if (!buf)
> + return;
> +
> + seq_buf_printf(buf, "%04x:%02x:%02x.%x;", pci_domain_nr(dev->bus),
> + dev->bus->number, PCI_SLOT(dev->devfn),
> + PCI_FUNC(dev->devfn));
dev vs pdev?
I think you could use pci_name() here (see pci_setup_device()).
> + * In the case where two devices are connected to different PCIe switches,
> + * this function will still return a positive distance as long as both
> + * switches evenutally have a common upstream bridge. Note this covers
s/evenutally/eventually/
> +static int upstream_bridge_distance_warn(struct pci_dev *provider,
> + struct pci_dev *client)
> +{
> + struct seq_buf acs_list;
> + int ret;
> +
> + seq_buf_init(&acs_list, kmalloc(PAGE_SIZE, GFP_KERNEL), PAGE_SIZE);
Check for kmalloc() failure here? Failure would mean acs_list->buffer is
NULL, but I gave up following the chain to see how that would be handled.
> +
> + ret = upstream_bridge_distance(provider, client, &acs_list);
> + if (ret == -2) {
> + pci_warn(client, "cannot be used for peer-to-peer DMA as ACS redirect is set between the client and provider\n");
Maybe include pci_name(provider) in these messages?
> + /* Drop final semicolon */
> + acs_list.buffer[acs_list.len-1] = 0;
> + pci_warn(client, "to disable ACS redirect for this path, add the kernel parameter: pci=disable_acs_redir=%s\n",
> + acs_list.buffer);
> +
> + } else if (ret < 0) {
> + pci_warn(client, "cannot be used for peer-to-peer DMA as the client and provider do not share an upstream bridge\n");
> + * pci_p2pdma_assign_provider - Check compatibily (as per pci_p2pdma_distance)
s/compatibily/compatibility/
> +struct pci_dev *pci_p2pmem_find(struct list_head *clients)
> +{
> + struct pci_dev *pdev = NULL;
> + struct pci_p2pdma_client *pos;
> + int distance;
> + int closest_distance = INT_MAX;
> + struct pci_dev **closest_pdevs;
> + int dev_cnt = 0;
> + const int max_devs = PAGE_SIZE / sizeof(*closest_pdevs);
> + int i;
> +
> + closest_pdevs = kmalloc(PAGE_SIZE, GFP_KERNEL);
Check for kmalloc() failure?
> +++ b/include/linux/pci-p2pdma.h
> @@ -0,0 +1,102 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * PCI Peer 2 Peer DMA support.
> + *
> + * Copyright (c) 2016-2018, Logan Gunthorpe
> + * Copyright (c) 2016-2017, Microsemi Corporation
> + * Copyright (c) 2017, Christoph Hellwig
> + * Copyright (c) 2018, Eideticom Inc.
> + *
Spurious blank line.
> + */
next prev parent reply other threads:[~2018-09-20 22:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 0:11 [PATCH v6 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory Logan Gunthorpe
2018-09-20 22:38 ` Bjorn Helgaas [this message]
2018-09-20 22:47 ` Logan Gunthorpe
2018-09-21 13:00 ` Bjorn Helgaas
2018-09-21 15:37 ` Logan Gunthorpe
2018-09-21 16:05 ` Christoph Hellwig
2018-09-13 0:11 ` [PATCH v6 02/13] PCI/P2PDMA: Add sysfs group to display p2pmem stats Logan Gunthorpe
2018-09-21 13:07 ` Bjorn Helgaas
2018-09-13 0:11 ` [PATCH v6 03/13] PCI/P2PDMA: Add PCI p2pmem DMA mappings to adjust the bus offset Logan Gunthorpe
2018-09-21 13:15 ` Bjorn Helgaas
2018-09-21 16:48 ` Bjorn Helgaas
2018-09-21 18:13 ` Logan Gunthorpe
2018-09-21 20:00 ` Bjorn Helgaas
2018-09-21 20:01 ` Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 04/13] PCI/P2PDMA: Introduce configfs/sysfs enable attribute helpers Logan Gunthorpe
2018-09-21 16:18 ` Bjorn Helgaas
2018-09-21 19:44 ` Logan Gunthorpe
2018-09-21 21:12 ` Logan Gunthorpe
2018-09-24 22:39 ` Bjorn Helgaas
2018-09-13 0:11 ` [PATCH v6 05/13] docs-rst: Add a new directory for PCI documentation Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 06/13] PCI/P2PDMA: Add P2P DMA driver writer's documentation Logan Gunthorpe
2018-09-21 16:41 ` Bjorn Helgaas
2018-09-21 18:03 ` Logan Gunthorpe
2018-09-21 19:47 ` Bjorn Helgaas
2018-09-13 0:11 ` [PATCH v6 07/13] block: Add PCI P2P flag for request queue and check support for requests Logan Gunthorpe
2018-09-13 0:28 ` Jens Axboe
2018-09-13 16:14 ` Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 08/13] IB/core: Ensure we map P2P memory correctly in rdma_rw_ctx_[init|destroy]() Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 09/13] nvme-pci: Use PCI p2pmem subsystem to manage the CMB Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 10/13] nvme-pci: Add support for P2P memory in requests Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 11/13] nvme-pci: Add a quirk for a pseudo CMB Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 12/13] nvmet: Introduce helper functions to allocate and free request SGLs Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 13/13] nvmet: Optionally use PCI P2P memory Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920223829.GD224714@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).