From: Bjorn Helgaas <helgaas@kernel.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-block@vger.kernel.org,
"Stephen Bates" <sbates@raithlin.com>,
"Christoph Hellwig" <hch@lst.de>,
"Keith Busch" <keith.busch@intel.com>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jason Gunthorpe" <jgg@mellanox.com>,
"Max Gurtovoy" <maxg@mellanox.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Christian König" <christian.koenig@amd.com>,
"Jens Axboe" <axboe@kernel.dk>
Subject: Re: [PATCH v6 02/13] PCI/P2PDMA: Add sysfs group to display p2pmem stats
Date: Fri, 21 Sep 2018 08:07:05 -0500 [thread overview]
Message-ID: <20180921130705.GF224714@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180913001156.4115-3-logang@deltatee.com>
On Wed, Sep 12, 2018 at 06:11:45PM -0600, Logan Gunthorpe wrote:
> Add a sysfs group to display statistics about P2P memory that is
> registered in each PCI device.
>
> Attributes in the group display the total amount of P2P memory, the
> amount available and whether it is published or not.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> +What: /sys/bus/pci/devices/.../p2pmem/available
> +Date: November 2017
> +Contact: Logan Gunthorpe <logang@deltatee.com>
> +Description:
> + If the device has any Peer-to-Peer memory registered, this
> + file contains the amount of memory that has not been
> + allocated (in decimal).
> +
> +What: /sys/bus/pci/devices/.../p2pmem/size
> +Date: November 2017
> +Contact: Logan Gunthorpe <logang@deltatee.com>
> +Description:
> + If the device has any Peer-to-Peer memory registered, this
> + file contains the total amount of memory that the device
> + provides (in decimal).
Maybe reorder this so the "size" (total amount) is documented before
"available" (some subset of "size")?
> +
> +What: /sys/bus/pci/devices/.../p2pmem/published
> +Date: November 2017
> +Contact: Logan Gunthorpe <logang@deltatee.com>
> +Description:
> + If the device has any Peer-to-Peer memory registered, this
> + file contains a '1' if the memory has been published for
> + use inside the kernel or a '0' if it is only intended
> + for use within the driver that published it.
It doesn't read quite right to talk about "use within the driver that
*published* it". Is it really published in that case? That sounds more
like "private". I expected something like the following (but I don't claim
to understand the whole use model here):
... this file contains a '1' if the memory has been published for use
outside the driver that owns the device.
next prev parent reply other threads:[~2018-09-21 13:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 0:11 [PATCH v6 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 01/13] PCI/P2PDMA: Support peer-to-peer memory Logan Gunthorpe
2018-09-20 22:38 ` Bjorn Helgaas
2018-09-20 22:47 ` Logan Gunthorpe
2018-09-21 13:00 ` Bjorn Helgaas
2018-09-21 15:37 ` Logan Gunthorpe
2018-09-21 16:05 ` Christoph Hellwig
2018-09-13 0:11 ` [PATCH v6 02/13] PCI/P2PDMA: Add sysfs group to display p2pmem stats Logan Gunthorpe
2018-09-21 13:07 ` Bjorn Helgaas [this message]
2018-09-13 0:11 ` [PATCH v6 03/13] PCI/P2PDMA: Add PCI p2pmem DMA mappings to adjust the bus offset Logan Gunthorpe
2018-09-21 13:15 ` Bjorn Helgaas
2018-09-21 16:48 ` Bjorn Helgaas
2018-09-21 18:13 ` Logan Gunthorpe
2018-09-21 20:00 ` Bjorn Helgaas
2018-09-21 20:01 ` Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 04/13] PCI/P2PDMA: Introduce configfs/sysfs enable attribute helpers Logan Gunthorpe
2018-09-21 16:18 ` Bjorn Helgaas
2018-09-21 19:44 ` Logan Gunthorpe
2018-09-21 21:12 ` Logan Gunthorpe
2018-09-24 22:39 ` Bjorn Helgaas
2018-09-13 0:11 ` [PATCH v6 05/13] docs-rst: Add a new directory for PCI documentation Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 06/13] PCI/P2PDMA: Add P2P DMA driver writer's documentation Logan Gunthorpe
2018-09-21 16:41 ` Bjorn Helgaas
2018-09-21 18:03 ` Logan Gunthorpe
2018-09-21 19:47 ` Bjorn Helgaas
2018-09-13 0:11 ` [PATCH v6 07/13] block: Add PCI P2P flag for request queue and check support for requests Logan Gunthorpe
2018-09-13 0:28 ` Jens Axboe
2018-09-13 16:14 ` Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 08/13] IB/core: Ensure we map P2P memory correctly in rdma_rw_ctx_[init|destroy]() Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 09/13] nvme-pci: Use PCI p2pmem subsystem to manage the CMB Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 10/13] nvme-pci: Add support for P2P memory in requests Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 11/13] nvme-pci: Add a quirk for a pseudo CMB Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 12/13] nvmet: Introduce helper functions to allocate and free request SGLs Logan Gunthorpe
2018-09-13 0:11 ` [PATCH v6 13/13] nvmet: Optionally use PCI P2P memory Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921130705.GF224714@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).