linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] perf/x86/intel/uncore: Use boot_cpu_data.logical_proc_id as the pkg id
@ 2018-09-21  1:07 Masayoshi Mizuma
  2018-09-21 12:33 ` Liang, Kan
  0 siblings, 1 reply; 2+ messages in thread
From: Masayoshi Mizuma @ 2018-09-21  1:07 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, Kan Liang
  Cc: Masayoshi Mizuma, Masayoshi Mizuma, linux-kernel

From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

Physical package id 0 is not always exists. We should use
boot_cpu_data.logical_proc_id directly as the pkg id here.

Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
---
 arch/x86/events/intel/uncore_snbep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 51d7c11..edaadac 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -3061,7 +3061,7 @@ static struct event_constraint bdx_uncore_pcu_constraints[] = {
 
 void bdx_uncore_cpu_init(void)
 {
-	int pkg = topology_phys_to_logical_pkg(0);
+	int pkg = boot_cpu_data.logical_proc_id;
 
 	if (bdx_uncore_cbox.num_boxes > boot_cpu_data.x86_max_cores)
 		bdx_uncore_cbox.num_boxes = boot_cpu_data.x86_max_cores;
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] perf/x86/intel/uncore: Use boot_cpu_data.logical_proc_id as the pkg id
  2018-09-21  1:07 [PATCH v2] perf/x86/intel/uncore: Use boot_cpu_data.logical_proc_id as the pkg id Masayoshi Mizuma
@ 2018-09-21 12:33 ` Liang, Kan
  0 siblings, 0 replies; 2+ messages in thread
From: Liang, Kan @ 2018-09-21 12:33 UTC (permalink / raw)
  To: Masayoshi Mizuma, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86
  Cc: Masayoshi Mizuma, linux-kernel



On 9/20/2018 9:07 PM, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> 
> Physical package id 0 is not always exists. We should use
> boot_cpu_data.logical_proc_id directly as the pkg id here.
> 
> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan
> ---
>   arch/x86/events/intel/uncore_snbep.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
> index 51d7c11..edaadac 100644
> --- a/arch/x86/events/intel/uncore_snbep.c
> +++ b/arch/x86/events/intel/uncore_snbep.c
> @@ -3061,7 +3061,7 @@ static struct event_constraint bdx_uncore_pcu_constraints[] = {
>   
>   void bdx_uncore_cpu_init(void)
>   {
> -	int pkg = topology_phys_to_logical_pkg(0);
> +	int pkg = boot_cpu_data.logical_proc_id;
>   
>   	if (bdx_uncore_cbox.num_boxes > boot_cpu_data.x86_max_cores)
>   		bdx_uncore_cbox.num_boxes = boot_cpu_data.x86_max_cores;
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-21 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21  1:07 [PATCH v2] perf/x86/intel/uncore: Use boot_cpu_data.logical_proc_id as the pkg id Masayoshi Mizuma
2018-09-21 12:33 ` Liang, Kan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).