From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <platform-driver-x86@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Feuerer <peter@piie.net>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Subject: [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling
Date: Thu, 20 Sep 2018 21:44:15 -0400 [thread overview]
Message-ID: <20180921014421.30804-1-paul.gortmaker@windriver.com> (raw)
I came across this older netbook over the xmas holidays, and noticed the
acerhdf driver wouldn't load. Turns out the BIOS string was too new,
and not listed in the driver. There were module params for overrides,
but I found their use isn't quite clear without reading the source.
Here I clarify some of the module parameter usage, and then add the new
BIOS string, so they won't be needed for this particular platform. Some
probe code is also shifted out to be __init to reduce the driver size a
bit. Further details can be found in the respective commit logs.
Since it was months ago when I created these patches, I retested on top
of tree to ensure things still work, as can be seen below.
root@gw:~# cat /proc/version
Linux version 4.19.0-rc4+ (paul@host) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)) #1 SMP Thu Sep 20 18:47:15 EDT 2018
root@gw:~# modprobe acerhdf
root@gw:~# dmesg|tail -n3
acerhdf: Acer Aspire One Fan driver, v.0.7.0
acerhdf: Fan control off, to enable do:
acerhdf: echo -n "enabled" > /sys/class/thermal/thermal_zoneN/mode # N=0,1,2...
root@gw:~# lsmod
Module Size Used by
acerhdf 16384 0
root@gw:~#
Paul.
---
Cc: Peter Feuerer <peter@piie.net>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Paul Gortmaker (6):
platform/x86: acerhdf: clarify modinfo messages for BIOS override
platform/x86: acerhdf: Enable ability to list supported systems
platform/x86: acerhdf: Remove cut-and-paste trap from instructions
platform/x86: acerhdf: Add BIOS entry for Gateway LT31 v1.3307
platform/x86: acerhdf: mark appropriate content with __init prefix
platform/x86: acerhdf: restructure to allow large BIOS table be __initconst
drivers/platform/x86/Kconfig | 5 +++-
drivers/platform/x86/acerhdf.c | 68 ++++++++++++++++++++++++++++++------------
2 files changed, 53 insertions(+), 20 deletions(-)
--
2.15.0
next reply other threads:[~2018-09-21 1:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 1:44 Paul Gortmaker [this message]
2018-09-21 1:44 ` [PATCH 1/6] platform/x86: acerhdf: clarify modinfo messages for BIOS override Paul Gortmaker
2018-09-21 1:44 ` [PATCH 2/6] platform/x86: acerhdf: Enable ability to list supported systems Paul Gortmaker
2018-09-21 1:44 ` [PATCH 3/6] platform/x86: acerhdf: Remove cut-and-paste trap from instructions Paul Gortmaker
2018-09-21 1:44 ` [PATCH 4/6] platform/x86: acerhdf: Add BIOS entry for Gateway LT31 v1.3307 Paul Gortmaker
2018-09-21 1:44 ` [PATCH 5/6] platform/x86: acerhdf: mark appropriate content with __init prefix Paul Gortmaker
2018-09-21 1:44 ` [PATCH 6/6] platform/x86: acerhdf: restructure to allow large BIOS table be __initconst Paul Gortmaker
2018-09-21 6:20 ` [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling Peter Feuerer
2018-09-26 11:09 ` Andy Shevchenko
2018-09-26 11:13 ` Andy Shevchenko
2018-09-26 14:11 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921014421.30804-1-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).