From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <platform-driver-x86@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Feuerer <peter@piie.net>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Subject: [PATCH 3/6] platform/x86: acerhdf: Remove cut-and-paste trap from instructions
Date: Thu, 20 Sep 2018 21:44:18 -0400 [thread overview]
Message-ID: <20180921014421.30804-4-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20180921014421.30804-1-paul.gortmaker@windriver.com>
Just like we avoid specifying actual block devices like sda for fdisk
and dd examples, we should not specify specific thermal zones here.
On the platform I was testing on, zone0 was acpitz, and zone1 was for
this acerhdf driver. Make the printk such that it won't work with a
blind cut-and-paste, and force the user to determine which zone is
correct for this driver.
Cc: Peter Feuerer <peter@piie.net>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/platform/x86/Kconfig | 5 ++++-
drivers/platform/x86/acerhdf.c | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 0c1aa6c314f5..1fca33c97e8a 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -60,7 +60,10 @@ config ACERHDF
After loading this driver the BIOS is still in control of the fan.
To let the kernel handle the fan, do:
- echo -n enabled > /sys/class/thermal/thermal_zone0/mode
+ echo -n enabled > /sys/class/thermal/thermal_zoneN/mode
+ where N=0,1,2... depending on the number of thermal nodes and the
+ detection order of your particular system. The "type" parameter
+ in the same node directory will tell you if it is "acerhdf".
For more information about this driver see
<http://piie.net/files/acerhdf_README.txt>
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 2735815c73c5..fef3b727bc24 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -688,7 +688,7 @@ static int acerhdf_check_hardware(void)
*/
if (!kernelmode) {
pr_notice("Fan control off, to enable do:\n");
- pr_notice("echo -n \"enabled\" > /sys/class/thermal/thermal_zone0/mode\n");
+ pr_notice("echo -n \"enabled\" > /sys/class/thermal/thermal_zoneN/mode # N=0,1,2...\n");
}
return 0;
--
2.15.0
next prev parent reply other threads:[~2018-09-21 1:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 1:44 [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling Paul Gortmaker
2018-09-21 1:44 ` [PATCH 1/6] platform/x86: acerhdf: clarify modinfo messages for BIOS override Paul Gortmaker
2018-09-21 1:44 ` [PATCH 2/6] platform/x86: acerhdf: Enable ability to list supported systems Paul Gortmaker
2018-09-21 1:44 ` Paul Gortmaker [this message]
2018-09-21 1:44 ` [PATCH 4/6] platform/x86: acerhdf: Add BIOS entry for Gateway LT31 v1.3307 Paul Gortmaker
2018-09-21 1:44 ` [PATCH 5/6] platform/x86: acerhdf: mark appropriate content with __init prefix Paul Gortmaker
2018-09-21 1:44 ` [PATCH 6/6] platform/x86: acerhdf: restructure to allow large BIOS table be __initconst Paul Gortmaker
2018-09-21 6:20 ` [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling Peter Feuerer
2018-09-26 11:09 ` Andy Shevchenko
2018-09-26 11:13 ` Andy Shevchenko
2018-09-26 14:11 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921014421.30804-4-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).