* [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c
@ 2018-09-21 10:24 zhong jiang
2018-09-21 16:22 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: zhong jiang @ 2018-09-21 10:24 UTC (permalink / raw)
To: broonie; +Cc: perex, bgoswami, tiwai, linux-kernel
We include wait.h twice in q6adm.c. it is unnecessary. hence remove
it. Further, order the include files as alphabet.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
sound/soc/qcom/qdsp6/q6adm.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c
index 932c3eb..da24251 100644
--- a/sound/soc/qcom/qdsp6/q6adm.c
+++ b/sound/soc/qcom/qdsp6/q6adm.c
@@ -2,25 +2,24 @@
// Copyright (c) 2011-2017, The Linux Foundation. All rights reserved.
// Copyright (c) 2018, Linaro Limited
-#include <linux/slab.h>
-#include <linux/wait.h>
-#include <linux/kernel.h>
#include <linux/device.h>
-#include <linux/module.h>
-#include <linux/sched.h>
#include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/kref.h>
+#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_platform.h>
-#include <linux/kref.h>
-#include <linux/wait.h>
-#include <linux/soc/qcom/apr.h>
#include <linux/platform_device.h>
+#include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/soc/qcom/apr.h>
+#include <linux/wait.h>
#include <sound/asound.h>
#include "q6adm.h"
#include "q6afe.h"
#include "q6core.h"
-#include "q6dsp-errno.h"
#include "q6dsp-common.h"
+#include "q6dsp-errno.h"
#define ADM_CMD_DEVICE_OPEN_V5 0x00010326
#define ADM_CMDRSP_DEVICE_OPEN_V5 0x00010329
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c
2018-09-21 10:24 [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c zhong jiang
@ 2018-09-21 16:22 ` Mark Brown
2018-09-25 8:56 ` zhong jiang
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2018-09-21 16:22 UTC (permalink / raw)
To: zhong jiang; +Cc: perex, bgoswami, tiwai, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
On Fri, Sep 21, 2018 at 06:24:58PM +0800, zhong jiang wrote:
> We include wait.h twice in q6adm.c. it is unnecessary. hence remove
> it. Further, order the include files as alphabet.
Please use subject lines matching the style for the subsystem. This
makes it easier for people to identify relevant patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c
2018-09-21 16:22 ` Mark Brown
@ 2018-09-25 8:56 ` zhong jiang
0 siblings, 0 replies; 3+ messages in thread
From: zhong jiang @ 2018-09-25 8:56 UTC (permalink / raw)
To: Mark Brown; +Cc: perex, bgoswami, tiwai, linux-kernel
On 2018/9/22 0:22, Mark Brown wrote:
> On Fri, Sep 21, 2018 at 06:24:58PM +0800, zhong jiang wrote:
>> We include wait.h twice in q6adm.c. it is unnecessary. hence remove
>> it. Further, order the include files as alphabet.
> Please use subject lines matching the style for the subsystem. This
> makes it easier for people to identify relevant patches.
Get it . Will notice . thanks
Sincerely,
zhong jiang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-25 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21 10:24 [PATCH] soc: qcom: qdsp6: remove duplicated include from q6adm.c zhong jiang
2018-09-21 16:22 ` Mark Brown
2018-09-25 8:56 ` zhong jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).