From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
rteysseyre@gmail.com,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger
Date: Fri, 21 Sep 2018 23:17:58 +0200 [thread overview]
Message-ID: <20180921211758.GC18062@amd> (raw)
In-Reply-To: <324778a9-a32c-ae6e-337a-39845f214bfc@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1979 bytes --]
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote:
> Hi Baolin,
>
> On 09/21/2018 05:31 AM, Baolin Wang wrote:
> > Hi Jacek and Pavel,
> >
> > On 11 September 2018 at 10:47, Baolin Wang <baolin.wang@linaro.org> wrote:
> >> This patch adds one new led trigger that LED device can configure
> >> the software or hardware pattern and trigger it.
> >>
> >> Consumers can write 'pattern' file to enable the software pattern
> >> which alters the brightness for the specified duration with one
> >> software timer.
> >>
> >> Moreover consumers can write 'hw_pattern' file to enable the hardware
> >> pattern for some LED controllers which can autonomously control
> >> brightness over time, according to some preprogrammed hardware
> >> patterns.
> >>
> >> Signed-off-by: Raphael Teysseyre <rteysseyre@gmail.com>
> >> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> > Do you have any comments for the v12 patch set? Thanks.
>
> We will probably have to remove hw_pattern from ledtrig-pattern
> since we are unable to come up with generic interface for it.
> Unless thread [0] will end up with some brilliant ideas. So far
> we're waiting for Pavel's reply.
>
> [0] https://lkml.org/lkml/2018/9/13/1216
To paint a picture:
brightness
rise hold lower hold down
^ XXXXXXXXXXXXXXX
| X XX
| X XX
| X XXXXXXXXXXXXXXXXXXXXXXXXXX
+-------------------------------------------------------> time
This is what Baolin's hardware can do, right?
This is also what pattern trigger can do, right?
So all we need to do is match the two interfaces, so that hw_pattern
returns -EINVAL on patterns hardware can not actually do.
I believe I described code to do that in [0] above.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-09-21 21:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 2:47 [PATCH v12 1/2] leds: core: Introduce LED pattern trigger Baolin Wang
2018-09-11 2:47 ` [PATCH v12 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Baolin Wang
2018-09-21 3:31 ` [PATCH v12 1/2] leds: core: Introduce LED pattern trigger Baolin Wang
2018-09-21 20:59 ` Jacek Anaszewski
2018-09-21 21:04 ` Pavel Machek
2018-09-21 21:12 ` Pavel Machek
2018-09-21 21:17 ` Pavel Machek [this message]
2018-09-21 22:11 ` Jacek Anaszewski
2018-09-21 22:18 ` Pavel Machek
2018-09-22 3:30 ` Baolin Wang
2018-09-22 19:44 ` Pavel Machek
2018-09-23 12:25 ` Jacek Anaszewski
2018-09-25 11:15 ` Baolin Wang
2018-09-25 20:00 ` Jacek Anaszewski
2018-09-26 3:13 ` Baolin Wang
2018-09-27 21:47 ` Pavel Machek
2018-09-24 23:54 ` Bjorn Andersson
2018-09-25 11:24 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921211758.GC18062@amd \
--to=pavel@ucw.cz \
--cc=baolin.wang@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).