From: Baolin Wang <baolin.wang@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
rteysseyre@gmail.com, Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger
Date: Tue, 25 Sep 2018 19:24:03 +0800 [thread overview]
Message-ID: <CAMz4kuL-MeTuYjADGU+ajczwtnidQ54wEgctBQN_PC28-7gszQ@mail.gmail.com> (raw)
In-Reply-To: <20180924235452.GI2523@minitux>
On 25 September 2018 at 07:54, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> On Mon 10 Sep 19:47 PDT 2018, Baolin Wang wrote:
> [..]
>> diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern
> [..]
>> +What: /sys/class/leds/<led>/hw_pattern
>> +Date: September 2018
>> +KernelVersion: 4.20
>> +Description:
>> + Specify a hardware pattern for the LED, for LED hardware that
>> + supports autonomously controlling brightness over time, according
>> + to some preprogrammed hardware patterns.
>> +
>> + Since different LED hardware can have different semantics of
>> + hardware patterns, each driver is expected to provide its own
>> + description for the hardware patterns in their ABI documentation
>> + file.
>> +
>> +What: /sys/class/leds/<led>/repeat
>> +Date: September 2018
>> +KernelVersion: 4.20
>> +Description:
>> + Specify a pattern repeat number. -1 means repeat indefinitely,
>> + other negative numbers and number 0 are invalid.
>> +
>> + This file will always return the originally written repeat
>> + number.
>
> This captures the infinite case much better, thanks!
>
> Given that 0 is described as invalid, does this imply that setting a new
> pattern the repeat will be disabled? And hence if my hardware supports
> only infinite or no-repeat setting a new pattern is the way to disable
> further repeats (rather than just setting repeat = 0)?
It won't. A new pattern setting will not affect your infinite or
no-repeat setting.
> Regardless, I believe the semantics of these two files will work fine
> for my Qualcomm LPG driver.
Thanks.
--
Baolin Wang
Best Regards
prev parent reply other threads:[~2018-09-25 11:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 2:47 [PATCH v12 1/2] leds: core: Introduce LED pattern trigger Baolin Wang
2018-09-11 2:47 ` [PATCH v12 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Baolin Wang
2018-09-21 3:31 ` [PATCH v12 1/2] leds: core: Introduce LED pattern trigger Baolin Wang
2018-09-21 20:59 ` Jacek Anaszewski
2018-09-21 21:04 ` Pavel Machek
2018-09-21 21:12 ` Pavel Machek
2018-09-21 21:17 ` Pavel Machek
2018-09-21 22:11 ` Jacek Anaszewski
2018-09-21 22:18 ` Pavel Machek
2018-09-22 3:30 ` Baolin Wang
2018-09-22 19:44 ` Pavel Machek
2018-09-23 12:25 ` Jacek Anaszewski
2018-09-25 11:15 ` Baolin Wang
2018-09-25 20:00 ` Jacek Anaszewski
2018-09-26 3:13 ` Baolin Wang
2018-09-27 21:47 ` Pavel Machek
2018-09-24 23:54 ` Bjorn Andersson
2018-09-25 11:24 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuL-MeTuYjADGU+ajczwtnidQ54wEgctBQN_PC28-7gszQ@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).