* [RFT] arm64: ARM: dts: exynos: Remove double SD card detect pin inversion on TM2
@ 2018-09-21 18:30 ` Krzysztof Kozlowski
2018-09-24 7:41 ` Marek Szyprowski
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2018-09-21 18:30 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Chanwoo Choi
The SDHCI standard, MMC host controller bindings and MMC core defines
card detect pin as active low. Therefore there is no point to invert it
twice.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index a1e3194b7483..86d8ddc3288a 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -939,8 +939,7 @@
status = "okay";
cap-sd-highspeed;
disable-wp;
- cd-gpios = <&gpa2 4 GPIO_ACTIVE_HIGH>;
- cd-inverted;
+ cd-gpios = <&gpa2 4 GPIO_ACTIVE_LOW>;
card-detect-delay = <200>;
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-sdr-timing = <0 4>;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFT] arm64: ARM: dts: exynos: Remove double SD card detect pin inversion on TM2
2018-09-21 18:30 ` [RFT] arm64: ARM: dts: exynos: Remove double SD card detect pin inversion on TM2 Krzysztof Kozlowski
@ 2018-09-24 7:41 ` Marek Szyprowski
0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2018-09-24 7:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz, Chanwoo Choi
Hi Krzysztof,
On 2018-09-21 20:30, Krzysztof Kozlowski wrote:
> The SDHCI standard, MMC host controller bindings and MMC core defines
> card detect pin as active low. Therefore there is no point to invert it
> twice.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Works fine on TM2 and TM2e. However I'm not sure if it makes sense to
refer to the SDHCI standard, as Exynos5433 has only DWMMC host controllers.
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index a1e3194b7483..86d8ddc3288a 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -939,8 +939,7 @@
> status = "okay";
> cap-sd-highspeed;
> disable-wp;
> - cd-gpios = <&gpa2 4 GPIO_ACTIVE_HIGH>;
> - cd-inverted;
> + cd-gpios = <&gpa2 4 GPIO_ACTIVE_LOW>;
> card-detect-delay = <200>;
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <0 4>;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-24 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180921183024epcas2p3bef08b81273524ec9d7afef4875bb746@epcas2p3.samsung.com>
2018-09-21 18:30 ` [RFT] arm64: ARM: dts: exynos: Remove double SD card detect pin inversion on TM2 Krzysztof Kozlowski
2018-09-24 7:41 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).