* [PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio
@ 2018-09-24 17:29 Andreas Kemnade
2018-09-24 22:11 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2018-09-24 17:29 UTC (permalink / raw)
To: Benoît Cousson, Tony Lindgren, Rob Herring, Mark Rutland,
linux-omap, devicetree, linux-kernel,
Discussions about the Letux Kernel
Cc: Andreas Kemnade
Pullup and down settings were missing, so add them to avoid
floating pins and make headset detection working.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/omap3-gta04.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 09e45e7ad4bc..6bcb459c1b20 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -657,6 +657,19 @@
status = "disabled";
};
+#define BIT(x) (1 << (x))
+&twl_gpio {
+ /* pullups: BIT(2) */
+ ti,pullups = <BIT(2)>;
+ /*
+ * pulldowns:
+ * BIT(0), BIT(1), BIT(6), BIT(7), BIT(8), BIT(13)
+ * BIT(15), BIT(16), BIT(17)
+ */
+ ti,pulldowns = <(BIT(0) | BIT(1) | BIT(6) | BIT(7) | BIT(8) |
+ BIT(13) | BIT(15) | BIT(16) | BIT(17))>;
+};
+
&twl_keypad {
status = "disabled";
};
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio
2018-09-24 17:29 [PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio Andreas Kemnade
@ 2018-09-24 22:11 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2018-09-24 22:11 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Benoît Cousson, Rob Herring, Mark Rutland, linux-omap,
devicetree, linux-kernel, Discussions about the Letux Kernel
* Andreas Kemnade <andreas@kemnade.info> [180924 10:34]:
> Pullup and down settings were missing, so add them to avoid
> floating pins and make headset detection working.
Applying into omap-for-v4.20/dt thanks.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-24 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-24 17:29 [PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio Andreas Kemnade
2018-09-24 22:11 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).