* [PATCH] pinctrl: paris: fix check on EINT_NA comparison
@ 2018-09-25 13:21 Colin King
2018-09-25 14:58 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-09-25 13:21 UTC (permalink / raw)
To: Linus Walleij, Matthias Brugger, Sean Wang, linux-gpio,
linux-arm-kernel, linux-mediatek
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently, the check on desc->eint.eint_n == EINT_NA is always false
because this is comparing a u16 to -1 which can never be true. Fix
this by casting EINT_NA to u16.
Fixes: fb5fa8dc151b ("pinctrl: mediatek: extend struct mtk_pin_desc to pinctrl-mtk-common-v2.c")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pinctrl/mediatek/pinctrl-paris.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
index 4cf0fea30b7d..77d380145dfd 100644
--- a/drivers/pinctrl/mediatek/pinctrl-paris.c
+++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
@@ -729,7 +729,7 @@ static int mtk_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
desc = (const struct mtk_pin_desc *)&hw->soc->pins[offset];
- if (desc->eint.eint_n == EINT_NA)
+ if (desc->eint.eint_n == (u16)EINT_NA)
return -ENOTSUPP;
return mtk_eint_find_irq(hw->eint, desc->eint.eint_n);
@@ -746,7 +746,7 @@ static int mtk_gpio_set_config(struct gpio_chip *chip, unsigned int offset,
if (!hw->eint ||
pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE ||
- desc->eint.eint_n == EINT_NA)
+ desc->eint.eint_n == (u16)EINT_NA)
return -ENOTSUPP;
debounce = pinconf_to_config_argument(config);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: paris: fix check on EINT_NA comparison
2018-09-25 13:21 [PATCH] pinctrl: paris: fix check on EINT_NA comparison Colin King
@ 2018-09-25 14:58 ` Dan Carpenter
2018-09-25 15:02 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2018-09-25 14:58 UTC (permalink / raw)
To: Colin King
Cc: Linus Walleij, Matthias Brugger, Sean Wang, linux-gpio,
linux-arm-kernel, linux-mediatek, kernel-janitors, linux-kernel
On Tue, Sep 25, 2018 at 02:21:30PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently, the check on desc->eint.eint_n == EINT_NA is always false
> because this is comparing a u16 to -1 which can never be true. Fix
> this by casting EINT_NA to u16.
>
> Fixes: fb5fa8dc151b ("pinctrl: mediatek: extend struct mtk_pin_desc to pinctrl-mtk-common-v2.c")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-paris.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index 4cf0fea30b7d..77d380145dfd 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -729,7 +729,7 @@ static int mtk_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
>
> desc = (const struct mtk_pin_desc *)&hw->soc->pins[offset];
>
> - if (desc->eint.eint_n == EINT_NA)
> + if (desc->eint.eint_n == (u16)EINT_NA)
Adding casts is ugly... I reported this earlier and think Sean Wang is
going to send a fix for it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: paris: fix check on EINT_NA comparison
2018-09-25 14:58 ` Dan Carpenter
@ 2018-09-25 15:02 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2018-09-25 15:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Linus Walleij, Matthias Brugger, Sean Wang, linux-gpio,
linux-arm-kernel, linux-mediatek, kernel-janitors, linux-kernel
On 25/09/18 15:58, Dan Carpenter wrote:
> On Tue, Sep 25, 2018 at 02:21:30PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently, the check on desc->eint.eint_n == EINT_NA is always false
>> because this is comparing a u16 to -1 which can never be true. Fix
>> this by casting EINT_NA to u16.
>>
>> Fixes: fb5fa8dc151b ("pinctrl: mediatek: extend struct mtk_pin_desc to pinctrl-mtk-common-v2.c")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/pinctrl/mediatek/pinctrl-paris.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
>> index 4cf0fea30b7d..77d380145dfd 100644
>> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
>> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
>> @@ -729,7 +729,7 @@ static int mtk_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
>>
>> desc = (const struct mtk_pin_desc *)&hw->soc->pins[offset];
>>
>> - if (desc->eint.eint_n == EINT_NA)
>> + if (desc->eint.eint_n == (u16)EINT_NA)
>
> Adding casts is ugly... I reported this earlier and think Sean Wang is
> going to send a fix for it.
Fair enough. Thanks for letting me know.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-25 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-25 13:21 [PATCH] pinctrl: paris: fix check on EINT_NA comparison Colin King
2018-09-25 14:58 ` Dan Carpenter
2018-09-25 15:02 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).