* [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit
@ 2018-08-29 7:08 Vincent Guittot
2018-08-30 8:46 ` Punit Agrawal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vincent Guittot @ 2018-08-29 7:08 UTC (permalink / raw)
To: robh+dt, mark.rutland, devicetree, punit.agrawal
Cc: edubezval, viresh.kumar, linux-kernel, linux-pm, Vincent Guittot
The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas
its usage in the code assumes that unit is uW/MHz/V^2
In drivers/thermal/cpu_cooling.c, the code is :
power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv;
do_div(power, 1000000000);
which can be summarized as :
power (mW) = capacitance * freq_mhz/1000 * (voltage_mv/1000)^2
or
power (mW) = (capacitance * freq_mhz * (voltage_mv/1000)^2) / 1000
then
power (mW) = power (uW) / 1000
so
power (uW) = capacitance * freq_mhz * (voltage_mv/1000)^2
Furthermore, if we test basic values like :
voltage_mv = 1000mV = 1V
freq_mhz = 1000Mhz
The minimum possible power, when dynamic-power-coefficient equals 1, will
be with current unit:
min power = 1 * 1000 * (1000000)^2 = 10^15 mW
which is not realistic
With the unit used by the code, the min power is
min power = 1 * 1000 * 1^2 = 1000uW = 1mW which is far more realistic
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
Documentation/devicetree/bindings/arm/cpus.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
index 29e1dc5..71d8cd0 100644
--- a/Documentation/devicetree/bindings/arm/cpus.txt
+++ b/Documentation/devicetree/bindings/arm/cpus.txt
@@ -274,7 +274,7 @@ described below.
Usage: optional
Value type: <prop-encoded-array>
Definition: A u32 value that represents the running time dynamic
- power coefficient in units of mW/MHz/uV^2. The
+ power coefficient in units of uW/MHz/V^2. The
coefficient can either be calculated from power
measurements or derived by analysis.
@@ -285,7 +285,7 @@ described below.
Pdyn = dynamic-power-coefficient * V^2 * f
- where voltage is in uV, frequency is in MHz.
+ where voltage is in V, frequency is in MHz.
Example 1 (dual-cluster big.LITTLE system 32-bit):
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit
2018-08-29 7:08 [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit Vincent Guittot
@ 2018-08-30 8:46 ` Punit Agrawal
2018-09-03 6:39 ` Viresh Kumar
2018-09-25 16:44 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Punit Agrawal @ 2018-08-30 8:46 UTC (permalink / raw)
To: Vincent Guittot
Cc: robh+dt, mark.rutland, devicetree, edubezval, viresh.kumar,
linux-kernel, linux-pm
Hi Vincent,
Vincent Guittot <vincent.guittot@linaro.org> writes:
> The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas
> its usage in the code assumes that unit is uW/MHz/V^2
>
> In drivers/thermal/cpu_cooling.c, the code is :
>
> power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv;
> do_div(power, 1000000000);
>
> which can be summarized as :
> power (mW) = capacitance * freq_mhz/1000 * (voltage_mv/1000)^2
> or
> power (mW) = (capacitance * freq_mhz * (voltage_mv/1000)^2) / 1000
> then
> power (mW) = power (uW) / 1000
> so
> power (uW) = capacitance * freq_mhz * (voltage_mv/1000)^2
>
> Furthermore, if we test basic values like :
> voltage_mv = 1000mV = 1V
> freq_mhz = 1000Mhz
>
> The minimum possible power, when dynamic-power-coefficient equals 1, will
> be with current unit:
> min power = 1 * 1000 * (1000000)^2 = 10^15 mW
> which is not realistic
>
> With the unit used by the code, the min power is
> min power = 1 * 1000 * 1^2 = 1000uW = 1mW which is far more realistic
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Acked-by: Punit Agrawal <punit.agrawal@arm.com>
Thanks for fixing the mismatch.
> ---
> Documentation/devicetree/bindings/arm/cpus.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
> index 29e1dc5..71d8cd0 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.txt
> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
> @@ -274,7 +274,7 @@ described below.
> Usage: optional
> Value type: <prop-encoded-array>
> Definition: A u32 value that represents the running time dynamic
> - power coefficient in units of mW/MHz/uV^2. The
> + power coefficient in units of uW/MHz/V^2. The
> coefficient can either be calculated from power
> measurements or derived by analysis.
>
> @@ -285,7 +285,7 @@ described below.
>
> Pdyn = dynamic-power-coefficient * V^2 * f
>
> - where voltage is in uV, frequency is in MHz.
> + where voltage is in V, frequency is in MHz.
>
> Example 1 (dual-cluster big.LITTLE system 32-bit):
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit
2018-08-29 7:08 [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit Vincent Guittot
2018-08-30 8:46 ` Punit Agrawal
@ 2018-09-03 6:39 ` Viresh Kumar
2018-09-25 16:44 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2018-09-03 6:39 UTC (permalink / raw)
To: Vincent Guittot
Cc: robh+dt, mark.rutland, devicetree, punit.agrawal, edubezval,
linux-kernel, linux-pm
On 29-08-18, 09:08, Vincent Guittot wrote:
> The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas
> its usage in the code assumes that unit is uW/MHz/V^2
>
> In drivers/thermal/cpu_cooling.c, the code is :
>
> power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv;
> do_div(power, 1000000000);
>
> which can be summarized as :
> power (mW) = capacitance * freq_mhz/1000 * (voltage_mv/1000)^2
> or
> power (mW) = (capacitance * freq_mhz * (voltage_mv/1000)^2) / 1000
> then
> power (mW) = power (uW) / 1000
> so
> power (uW) = capacitance * freq_mhz * (voltage_mv/1000)^2
>
> Furthermore, if we test basic values like :
> voltage_mv = 1000mV = 1V
> freq_mhz = 1000Mhz
>
> The minimum possible power, when dynamic-power-coefficient equals 1, will
> be with current unit:
> min power = 1 * 1000 * (1000000)^2 = 10^15 mW
> which is not realistic
>
> With the unit used by the code, the min power is
> min power = 1 * 1000 * 1^2 = 1000uW = 1mW which is far more realistic
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/cpus.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit
2018-08-29 7:08 [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit Vincent Guittot
2018-08-30 8:46 ` Punit Agrawal
2018-09-03 6:39 ` Viresh Kumar
@ 2018-09-25 16:44 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-09-25 16:44 UTC (permalink / raw)
To: Vincent Guittot
Cc: mark.rutland, devicetree, punit.agrawal, edubezval, viresh.kumar,
linux-kernel, linux-pm
On Wed, Aug 29, 2018 at 09:08:38AM +0200, Vincent Guittot wrote:
> The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas
> its usage in the code assumes that unit is uW/MHz/V^2
>
> In drivers/thermal/cpu_cooling.c, the code is :
>
> power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv;
> do_div(power, 1000000000);
>
> which can be summarized as :
> power (mW) = capacitance * freq_mhz/1000 * (voltage_mv/1000)^2
> or
> power (mW) = (capacitance * freq_mhz * (voltage_mv/1000)^2) / 1000
> then
> power (mW) = power (uW) / 1000
> so
> power (uW) = capacitance * freq_mhz * (voltage_mv/1000)^2
>
> Furthermore, if we test basic values like :
> voltage_mv = 1000mV = 1V
> freq_mhz = 1000Mhz
>
> The minimum possible power, when dynamic-power-coefficient equals 1, will
> be with current unit:
> min power = 1 * 1000 * (1000000)^2 = 10^15 mW
> which is not realistic
>
> With the unit used by the code, the min power is
> min power = 1 * 1000 * 1^2 = 1000uW = 1mW which is far more realistic
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/cpus.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-25 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 7:08 [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit Vincent Guittot
2018-08-30 8:46 ` Punit Agrawal
2018-09-03 6:39 ` Viresh Kumar
2018-09-25 16:44 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).