* [PATCH net-next] net: ethernet: dpaa: remove unused variables
@ 2018-09-26 13:12 Arnd Bergmann
2018-09-26 17:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-09-26 13:12 UTC (permalink / raw)
To: Madalin Bucur, David S. Miller
Cc: Arnd Bergmann, Andrew Lunn, Florian Fainelli, Yangbo Lu,
Jake Moroni, Gustavo A. R. Silva, netdev, linux-kernel
The patch that removed the only users of the oldadv/newadv variables
accidentally left the now-unused declarations behind:
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c: In function 'dpaa_set_pauseparam':
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:14: error: unused variable 'oldadv' [-Werror=unused-variable]
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:6: error: unused variable 'newadv' [-Werror=unused-variable]
Fixes: 70814e819c11 ("net: ethernet: Add helper for set_pauseparam for Asym Pause")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
index 5d0fdf667b82..13d6e2272ece 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
@@ -182,7 +182,6 @@ static int dpaa_set_pauseparam(struct net_device *net_dev,
struct phy_device *phydev;
bool rx_pause, tx_pause;
struct dpaa_priv *priv;
- u32 newadv, oldadv;
int err;
priv = netdev_priv(net_dev);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: ethernet: dpaa: remove unused variables
2018-09-26 13:12 [PATCH net-next] net: ethernet: dpaa: remove unused variables Arnd Bergmann
@ 2018-09-26 17:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-26 17:35 UTC (permalink / raw)
To: arnd
Cc: madalin.bucur, andrew, f.fainelli, yangbo.lu, mail, gustavo,
netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 26 Sep 2018 15:12:13 +0200
> The patch that removed the only users of the oldadv/newadv variables
> accidentally left the now-unused declarations behind:
>
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c: In function 'dpaa_set_pauseparam':
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:14: error: unused variable 'oldadv' [-Werror=unused-variable]
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:6: error: unused variable 'newadv' [-Werror=unused-variable]
>
> Fixes: 70814e819c11 ("net: ethernet: Add helper for set_pauseparam for Asym Pause")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-26 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 13:12 [PATCH net-next] net: ethernet: dpaa: remove unused variables Arnd Bergmann
2018-09-26 17:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).