* [PATCH] drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION
@ 2018-09-26 19:38 Arnd Bergmann
2018-09-27 11:21 ` Noralf Trønnes
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-09-26 19:38 UTC (permalink / raw)
To: Philipp Zabel, David Airlie
Cc: Arnd Bergmann, Lucas Stach, Noralf Trønnes, Daniel Vetter,
Sam Ravnborg, Souptick Joarder, Leonard Crestez,
Thomas Zimmermann, dri-devel, linux-kernel
The variable is declared in an #ifdef section, but the user is
now unconditional, which leads to a build failure:
drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'?
Remove the remaining #ifdef as well.
Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/imx/imx-drm-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index a70f3131a377..0e6942f21a4e 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -35,10 +35,8 @@
#define MAX_CRTC 4
-#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
static int legacyfb_depth = 16;
module_param(legacyfb_depth, int, 0444);
-#endif
DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION
2018-09-26 19:38 [PATCH] drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION Arnd Bergmann
@ 2018-09-27 11:21 ` Noralf Trønnes
0 siblings, 0 replies; 2+ messages in thread
From: Noralf Trønnes @ 2018-09-27 11:21 UTC (permalink / raw)
To: Arnd Bergmann, Philipp Zabel, David Airlie
Cc: Lucas Stach, Daniel Vetter, Sam Ravnborg, Souptick Joarder,
Leonard Crestez, Thomas Zimmermann, dri-devel, linux-kernel
Den 26.09.2018 21.38, skrev Arnd Bergmann:
> The variable is declared in an #ifdef section, but the user is
> now unconditional, which leads to a build failure:
>
> drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
> drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'?
>
> Remove the remaining #ifdef as well.
>
> Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks for fixing my mistakes Arnd.
Applied to drm-misc-next.
Noralf.
> drivers/gpu/drm/imx/imx-drm-core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> index a70f3131a377..0e6942f21a4e 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -35,10 +35,8 @@
>
> #define MAX_CRTC 4
>
> -#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
> static int legacyfb_depth = 16;
> module_param(legacyfb_depth, int, 0444);
> -#endif
>
> DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-27 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 19:38 [PATCH] drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION Arnd Bergmann
2018-09-27 11:21 ` Noralf Trønnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).