From: Nathan Chancellor <natechancellor@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IB/mlx4: Avoid implicit enumerated type conversion
Date: Wed, 26 Sep 2018 18:08:03 -0700 [thread overview]
Message-ID: <20180927010803.GA7640@flashbox> (raw)
In-Reply-To: <20180925023722.GA32600@ziepe.ca>
On Mon, Sep 24, 2018 at 08:37:22PM -0600, Jason Gunthorpe wrote:
> On Mon, Sep 24, 2018 at 03:29:38PM -0700, Nick Desaulniers wrote:
> > On Mon, Sep 24, 2018 at 3:27 PM Nathan Chancellor
> > <natechancellor@gmail.com> wrote:
> > >
> > > On Mon, Sep 24, 2018 at 03:24:36PM -0700, Nick Desaulniers wrote:
> > > > On Mon, Sep 24, 2018 at 12:57 PM Nathan Chancellor
> > > > <natechancellor@gmail.com> wrote:
> > > > >
> > > > > Clang warns when one enumerated type is implicitly converted to another.
> > > > >
> > > > > drivers/infiniband/hw/mlx4/mad.c:1811:41: warning: implicit conversion
> > > > > from enumeration type 'enum mlx4_ib_qp_flags' to different enumeration
> > > > > type 'enum ib_qp_create_flags' [-Wenum-conversion]
> > > > > qp_init_attr.init_attr.create_flags = MLX4_IB_SRIOV_TUNNEL_QP;
> > > > > ~ ^~~~~~~~~~~~~~~~~~~~~~~
> > > > >
> > > > > drivers/infiniband/hw/mlx4/mad.c:1819:41: warning: implicit conversion
> > > > > from enumeration type 'enum mlx4_ib_qp_flags' to different enumeration
> > > > > type 'enum ib_qp_create_flags' [-Wenum-conversion]
> > > > > qp_init_attr.init_attr.create_flags = MLX4_IB_SRIOV_SQP;
> > > > > ~ ^~~~~~~~~~~~~~~~~
> > > > >
> > > > > The type mlx4_ib_qp_flags explicitly provides supplemental values to the
> > > > > type ib_qp_create_flags. Make that clear to Clang by changing the
> > > > > create_flags type to u32.
> > > > >
> > > > > Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> > > > > include/rdma/ib_verbs.h | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> > > > > index e463d3007a35..f6f4d9e3c8ed 100644
> > > > > +++ b/include/rdma/ib_verbs.h
> > > > > @@ -1149,7 +1149,7 @@ struct ib_qp_init_attr {
> > > > > struct ib_qp_cap cap;
> > > > > enum ib_sig_type sq_sig_type;
> > > > > enum ib_qp_type qp_type;
> > > > > - enum ib_qp_create_flags create_flags;
> > > > > + u32 create_flags;
> > > >
> > > > I think it might be better to just have explicit casts at the
> > > > assignment. What do the maintainers think?
> > > >
> > >
> > > That's fine with me, I tend to explicitly cast if it is only one
> > > location but it certainly makes sense in this case as well. I'll
> > > wait for the maintainers to weigh in before sending a v2.
> >
> > Yeah, I mean my opinion on this might seem arbitrary, but based on the
> > pattern and the comment in ib_qp_create_flags, those enum values are
> > reserved to be "subclassed" in a sense, so they should always be in
> > sync or this code will have bigger problems.
>
> One should not use an 'enum' type name for bitfield storage, as once
> you start or'ing things together the values no longer fall on the
> enum. Some compilers and tools even give warnings in this case, ie
>
> enum x foo = X_A | X_B;
>
> Is an assignment from 'int' to an 'enum x' with an implicit cast.
>
> For this reason, usually bitfield enum declarations should be
> anonymous.
>
> Jason
Hi Jason,
I apologize for not understanding but how should I adjust my patch so
that it is acceptable? Do you want the explicit casts like Nick
suggested?
Thanks for the comments,
Nathan
next prev parent reply other threads:[~2018-09-27 1:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 19:57 [PATCH] IB/mlx4: Avoid implicit enumerated type conversion Nathan Chancellor
2018-09-24 22:24 ` Nick Desaulniers
2018-09-24 22:27 ` Nathan Chancellor
2018-09-24 22:29 ` Nick Desaulniers
2018-09-25 2:37 ` Jason Gunthorpe
2018-09-27 1:08 ` Nathan Chancellor [this message]
2018-09-27 4:48 ` Jason Gunthorpe
2018-09-27 20:13 ` Nick Desaulniers
2018-09-27 20:28 ` Nathan Chancellor
2018-09-27 20:34 ` Nick Desaulniers
2018-09-27 20:36 ` Nathan Chancellor
2018-09-27 22:28 ` Jason Gunthorpe
2018-09-27 22:33 ` Bart Van Assche
2018-09-27 22:42 ` Nick Desaulniers
2018-09-27 22:58 ` Jason Gunthorpe
2018-09-27 23:08 ` Bart Van Assche
2018-09-28 0:55 ` Nick Desaulniers
2018-09-28 3:04 ` Jason Gunthorpe
2018-09-27 20:43 ` [PATCH v2] " Nathan Chancellor
2018-09-27 20:53 ` Nick Desaulniers
2018-10-03 22:35 ` [PATCH] " Jason Gunthorpe
2018-10-03 22:53 ` Nick Desaulniers
2018-10-03 23:01 ` Jason Gunthorpe
2018-10-03 23:09 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927010803.GA7640@flashbox \
--to=natechancellor@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).