* [GIT PULL 0/6] perf/urgent fixes
@ 2018-09-28 12:25 Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 1/6] perf script python: Fix export-to-postgresql.py occasional failure Arnaldo Carvalho de Melo
` (5 more replies)
0 siblings, 6 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-28 12:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Arnaldo Carvalho de Melo, Adrian Hunter, David Ahern,
Hadrien Grasland, Jin Yao, Jiri Olsa, Milian Wolff, Namhyung Kim,
Sandipan Das, stable, Thiago Macieira, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 5d05dfd13f20b01a3cd5d293058baa7d5c1583b6:
Merge tag 'perf-urgent-for-mingo-4.19-20180918' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2018-09-19 13:25:35 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.19-20180928
for you to fetch changes up to 30aaba0acd1b4b6e69c45c416f2dbc9c8c5bdd50:
perf python: Use -Wno-redundant-decls to build with PYTHON=python3 (2018-09-27 22:31:05 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Fix the build on Clear Linux, coping with redundant declarations of
function prototypes in python3 header files by adding
-Wno-redundant-decls to build with PYTHON=python3 (Arnaldo Carvalho de Melo)
- Fixes for processing inline frames in backtraces using DWARF based
unwinding (Milian Wolff)
- Cope with bad DWARF info for function names for inline frames,not
trying to demangle this symbol. Problem reported with rust but
reproduced as well with C++. Problem reported to the libbpf
maintainers (Milian Wolff)
- Fix python export to postgresql and sqlite code (Adrian Hunter)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf script python: Fix export-to-postgresql.py occasional failure
perf script python: Fix export-to-sqlite.py sample columns
Arnaldo Carvalho de Melo (1):
perf python: Use -Wno-redundant-decls to build with PYTHON=python3
Milian Wolff (3):
perf report: Don't try to map ip to invalid map
perf report: Use the offset address to find inline frames
perf report: Don't crash on invalid inline debug information
tools/perf/scripts/python/export-to-postgresql.py | 9 +++++++++
tools/perf/scripts/python/export-to-sqlite.py | 6 +++++-
tools/perf/util/machine.c | 11 ++++++-----
tools/perf/util/setup.py | 2 +-
tools/perf/util/srcline.c | 3 +++
5 files changed, 24 insertions(+), 7 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with
and without libelf support. Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
The Clear Linux container is building with NO_CLANG=1, the problem preventing
its use when building for python3 has been identified and the next builds will
build in ClearLinux with both gcc and clang. This time around only gcc was
used.
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0
6 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
7 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
8 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
14 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 8.2.1 20180502
15 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
16 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
17 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
18 debian:experimental : Ok gcc (Debian 8.2.0-7) 8.2.0
19 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0
20 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
21 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0
22 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
23 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
24 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
25 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
26 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
27 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
28 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
29 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
30 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
31 fedora:27 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6)
32 fedora:28 : Ok gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
33 fedora:rawhide : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3)
34 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0
35 mageia:5 : Ok gcc (GCC) 4.9.2
36 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0
37 opensuse:13.2 : Ok gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064]
38 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
39 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
40 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
41 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812]
42 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
43 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1)
44 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
45 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
46 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
47 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
48 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
49 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
50 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
51 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
52 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
53 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
54 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
55 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
56 ubuntu:18.04 : Ok gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
57 ubuntu:18.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
58 ubuntu:18.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
59 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
60 ubuntu:18.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
61 ubuntu:18.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
62 ubuntu:18.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
63 ubuntu:18.04-x-riscv64 : Ok riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
64 ubuntu:18.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
65 ubuntu:18.04-x-sh4 : Ok sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
66 ubuntu:18.04-x-sparc64 : Ok sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
67 ubuntu:18.10 : Ok gcc (Ubuntu 8.2.0-4ubuntu1) 8.2.0
#
# uname -a
Linux jouet 4.19.0-rc4-00022-gad3273d5f1b9 #1 SMP Mon Sep 17 17:18:22 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# git log --oneline -1
30aaba0acd1b perf python: Use -Wno-redundant-decls to build with PYTHON=python3
# perf version --build-options
perf version 4.19.rc4.g30aaba
dwarf: [ on ] # HAVE_DWARF_SUPPORT
dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
glibc: [ on ] # HAVE_GLIBC_SUPPORT
gtk2: [ on ] # HAVE_GTK2_SUPPORT
syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
libbfd: [ on ] # HAVE_LIBBFD_SUPPORT
libelf: [ on ] # HAVE_LIBELF_SUPPORT
libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT
numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT
libperl: [ on ] # HAVE_LIBPERL_SUPPORT
libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
libslang: [ on ] # HAVE_SLANG_SUPPORT
libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
zlib: [ on ] # HAVE_ZLIB_SUPPORT
lzma: [ on ] # HAVE_LZMA_SUPPORT
get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT
bpf: [ on ] # HAVE_LIBBPF_SUPPORT
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Number of exit events of a simple workload : Ok
23: Software clock events period values : Ok
24: Object code reading : Ok
25: Sample parsing : Ok
26: Use a dummy software event to keep tracking : Ok
27: Parse with no sample_id_all bit set : Ok
28: Filter hist entries : Ok
29: Lookup mmap thread : Ok
30: Share thread mg : Ok
31: Sort output of hist entries : Ok
32: Cumulate child hist entries : Ok
33: Track with sched_switch : Ok
34: Filter fds with revents mask in a fdarray : Ok
35: Add fd to a fdarray, making it autogrow : Ok
36: kmod_path__parse : Ok
37: Thread map : Ok
38: LLVM search and compile :
38.1: Basic BPF llvm compile : Ok
38.2: kbuild searching : Ok
38.3: Compile source for BPF prologue generation : Ok
38.4: Compile source for BPF relocation : Ok
39: Session topology : Ok
40: BPF filter :
40.1: Basic BPF filtering : Ok
40.2: BPF pinning : Ok
40.3: BPF prologue generation : Ok
40.4: BPF relocation checker : Ok
41: Synthesize thread map : Ok
42: Remove thread map : Ok
43: Synthesize cpu map : Ok
44: Synthesize stat config : Ok
45: Synthesize stat : Ok
46: Synthesize stat round : Ok
47: Synthesize attr update : Ok
48: Event times : Ok
49: Read backward ring buffer : Ok
50: Print cpu map : Ok
51: Probe SDT events : Ok
52: is_printable_array : Ok
53: Print bitmap : Ok
54: perf hooks : Ok
55: builtin clang support : Skip (not compiled in)
56: unit_number__scnprintf : Ok
57: mem2node : Ok
58: x86 rdpmc : Ok
59: Convert perf time to TSC : Ok
60: DWARF unwind : Ok
61: x86 instruction decoder - new instructions : Ok
62: x86 bp modify : Ok
63: Use vfs_getname probe to get syscall args filenames : Ok
64: Check open filename arg using perf trace + vfs_getname: Ok
65: probe libc's inet_pton & backtrace it with ping : Ok
66: Add vfs_getname probe to get syscall args filenames : Ok
$ time make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
- /home/acme/git/perf/tools/perf/BUILD_TEST_FEATURE_DUMP: make FEATURE_DUMP_COPY=/home/acme/git/perf/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump
make_no_gtk2_O: make NO_GTK2=1
make_install_O: make install
make_install_prefix_O: make install prefix=/tmp/krava
make_tags_O: make tags
make_static_O: make LDFLAGS=-static
make_debug_O: make DEBUG=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_clean_all_O: make clean all
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libbpf_O: make NO_LIBBPF=1
make_help_O: make help
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_perf_o_O: make perf.o
make_no_auxtrace_O: make NO_AUXTRACE=1
make_util_map_o_O: make util/map.o
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_slang_O: make NO_SLANG=1
make_pure_O: make
make_no_libelf_O: make NO_LIBELF=1
make_no_newt_O: make NO_NEWT=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_doc_O: make doc
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_install_bin_O: make install-bin
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 1/6] perf script python: Fix export-to-postgresql.py occasional failure
2018-09-28 12:25 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
@ 2018-09-28 12:25 ` Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 2/6] perf script python: Fix export-to-sqlite.py sample columns Arnaldo Carvalho de Melo
` (4 subsequent siblings)
5 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-28 12:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Jiri Olsa, stable, Arnaldo Carvalho de Melo
From: Adrian Hunter <adrian.hunter@intel.com>
Occasional export failures were found to be caused by truncating 64-bit
pointers to 32-bits. Fix by explicitly setting types for all ctype
arguments and results.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180911114504.28516-2-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/scripts/python/export-to-postgresql.py | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tools/perf/scripts/python/export-to-postgresql.py b/tools/perf/scripts/python/export-to-postgresql.py
index efcaf6cac2eb..e46f51b17513 100644
--- a/tools/perf/scripts/python/export-to-postgresql.py
+++ b/tools/perf/scripts/python/export-to-postgresql.py
@@ -204,14 +204,23 @@ from ctypes import *
libpq = CDLL("libpq.so.5")
PQconnectdb = libpq.PQconnectdb
PQconnectdb.restype = c_void_p
+PQconnectdb.argtypes = [ c_char_p ]
PQfinish = libpq.PQfinish
+PQfinish.argtypes = [ c_void_p ]
PQstatus = libpq.PQstatus
+PQstatus.restype = c_int
+PQstatus.argtypes = [ c_void_p ]
PQexec = libpq.PQexec
PQexec.restype = c_void_p
+PQexec.argtypes = [ c_void_p, c_char_p ]
PQresultStatus = libpq.PQresultStatus
+PQresultStatus.restype = c_int
+PQresultStatus.argtypes = [ c_void_p ]
PQputCopyData = libpq.PQputCopyData
+PQputCopyData.restype = c_int
PQputCopyData.argtypes = [ c_void_p, c_void_p, c_int ]
PQputCopyEnd = libpq.PQputCopyEnd
+PQputCopyEnd.restype = c_int
PQputCopyEnd.argtypes = [ c_void_p, c_void_p ]
sys.path.append(os.environ['PERF_EXEC_PATH'] + \
--
2.14.4
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 2/6] perf script python: Fix export-to-sqlite.py sample columns
2018-09-28 12:25 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 1/6] perf script python: Fix export-to-postgresql.py occasional failure Arnaldo Carvalho de Melo
@ 2018-09-28 12:25 ` Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 3/6] perf report: Don't try to map ip to invalid map Arnaldo Carvalho de Melo
` (3 subsequent siblings)
5 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-28 12:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Jiri Olsa, stable, Arnaldo Carvalho de Melo
From: Adrian Hunter <adrian.hunter@intel.com>
With the "branches" export option, not all sample columns are exported.
However the unwanted columns are not at the end of the tuple, as assumed
by the code. Fix by taking the first 15 and last 3 values, instead of
the first 18.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180911114504.28516-3-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/scripts/python/export-to-sqlite.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
index f827bf77e9d2..e4bb82c8aba9 100644
--- a/tools/perf/scripts/python/export-to-sqlite.py
+++ b/tools/perf/scripts/python/export-to-sqlite.py
@@ -440,7 +440,11 @@ def branch_type_table(*x):
def sample_table(*x):
if branches:
- bind_exec(sample_query, 18, x)
+ for xx in x[0:15]:
+ sample_query.addBindValue(str(xx))
+ for xx in x[19:22]:
+ sample_query.addBindValue(str(xx))
+ do_query_(sample_query)
else:
bind_exec(sample_query, 22, x)
--
2.14.4
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 3/6] perf report: Don't try to map ip to invalid map
2018-09-28 12:25 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 1/6] perf script python: Fix export-to-postgresql.py occasional failure Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 2/6] perf script python: Fix export-to-sqlite.py sample columns Arnaldo Carvalho de Melo
@ 2018-09-28 12:25 ` Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 4/6] perf report: Use the offset address to find inline frames Arnaldo Carvalho de Melo
` (2 subsequent siblings)
5 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-28 12:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Milian Wolff,
Jin Yao, Namhyung Kim, Arnaldo Carvalho de Melo
From: Milian Wolff <milian.wolff@kdab.com>
Fixes a crash when the report encounters an address that could not be
associated with an mmaped region:
#0 0x00005555557bdc4a in callchain_srcline (ip=<error reading variable: Cannot access memory at address 0x38>, sym=0x0, map=0x0) at util/machine.c:2329
#1 unwind_entry (entry=entry@entry=0x7fffffff9180, arg=arg@entry=0x7ffff5642498) at util/machine.c:2329
#2 0x00005555558370af in entry (arg=0x7ffff5642498, cb=0x5555557bdb50 <unwind_entry>, thread=<optimized out>, ip=18446744073709551615) at util/unwind-libunwind-local.c:586
#3 get_entries (ui=ui@entry=0x7fffffff9620, cb=0x5555557bdb50 <unwind_entry>, arg=0x7ffff5642498, max_stack=<optimized out>) at util/unwind-libunwind-local.c:703
#4 0x0000555555837192 in _unwind__get_entries (cb=<optimized out>, arg=<optimized out>, thread=<optimized out>, data=<optimized out>, max_stack=<optimized out>) at util/unwind-libunwind-local.c:725
#5 0x00005555557c310f in thread__resolve_callchain_unwind (max_stack=127, sample=0x7fffffff9830, evsel=0x555555c7b3b0, cursor=0x7ffff5642498, thread=0x555555c7f6f0) at util/machine.c:2351
#6 thread__resolve_callchain (thread=0x555555c7f6f0, cursor=0x7ffff5642498, evsel=0x555555c7b3b0, sample=0x7fffffff9830, parent=0x7fffffff97b8, root_al=0x7fffffff9750, max_stack=127) at util/machine.c:2378
#7 0x00005555557ba4ee in sample__resolve_callchain (sample=<optimized out>, cursor=<optimized out>, parent=parent@entry=0x7fffffff97b8, evsel=<optimized out>, al=al@entry=0x7fffffff9750,
max_stack=<optimized out>) at util/callchain.c:1085
Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
Tested-by: Sandipan Das <sandipan@linux.ibm.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Fixes: 2a9d5050dc84 ("perf script: Show correct offsets for DWARF-based unwinding")
Link: http://lkml.kernel.org/r/20180926135207.30263-1-milian.wolff@kdab.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/machine.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index c4acd2001db0..0cb4f8bf3ca7 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -2312,7 +2312,7 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
{
struct callchain_cursor *cursor = arg;
const char *srcline = NULL;
- u64 addr;
+ u64 addr = entry->ip;
if (symbol_conf.hide_unresolved && entry->sym == NULL)
return 0;
@@ -2324,7 +2324,8 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
* Convert entry->ip from a virtual address to an offset in
* its corresponding binary.
*/
- addr = map__map_ip(entry->map, entry->ip);
+ if (entry->map)
+ addr = map__map_ip(entry->map, entry->ip);
srcline = callchain_srcline(entry->map, entry->sym, addr);
return callchain_cursor_append(cursor, entry->ip,
--
2.14.4
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 4/6] perf report: Use the offset address to find inline frames
2018-09-28 12:25 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2018-09-28 12:25 ` [PATCH 3/6] perf report: Don't try to map ip to invalid map Arnaldo Carvalho de Melo
@ 2018-09-28 12:25 ` Arnaldo Carvalho de Melo
2018-10-01 5:42 ` Ravi Bangoria
2018-09-28 12:25 ` [PATCH 5/6] perf report: Don't crash on invalid inline debug information Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 6/6] perf python: Use -Wno-redundant-decls to build with PYTHON=python3 Arnaldo Carvalho de Melo
5 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-28 12:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Milian Wolff,
Jin Yao, Namhyung Kim, Sandipan Das, Arnaldo Carvalho de Melo
From: Milian Wolff <milian.wolff@kdab.com>
To correctly find inlined frames, we have to use the file offset instead
of the virtual memory address. This was already fixed for displaying
srcline information while displaying in commit 2a9d5050dc84fa20 ("perf
script: Show correct offsets for DWARF-based unwinding"). We just need
to use the same corrected address also when trying to find inline
frames.
This is another follow-up to commit 19610184693c ("perf script: Show
virtual addresses instead of offsets").
Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Sandipan Das <sandipan@linux.ibm.com>
Fixes: 19610184693c ("perf script: Show virtual addresses instead of offsets")
Link: http://lkml.kernel.org/r/20180926135207.30263-2-milian.wolff@kdab.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/machine.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 0cb4f8bf3ca7..73a651f10a0f 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -2317,9 +2317,6 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
if (symbol_conf.hide_unresolved && entry->sym == NULL)
return 0;
- if (append_inlines(cursor, entry->map, entry->sym, entry->ip) == 0)
- return 0;
-
/*
* Convert entry->ip from a virtual address to an offset in
* its corresponding binary.
@@ -2327,6 +2324,9 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
if (entry->map)
addr = map__map_ip(entry->map, entry->ip);
+ if (append_inlines(cursor, entry->map, entry->sym, addr) == 0)
+ return 0;
+
srcline = callchain_srcline(entry->map, entry->sym, addr);
return callchain_cursor_append(cursor, entry->ip,
entry->map, entry->sym,
--
2.14.4
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 5/6] perf report: Don't crash on invalid inline debug information
2018-09-28 12:25 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2018-09-28 12:25 ` [PATCH 4/6] perf report: Use the offset address to find inline frames Arnaldo Carvalho de Melo
@ 2018-09-28 12:25 ` Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 6/6] perf python: Use -Wno-redundant-decls to build with PYTHON=python3 Arnaldo Carvalho de Melo
5 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-28 12:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users, Milian Wolff,
Jin Yao, Jiri Olsa, Namhyung Kim, Arnaldo Carvalho de Melo
From: Milian Wolff <milian.wolff@kdab.com>
When the function name for an inline frame is invalid, we must not try
to demangle this symbol, otherwise we crash with:
#0 0x0000555555895c01 in bfd_demangle ()
#1 0x0000555555823262 in demangle_sym (dso=0x555555d92b90, elf_name=0x0, kmodule=0) at util/symbol-elf.c:215
#2 dso__demangle_sym (dso=dso@entry=0x555555d92b90, kmodule=<optimized out>, kmodule@entry=0, elf_name=elf_name@entry=0x0) at util/symbol-elf.c:400
#3 0x00005555557fef4b in new_inline_sym (funcname=0x0, base_sym=0x555555d92b90, dso=0x555555d92b90) at util/srcline.c:89
#4 inline_list__append_dso_a2l (dso=dso@entry=0x555555c7bb00, node=node@entry=0x555555e31810, sym=sym@entry=0x555555d92b90) at util/srcline.c:264
#5 0x00005555557ff27f in addr2line (dso_name=dso_name@entry=0x555555d92430 "/home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926da66033d24fce5/elf", addr=addr@entry=2888, file=file@entry=0x0,
line=line@entry=0x0, dso=dso@entry=0x555555c7bb00, unwind_inlines=unwind_inlines@entry=true, node=0x555555e31810, sym=0x555555d92b90) at util/srcline.c:313
#6 0x00005555557ffe7c in addr2inlines (sym=0x555555d92b90, dso=0x555555c7bb00, addr=2888, dso_name=0x555555d92430 "/home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926da66033d24fce5/elf")
at util/srcline.c:358
So instead handle the case where we get invalid function names for
inlined frames and use a fallback '??' function name instead.
While this crash was originally reported by Hadrien for rust code, I can
now also reproduce it with trivial C++ code. Indeed, it seems like
libbfd fails to interpret the debug information for the inline frame
symbol name:
$ addr2line -e /home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926da66033d24fce5/elf -if b48
main
/usr/include/c++/8.2.1/complex:610
??
/usr/include/c++/8.2.1/complex:618
??
/usr/include/c++/8.2.1/complex:675
??
/usr/include/c++/8.2.1/complex:685
main
/home/milian/projects/kdab/rnd/hotspot/tests/test-clients/cpp-inlining/main.cpp:39
I've reported this bug upstream and also attached a patch there which
should fix this issue:
https://sourceware.org/bugzilla/show_bug.cgi?id=23715
Reported-by: Hadrien Grasland <grasland@lal.in2p3.fr>
Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/20180926135207.30263-3-milian.wolff@kdab.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/srcline.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index 09d6746e6ec8..e767c4a9d4d2 100644
--- a/tools/perf/util/srcline.c
+++ b/tools/perf/util/srcline.c
@@ -85,6 +85,9 @@ static struct symbol *new_inline_sym(struct dso *dso,
struct symbol *inline_sym;
char *demangled = NULL;
+ if (!funcname)
+ funcname = "??";
+
if (dso) {
demangled = dso__demangle_sym(dso, 0, funcname);
if (demangled)
--
2.14.4
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 6/6] perf python: Use -Wno-redundant-decls to build with PYTHON=python3
2018-09-28 12:25 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2018-09-28 12:25 ` [PATCH 5/6] perf report: Don't crash on invalid inline debug information Arnaldo Carvalho de Melo
@ 2018-09-28 12:25 ` Arnaldo Carvalho de Melo
5 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-09-28 12:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Arnaldo Carvalho de Melo, Adrian Hunter, David Ahern, Jiri Olsa,
Namhyung Kim, Thiago Macieira, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
When building in ClearLinux using 'make PYTHON=python3' with gcc 8.2.1
it fails with:
GEN /tmp/build/perf/python/perf.so
In file included from /usr/include/python3.7m/Python.h:126,
from /git/linux/tools/perf/util/python.c:2:
/usr/include/python3.7m/import.h:58:24: error: redundant redeclaration of ‘_PyImport_AddModuleObject’ [-Werror=redundant-decls]
PyAPI_FUNC(PyObject *) _PyImport_AddModuleObject(PyObject *, PyObject *);
^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/python3.7m/import.h:47:24: note: previous declaration of ‘_PyImport_AddModuleObject’ was here
PyAPI_FUNC(PyObject *) _PyImport_AddModuleObject(PyObject *name,
^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
error: command 'gcc' failed with exit status 1
And indeed there is a redundant declaration in that Python.h file, one
with parameter names and the other without, so just add
-Wno-error=redundant-decls to the python setup instructions.
Now perf builds with gcc in ClearLinux with the following Dockerfile:
# docker.io/acmel/linux-perf-tools-build-clearlinux:latest
FROM docker.io/clearlinux:latest
MAINTAINER Arnaldo Carvalho de Melo <acme@kernel.org>
RUN swupd update && \
swupd bundle-add sysadmin-basic-dev
RUN mkdir -m 777 -p /git /tmp/build/perf /tmp/build/objtool /tmp/build/linux && \
groupadd -r perfbuilder && \
useradd -m -r -g perfbuilder perfbuilder && \
chown -R perfbuilder.perfbuilder /tmp/build/ /git/
USER perfbuilder
COPY rx_and_build.sh /
ENV EXTRA_MAKE_ARGS=PYTHON=python3
ENTRYPOINT ["/rx_and_build.sh"]
Now to figure out why the build fails with clang, that is present in the
above container as detected by the rx_and_build.sh script:
clang version 6.0.1 (tags/RELEASE_601/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/sbin
make: Entering directory '/git/linux/tools/perf'
BUILD: Doing 'make -j4' parallel build
HOSTCC /tmp/build/perf/fixdep.o
HOSTLD /tmp/build/perf/fixdep-in.o
LINK /tmp/build/perf/fixdep
Auto-detecting system features:
... dwarf: [ OFF ]
... dwarf_getlocations: [ OFF ]
... glibc: [ OFF ]
... gtk2: [ OFF ]
... libaudit: [ OFF ]
... libbfd: [ OFF ]
... libelf: [ OFF ]
... libnuma: [ OFF ]
... numa_num_possible_cpus: [ OFF ]
... libperl: [ OFF ]
... libpython: [ OFF ]
... libslang: [ OFF ]
... libcrypto: [ OFF ]
... libunwind: [ OFF ]
... libdw-dwarf-unwind: [ OFF ]
... zlib: [ OFF ]
... lzma: [ OFF ]
... get_cpuid: [ OFF ]
... bpf: [ OFF ]
Makefile.config:331: *** No gnu/libc-version.h found, please install glibc-dev[el]. Stop.
make[1]: *** [Makefile.perf:206: sub-make] Error 2
make: *** [Makefile:70: all] Error 2
make: Leaving directory '/git/linux/tools/perf'
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Thiago Macieira <thiago.macieira@intel.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-c3khb9ac86s00qxzjrueomme@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
index 97efbcad076e..1942f6dd24f6 100644
--- a/tools/perf/util/setup.py
+++ b/tools/perf/util/setup.py
@@ -35,7 +35,7 @@ class install_lib(_install_lib):
cflags = getenv('CFLAGS', '').split()
# switch off several checks (need to be at the end of cflags list)
-cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter' ]
+cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls' ]
if cc != "clang":
cflags += ['-Wno-cast-function-type' ]
--
2.14.4
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 4/6] perf report: Use the offset address to find inline frames
2018-09-28 12:25 ` [PATCH 4/6] perf report: Use the offset address to find inline frames Arnaldo Carvalho de Melo
@ 2018-10-01 5:42 ` Ravi Bangoria
0 siblings, 0 replies; 32+ messages in thread
From: Ravi Bangoria @ 2018-10-01 5:42 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Ingo Molnar, Milian Wolff
Cc: Clark Williams, linux-kernel, linux-perf-users, Jin Yao,
Namhyung Kim, Sandipan Das, Arnaldo Carvalho de Melo,
Ravi Bangoria
Hi Milian,
Seems this has a regression:
With acme/perf/urgent:
$ ./perf record -e cycles:u --call-graph=dwarf ls
$ ./perf script
ls 13585 602082.534478: 28032 cycles:u:
1f1f4 __GI___tunables_init+0xffff0000d3dc00a4 (/usr/lib64/ld-2.26.so)
20e2b _dl_sysdep_start+0xffff0000d3dc04ab (/usr/lib64/ld-2.26.so)
1ca7 _dl_start_final+0xffff0000d3dc00f7 (/usr/lib64/ld-2.26.so)
29b3 _dl_start+0xffff0000d3dc0553 (/usr/lib64/ld-2.26.so)
1437 _start+0xffff0000d3dc0017 (/usr/lib64/ld-2.26.so)
After reverting this patch:
$ git revert d9c910d5f8c3a1858f115dc9d3b157df32da70a3
[a/perf/urgent 72cada4e6b30] Revert "perf report: Use the offset address to find inline frames"
$ ./perf script
ls 13585 602082.534478: 28032 cycles:u:
7fff9613f1f4 __GI___tunables_init+0xa4 (/usr/lib64/ld-2.26.so)
7fff96140e2b _dl_sysdep_start+0x4ab (/usr/lib64/ld-2.26.so)
7fff96121ca7 _dl_start_final+0xf7 (/usr/lib64/ld-2.26.so)
7fff961229b3 _dl_start+0x553 (/usr/lib64/ld-2.26.so)
7fff96121437 _start+0x17 (/usr/lib64/ld-2.26.so)
Thanks,
Ravi
On 09/28/2018 05:55 PM, Arnaldo Carvalho de Melo wrote:
> From: Milian Wolff <milian.wolff@kdab.com>
>
> To correctly find inlined frames, we have to use the file offset instead
> of the virtual memory address. This was already fixed for displaying
> srcline information while displaying in commit 2a9d5050dc84fa20 ("perf
> script: Show correct offsets for DWARF-based unwinding"). We just need
> to use the same corrected address also when trying to find inline
> frames.
>
> This is another follow-up to commit 19610184693c ("perf script: Show
> virtual addresses instead of offsets").
>
> Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Cc: Jin Yao <yao.jin@linux.intel.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Sandipan Das <sandipan@linux.ibm.com>
> Fixes: 19610184693c ("perf script: Show virtual addresses instead of offsets")
> Link: http://lkml.kernel.org/r/20180926135207.30263-2-milian.wolff@kdab.com
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/util/machine.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index 0cb4f8bf3ca7..73a651f10a0f 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -2317,9 +2317,6 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
> if (symbol_conf.hide_unresolved && entry->sym == NULL)
> return 0;
>
> - if (append_inlines(cursor, entry->map, entry->sym, entry->ip) == 0)
> - return 0;
> -
> /*
> * Convert entry->ip from a virtual address to an offset in
> * its corresponding binary.
> @@ -2327,6 +2324,9 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
> if (entry->map)
> addr = map__map_ip(entry->map, entry->ip);
>
> + if (append_inlines(cursor, entry->map, entry->sym, addr) == 0)
> + return 0;
> +
> srcline = callchain_srcline(entry->map, entry->sym, addr);
> return callchain_cursor_append(cursor, entry->ip,
> entry->map, entry->sym,
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2020-01-13 9:25 ` Jiri Olsa
@ 2020-01-13 9:44 ` Ravi Bangoria
0 siblings, 0 replies; 32+ messages in thread
From: Ravi Bangoria @ 2020-01-13 9:44 UTC (permalink / raw)
To: Jiri Olsa
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Ingo Molnar,
Thomas Gleixner, Namhyung Kim, Clark Williams, linux-kernel,
linux-perf-users, Adrian Hunter, Arnaldo Carvalho de Melo,
Ravi Bangoria
On 1/13/20 2:55 PM, Jiri Olsa wrote:
> On Mon, Jan 13, 2020 at 01:58:59PM +0530, Ravi Bangoria wrote:
>
> SNIP
>
>> | ^~~~
>> In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
>> from /usr/include/glib-2.0/gobject/gbinding.h:29,
>> from /usr/include/glib-2.0/glib-object.h:23,
>> from /usr/include/glib-2.0/gio/gioenums.h:28,
>> from /usr/include/glib-2.0/gio/giotypes.h:28,
>> from /usr/include/glib-2.0/gio/gio.h:26,
>> from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
>> from /usr/include/gtk-2.0/gdk/gdk.h:32,
>> from /usr/include/gtk-2.0/gtk/gtk.h:32,
>> from test-gtk2.c:3:
>> /usr/include/glib-2.0/gobject/gtype.h:679:1: note: declared here
>> 679 | {
>> | ^
>> In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
>> from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
>> from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
>> from /usr/include/gtk-2.0/gtk/gtk.h:126,
>> from test-gtk2.c:3:
>> /usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: error: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations]
>> 73 | GTimeVal last_popdown;
>> | ^~~~~~~~
>> In file included from /usr/include/glib-2.0/glib/galloca.h:32,
>> from /usr/include/glib-2.0/glib.h:30,
>> from /usr/include/glib-2.0/gobject/gbinding.h:28,
>> from /usr/include/glib-2.0/glib-object.h:23,
>> from /usr/include/glib-2.0/gio/gioenums.h:28,
>> from /usr/include/glib-2.0/gio/giotypes.h:28,
>> from /usr/include/glib-2.0/gio/gio.h:26,
>> from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
>> from /usr/include/gtk-2.0/gdk/gdk.h:32,
>> from /usr/include/gtk-2.0/gtk/gtk.h:32,
>> from test-gtk2.c:3:
>> /usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
>> 551 | struct _GTimeVal
>> | ^~~~~~~~~
>> cc1: all warnings being treated as errors
>>
>
> patch below fixes that for me.. please let me know
> if it works for you and I'll post full patch
>
> jirka
>
LGTM. You can add:
Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2020-01-13 8:28 ` Ravi Bangoria
@ 2020-01-13 9:25 ` Jiri Olsa
2020-01-13 9:44 ` Ravi Bangoria
0 siblings, 1 reply; 32+ messages in thread
From: Jiri Olsa @ 2020-01-13 9:25 UTC (permalink / raw)
To: Ravi Bangoria
Cc: Arnaldo Carvalho de Melo, Jiri Olsa, Ingo Molnar,
Thomas Gleixner, Namhyung Kim, Clark Williams, linux-kernel,
linux-perf-users, Adrian Hunter, Arnaldo Carvalho de Melo
On Mon, Jan 13, 2020 at 01:58:59PM +0530, Ravi Bangoria wrote:
SNIP
> | ^~~~
> In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
> from /usr/include/glib-2.0/gobject/gbinding.h:29,
> from /usr/include/glib-2.0/glib-object.h:23,
> from /usr/include/glib-2.0/gio/gioenums.h:28,
> from /usr/include/glib-2.0/gio/giotypes.h:28,
> from /usr/include/glib-2.0/gio/gio.h:26,
> from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
> from /usr/include/gtk-2.0/gdk/gdk.h:32,
> from /usr/include/gtk-2.0/gtk/gtk.h:32,
> from test-gtk2.c:3:
> /usr/include/glib-2.0/gobject/gtype.h:679:1: note: declared here
> 679 | {
> | ^
> In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
> from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
> from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
> from /usr/include/gtk-2.0/gtk/gtk.h:126,
> from test-gtk2.c:3:
> /usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: error: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations]
> 73 | GTimeVal last_popdown;
> | ^~~~~~~~
> In file included from /usr/include/glib-2.0/glib/galloca.h:32,
> from /usr/include/glib-2.0/glib.h:30,
> from /usr/include/glib-2.0/gobject/gbinding.h:28,
> from /usr/include/glib-2.0/glib-object.h:23,
> from /usr/include/glib-2.0/gio/gioenums.h:28,
> from /usr/include/glib-2.0/gio/giotypes.h:28,
> from /usr/include/glib-2.0/gio/gio.h:26,
> from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
> from /usr/include/gtk-2.0/gdk/gdk.h:32,
> from /usr/include/gtk-2.0/gtk/gtk.h:32,
> from test-gtk2.c:3:
> /usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
> 551 | struct _GTimeVal
> | ^~~~~~~~~
> cc1: all warnings being treated as errors
>
patch below fixes that for me.. please let me know
if it works for you and I'll post full patch
jirka
---
diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index f30a89046aa3..7ac0d8088565 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -197,7 +197,7 @@ $(OUTPUT)test-libcrypto.bin:
$(BUILD) -lcrypto
$(OUTPUT)test-gtk2.bin:
- $(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)
+ $(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) -Wno-deprecated-declarations
$(OUTPUT)test-gtk2-infobar.bin:
$(BUILD) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)
diff --git a/tools/perf/ui/gtk/Build b/tools/perf/ui/gtk/Build
index ec22e899a224..eef708c502f4 100644
--- a/tools/perf/ui/gtk/Build
+++ b/tools/perf/ui/gtk/Build
@@ -1,4 +1,4 @@
-CFLAGS_gtk += -fPIC $(GTK_CFLAGS)
+CFLAGS_gtk += -fPIC $(GTK_CFLAGS) -Wno-deprecated-declarations
gtk-y += browser.o
gtk-y += hists.o
@@ -7,3 +7,8 @@ gtk-y += util.o
gtk-y += helpline.o
gtk-y += progress.o
gtk-y += annotate.o
+gtk-y += zalloc.o
+
+$(OUTPUT)ui/gtk/zalloc.o: ../lib/zalloc.c FORCE
+ $(call rule_mkdir)
+ $(call if_changed_dep,cc_o_c)
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2019-12-05 19:32 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
2019-12-06 7:57 ` Ingo Molnar
@ 2020-01-13 8:28 ` Ravi Bangoria
2020-01-13 9:25 ` Jiri Olsa
1 sibling, 1 reply; 32+ messages in thread
From: Ravi Bangoria @ 2020-01-13 8:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jiri Olsa
Cc: Ingo Molnar, Thomas Gleixner, Namhyung Kim, Clark Williams,
linux-kernel, linux-perf-users, Adrian Hunter,
Arnaldo Carvalho de Melo, Ravi Bangoria
On 12/6/19 1:02 AM, Arnaldo Carvalho de Melo wrote:
> 39 fedora:31 : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 9.0.0 (Fedora 9.0.0-1.fc31)
Not related to this pull request, but because we are discussing the
bison issue in this thread, I thought to report here.
On my Fedora 31, gtk2 also fails:
$ rpm -qa | grep gtk2
gtk2-2.24.32-6.fc31.x86_64
gtk2-devel-2.24.32-6.fc31.x86_64
$ make
Auto-detecting system features:
... glibc: [ on ]
... gtk2: [ OFF ]
... libaudit: [ on ]
Makefile.config:687: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev
Detail logs:
$ cat tools/build/feature/test-gtk2.make.output
In file included from /usr/include/gtk-2.0/gtk/gtkobject.h:37,
from /usr/include/gtk-2.0/gtk/gtkwidget.h:36,
from /usr/include/gtk-2.0/gtk/gtkcontainer.h:35,
from /usr/include/gtk-2.0/gtk/gtkbin.h:35,
from /usr/include/gtk-2.0/gtk/gtkwindow.h:36,
from /usr/include/gtk-2.0/gtk/gtkdialog.h:35,
from /usr/include/gtk-2.0/gtk/gtkaboutdialog.h:32,
from /usr/include/gtk-2.0/gtk/gtk.h:33,
from test-gtk2.c:3:
/usr/include/gtk-2.0/gtk/gtktypeutils.h:236:1: error: ‘GTypeDebugFlags’ is deprecated [-Werror=deprecated-declarations]
236 | void gtk_type_init (GTypeDebugFlags debug_flags);
| ^~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
from /usr/include/glib-2.0/gobject/gbinding.h:29,
from /usr/include/glib-2.0/glib-object.h:23,
from /usr/include/glib-2.0/gio/gioenums.h:28,
from /usr/include/glib-2.0/gio/giotypes.h:28,
from /usr/include/glib-2.0/gio/gio.h:26,
from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
from /usr/include/gtk-2.0/gdk/gdk.h:32,
from /usr/include/gtk-2.0/gtk/gtk.h:32,
from test-gtk2.c:3:
/usr/include/glib-2.0/gobject/gtype.h:679:1: note: declared here
679 | {
| ^
In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
from /usr/include/gtk-2.0/gtk/gtk.h:126,
from test-gtk2.c:3:
/usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: error: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations]
73 | GTimeVal last_popdown;
| ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
from /usr/include/glib-2.0/glib.h:30,
from /usr/include/glib-2.0/gobject/gbinding.h:28,
from /usr/include/glib-2.0/glib-object.h:23,
from /usr/include/glib-2.0/gio/gioenums.h:28,
from /usr/include/glib-2.0/gio/giotypes.h:28,
from /usr/include/glib-2.0/gio/gio.h:26,
from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
from /usr/include/gtk-2.0/gdk/gdk.h:32,
from /usr/include/gtk-2.0/gtk/gtk.h:32,
from test-gtk2.c:3:
/usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
551 | struct _GTimeVal
| ^~~~~~~~~
cc1: all warnings being treated as errors
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2019-12-06 15:04 ` Jiri Olsa
@ 2019-12-06 15:35 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-12-06 15:35 UTC (permalink / raw)
To: Jiri Olsa
Cc: Ingo Molnar, Thomas Gleixner, Jiri Olsa, Namhyung Kim,
Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Ravi Bangoria, Arnaldo Carvalho de Melo
Em Fri, Dec 06, 2019 at 04:04:55PM +0100, Jiri Olsa escreveu:
> On Fri, Dec 06, 2019 at 11:43:54AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Dec 06, 2019 at 03:25:16PM +0100, Jiri Olsa escreveu:
> > > On Fri, Dec 06, 2019 at 08:57:01AM +0100, Ingo Molnar wrote:
> > >
> > > SNIP
> > >
> > > > > tools/include/uapi/drm/drm.h | 3 +-
> > > > > tools/include/uapi/drm/i915_drm.h | 128 +++++++++++++++++++++++++++++++++++++-
> > > > > tools/perf/builtin-inject.c | 13 +---
> > > > > tools/perf/builtin-report.c | 8 +++
> > > > > tools/perf/util/sort.c | 16 +++--
> > > > > 5 files changed, 147 insertions(+), 21 deletions(-)
> > > >
> > > > Pulled, thanks a lot Arnaldo!
> > > >
> > > > JFYI, on my system the default perf/urgent build still has this noise
> > > > generated by util/parse-events.y and util/expr.y:
> > > >
> > > > util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > > > 1 | %pure-parser
> > > > | ^~~~~~~~~~~~
> > > > util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> > > > util/expr.y:15.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > > > 15 | %pure-parser
> > > > | ^~~~~~~~~~~~
> > > > util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> > >
> > > just saw it in fedora 31 with new bison, change below
> > > should fix it, I'll post it with other fixes later
> >
> > As I explained to Ingo, this will make it fail with older systems, for
> > now this is just a warning, thus I've not been eager to get this merged,
> > Andi alredy submitted this, for instance.
> >
> > Is there some way to have some sort of ifdef based on bison's version so
> > that we can have both?
>
> I see, I guess we could use one or another based on
> bison version with macro
If you could do that, that would be great, the attempt may well
enlighten us if that is possible and if not, then, oh well, I can just
update bison on these older systems and keep a note in my container
definition files :-)
- Arnaldo
> jirka
>
> >
> > At some point I'll just bite the bullet and stop testing on such older
> > systems, but while this is not strictly needed...
> >
> > - Arnaldo
> >
> > > jirka
> > >
> > > ---
> > > diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> > > index f9a20a39b64a..4ef801334b9d 100644
> > > --- a/tools/perf/util/expr.y
> > > +++ b/tools/perf/util/expr.y
> > > @@ -12,7 +12,7 @@
> > > #define MAXIDLEN 256
> > > %}
> > >
> > > -%pure-parser
> > > +%define api.pure
> > > %parse-param { double *final_val }
> > > %parse-param { struct parse_ctx *ctx }
> > > %parse-param { const char **pp }
> > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> > > index e2eea4e601b4..87a0d11676f0 100644
> > > --- a/tools/perf/util/parse-events.y
> > > +++ b/tools/perf/util/parse-events.y
> > > @@ -1,4 +1,4 @@
> > > -%pure-parser
> > > +%define api.pure
> > > %parse-param {void *_parse_state}
> > > %parse-param {void *scanner}
> > > %lex-param {void* scanner}
> >
> > --
> >
> > - Arnaldo
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2019-12-06 14:43 ` Arnaldo Carvalho de Melo
@ 2019-12-06 15:04 ` Jiri Olsa
2019-12-06 15:35 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 32+ messages in thread
From: Jiri Olsa @ 2019-12-06 15:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, Thomas Gleixner, Jiri Olsa, Namhyung Kim,
Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Ravi Bangoria, Arnaldo Carvalho de Melo
On Fri, Dec 06, 2019 at 11:43:54AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Dec 06, 2019 at 03:25:16PM +0100, Jiri Olsa escreveu:
> > On Fri, Dec 06, 2019 at 08:57:01AM +0100, Ingo Molnar wrote:
> >
> > SNIP
> >
> > > > tools/include/uapi/drm/drm.h | 3 +-
> > > > tools/include/uapi/drm/i915_drm.h | 128 +++++++++++++++++++++++++++++++++++++-
> > > > tools/perf/builtin-inject.c | 13 +---
> > > > tools/perf/builtin-report.c | 8 +++
> > > > tools/perf/util/sort.c | 16 +++--
> > > > 5 files changed, 147 insertions(+), 21 deletions(-)
> > >
> > > Pulled, thanks a lot Arnaldo!
> > >
> > > JFYI, on my system the default perf/urgent build still has this noise
> > > generated by util/parse-events.y and util/expr.y:
> > >
> > > util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > > 1 | %pure-parser
> > > | ^~~~~~~~~~~~
> > > util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> > > util/expr.y:15.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > > 15 | %pure-parser
> > > | ^~~~~~~~~~~~
> > > util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> >
> > just saw it in fedora 31 with new bison, change below
> > should fix it, I'll post it with other fixes later
>
> As I explained to Ingo, this will make it fail with older systems, for
> now this is just a warning, thus I've not been eager to get this merged,
> Andi alredy submitted this, for instance.
>
> Is there some way to have some sort of ifdef based on bison's version so
> that we can have both?
I see, I guess we could use one or another based on
bison version with macro
jirka
>
> At some point I'll just bite the bullet and stop testing on such older
> systems, but while this is not strictly needed...
>
> - Arnaldo
>
> > jirka
> >
> > ---
> > diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> > index f9a20a39b64a..4ef801334b9d 100644
> > --- a/tools/perf/util/expr.y
> > +++ b/tools/perf/util/expr.y
> > @@ -12,7 +12,7 @@
> > #define MAXIDLEN 256
> > %}
> >
> > -%pure-parser
> > +%define api.pure
> > %parse-param { double *final_val }
> > %parse-param { struct parse_ctx *ctx }
> > %parse-param { const char **pp }
> > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> > index e2eea4e601b4..87a0d11676f0 100644
> > --- a/tools/perf/util/parse-events.y
> > +++ b/tools/perf/util/parse-events.y
> > @@ -1,4 +1,4 @@
> > -%pure-parser
> > +%define api.pure
> > %parse-param {void *_parse_state}
> > %parse-param {void *scanner}
> > %lex-param {void* scanner}
>
> --
>
> - Arnaldo
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2019-12-06 14:25 ` Jiri Olsa
@ 2019-12-06 14:43 ` Arnaldo Carvalho de Melo
2019-12-06 15:04 ` Jiri Olsa
0 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-12-06 14:43 UTC (permalink / raw)
To: Jiri Olsa
Cc: Ingo Molnar, Thomas Gleixner, Jiri Olsa, Namhyung Kim,
Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Ravi Bangoria, Arnaldo Carvalho de Melo
Em Fri, Dec 06, 2019 at 03:25:16PM +0100, Jiri Olsa escreveu:
> On Fri, Dec 06, 2019 at 08:57:01AM +0100, Ingo Molnar wrote:
>
> SNIP
>
> > > tools/include/uapi/drm/drm.h | 3 +-
> > > tools/include/uapi/drm/i915_drm.h | 128 +++++++++++++++++++++++++++++++++++++-
> > > tools/perf/builtin-inject.c | 13 +---
> > > tools/perf/builtin-report.c | 8 +++
> > > tools/perf/util/sort.c | 16 +++--
> > > 5 files changed, 147 insertions(+), 21 deletions(-)
> >
> > Pulled, thanks a lot Arnaldo!
> >
> > JFYI, on my system the default perf/urgent build still has this noise
> > generated by util/parse-events.y and util/expr.y:
> >
> > util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > 1 | %pure-parser
> > | ^~~~~~~~~~~~
> > util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> > util/expr.y:15.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> > 15 | %pure-parser
> > | ^~~~~~~~~~~~
> > util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
>
> just saw it in fedora 31 with new bison, change below
> should fix it, I'll post it with other fixes later
As I explained to Ingo, this will make it fail with older systems, for
now this is just a warning, thus I've not been eager to get this merged,
Andi alredy submitted this, for instance.
Is there some way to have some sort of ifdef based on bison's version so
that we can have both?
At some point I'll just bite the bullet and stop testing on such older
systems, but while this is not strictly needed...
- Arnaldo
> jirka
>
> ---
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index f9a20a39b64a..4ef801334b9d 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -12,7 +12,7 @@
> #define MAXIDLEN 256
> %}
>
> -%pure-parser
> +%define api.pure
> %parse-param { double *final_val }
> %parse-param { struct parse_ctx *ctx }
> %parse-param { const char **pp }
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index e2eea4e601b4..87a0d11676f0 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -1,4 +1,4 @@
> -%pure-parser
> +%define api.pure
> %parse-param {void *_parse_state}
> %parse-param {void *scanner}
> %lex-param {void* scanner}
--
- Arnaldo
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2019-12-06 7:57 ` Ingo Molnar
2019-12-06 14:24 ` Arnaldo Carvalho de Melo
@ 2019-12-06 14:25 ` Jiri Olsa
2019-12-06 14:43 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 32+ messages in thread
From: Jiri Olsa @ 2019-12-06 14:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, Thomas Gleixner, Jiri Olsa,
Namhyung Kim, Clark Williams, linux-kernel, linux-perf-users,
Adrian Hunter, Ravi Bangoria, Arnaldo Carvalho de Melo
On Fri, Dec 06, 2019 at 08:57:01AM +0100, Ingo Molnar wrote:
SNIP
> > tools/include/uapi/drm/drm.h | 3 +-
> > tools/include/uapi/drm/i915_drm.h | 128 +++++++++++++++++++++++++++++++++++++-
> > tools/perf/builtin-inject.c | 13 +---
> > tools/perf/builtin-report.c | 8 +++
> > tools/perf/util/sort.c | 16 +++--
> > 5 files changed, 147 insertions(+), 21 deletions(-)
>
> Pulled, thanks a lot Arnaldo!
>
> JFYI, on my system the default perf/urgent build still has this noise
> generated by util/parse-events.y and util/expr.y:
>
> util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> 1 | %pure-parser
> | ^~~~~~~~~~~~
> util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> util/expr.y:15.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> 15 | %pure-parser
> | ^~~~~~~~~~~~
> util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
just saw it in fedora 31 with new bison, change below
should fix it, I'll post it with other fixes later
jirka
---
diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
index f9a20a39b64a..4ef801334b9d 100644
--- a/tools/perf/util/expr.y
+++ b/tools/perf/util/expr.y
@@ -12,7 +12,7 @@
#define MAXIDLEN 256
%}
-%pure-parser
+%define api.pure
%parse-param { double *final_val }
%parse-param { struct parse_ctx *ctx }
%parse-param { const char **pp }
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index e2eea4e601b4..87a0d11676f0 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -1,4 +1,4 @@
-%pure-parser
+%define api.pure
%parse-param {void *_parse_state}
%parse-param {void *scanner}
%lex-param {void* scanner}
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2019-12-06 7:57 ` Ingo Molnar
@ 2019-12-06 14:24 ` Arnaldo Carvalho de Melo
2019-12-06 14:25 ` Jiri Olsa
1 sibling, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-12-06 14:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: Thomas Gleixner, Jiri Olsa, Namhyung Kim, Clark Williams,
linux-kernel, linux-perf-users, Adrian Hunter, Ravi Bangoria,
Arnaldo Carvalho de Melo
Em Fri, Dec 06, 2019 at 08:57:01AM +0100, Ingo Molnar escreveu:
> Pulled, thanks a lot Arnaldo!
> JFYI, on my system the default perf/urgent build still has this noise
> generated by util/parse-events.y and util/expr.y:
> util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> 1 | %pure-parser
> | ^~~~~~~~~~~~
> util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
> util/expr.y:15.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
> 15 | %pure-parser
> | ^~~~~~~~~~~~
> util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
I'll get to this, I've been postponing dealing with this nuisance as,
IIRC, this will make perf not build in systems with older bisons.
- Arnaldo
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2019-12-05 19:32 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
@ 2019-12-06 7:57 ` Ingo Molnar
2019-12-06 14:24 ` Arnaldo Carvalho de Melo
2019-12-06 14:25 ` Jiri Olsa
2020-01-13 8:28 ` Ravi Bangoria
1 sibling, 2 replies; 32+ messages in thread
From: Ingo Molnar @ 2019-12-06 7:57 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Thomas Gleixner, Jiri Olsa, Namhyung Kim, Clark Williams,
linux-kernel, linux-perf-users, Adrian Hunter, Ravi Bangoria,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo/Thomas,
>
> Please consider pulling,
>
> Best regards,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 9f58c93efdffc2cba91fdcee010b3e5e8860334d:
>
> Merge tag 'perf-core-for-mingo-5.5-20191203' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2019-12-04 08:49:52 +0100)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-5.5-20191205
>
> for you to fetch changes up to fd9bee5e24141d00e23b66d1b51bc759efa7e3fe:
>
> tools headers UAPI: Update tools's copy of drm.h headers (2019-12-04 16:22:38 -0300)
>
> ----------------------------------------------------------------
> perf inject:
>
> Adrian Hunter:
>
> - Fix processing of ID index for injected instruction tracing
>
> perf report:
>
> Ravi Bangoria:
>
> - Replace pr_err() with ui__error(), so that we can see the output
> in the TUI mode instead of showing and immediately restoring the
> screen to the state before perf was started.
>
> - Don't start --mem-mode/--branch-mode mode if required samples are not
> available.
>
> tools headers UAPI:
>
> Arnaldo Carvalho de Melo:
>
> - Sync drm/i915_drm.h with the kernel sources
>
> - Update tools's copy of drm.h headers.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (1):
> perf inject: Fix processing of ID index for injected instruction tracing
>
> Arnaldo Carvalho de Melo (2):
> tools headers UAPI: Sync drm/i915_drm.h with the kernel sources
> tools headers UAPI: Update tools's copy of drm.h headers
>
> Ravi Bangoria (3):
> perf report/top TUI: Replace pr_err() with ui__error()
> perf report: Make -F more strict like -s
> perf report: Bail out --mem-mode if mem info is not available
>
> tools/include/uapi/drm/drm.h | 3 +-
> tools/include/uapi/drm/i915_drm.h | 128 +++++++++++++++++++++++++++++++++++++-
> tools/perf/builtin-inject.c | 13 +---
> tools/perf/builtin-report.c | 8 +++
> tools/perf/util/sort.c | 16 +++--
> 5 files changed, 147 insertions(+), 21 deletions(-)
Pulled, thanks a lot Arnaldo!
JFYI, on my system the default perf/urgent build still has this noise
generated by util/parse-events.y and util/expr.y:
util/parse-events.y:1.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
1 | %pure-parser
| ^~~~~~~~~~~~
util/parse-events.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
util/expr.y:15.1-12: warning: deprecated directive, use ‘%define api.pure’ [-Wdeprecated]
15 | %pure-parser
| ^~~~~~~~~~~~
util/expr.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
Thanks,
Ingo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2019-12-05 19:32 Arnaldo Carvalho de Melo
2019-12-06 7:57 ` Ingo Molnar
2020-01-13 8:28 ` Ravi Bangoria
0 siblings, 2 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-12-05 19:32 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner
Cc: Jiri Olsa, Namhyung Kim, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo, Adrian Hunter,
Ravi Bangoria, Arnaldo Carvalho de Melo
Hi Ingo/Thomas,
Please consider pulling,
Best regards,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 9f58c93efdffc2cba91fdcee010b3e5e8860334d:
Merge tag 'perf-core-for-mingo-5.5-20191203' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2019-12-04 08:49:52 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-5.5-20191205
for you to fetch changes up to fd9bee5e24141d00e23b66d1b51bc759efa7e3fe:
tools headers UAPI: Update tools's copy of drm.h headers (2019-12-04 16:22:38 -0300)
----------------------------------------------------------------
perf inject:
Adrian Hunter:
- Fix processing of ID index for injected instruction tracing
perf report:
Ravi Bangoria:
- Replace pr_err() with ui__error(), so that we can see the output
in the TUI mode instead of showing and immediately restoring the
screen to the state before perf was started.
- Don't start --mem-mode/--branch-mode mode if required samples are not
available.
tools headers UAPI:
Arnaldo Carvalho de Melo:
- Sync drm/i915_drm.h with the kernel sources
- Update tools's copy of drm.h headers.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (1):
perf inject: Fix processing of ID index for injected instruction tracing
Arnaldo Carvalho de Melo (2):
tools headers UAPI: Sync drm/i915_drm.h with the kernel sources
tools headers UAPI: Update tools's copy of drm.h headers
Ravi Bangoria (3):
perf report/top TUI: Replace pr_err() with ui__error()
perf report: Make -F more strict like -s
perf report: Bail out --mem-mode if mem info is not available
tools/include/uapi/drm/drm.h | 3 +-
tools/include/uapi/drm/i915_drm.h | 128 +++++++++++++++++++++++++++++++++++++-
tools/perf/builtin-inject.c | 13 +---
tools/perf/builtin-report.c | 8 +++
tools/perf/util/sort.c | 16 +++--
5 files changed, 147 insertions(+), 21 deletions(-)
Test results:
The first ones are container based builds of tools/perf with and without libelf
support. Where clang is available, it is also used to build perf with/without
libelf, and building with LIBCLANGLLVM=1 (built-in clang) with gcc and clang
when clang and its devel libraries are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
Clearlinux is failing when building with libpython, but that is not a perf
regression, will try to remove one compiler warning that is causing the problem
when building some of the glue code files in the python files, outside perf.
OpenMandriva Cooker works well with gcc, uncovers a bug where we have to
get compiler-clang.h from the kernel sources, will be fixed soon.
With the update of linux/linkage.h to move from ENTRY()/ENDPROC() to
SYM_FUNC_START()/etc some of the older containers can't be used with clang,
as the minimum version for the constructs used in the new linkage.h is 3.5,
older versions (3.4, 3.4.2, etc) end up with:
bench/../../arch/x86/lib/memcpy_64.S:44:14: error: unexpected token in '.type' directive
.type MEMCPY STT_FUNC ; .size MEMCPY, .-MEMCPY
^
Finally the build-tests and container tests were performed with the following
two fixes (different sha, same contents), that are not in this patch series,
will go thru the bpf/net trees.
The 'perf test' was performed with what is in this series tho.
$ git log --oneline -2
e1bc15a8e7d1 (HEAD -> perf/core) libbpf: Use PRIu64 for sym->st_value to fix build on 32-bit arches
0d0f9df96c5a libbpf: Fix up generation of bpf_helper_defs.h
$
# export PERF_TARBALL=http://192.168.124.1/perf/perf-5.4.0.tar.xz
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0, clang version 3.8.0 (tags/RELEASE_380/final)
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822, clang version 3.8.1 (tags/RELEASE_381/final)
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0, clang version 4.0.0 (tags/RELEASE_400/final)
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0, Alpine clang version 5.0.0 (tags/RELEASE_500/final) (based on LLVM 5.0.0)
5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0, Alpine clang version 5.0.1 (tags/RELEASE_501/final) (based on LLVM 5.0.1)
6 alpine:3.9 : Ok gcc (Alpine 8.3.0) 8.3.0, Alpine clang version 5.0.1 (tags/RELEASE_502/final) (based on LLVM 5.0.1)
7 alpine:3.10 : Ok gcc (Alpine 8.3.0) 8.3.0, Alpine clang version 8.0.0 (tags/RELEASE_800/final) (based on LLVM 8.0.0)
8 alpine:edge : Ok gcc (Alpine 9.2.0) 9.2.0, Alpine clang version 9.0.0 (git://git.alpinelinux.org/aports 25c73ae7b95bdb42ae5f0ceac3b703e766582527) (based on LLVM 9.0.0)
9 amazonlinux:1 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2), clang version 3.6.2 (tags/RELEASE_362/final)
10 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6), clang version 7.0.1 (Amazon Linux 2 7.0.1-1.amzn2.0.2)
11 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
12 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
13 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
14 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
15 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39)
16 centos:8 : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3), clang version 7.0.1 (tags/RELEASE_701/final)
17 clearlinux:latest : FAIL gcc (Clear Linux OS for Intel Architecture) 9.2.1 20191125 gcc-9-branch@278689, clang version 9.0.0 (tags/RELEASE_900/final)
18 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u2) 4.9.2, Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
19 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516, clang version 3.8.1-24 (tags/RELEASE_381/final)
20 debian:10 : Ok gcc (Debian 8.3.0-6) 8.3.0, clang version 7.0.1-8 (tags/RELEASE_701/final)
21 debian:experimental : Ok gcc (Debian 9.2.1-19) 9.2.1 20191109, clang version 8.0.1-4 (tags/RELEASE_801/final)
22 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.3.0-19) 8.3.0
23 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.3.0-19) 8.3.0
24 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 9.2.1-8) 9.2.1 20190909
25 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 9.2.1-8) 9.2.1 20190909
26 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
27 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6), clang version 3.5.0 (tags/RELEASE_350/final)
28 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6), clang version 3.7.0 (tags/RELEASE_370/final)
29 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1), clang version 3.8.1 (tags/RELEASE_381/final)
30 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
31 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1), clang version 3.9.1 (tags/RELEASE_391/final)
32 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2), clang version 4.0.1 (tags/RELEASE_401/final)
33 fedora:27 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6), clang version 5.0.2 (tags/RELEASE_502/final)
34 fedora:28 : Ok gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2), clang version 6.0.1 (tags/RELEASE_601/final)
35 fedora:29 : Ok gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2), clang version 7.0.1 (Fedora 7.0.1-6.fc29)
36 fedora:30 : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 8.0.0 (Fedora 8.0.0-3.fc30)
37 fedora:30-x-ARC-glibc : Ok arc-linux-gcc (ARC HS GNU/Linux glibc toolchain 2019.03-rc1) 8.3.1 20190225
38 fedora:30-x-ARC-uClibc : Ok arc-linux-gcc (ARCv2 ISA Linux uClibc toolchain 2019.03-rc1) 8.3.1 20190225
39 fedora:31 : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 9.0.0 (Fedora 9.0.0-1.fc31)
40 fedora:32 : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 9.0.0 (Fedora 9.0.0-1.fc32)
41 fedora:rawhide : Ok gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1), clang version 9.0.0 (Fedora 9.0.0-1.fc32)
42 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 9.2.0-r2 p3) 9.2.0
43 mageia:5 : Ok gcc (GCC) 4.9.2, clang version 3.5.2 (tags/RELEASE_352/final)
44 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0, clang version 3.9.1 (tags/RELEASE_391/final)
45 mageia:7 : Ok gcc (Mageia 8.3.1-0.20190524.1.mga7) 8.3.1 20190524, clang version 8.0.0 (Mageia 8.0.0-1.mga7)
46 manjaro:latest : Ok gcc (GCC) 9.2.0, clang version 9.0.0 (tags/RELEASE_900/final)
47 openmandriva:cooker : Ok gcc (GCC) 9.2.1 20191123 (OpenMandriva)
48 opensuse:15.0 : Ok gcc (SUSE Linux) 7.4.1 20190424 [gcc-7-branch revision 270538], clang version 5.0.1 (tags/RELEASE_501/final 312548)
49 opensuse:15.1 : Ok gcc (SUSE Linux) 7.4.1 20190905 [gcc-7-branch revision 275407], clang version 7.0.1 (tags/RELEASE_701/final 349238)
50 opensuse:15.2 : Ok gcc (SUSE Linux) 7.4.1 20190905 [gcc-7-branch revision 275407], clang version 7.0.1 (tags/RELEASE_701/final 349238)
51 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5, clang version 3.8.0 (tags/RELEASE_380/final 262553)
52 opensuse:tumbleweed : Ok gcc (SUSE Linux) 9.2.1 20190903 [gcc-9-branch revision 275330], clang version 9.0.0 (tags/RELEASE_900/final 372316)
53 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
54 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39.0.3)
55 oraclelinux:8 : Ok gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3.0.1), clang version 7.0.1 (tags/RELEASE_701/final)
56 ubuntu:12.04 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
57 ubuntu:14.04 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4) 4.8.4
58 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609, clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
59 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
60 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
61 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
62 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
63 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
64 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
65 ubuntu:18.04 : Ok gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0, clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
66 ubuntu:18.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.4.0-1ubuntu1~18.04.1) 7.4.0
67 ubuntu:18.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.4.0-1ubuntu1~18.04.1) 7.4.0
68 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
69 ubuntu:18.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
70 ubuntu:18.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
71 ubuntu:18.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
72 ubuntu:18.04-x-riscv64 : Ok riscv64-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
73 ubuntu:18.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
74 ubuntu:18.04-x-sh4 : Ok sh4-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
75 ubuntu:18.04-x-sparc64 : Ok sparc64-linux-gnu-gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
76 ubuntu:18.10 : Ok gcc (Ubuntu 8.3.0-6ubuntu1~18.10.1) 8.3.0, clang version 7.0.0-3 (tags/RELEASE_700/final)
77 ubuntu:19.04 : Ok gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0, clang version 8.0.0-3 (tags/RELEASE_800/final)
78 ubuntu:19.04-x-alpha : Ok alpha-linux-gnu-gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0
79 ubuntu:19.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 8.3.0-6ubuntu1) 8.3.0
80 ubuntu:19.04-x-hppa : Ok hppa-linux-gnu-gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0
81 ubuntu:19.10 : Ok gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008, clang version 9.0.0-2 (tags/RELEASE_900/final)
# uname -a
Linux quaco 5.3.14-200.fc30.x86_64 #1 SMP Mon Dec 2 15:57:50 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
# git log --oneline -1
fd9bee5e2414 tools headers UAPI: Update tools's copy of drm.h headers
# perf version --build-options
perf version 5.4.gfd9bee5e2414
dwarf: [ on ] # HAVE_DWARF_SUPPORT
dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
glibc: [ on ] # HAVE_GLIBC_SUPPORT
gtk2: [ on ] # HAVE_GTK2_SUPPORT
syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
libbfd: [ on ] # HAVE_LIBBFD_SUPPORT
libelf: [ on ] # HAVE_LIBELF_SUPPORT
libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT
numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT
libperl: [ on ] # HAVE_LIBPERL_SUPPORT
libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
libslang: [ on ] # HAVE_SLANG_SUPPORT
libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
zlib: [ on ] # HAVE_ZLIB_SUPPORT
lzma: [ on ] # HAVE_LZMA_SUPPORT
get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT
bpf: [ on ] # HAVE_LIBBPF_SUPPORT
aio: [ on ] # HAVE_AIO_SUPPORT
zstd: [ on ] # HAVE_ZSTD_SUPPORT
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Watchpoint :
22.1: Read Only Watchpoint : Skip
22.2: Write Only Watchpoint : Ok
22.3: Read / Write Watchpoint : Ok
22.4: Modify Watchpoint : Ok
23: Number of exit events of a simple workload : Ok
24: Software clock events period values : Ok
25: Object code reading : Ok
26: Sample parsing : Ok
27: Use a dummy software event to keep tracking : Ok
28: Parse with no sample_id_all bit set : Ok
29: Filter hist entries : Ok
30: Lookup mmap thread : Ok
31: Share thread maps : Ok
32: Sort output of hist entries : Ok
33: Cumulate child hist entries : Ok
34: Track with sched_switch : Ok
35: Filter fds with revents mask in a fdarray : Ok
36: Add fd to a fdarray, making it autogrow : Ok
37: kmod_path__parse : Ok
38: Thread map : Ok
39: LLVM search and compile :
39.1: Basic BPF llvm compile : Ok
39.2: kbuild searching : Ok
39.3: Compile source for BPF prologue generation : Ok
39.4: Compile source for BPF relocation : Ok
40: Session topology : Ok
41: BPF filter :
41.1: Basic BPF filtering : Ok
41.2: BPF pinning : Ok
41.3: BPF prologue generation : Ok
41.4: BPF relocation checker : Ok
42: Synthesize thread map : Ok
43: Remove thread map : Ok
44: Synthesize cpu map : Ok
45: Synthesize stat config : Ok
46: Synthesize stat : Ok
47: Synthesize stat round : Ok
48: Synthesize attr update : Ok
49: Event times : Ok
50: Read backward ring buffer : Ok
51: Print cpu map : Ok
52: Merge cpu map : Ok
53: Probe SDT events : Ok
54: is_printable_array : Ok
55: Print bitmap : Ok
56: perf hooks : Ok
57: builtin clang support : Skip (not compiled in)
58: unit_number__scnprintf : Ok
59: mem2node : Ok
60: time utils : Ok
61: Test jit_write_elf : Ok
62: maps__merge_in : Ok
63: x86 rdpmc : Ok
64: Convert perf time to TSC : Ok
65: DWARF unwind : Ok
66: x86 instruction decoder - new instructions : Ok
67: Intel PT packet decoder : Ok
68: x86 bp modify : Ok
69: probe libc's inet_pton & backtrace it with ping : Ok
70: Use vfs_getname probe to get syscall args filenames : Ok
71: Add vfs_getname probe to get syscall args filenames : Ok
72: Check open filename arg using perf trace + vfs_getname: Ok
73: Zstd perf.data compression/decompression : Ok
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_help_O: make help
make_no_libnuma_O: make NO_LIBNUMA=1
make_tags_O: make tags
make_clean_all_O: make clean all
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_gtk2_O: make NO_GTK2=1
make_no_newt_O: make NO_NEWT=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_static_O: make LDFLAGS=-static NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 NO_JVMTI=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_cscope_O: make cscope
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_backtrace_O: make NO_BACKTRACE=1
make_util_map_o_O: make util/map.o
make_no_libelf_O: make NO_LIBELF=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1 NO_LIBZSTD=1 NO_LIBCAP=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_debug_O: make DEBUG=1
make_no_slang_O: make NO_SLANG=1
make_install_O: make install
make_pure_O: make
make_install_prefix_O: make install prefix=/tmp/krava
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_doc_O: make doc
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_libperl_O: make NO_LIBPERL=1
make_install_bin_O: make install-bin
make_perf_o_O: make perf.o
make_no_demangle_O: make NO_DEMANGLE=1
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2018-05-07 20:13 Arnaldo Carvalho de Melo
@ 2018-05-10 18:10 ` Ingo Molnar
0 siblings, 0 replies; 32+ messages in thread
From: Ingo Molnar @ 2018-05-10 18:10 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Andi Kleen, David Ahern, Fenghua Yu,
Jiri Olsa, Kan Liang, KarimAllah Ahmed, Marc Zyngier,
Namhyung Kim, Peter Zijlstra, Radim Krčmář,
Wang Nan, William Cohen, Yisheng Xie, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 1504269814263c9676b4605a6a91e14dc6ceac21:
>
> Merge tag 'linux-kselftest-4.17-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest (2018-05-03 19:26:51 -1000)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf-urgent-for-mingo-4.17-20180507
>
> for you to fetch changes up to 4a35a9027f64d588d2fd9436dda4126e8d5647d7:
>
> Revert "perf pmu: Fix pmu events parsing rule" (2018-05-07 16:28:10 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Revert "perf pmu: Fix pmu events parsing rule", as it broke Intel PT
> event description parsing (Arnaldo Carvalho de Melo)
>
> . Sync x86's cpufeatures.h and kvm UAPI headers with the kernel sources,
> suppressing the ABI drift warnings (Arnaldo Carvalho de Melo)
>
> - Remove duplicated entry for westmereep-dp in Intel's mapfile.csv (William Cohen)
>
> - Fix typo in 'perf bench numa' options description (Yisheng Xie)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
> tools headers: Sync x86 cpufeatures.h with the kernel sources
> tools headers kvm: Sync uapi/linux/kvm.h with the kernel sources
> tools headers kvm: Sync ARM UAPI headers with the kernel sources
> Revert "perf pmu: Fix pmu events parsing rule"
>
> William Cohen (1):
> perf vendor events intel: Remove duplicated entry for westmereep-dp in mapfile.csv
>
> Yisheng Xie (1):
> perf bench numa: Fix typo in options
>
> tools/arch/arm/include/uapi/asm/kvm.h | 6 ++++++
> tools/arch/arm64/include/uapi/asm/kvm.h | 6 ++++++
> tools/arch/x86/include/asm/cpufeatures.h | 1 +
> tools/include/uapi/linux/kvm.h | 7 +++++++
> tools/perf/bench/numa.c | 2 +-
> tools/perf/pmu-events/arch/x86/mapfile.csv | 1 -
> tools/perf/util/parse-events.y | 8 ++++----
> 7 files changed, 25 insertions(+), 6 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2018-05-07 20:13 Arnaldo Carvalho de Melo
2018-05-10 18:10 ` Ingo Molnar
0 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-05-07 20:13 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin,
Andi Kleen, David Ahern, Fenghua Yu, Jiri Olsa, Kan Liang,
KarimAllah Ahmed, Marc Zyngier, Namhyung Kim, Peter Zijlstra,
Radim Krčmář,
Wang Nan, William Cohen, Yisheng Xie, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 1504269814263c9676b4605a6a91e14dc6ceac21:
Merge tag 'linux-kselftest-4.17-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest (2018-05-03 19:26:51 -1000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf-urgent-for-mingo-4.17-20180507
for you to fetch changes up to 4a35a9027f64d588d2fd9436dda4126e8d5647d7:
Revert "perf pmu: Fix pmu events parsing rule" (2018-05-07 16:28:10 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Revert "perf pmu: Fix pmu events parsing rule", as it broke Intel PT
event description parsing (Arnaldo Carvalho de Melo)
. Sync x86's cpufeatures.h and kvm UAPI headers with the kernel sources,
suppressing the ABI drift warnings (Arnaldo Carvalho de Melo)
- Remove duplicated entry for westmereep-dp in Intel's mapfile.csv (William Cohen)
- Fix typo in 'perf bench numa' options description (Yisheng Xie)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
tools headers: Sync x86 cpufeatures.h with the kernel sources
tools headers kvm: Sync uapi/linux/kvm.h with the kernel sources
tools headers kvm: Sync ARM UAPI headers with the kernel sources
Revert "perf pmu: Fix pmu events parsing rule"
William Cohen (1):
perf vendor events intel: Remove duplicated entry for westmereep-dp in mapfile.csv
Yisheng Xie (1):
perf bench numa: Fix typo in options
tools/arch/arm/include/uapi/asm/kvm.h | 6 ++++++
tools/arch/arm64/include/uapi/asm/kvm.h | 6 ++++++
tools/arch/x86/include/asm/cpufeatures.h | 1 +
tools/include/uapi/linux/kvm.h | 7 +++++++
tools/perf/bench/numa.c | 2 +-
tools/perf/pmu-events/arch/x86/mapfile.csv | 1 -
tools/perf/util/parse-events.y | 8 ++++----
7 files changed, 25 insertions(+), 6 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with
and without libelf support. Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
6 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
7 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
8 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
9 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
11 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
12 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
13 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
14 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
15 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
16 debian:experimental : Ok gcc (Debian 7.3.0-15) 7.3.0
17 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 7.3.0-15) 7.3.0
18 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
19 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 7.3.0-12) 7.3.0
20 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
21 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
22 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
23 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
24 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
25 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
26 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
27 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
28 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
29 fedora:27 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
# uname -a
Linux jouet 4.17.0-rc3-00034-gf4ef6a438cee #18 SMP Thu May 3 11:49:35 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Number of exit events of a simple workload : Ok
23: Software clock events period values : Ok
24: Object code reading : Ok
25: Sample parsing : Ok
26: Use a dummy software event to keep tracking : Ok
27: Parse with no sample_id_all bit set : Ok
28: Filter hist entries : Ok
29: Lookup mmap thread : Ok
30: Share thread mg : Ok
31: Sort output of hist entries : Ok
32: Cumulate child hist entries : Ok
33: Track with sched_switch : Ok
34: Filter fds with revents mask in a fdarray : Ok
35: Add fd to a fdarray, making it autogrow : Ok
36: kmod_path__parse : Ok
37: Thread map : Ok
38: LLVM search and compile :
38.1: Basic BPF llvm compile : Ok
38.2: kbuild searching : Ok
38.3: Compile source for BPF prologue generation : Ok
38.4: Compile source for BPF relocation : Ok
39: Session topology : Ok
40: BPF filter :
40.1: Basic BPF filtering : Ok
40.2: BPF pinning : Ok
40.3: BPF prologue generation : Ok
40.4: BPF relocation checker : Ok
41: Synthesize thread map : Ok
42: Remove thread map : Ok
43: Synthesize cpu map : Ok
44: Synthesize stat config : Ok
45: Synthesize stat : Ok
46: Synthesize stat round : Ok
47: Synthesize attr update : Ok
48: Event times : Ok
49: Read backward ring buffer : Ok
50: Print cpu map : Ok
51: Probe SDT events : Ok
52: is_printable_array : Ok
53: Print bitmap : Ok
54: perf hooks : Ok
55: builtin clang support : Skip (not compiled in)
56: unit_number__scnprintf : Ok
57: mem2node : Ok
58: x86 rdpmc : Ok
59: Convert perf time to TSC : Ok
60: DWARF unwind : Ok
61: x86 instruction decoder - new instructions : Ok
62: Use vfs_getname probe to get syscall args filenames : Ok
63: Check open filename arg using perf trace + vfs_getname: Ok
64: probe libc's inet_pton & backtrace it with ping : Ok
65: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_gtk2_O: make NO_GTK2=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_perf_o_O: make perf.o
make_static_O: make LDFLAGS=-static
make_util_map_o_O: make util/map.o
make_pure_O: make
make_with_babeltrace_O: make LIBBABELTRACE=1
make_clean_all_O: make clean all
make_install_prefix_O: make install prefix=/tmp/krava
make_no_newt_O: make NO_NEWT=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_libaudit_O: make NO_LIBAUDIT=1
make_install_bin_O: make install-bin
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_libelf_O: make NO_LIBELF=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_tags_O: make tags
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_slang_O: make NO_SLANG=1
make_doc_O: make doc
make_no_libbionic_O: make NO_LIBBIONIC=1
make_help_O: make help
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libperl_O: make NO_LIBPERL=1
make_debug_O: make DEBUG=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_install_O: make install
make_no_libbpf_O: make NO_LIBBPF=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
[acme@jouet perf]$
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2018-04-06 11:24 Arnaldo Carvalho de Melo
@ 2018-04-06 12:41 ` Ingo Molnar
0 siblings, 0 replies; 32+ messages in thread
From: Ingo Molnar @ 2018-04-06 12:41 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter, Andi Kleen,
Arnaldo Carvalho de Melo, Chris Wilson, David Ahern, Jin Yao,
Jiri Olsa, Joonas Lahtinen, Kan Liang, Lionel Landwerlin,
Namhyung Kim, Tvrtko Ursulin, Wang Nan
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit d1e7e602cd64cf61f87dbf30df07c24df9eb1d99:
>
> perf/x86/intel: Move regs->flags EXACT bit init (2018-04-05 09:28:40 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.17-20180406
>
> for you to fetch changes up to 01f97511f13cbf2ba3d23b2bffa06258dc81e283:
>
> tools headers uapi: Synchronize i915_drm.h (2018-04-05 14:48:51 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Show group details on the title line in the annotate browser
> and 'perf annotate --stdio2' output, so that the per-event
> columns can have headers (Arnaldo Carvalho de Melo)
>
> - Fixup vertical line separating metrics from instructions and
> cleaning unused lines at the bottom, both in the annotate TUI
> browser (Arnaldo Carvalho de Melo)
>
> - Remove duplicated 'samples' in lost samples warning in
> 'perf report' (Arnaldo Carvalho de Melo)
>
> - Synchronize i915_drm.h, silencing the perf build process,
> automagically adding support for the new DRM_I915_QUERY
> ioctl (Arnaldo Carvalho de Melo)
>
> - Make auxtrace_queues__add_buffer() allocate struct buffer,
> from a patchkit already applied (Adrian Hunter)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (1):
> perf auxtrace: Make auxtrace_queues__add_buffer() allocate struct buffer
>
> Arnaldo Carvalho de Melo (5):
> perf annotate: Show group details on the title line
> perf annotate browser: Fixup vertical line separating metrics from instructions
> perf ui browser: Fixup cleaning unused lines at the bottom
> perf report: Remove duplicated 'samples' in lost samples warning
> tools headers uapi: Synchronize i915_drm.h
>
> tools/include/uapi/drm/i915_drm.h | 112 ++++++++++++++++++++++++++++++++++++--
> tools/perf/ui/browser.c | 4 +-
> tools/perf/ui/browsers/annotate.c | 2 +-
> tools/perf/util/annotate.c | 7 ++-
> tools/perf/util/auxtrace.c | 54 ++++++++----------
> tools/perf/util/session.c | 2 +-
> 6 files changed, 141 insertions(+), 40 deletions(-)
Pulled, thanks a lot Arnaldo!
Thanks,
Ingo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2018-04-06 11:24 Arnaldo Carvalho de Melo
2018-04-06 12:41 ` Ingo Molnar
0 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-04-06 11:24 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Andi Kleen, Arnaldo Carvalho de Melo,
Chris Wilson, David Ahern, Jin Yao, Jiri Olsa, Joonas Lahtinen,
Kan Liang, Lionel Landwerlin, Namhyung Kim, Tvrtko Ursulin,
Wang Nan
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit d1e7e602cd64cf61f87dbf30df07c24df9eb1d99:
perf/x86/intel: Move regs->flags EXACT bit init (2018-04-05 09:28:40 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.17-20180406
for you to fetch changes up to 01f97511f13cbf2ba3d23b2bffa06258dc81e283:
tools headers uapi: Synchronize i915_drm.h (2018-04-05 14:48:51 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Show group details on the title line in the annotate browser
and 'perf annotate --stdio2' output, so that the per-event
columns can have headers (Arnaldo Carvalho de Melo)
- Fixup vertical line separating metrics from instructions and
cleaning unused lines at the bottom, both in the annotate TUI
browser (Arnaldo Carvalho de Melo)
- Remove duplicated 'samples' in lost samples warning in
'perf report' (Arnaldo Carvalho de Melo)
- Synchronize i915_drm.h, silencing the perf build process,
automagically adding support for the new DRM_I915_QUERY
ioctl (Arnaldo Carvalho de Melo)
- Make auxtrace_queues__add_buffer() allocate struct buffer,
from a patchkit already applied (Adrian Hunter)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (1):
perf auxtrace: Make auxtrace_queues__add_buffer() allocate struct buffer
Arnaldo Carvalho de Melo (5):
perf annotate: Show group details on the title line
perf annotate browser: Fixup vertical line separating metrics from instructions
perf ui browser: Fixup cleaning unused lines at the bottom
perf report: Remove duplicated 'samples' in lost samples warning
tools headers uapi: Synchronize i915_drm.h
tools/include/uapi/drm/i915_drm.h | 112 ++++++++++++++++++++++++++++++++++++--
tools/perf/ui/browser.c | 4 +-
tools/perf/ui/browsers/annotate.c | 2 +-
tools/perf/util/annotate.c | 7 ++-
tools/perf/util/auxtrace.c | 54 ++++++++----------
tools/perf/util/session.c | 2 +-
6 files changed, 141 insertions(+), 40 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support. Where clang is available, it is also used to build
perf with/without libelf.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
6 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
7 amazonlinux:2 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
8 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
9 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
11 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
12 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
13 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
14 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
15 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
16 debian:experimental : Ok gcc (Debian 7.3.0-14) 7.3.0
17 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
18 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
19 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 7.3.0-12) 7.3.0
20 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
21 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
22 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
23 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
24 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
25 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
26 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
27 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
28 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
29 fedora:27 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
30 fedora:28 : Ok gcc (GCC) 8.0.1 20180324 (Red Hat 8.0.1-0.20)
31 fedora:rawhide : Ok gcc (GCC) 8.0.1 20180222 (Red Hat 8.0.1-0.16)
32 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 6.4.0-r1 p1.3) 6.4.0
33 mageia:5 : Ok gcc (GCC) 4.9.2
34 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0
35 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
36 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
37 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
38 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.0
39 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
40 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16.0.3)
41 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
42 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
43 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.4-2017.05) 5.4.1 20170404
44 ubuntu:15.04 : Ok gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
45 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
46 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
47 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
48 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
49 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
50 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
51 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
52 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
53 ubuntu:17.04 : Ok gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
54 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0
55 ubuntu:18.04 : Ok gcc (Ubuntu 7.2.0-16ubuntu1) 7.2.0
# uname -a
Linux jouet 4.16.0-rc7 #3 SMP Mon Mar 26 14:35:30 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Skip
22: Number of exit events of a simple workload : Ok
23: Software clock events period values : Ok
24: Object code reading : Ok
25: Sample parsing : Ok
26: Use a dummy software event to keep tracking : Ok
27: Parse with no sample_id_all bit set : Ok
28: Filter hist entries : Ok
29: Lookup mmap thread : Ok
30: Share thread mg : Ok
31: Sort output of hist entries : Ok
32: Cumulate child hist entries : Ok
33: Track with sched_switch : Ok
34: Filter fds with revents mask in a fdarray : Ok
35: Add fd to a fdarray, making it autogrow : Ok
36: kmod_path__parse : Ok
37: Thread map : Ok
38: LLVM search and compile :
38.1: Basic BPF llvm compile : Ok
38.2: kbuild searching : Ok
38.3: Compile source for BPF prologue generation : Ok
38.4: Compile source for BPF relocation : Ok
39: Session topology : Ok
40: BPF filter :
40.1: Basic BPF filtering : Ok
40.2: BPF pinning : Ok
40.3: BPF prologue generation : Ok
40.4: BPF relocation checker : Ok
41: Synthesize thread map : Ok
42: Remove thread map : Ok
43: Synthesize cpu map : Ok
44: Synthesize stat config : Ok
45: Synthesize stat : Ok
46: Synthesize stat round : Ok
47: Synthesize attr update : Ok
48: Event times : Ok
49: Read backward ring buffer : Ok
50: Print cpu map : Ok
51: Probe SDT events : Ok
52: is_printable_array : Ok
53: Print bitmap : Ok
54: perf hooks : Ok
55: builtin clang support : Skip (not compiled in)
56: unit_number__scnprintf : Ok
57: mem2node : Ok
58: x86 rdpmc : Ok
59: Convert perf time to TSC : Ok
60: DWARF unwind : Ok
61: x86 instruction decoder - new instructions : Ok
62: Use vfs_getname probe to get syscall args filenames : Ok
63: probe libc's inet_pton & backtrace it with ping : Ok
64: Check open filename arg using perf trace + vfs_getname: Ok
65: probe libc's inet_pton & backtrace it with ping : Ok
66: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_auxtrace_O: make NO_AUXTRACE=1
make_util_map_o_O: make util/map.o
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_install_O: make install
make_pure_O: make
make_no_libelf_O: make NO_LIBELF=1
make_no_slang_O: make NO_SLANG=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_gtk2_O: make NO_GTK2=1
make_install_bin_O: make install-bin
make_no_libperl_O: make NO_LIBPERL=1
make_no_newt_O: make NO_NEWT=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_libbpf_O: make NO_LIBBPF=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_demangle_O: make NO_DEMANGLE=1
make_debug_O: make DEBUG=1
make_help_O: make help
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_static_O: make LDFLAGS=-static
make_no_libbionic_O: make NO_LIBBIONIC=1
make_tags_O: make tags
make_install_prefix_O: make install prefix=/tmp/krava
make_no_libnuma_O: make NO_LIBNUMA=1
make_clean_all_O: make clean all
make_perf_o_O: make perf.o
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_backtrace_O: make NO_BACKTRACE=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_doc_O: make doc
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2015-11-12 22:56 Arnaldo Carvalho de Melo
@ 2015-11-13 9:11 ` Ingo Molnar
0 siblings, 0 replies; 32+ messages in thread
From: Ingo Molnar @ 2015-11-13 9:11 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Brendan Gregg, David Ahern, Jiri Olsa, Jonathan Cameron,
Kamal Mostafa, Masami Hiramatsu, Namhyung Kim, Pali Rohar,
Pavel Machek, pi3orama, Roberta Dobrescu, Wang Nan, Zefan Li
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 41ac18ebfc429ce3f4d369ef07447d652999a0cd:
>
> perf/x86/intel/rapl: Remove the unused RAPL_EVENT_DESC() macro (2015-11-12 09:44:25 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 2059fc7a5a9e667797b8ec503bfb4685afee48d8:
>
> perf symbols: Allow forcing reading of non-root owned files by root (2015-11-12 18:58:18 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> - Fix 'd' hotkey for filtering by DSO in the top/report
> TUI browser (Arnaldo Carvalho de Melo)
>
> - Allow forcing reading of non-root owned /tmp/perf-PID JIT
> symbol maps (Arnaldo Carvalho de Melo)
>
> - Rebuild rbtree when adjusting symbols for kcore (Adrian Hunter)
>
> - Actually install tmon in the tools/ install rule (Kamal Mostafa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (1):
> perf symbols: Rebuild rbtree when adjusting symbols for kcore
>
> Arnaldo Carvalho de Melo (3):
> perf hists browser: Fix 'd' hotkey action to filter by DSO
> perf hists browser: The dso can be obtained from popup_action->ms.map->dso
> perf symbols: Allow forcing reading of non-root owned files by root
>
> Kamal Mostafa (2):
> tools: Actually install tmon in the install rule
> tools: Add a "make all" rule
>
> tools/Makefile | 11 ++++++++++-
> tools/perf/builtin-report.c | 6 +++---
> tools/perf/ui/browsers/hists.c | 7 +------
> tools/perf/util/symbol.c | 34 ++++++++++++++++------------------
> tools/perf/util/symbol.h | 1 +
> 5 files changed, 31 insertions(+), 28 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2015-11-12 22:56 Arnaldo Carvalho de Melo
2015-11-13 9:11 ` Ingo Molnar
0 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-11-12 22:56 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Brendan Gregg, David Ahern, Jiri Olsa, Jonathan Cameron,
Kamal Mostafa, Masami Hiramatsu, Namhyung Kim, Pali Rohar,
Pavel Machek, pi3orama, Roberta Dobrescu, Wang Nan, Zefan Li
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 41ac18ebfc429ce3f4d369ef07447d652999a0cd:
perf/x86/intel/rapl: Remove the unused RAPL_EVENT_DESC() macro (2015-11-12 09:44:25 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo
for you to fetch changes up to 2059fc7a5a9e667797b8ec503bfb4685afee48d8:
perf symbols: Allow forcing reading of non-root owned files by root (2015-11-12 18:58:18 -0300)
----------------------------------------------------------------
perf/urgent fixes:
- Fix 'd' hotkey for filtering by DSO in the top/report
TUI browser (Arnaldo Carvalho de Melo)
- Allow forcing reading of non-root owned /tmp/perf-PID JIT
symbol maps (Arnaldo Carvalho de Melo)
- Rebuild rbtree when adjusting symbols for kcore (Adrian Hunter)
- Actually install tmon in the tools/ install rule (Kamal Mostafa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (1):
perf symbols: Rebuild rbtree when adjusting symbols for kcore
Arnaldo Carvalho de Melo (3):
perf hists browser: Fix 'd' hotkey action to filter by DSO
perf hists browser: The dso can be obtained from popup_action->ms.map->dso
perf symbols: Allow forcing reading of non-root owned files by root
Kamal Mostafa (2):
tools: Actually install tmon in the install rule
tools: Add a "make all" rule
tools/Makefile | 11 ++++++++++-
tools/perf/builtin-report.c | 6 +++---
tools/perf/ui/browsers/hists.c | 7 +------
tools/perf/util/symbol.c | 34 ++++++++++++++++------------------
tools/perf/util/symbol.h | 1 +
5 files changed, 31 insertions(+), 28 deletions(-)
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2013-10-07 19:02 Arnaldo Carvalho de Melo
@ 2013-10-08 5:32 ` Ingo Molnar
0 siblings, 0 replies; 32+ messages in thread
From: Ingo Molnar @ 2013-10-08 5:32 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Masami Hiramatsu,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Sonny Rao, Stephane Eranian, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit d8b11a0cbd1c66ce283eb9dabe0498dfa6483f32:
>
> perf/x86: Clean up cap_user_time* setting (2013-10-04 09:58:55 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to b314e5cfd11fd78545ce6c2be42646254390c1aa:
>
> perf session: Fix infinite loop on invalid perf.data file (2013-10-04 15:17:46 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . The libaudit test was failing in some systems due to a unescaped newline, fix
> it so that the 'trace' tool can be built in such systems.
>
> . Fix installation of libexec components.
>
> . Add default handler for mmap2 events so that tools that don't explicitely
> define an MMAP2 handler don't crash, fix from David Ahern.
>
> . Fix to find line information for probe list, from Masami Hiramatsu.
>
> . Set child_pid after perf_evlist__prepare_workload(), fix from Namhyung Kim.
>
> . Fix infinite loop on invalid perf.data file, from Namhyung Kim.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf tools: Fix libaudit test
> perf tools: Fix installation of libexec components
>
> David Ahern (1):
> perf tools: Add default handler for mmap2 events
>
> Masami Hiramatsu (1):
> perf probe: Fix to find line information for probe list
>
> Namhyung Kim (2):
> perf stat: Set child_pid after perf_evlist__prepare_workload()
> perf session: Fix infinite loop on invalid perf.data file
>
> tools/perf/Makefile | 1 +
> tools/perf/builtin-stat.c | 1 +
> tools/perf/config/feature-tests.mak | 2 +-
> tools/perf/util/dwarf-aux.c | 25 ++++++++++++++++---
> tools/perf/util/dwarf-aux.h | 6 ++++-
> tools/perf/util/header.c | 12 +++++++++
> tools/perf/util/probe-finder.c | 49 +++++++++++++++++++++++++------------
> tools/perf/util/session.c | 4 ++-
> 8 files changed, 77 insertions(+), 23 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2013-10-07 19:02 Arnaldo Carvalho de Melo
2013-10-08 5:32 ` Ingo Molnar
0 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-10-07 19:02 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Frederic Weisbecker, Jiri Olsa, Masami Hiramatsu,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Sonny Rao, Stephane Eranian, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit d8b11a0cbd1c66ce283eb9dabe0498dfa6483f32:
perf/x86: Clean up cap_user_time* setting (2013-10-04 09:58:55 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to b314e5cfd11fd78545ce6c2be42646254390c1aa:
perf session: Fix infinite loop on invalid perf.data file (2013-10-04 15:17:46 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. The libaudit test was failing in some systems due to a unescaped newline, fix
it so that the 'trace' tool can be built in such systems.
. Fix installation of libexec components.
. Add default handler for mmap2 events so that tools that don't explicitely
define an MMAP2 handler don't crash, fix from David Ahern.
. Fix to find line information for probe list, from Masami Hiramatsu.
. Set child_pid after perf_evlist__prepare_workload(), fix from Namhyung Kim.
. Fix infinite loop on invalid perf.data file, from Namhyung Kim.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf tools: Fix libaudit test
perf tools: Fix installation of libexec components
David Ahern (1):
perf tools: Add default handler for mmap2 events
Masami Hiramatsu (1):
perf probe: Fix to find line information for probe list
Namhyung Kim (2):
perf stat: Set child_pid after perf_evlist__prepare_workload()
perf session: Fix infinite loop on invalid perf.data file
tools/perf/Makefile | 1 +
tools/perf/builtin-stat.c | 1 +
tools/perf/config/feature-tests.mak | 2 +-
tools/perf/util/dwarf-aux.c | 25 ++++++++++++++++---
tools/perf/util/dwarf-aux.h | 6 ++++-
tools/perf/util/header.c | 12 +++++++++
tools/perf/util/probe-finder.c | 49 +++++++++++++++++++++++++------------
tools/perf/util/session.c | 4 ++-
8 files changed, 77 insertions(+), 23 deletions(-)
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2013-09-25 17:20 Arnaldo Carvalho de Melo
@ 2013-09-25 18:28 ` Ingo Molnar
0 siblings, 0 replies; 32+ messages in thread
From: Ingo Molnar @ 2013-09-25 18:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Frederic Weisbecker,
Ingo Molnar, Jiri Olsa, Masami Hiramatsu, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit cf3b425dd8d99e01214515a6754f9e69ecc6dce8:
>
> perf/x86/intel: Add model number for Avoton Silvermont (2013-09-23 10:22:00 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to de95ab53645a2f0015e0f68ee723f18dce2b8b51:
>
> perf symbols: Demangle cloned functions (2013-09-25 12:58:21 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . It was possible to use an uninitialized buffer when reading
> kernel modules information and checking if the file was a
> /proc/sys/kernel/kptr_restrict'ed one, fix for this from
> Adrian Hunter.
>
> . The libbfd demangler doesn't handle cloned functions (e.g. symbol.clone.NUM),
> feed it unsuffixed symbol names, workaround from Andi Kleen.
>
> . Fix segfault in 'perf trace' when processing perf.data files with PERF_RECORD_MMAP2
> records, recently added but not handled in this tool, from David Ahern.
>
> . Fix libdl related build in old systems like Fedora 12, from David Ahern.
>
> . Make 'perf kmem' work again on non NUMA machines, fix from Jiri Olsa.
>
> . Fix probing symbols with optimization suffix in 'perf probe' where some
> operations that are entirely user level and involves vmlinux/DWARF were working
> but when the symbol name was fed to the kprobes tracer, the in kernel code
> would use /proc/kallsyms where the name had the suffix, from Masami Hiramatsu.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (1):
> perf machine: Fix path unpopulated in machine__create_modules()
>
> Andi Kleen (1):
> perf symbols: Demangle cloned functions
>
> David Ahern (2):
> perf trace: Add mmap2 handler
> perf tools: Explicitly add libdl dependency
>
> Jiri Olsa (1):
> perf kmem: Make it work again on non NUMA machines
>
> Masami Hiramatsu (1):
> perf probe: Fix probing symbols with optimization suffix
>
> tools/perf/builtin-kmem.c | 2 +-
> tools/perf/builtin-trace.c | 1 +
> tools/perf/config/Makefile | 2 +-
> tools/perf/util/machine.c | 2 +-
> tools/perf/util/probe-finder.c | 77 ++++++++++++++++++++++--------------------
> tools/perf/util/probe-finder.h | 3 ++
> tools/perf/util/symbol-elf.c | 27 ++++++++++++++-
> 7 files changed, 74 insertions(+), 40 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2013-09-25 17:20 Arnaldo Carvalho de Melo
2013-09-25 18:28 ` Ingo Molnar
0 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-25 17:20 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Corey Ashford, David Ahern, Frederic Weisbecker,
Ingo Molnar, Jiri Olsa, Masami Hiramatsu, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit cf3b425dd8d99e01214515a6754f9e69ecc6dce8:
perf/x86/intel: Add model number for Avoton Silvermont (2013-09-23 10:22:00 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to de95ab53645a2f0015e0f68ee723f18dce2b8b51:
perf symbols: Demangle cloned functions (2013-09-25 12:58:21 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. It was possible to use an uninitialized buffer when reading
kernel modules information and checking if the file was a
/proc/sys/kernel/kptr_restrict'ed one, fix for this from
Adrian Hunter.
. The libbfd demangler doesn't handle cloned functions (e.g. symbol.clone.NUM),
feed it unsuffixed symbol names, workaround from Andi Kleen.
. Fix segfault in 'perf trace' when processing perf.data files with PERF_RECORD_MMAP2
records, recently added but not handled in this tool, from David Ahern.
. Fix libdl related build in old systems like Fedora 12, from David Ahern.
. Make 'perf kmem' work again on non NUMA machines, fix from Jiri Olsa.
. Fix probing symbols with optimization suffix in 'perf probe' where some
operations that are entirely user level and involves vmlinux/DWARF were working
but when the symbol name was fed to the kprobes tracer, the in kernel code
would use /proc/kallsyms where the name had the suffix, from Masami Hiramatsu.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (1):
perf machine: Fix path unpopulated in machine__create_modules()
Andi Kleen (1):
perf symbols: Demangle cloned functions
David Ahern (2):
perf trace: Add mmap2 handler
perf tools: Explicitly add libdl dependency
Jiri Olsa (1):
perf kmem: Make it work again on non NUMA machines
Masami Hiramatsu (1):
perf probe: Fix probing symbols with optimization suffix
tools/perf/builtin-kmem.c | 2 +-
tools/perf/builtin-trace.c | 1 +
tools/perf/config/Makefile | 2 +-
tools/perf/util/machine.c | 2 +-
tools/perf/util/probe-finder.c | 77 ++++++++++++++++++++++--------------------
tools/perf/util/probe-finder.h | 3 ++
tools/perf/util/symbol-elf.c | 27 ++++++++++++++-
7 files changed, 74 insertions(+), 40 deletions(-)
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [GIT PULL 0/6] perf/urgent fixes
2013-09-05 19:42 Arnaldo Carvalho de Melo
@ 2013-09-06 12:09 ` Ingo Molnar
0 siblings, 0 replies; 32+ messages in thread
From: Ingo Molnar @ 2013-09-06 12:09 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Corey Ashford, David Ahern, Frederic Weisbecker, Jiri Olsa,
Kyle McMartin, Linus Torvalds, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 816434ec4a674fcdb3c2221a6dffdc8f34020550:
>
> Merge branch 'x86-spinlocks-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2013-09-04 11:55:10 -0700)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
>
> for you to fetch changes up to 526fd8d4f770d18e99680ff87965e16bb8f1d806:
>
> perf session: Separate progress bar update when processing events (2013-09-05 16:19:02 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fixes:
>
> . Fix parsing with no sample_id_all bit set, this regression prevents perf
> from reading old perf.data files generated in systems where
> perf_event_attr.sample_id_all isn't available, from Adrian Hunter.
>
> . Add signal checking to the inner 'perf trace' event processing loop, allowing
> faster response to control+C.
>
> . Fix formatting of long symbol names removing the hardcoding of a buffer
> size used to format histogram entries, which was truncating the lines.
>
> . Separate progress bar update when processing events, reducing potentially big
> overhead in not needed TUI progress bar screen updates, from Jiri Olsa.
>
> . Fix 'perf trace' build in architectures where MAP_32BIT is not defined, from
> Kyle McMartin.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf tools: Add test for parsing with no sample_id_all bit
> perf evlist: Fix parsing with no sample_id_all bit set
>
> Arnaldo Carvalho de Melo (2):
> perf trace: Check control+C more often
> perf hists: Fix formatting of long symbol names
>
> Jiri Olsa (1):
> perf session: Separate progress bar update when processing events
>
> Kyle McMartin (1):
> perf trace: Check if MAP_32BIT is defined
>
> tools/perf/Makefile | 3 +-
> tools/perf/builtin-trace.c | 5 ++
> tools/perf/tests/builtin-test.c | 4 ++
> tools/perf/tests/parse-no-sample-id-all.c | 108 ++++++++++++++++++++++++++++++
> tools/perf/tests/tests.h | 1 +
> tools/perf/ui/stdio/hist.c | 23 +++++--
> tools/perf/util/evlist.c | 9 ++-
> tools/perf/util/session.c | 3 +-
> 8 files changed, 146 insertions(+), 10 deletions(-)
> create mode 100644 tools/perf/tests/parse-no-sample-id-all.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2013-09-05 19:42 Arnaldo Carvalho de Melo
2013-09-06 12:09 ` Ingo Molnar
0 siblings, 1 reply; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-05 19:42 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Corey Ashford, David Ahern, Frederic Weisbecker, Jiri Olsa,
Kyle McMartin, Linus Torvalds, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 816434ec4a674fcdb3c2221a6dffdc8f34020550:
Merge branch 'x86-spinlocks-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2013-09-04 11:55:10 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-urgent-for-mingo
for you to fetch changes up to 526fd8d4f770d18e99680ff87965e16bb8f1d806:
perf session: Separate progress bar update when processing events (2013-09-05 16:19:02 -0300)
----------------------------------------------------------------
perf/urgent fixes:
. Fix parsing with no sample_id_all bit set, this regression prevents perf
from reading old perf.data files generated in systems where
perf_event_attr.sample_id_all isn't available, from Adrian Hunter.
. Add signal checking to the inner 'perf trace' event processing loop, allowing
faster response to control+C.
. Fix formatting of long symbol names removing the hardcoding of a buffer
size used to format histogram entries, which was truncating the lines.
. Separate progress bar update when processing events, reducing potentially big
overhead in not needed TUI progress bar screen updates, from Jiri Olsa.
. Fix 'perf trace' build in architectures where MAP_32BIT is not defined, from
Kyle McMartin.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf tools: Add test for parsing with no sample_id_all bit
perf evlist: Fix parsing with no sample_id_all bit set
Arnaldo Carvalho de Melo (2):
perf trace: Check control+C more often
perf hists: Fix formatting of long symbol names
Jiri Olsa (1):
perf session: Separate progress bar update when processing events
Kyle McMartin (1):
perf trace: Check if MAP_32BIT is defined
tools/perf/Makefile | 3 +-
tools/perf/builtin-trace.c | 5 ++
tools/perf/tests/builtin-test.c | 4 ++
tools/perf/tests/parse-no-sample-id-all.c | 108 ++++++++++++++++++++++++++++++
tools/perf/tests/tests.h | 1 +
tools/perf/ui/stdio/hist.c | 23 +++++--
tools/perf/util/evlist.c | 9 ++-
tools/perf/util/session.c | 3 +-
8 files changed, 146 insertions(+), 10 deletions(-)
create mode 100644 tools/perf/tests/parse-no-sample-id-all.c
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2011-08-26 15:37 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-08-26 15:37 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Anton Blanchard,
David Ahern, Eric B Munson, Frederic Weisbecker,
Masami Hiramatsu, Paul Mackerras, Pekka Enberg, Peter Zijlstra,
Thomas Gleixner, yrl.pp-manager.tt, arnaldo.melo
Hi Ingo,
Please consider pulling from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/urgent
Regards,
- Arnaldo
Anton Blanchard (4):
perf symbols: Fix ppc64 SEGV in dso__load_sym with debuginfo files
perf symbols: /proc/kallsyms does not sort module symbols
perf symbols: Preserve symbol scope when parsing /proc/kallsyms
perf symbols: Add some heuristics for choosing the best duplicate symbol
David Ahern (1):
perf record: Create events initially disabled and enable after init
Masami Hiramatsu (1):
perf probe: Fix regression of variable finder
tools/perf/builtin-record.c | 3 +
tools/perf/util/evlist.c | 13 ++++
tools/perf/util/evlist.h | 1 +
tools/perf/util/probe-finder.c | 2 +-
tools/perf/util/symbol.c | 129 ++++++++++++++++++++++++++++++++--------
5 files changed, 123 insertions(+), 25 deletions(-)
^ permalink raw reply [flat|nested] 32+ messages in thread
* [GIT PULL 0/6] perf/urgent fixes
@ 2011-08-18 16:49 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 32+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-08-18 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Andi Kleen,
Frederic Weisbecker, Geunsik Lim, Ingo Molnar, Joe Perches,
Josh Boyer, Lin Ming, Li Zefan, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, arnaldo.melo
Hi Ingo,
Please consider pulling from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/urgent
The group event stuff is a fix, as all that was missing was to expose
the "group" bool variable thru a command line option.
Regards,
- Arnaldo
Geunsik Lim (1):
MAINTAINERS: Fix list of perf events source files
Josh Boyer (1):
perf tools: Fix build against newer glibc
Lin Ming (1):
perf tools: Add group event scheduling option to perf record/stat
Stephane Eranian (3):
perf list: Fix exit value
perf evlist: Fix missing event name init for default event
perf tools: Fix error handling of unknown events
MAINTAINERS | 2 +-
tools/perf/builtin-record.c | 4 +++-
tools/perf/builtin-stat.c | 7 +++++--
tools/perf/util/evlist.c | 11 ++++++++++-
tools/perf/util/include/linux/compiler.h | 2 ++
tools/perf/util/parse-events.c | 8 +++++---
6 files changed, 26 insertions(+), 8 deletions(-)
^ permalink raw reply [flat|nested] 32+ messages in thread
end of thread, other threads:[~2020-01-13 9:44 UTC | newest]
Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28 12:25 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 1/6] perf script python: Fix export-to-postgresql.py occasional failure Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 2/6] perf script python: Fix export-to-sqlite.py sample columns Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 3/6] perf report: Don't try to map ip to invalid map Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 4/6] perf report: Use the offset address to find inline frames Arnaldo Carvalho de Melo
2018-10-01 5:42 ` Ravi Bangoria
2018-09-28 12:25 ` [PATCH 5/6] perf report: Don't crash on invalid inline debug information Arnaldo Carvalho de Melo
2018-09-28 12:25 ` [PATCH 6/6] perf python: Use -Wno-redundant-decls to build with PYTHON=python3 Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2019-12-05 19:32 [GIT PULL 0/6] perf/urgent fixes Arnaldo Carvalho de Melo
2019-12-06 7:57 ` Ingo Molnar
2019-12-06 14:24 ` Arnaldo Carvalho de Melo
2019-12-06 14:25 ` Jiri Olsa
2019-12-06 14:43 ` Arnaldo Carvalho de Melo
2019-12-06 15:04 ` Jiri Olsa
2019-12-06 15:35 ` Arnaldo Carvalho de Melo
2020-01-13 8:28 ` Ravi Bangoria
2020-01-13 9:25 ` Jiri Olsa
2020-01-13 9:44 ` Ravi Bangoria
2018-05-07 20:13 Arnaldo Carvalho de Melo
2018-05-10 18:10 ` Ingo Molnar
2018-04-06 11:24 Arnaldo Carvalho de Melo
2018-04-06 12:41 ` Ingo Molnar
2015-11-12 22:56 Arnaldo Carvalho de Melo
2015-11-13 9:11 ` Ingo Molnar
2013-10-07 19:02 Arnaldo Carvalho de Melo
2013-10-08 5:32 ` Ingo Molnar
2013-09-25 17:20 Arnaldo Carvalho de Melo
2013-09-25 18:28 ` Ingo Molnar
2013-09-05 19:42 Arnaldo Carvalho de Melo
2013-09-06 12:09 ` Ingo Molnar
2011-08-26 15:37 Arnaldo Carvalho de Melo
2011-08-18 16:49 Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).