linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Bad MAINTAINERS pattern in section 'VIRTIO AND VHOST VSOCK DRIVER'
@ 2018-09-28 22:05 Joe Perches
  2018-10-12 15:46 ` Stefan Hajnoczi
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2018-09-28 22:05 UTC (permalink / raw)
  To: linux-kernel
  Cc: Stefan Hajnoczi, kvm, virtualization, netdev, David S . Miller

Please fix this defect appropriately.

linux-next MAINTAINERS section:

	15660	VIRTIO AND VHOST VSOCK DRIVER
	15661	M:	Stefan Hajnoczi <stefanha@redhat.com>
	15662	L:	kvm@vger.kernel.org
	15663	L:	virtualization@lists.linux-foundation.org
	15664	L:	netdev@vger.kernel.org
	15665	S:	Maintained
	15666	F:	include/linux/virtio_vsock.h
	15667	F:	include/uapi/linux/virtio_vsock.h
	15668	F:	include/uapi/linux/vsockmon.h
	15669	F:	include/uapi/linux/vm_sockets_diag.h
	15670	F:	net/vmw_vsock/diag.c
	15671	F:	net/vmw_vsock/af_vsock_tap.c
	15672	F:	net/vmw_vsock/virtio_transport_common.c
	15673	F:	net/vmw_vsock/virtio_transport.c
	15674	F:	drivers/net/vsockmon.c
	15675	F:	drivers/vhost/vsock.c
-->	15676	F:	drivers/vhost/vsock.h
	15677	F:	tools/testing/vsock/

Commit that introduced this:

commit 433fc58e6bf2c8bd97e57153ed28e64fd78207b8
 Author: Asias He <asias@redhat.com>
 Date:   Thu Jul 28 15:36:34 2016 +0100
 
     VSOCK: Introduce vhost_vsock.ko
     
     VM sockets vhost transport implementation.  This driver runs on the
     host.
     
     Signed-off-by: Asias He <asias@redhat.com>
     Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
 
  MAINTAINERS                |   2 +
  drivers/vhost/vsock.c      | 722 +++++++++++++++++++++++++++++++++++++++++++++
  include/uapi/linux/vhost.h |   5 +
  3 files changed, 729 insertions(+)

Last commit with drivers/vhost/vsock.h

commit 8ac2837c89c8c0fcad557e4380aeef80580390f9
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Wed Dec 9 10:51:12 2015 +0800

    Revert "Merge branch 'vsock-virtio'"
    
    This reverts commit 0d76d6e8b2507983a2cae4c09880798079007421 and merge
    commit c402293bd76fbc93e52ef8c0947ab81eea3ae019, reversing changes made
    to c89359a42e2a49656451569c382eed63e781153c.
    
    The virtio-vsock device specification is not finalized yet.  Michael
    Tsirkin voiced concerned about merging this code when the hardware
    interface (and possibly the userspace interface) could still change.
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

 drivers/vhost/Kconfig                   |    4 -
 drivers/vhost/Kconfig.vsock             |    7 -
 drivers/vhost/Makefile                  |    4 -
 drivers/vhost/vsock.c                   |  630 ---------------
 drivers/vhost/vsock.h                   |    4 -
 include/linux/virtio_vsock.h            |  209 -----
 include/net/af_vsock.h                  |    2 -
 include/uapi/linux/virtio_ids.h         |    1 -
 include/uapi/linux/virtio_vsock.h       |   89 ---
 net/vmw_vsock/Kconfig                   |   18 -
 net/vmw_vsock/Makefile                  |    2 -
 net/vmw_vsock/af_vsock.c                |   70 --
 net/vmw_vsock/virtio_transport.c        |  466 -----------
 net/vmw_vsock/virtio_transport_common.c | 1272 -------------------------------
 14 files changed, 2778 deletions(-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bad MAINTAINERS pattern in section 'VIRTIO AND VHOST VSOCK DRIVER'
  2018-09-28 22:05 Bad MAINTAINERS pattern in section 'VIRTIO AND VHOST VSOCK DRIVER' Joe Perches
@ 2018-10-12 15:46 ` Stefan Hajnoczi
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2018-10-12 15:46 UTC (permalink / raw)
  To: Joe Perches
  Cc: linux-kernel, Stefan Hajnoczi, kvm, virtualization, netdev,
	David S . Miller

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Fri, Sep 28, 2018 at 03:05:26PM -0700, Joe Perches wrote:
> Please fix this defect appropriately.
> 
> linux-next MAINTAINERS section:
> 
> 	15660	VIRTIO AND VHOST VSOCK DRIVER
> 	15661	M:	Stefan Hajnoczi <stefanha@redhat.com>
> 	15662	L:	kvm@vger.kernel.org
> 	15663	L:	virtualization@lists.linux-foundation.org
> 	15664	L:	netdev@vger.kernel.org
> 	15665	S:	Maintained
> 	15666	F:	include/linux/virtio_vsock.h
> 	15667	F:	include/uapi/linux/virtio_vsock.h
> 	15668	F:	include/uapi/linux/vsockmon.h
> 	15669	F:	include/uapi/linux/vm_sockets_diag.h
> 	15670	F:	net/vmw_vsock/diag.c
> 	15671	F:	net/vmw_vsock/af_vsock_tap.c
> 	15672	F:	net/vmw_vsock/virtio_transport_common.c
> 	15673	F:	net/vmw_vsock/virtio_transport.c
> 	15674	F:	drivers/net/vsockmon.c
> 	15675	F:	drivers/vhost/vsock.c
> -->	15676	F:	drivers/vhost/vsock.h

Hi Joe,
Thanks for pointing this out and sorry for the late response.  I have
sent a patch.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-12 15:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28 22:05 Bad MAINTAINERS pattern in section 'VIRTIO AND VHOST VSOCK DRIVER' Joe Perches
2018-10-12 15:46 ` Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).