From: Bjorn Helgaas <helgaas@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Keith Busch <keith.busch@intel.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
linux-pci@vger.kernel.org
Subject: Re: Bad MAINTAINERS pattern in section 'ACPI'
Date: Fri, 28 Sep 2018 18:06:17 -0500 [thread overview]
Message-ID: <20180928230616.GA150287@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180928215054.28561-1-joe@perches.com>
[+cc Tony, Borislav (ACPI APEI reviewers), linux-pci]
On Fri, Sep 28, 2018 at 02:50:53PM -0700, Joe Perches wrote:
> Please fix this defect appropriately.
>
> linux-next MAINTAINERS section:
>
> 308 ACPI
> 309 M: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> 310 M: Len Brown <lenb@kernel.org>
> 311 L: linux-acpi@vger.kernel.org
> 312 W: https://01.org/linux-acpi
> 313 Q: https://patchwork.kernel.org/project/linux-acpi/list/
> 314 T: git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
> 315 B: https://bugzilla.kernel.org
> 316 S: Supported
> 317 F: drivers/acpi/
> 318 F: drivers/pnp/pnpacpi/
> 319 F: include/linux/acpi.h
> 320 F: include/linux/fwnode.h
> 321 F: include/acpi/
> 322 F: Documentation/acpi/
> 323 F: Documentation/ABI/testing/sysfs-bus-acpi
> 324 F: Documentation/ABI/testing/configfs-acpi
> 325 F: drivers/pci/*acpi*
> 326 F: drivers/pci/*/*acpi*
> --> 327 F: drivers/pci/*/*/*acpi*
> 328 F: tools/power/acpi/
My proposal to fix this:
commit a99051c0d3c59fd259fd76a8bbd9837b76b509d9
Author: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri Sep 28 17:34:21 2018 -0500
MAINTAINERS: Remove obsolete drivers/pci pattern from ACPI section
Prior to 256a45937093 ("PCI/AER: Squash aerdrv_acpi.c into aerdrv.c"),
drivers/pci/pcie/aer/aerdrv_acpi.c contained code to parse the ACPI HEST
table. That code now lives in drivers/pci/pcie/aer.c.
Remove the "F: drivers/pci/*/*/*acpi*" pattern because it matches nothing.
We could add a "F: drivers/pci/pcie/aer.c" pattern to the ACPI APEI
section, but that file sees a lot of changes, almost none of which are of
interest to the ACPI folks.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
diff --git a/MAINTAINERS b/MAINTAINERS
index 700408b7bc53..9babd8a0406b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -324,7 +324,6 @@ F: Documentation/ABI/testing/sysfs-bus-acpi
F: Documentation/ABI/testing/configfs-acpi
F: drivers/pci/*acpi*
F: drivers/pci/*/*acpi*
-F: drivers/pci/*/*/*acpi*
F: tools/power/acpi/
ACPI APEI
next prev parent reply other threads:[~2018-09-28 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 21:50 Bad MAINTAINERS pattern in section 'ACPI' Joe Perches
2018-09-28 23:06 ` Bjorn Helgaas [this message]
2018-09-29 13:18 ` Rafael J. Wysocki
2018-10-01 18:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928230616.GA150287@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=joe@perches.com \
--cc=keith.busch@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).