* [PATCH] Staging: vt6656: baseband.c: fixed unnecessary paranthesis
@ 2018-09-29 8:58 Shubham Singh
2018-09-29 9:34 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Shubham Singh @ 2018-09-29 8:58 UTC (permalink / raw)
To: forest; +Cc: gregkh, devel, linux-kernel, shubhsherl
From: shubhsherl <dhoni.singh094@gmail.com>
Fixed a coding line issue.
Signed-off-by: shubhsherl <dhoni.singh094@gmail.com>
---
drivers/staging/vt6656/baseband.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
index b29ba237fa29..540cc9eafd07 100644
--- a/drivers/staging/vt6656/baseband.c
+++ b/drivers/staging/vt6656/baseband.c
@@ -382,8 +382,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
dev_dbg(&priv->usb->dev, "RF Type %d\n", priv->rf_type);
- if ((priv->rf_type == RF_AL2230) ||
- (priv->rf_type == RF_AL2230S)) {
+ if (priv->rf_type == RF_AL2230 ||
+ priv->rf_type == RF_AL2230S) {
priv->bb_rx_conf = vnt_vt3184_al2230[10];
length = sizeof(vnt_vt3184_al2230);
addr = vnt_vt3184_al2230;
@@ -454,8 +454,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
vnt_control_out(priv, MESSAGE_TYPE_WRITE, 0,
MESSAGE_REQUEST_BBAGC, length_agc, array);
- if ((priv->rf_type == RF_VT3226) ||
- (priv->rf_type == RF_VT3342A0)) {
+ if (priv->rf_type == RF_VT3226 ||
+ priv->rf_type == RF_VT3342A0) {
vnt_control_out_u8(priv, MESSAGE_REQUEST_MACREG,
MAC_REG_ITRTMSET, 0x23);
vnt_mac_reg_bits_on(priv, MAC_REG_PAPEDELAY, 0x01);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: vt6656: baseband.c: fixed unnecessary paranthesis
2018-09-29 8:58 [PATCH] Staging: vt6656: baseband.c: fixed unnecessary paranthesis Shubham Singh
@ 2018-09-29 9:34 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-09-29 9:34 UTC (permalink / raw)
To: Shubham Singh; +Cc: forest, devel, linux-kernel
On Sat, Sep 29, 2018 at 02:28:54PM +0530, Shubham Singh wrote:
> From: shubhsherl <dhoni.singh094@gmail.com>
>
> Fixed a coding line issue.
>
> Signed-off-by: shubhsherl <dhoni.singh094@gmail.com>
We need a real name please.
> ---
> drivers/staging/vt6656/baseband.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
> index b29ba237fa29..540cc9eafd07 100644
> --- a/drivers/staging/vt6656/baseband.c
> +++ b/drivers/staging/vt6656/baseband.c
> @@ -382,8 +382,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
>
> dev_dbg(&priv->usb->dev, "RF Type %d\n", priv->rf_type);
>
> - if ((priv->rf_type == RF_AL2230) ||
> - (priv->rf_type == RF_AL2230S)) {
> + if (priv->rf_type == RF_AL2230 ||
> + priv->rf_type == RF_AL2230S) {
Huh? What coding style issue caused this? The original code is fine,
don't you agree? This type of change just makes it harder to work with
over time (hint, you have to go look up the order of operations all the
time...)
thanks
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-29 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-29 8:58 [PATCH] Staging: vt6656: baseband.c: fixed unnecessary paranthesis Shubham Singh
2018-09-29 9:34 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).