* [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
@ 2018-10-01 10:11 Niklas Cassel
2018-10-01 12:10 ` Alex Elder
2018-10-02 3:57 ` Bjorn Andersson
0 siblings, 2 replies; 5+ messages in thread
From: Niklas Cassel @ 2018-10-01 10:11 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: bjorn.andersson, elder, Niklas Cassel, alsa-devel, linux-kernel
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
to select it, not depend upon it.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
drivers/slimbus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 9d73ad806698..9cca2c3559f2 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
config SLIM_QCOM_NGD_CTRL
tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
- depends on QCOM_QMI_HELPERS
depends on HAS_IOMEM && DMA_ENGINE
+ select QCOM_QMI_HELPERS
help
Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
Component is programmed using Linux kernel.
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-10-01 10:11 [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected Niklas Cassel
@ 2018-10-01 12:10 ` Alex Elder
2018-10-02 3:57 ` Bjorn Andersson
1 sibling, 0 replies; 5+ messages in thread
From: Alex Elder @ 2018-10-01 12:10 UTC (permalink / raw)
To: Niklas Cassel, Srinivas Kandagatla
Cc: bjorn.andersson, alsa-devel, linux-kernel
On 10/01/2018 05:11 AM, Niklas Cassel wrote:
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/slimbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 9d73ad806698..9cca2c3559f2 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
>
> config SLIM_QCOM_NGD_CTRL
> tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
> - depends on QCOM_QMI_HELPERS
> depends on HAS_IOMEM && DMA_ENGINE
> + select QCOM_QMI_HELPERS
> help
> Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
> Component is programmed using Linux kernel.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-10-01 10:11 [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected Niklas Cassel
2018-10-01 12:10 ` Alex Elder
@ 2018-10-02 3:57 ` Bjorn Andersson
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2018-10-02 3:57 UTC (permalink / raw)
To: Niklas Cassel; +Cc: Srinivas Kandagatla, elder, alsa-devel, linux-kernel
On Mon 01 Oct 03:11 PDT 2018, Niklas Cassel wrote:
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/slimbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 9d73ad806698..9cca2c3559f2 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
>
> config SLIM_QCOM_NGD_CTRL
> tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
> - depends on QCOM_QMI_HELPERS
> depends on HAS_IOMEM && DMA_ENGINE
> + select QCOM_QMI_HELPERS
> help
> Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
> Component is programmed using Linux kernel.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-10-03 17:52 Srinivas Kandagatla
@ 2018-10-15 18:32 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2018-10-15 18:32 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: linux-kernel, Niklas Cassel
On Wed, Oct 03, 2018 at 06:52:36PM +0100, Srinivas Kandagatla wrote:
> From: Niklas Cassel <niklas.cassel@linaro.org>
>
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Reviewed-by: Alex Elder <elder@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/slimbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 9d73ad806698..9cca2c3559f2 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
>
> config SLIM_QCOM_NGD_CTRL
> tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
> - depends on QCOM_QMI_HELPERS
> depends on HAS_IOMEM && DMA_ENGINE
> + select QCOM_QMI_HELPERS
> help
> Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
> Component is programmed using Linux kernel.
> --
> 2.19.0
>
This adds the following build warning when applied:
WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS
Depends on [n]: ARCH_QCOM && NET [=y]
Selected by [m]:
- SLIM_QCOM_NGD_CTRL [=m] && SLIMBUS [=m] && HAS_IOMEM [=y] && DMA_ENGINE [=y]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
@ 2018-10-03 17:52 Srinivas Kandagatla
2018-10-15 18:32 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Srinivas Kandagatla @ 2018-10-03 17:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Niklas Cassel, Srinivas Kandagatla
From: Niklas Cassel <niklas.cassel@linaro.org>
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
to select it, not depend upon it.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/slimbus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 9d73ad806698..9cca2c3559f2 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
config SLIM_QCOM_NGD_CTRL
tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
- depends on QCOM_QMI_HELPERS
depends on HAS_IOMEM && DMA_ENGINE
+ select QCOM_QMI_HELPERS
help
Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
Component is programmed using Linux kernel.
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-15 18:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 10:11 [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected Niklas Cassel
2018-10-01 12:10 ` Alex Elder
2018-10-02 3:57 ` Bjorn Andersson
2018-10-03 17:52 Srinivas Kandagatla
2018-10-15 18:32 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).