* [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS
@ 2018-10-01 9:55 Niklas Cassel
2018-10-01 12:10 ` Alex Elder
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Niklas Cassel @ 2018-10-01 9:55 UTC (permalink / raw)
To: Andy Gross, David Brown
Cc: bjorn.andersson, elder, Niklas Cassel, linux-arm-msm, linux-soc,
linux-kernel
The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
hidden kconfig, so it is not selectable in menuconfig.
Remove the help text so that it is more clear that this is intentionally
a hidden kconfig.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
drivers/soc/qcom/Kconfig | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 684cb51694d1..fcbf8a2e4080 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -75,11 +75,6 @@ config QCOM_QMI_HELPERS
tristate
depends on ARCH_QCOM || COMPILE_TEST
depends on NET
- help
- Helper library for handling QMI encoded messages. QMI encoded
- messages are used in communication between the majority of QRTR
- clients and this helpers provide the common functionality needed for
- doing this from a kernel driver.
config QCOM_RMTFS_MEM
tristate "Qualcomm Remote Filesystem memory driver"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS
2018-10-01 9:55 [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS Niklas Cassel
@ 2018-10-01 12:10 ` Alex Elder
2018-10-02 3:57 ` Bjorn Andersson
2018-11-14 18:04 ` Andy Gross
2 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2018-10-01 12:10 UTC (permalink / raw)
To: Niklas Cassel, Andy Gross, David Brown
Cc: bjorn.andersson, linux-arm-msm, linux-soc, linux-kernel
On 10/01/2018 04:55 AM, Niklas Cassel wrote:
> The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
> hidden kconfig, so it is not selectable in menuconfig.
>
> Remove the help text so that it is more clear that this is intentionally
> a hidden kconfig.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Looks good to me. If someone needs it, they know what it's for.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/soc/qcom/Kconfig | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 684cb51694d1..fcbf8a2e4080 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -75,11 +75,6 @@ config QCOM_QMI_HELPERS
> tristate
> depends on ARCH_QCOM || COMPILE_TEST
> depends on NET
> - help
> - Helper library for handling QMI encoded messages. QMI encoded
> - messages are used in communication between the majority of QRTR
> - clients and this helpers provide the common functionality needed for
> - doing this from a kernel driver.
>
> config QCOM_RMTFS_MEM
> tristate "Qualcomm Remote Filesystem memory driver"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS
2018-10-01 9:55 [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS Niklas Cassel
2018-10-01 12:10 ` Alex Elder
@ 2018-10-02 3:57 ` Bjorn Andersson
2018-11-14 18:04 ` Andy Gross
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-10-02 3:57 UTC (permalink / raw)
To: Niklas Cassel
Cc: Andy Gross, David Brown, elder, linux-arm-msm, linux-soc, linux-kernel
On Mon 01 Oct 02:55 PDT 2018, Niklas Cassel wrote:
> The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
> hidden kconfig, so it is not selectable in menuconfig.
>
> Remove the help text so that it is more clear that this is intentionally
> a hidden kconfig.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/soc/qcom/Kconfig | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 684cb51694d1..fcbf8a2e4080 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -75,11 +75,6 @@ config QCOM_QMI_HELPERS
> tristate
> depends on ARCH_QCOM || COMPILE_TEST
> depends on NET
> - help
> - Helper library for handling QMI encoded messages. QMI encoded
> - messages are used in communication between the majority of QRTR
> - clients and this helpers provide the common functionality needed for
> - doing this from a kernel driver.
>
> config QCOM_RMTFS_MEM
> tristate "Qualcomm Remote Filesystem memory driver"
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS
2018-10-01 9:55 [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS Niklas Cassel
2018-10-01 12:10 ` Alex Elder
2018-10-02 3:57 ` Bjorn Andersson
@ 2018-11-14 18:04 ` Andy Gross
2 siblings, 0 replies; 4+ messages in thread
From: Andy Gross @ 2018-11-14 18:04 UTC (permalink / raw)
To: Niklas Cassel
Cc: David Brown, bjorn.andersson, elder, linux-arm-msm, linux-soc,
linux-kernel
On Mon, Oct 01, 2018 at 11:55:54AM +0200, Niklas Cassel wrote:
> The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
> hidden kconfig, so it is not selectable in menuconfig.
>
> Remove the help text so that it is more clear that this is intentionally
> a hidden kconfig.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> ---
Added to queue. Thanks.
Andy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-14 18:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 9:55 [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS Niklas Cassel
2018-10-01 12:10 ` Alex Elder
2018-10-02 3:57 ` Bjorn Andersson
2018-11-14 18:04 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).