From: Adam Borowski <kilobyte@angband.pl>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD
Date: Mon, 8 Oct 2018 18:48:11 +0200 [thread overview]
Message-ID: <20181008164811.oydbuy2xu2d72y5f@angband.pl> (raw)
In-Reply-To: <20181008131944.GB20703@kroah.com>
On Mon, Oct 08, 2018 at 03:19:44PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
> > A spanking new machine I just got has all but one USB ports wired as 3.0.
> > Booting defconfig resulted in no keyboard or mouse, which was pretty
> > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
> > As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
> >
> > Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> > ---
> > arch/x86/configs/x86_64_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> defconfig for x86 actually still works? That's amazing in itself :)
IIRC Gentoo even suggests it in the install instructions (although I
haven't looked at Gentoo in quite a while). Other distros have handcrafted
approximations of allmodconfig.
> > +CONFIG_USB_XHCI_HCD=y
> > CONFIG_USB_EHCI_HCD=y
> > CONFIG_USB_OHCI_HCD=y
>
> You can probably turn ehci and ohci off if you have xhci in the
> "default" system now.
Besides mixed wiring (as Alan and Randy mentioned), some machines without
USB3 are still usable. I haven't upgraded my home machine in ages -- yet
despite it being an ancient Phenom2 x6 it builds defconfig in 6m 13s while
this fresh work box in 3m something. Defconfig is supposed to handle a wide
range of common hardware, so keeping support for 2011 stuff would be wise.
As for !x86, I see that defconfigs for non-fringe archs already enable XHCI.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢰⠒⠀⣿⡁ 10 people enter a bar: 1 who understands binary,
⢿⡄⠘⠷⠚⠋⠀ 1 who doesn't, D who prefer to write it as hex,
⠈⠳⣄⠀⠀⠀⠀ and 1 who narrowly avoided an off-by-one error.
next prev parent reply other threads:[~2018-10-08 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 10:32 [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD Adam Borowski
2018-10-08 13:19 ` Greg Kroah-Hartman
2018-10-08 15:20 ` Alan Stern
2018-10-08 15:55 ` Randy Dunlap
2018-10-08 16:48 ` Adam Borowski [this message]
2018-10-09 6:18 ` Ingo Molnar
2018-10-09 6:28 ` [PATCH v2] " Adam Borowski
2018-10-10 6:33 ` [tip:x86/build] x86/defconfig: Enable CONFIG_USB_XHCI_HCD=y tip-bot for Adam Borowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008164811.oydbuy2xu2d72y5f@angband.pl \
--to=kilobyte@angband.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).