From: Randy Dunlap <rdunlap@infradead.org>
To: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Adam Borowski <kilobyte@angband.pl>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD
Date: Mon, 8 Oct 2018 08:55:52 -0700 [thread overview]
Message-ID: <dbd4eafe-79c5-7f18-5291-2a79eba685a8@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1810081117030.28294-100000@netrider.rowland.org>
On 10/8/18 8:20 AM, Alan Stern wrote:
> On Mon, 8 Oct 2018, Greg Kroah-Hartman wrote:
>
>> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
>>> A spanking new machine I just got has all but one USB ports wired as 3.0.
>>> Booting defconfig resulted in no keyboard or mouse, which was pretty
>>> uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
>>> As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
>>>
>>> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
>>> ---
>>> arch/x86/configs/x86_64_defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> defconfig for x86 actually still works? That's amazing in itself :)
>>
>>> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
>>> index e32fc1f274d8..ac9ae487cfeb 100644
>>> --- a/arch/x86/configs/x86_64_defconfig
>>> +++ b/arch/x86/configs/x86_64_defconfig
>>> @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
>>> CONFIG_USB=y
>>> CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>>> CONFIG_USB_MON=y
>>> +CONFIG_USB_XHCI_HCD=y
>>> CONFIG_USB_EHCI_HCD=y
>>> CONFIG_USB_EHCI_TT_NEWSCHED=y
>>> CONFIG_USB_OHCI_HCD=y
>>
>> You can probably turn ehci and ohci off if you have xhci in the
>> "default" system now.
>
> Heh. My office PC has both EHCI and xHCI controllers, but it uses xHCI
> _only_ for SuperSpeed devices, and only on some of the ports. Not a
> combination I have heard of anywhere else. Enabling xHCI without EHCI
> on that computer would be a bad idea. :-)
Yeah, I have some mixed HCD usages as well.
--
~Randy
next prev parent reply other threads:[~2018-10-08 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 10:32 [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD Adam Borowski
2018-10-08 13:19 ` Greg Kroah-Hartman
2018-10-08 15:20 ` Alan Stern
2018-10-08 15:55 ` Randy Dunlap [this message]
2018-10-08 16:48 ` Adam Borowski
2018-10-09 6:18 ` Ingo Molnar
2018-10-09 6:28 ` [PATCH v2] " Adam Borowski
2018-10-10 6:33 ` [tip:x86/build] x86/defconfig: Enable CONFIG_USB_XHCI_HCD=y tip-bot for Adam Borowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd4eafe-79c5-7f18-5291-2a79eba685a8@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).