From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Boyd <sboyd@kernel.org>, James Cameron <quozl@laptop.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 8/8] Input: olpc_apsp: allocate the GPIOs used
Date: Wed, 10 Oct 2018 10:10:13 -0700 [thread overview]
Message-ID: <20181010171013.GD47260@dtor-ws> (raw)
In-Reply-To: <20181010142504.233467-9-lkundrak@v3.sk>
On Wed, Oct 10, 2018 at 04:25:04PM +0200, Lubomir Rintel wrote:
> Take the GPIO lines are used by the SP. The driver doesn't touch the
> lines -- this is done to disallow anything else from fiddling with
> them because that would confuse the SP firmware.
>
> Also, the lines are now nicely visible in /sys/kernel/debug/gpio.
Linus, is this something that should be handled by GPIO "hogs"?
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/input/serio/olpc_apsp.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/input/serio/olpc_apsp.c b/drivers/input/serio/olpc_apsp.c
> index fe9e19014e70..287759c5f36d 100644
> --- a/drivers/input/serio/olpc_apsp.c
> +++ b/drivers/input/serio/olpc_apsp.c
> @@ -24,6 +24,7 @@
> #include <linux/slab.h>
> #include <linux/delay.h>
> #include <linux/clk.h>
> +#include <linux/gpio/consumer.h>
>
> /*
> * The OLPC XO-1.75 and XO-4 laptops do not have a hardware PS/2 controller.
> @@ -76,6 +77,8 @@ struct olpc_apsp {
> struct serio *padio;
> void __iomem *base;
> struct clk *clk;
> + struct gpio_desc *clk_gpio;
> + struct gpio_desc *data_gpio;
> int open_count;
> int irq;
> };
> @@ -211,6 +214,16 @@ static int olpc_apsp_probe(struct platform_device *pdev)
> if (IS_ERR(priv->clk))
> return PTR_ERR(priv->clk);
>
> + priv->clk_gpio = devm_gpiod_get_optional(&pdev->dev, "clk",
> + GPIOD_ASIS);
> + if (IS_ERR(priv->clk_gpio))
> + return PTR_ERR(priv->clk_gpio);
> +
> + priv->data_gpio = devm_gpiod_get_optional(&pdev->dev, "data",
> + GPIOD_ASIS);
> + if (IS_ERR(priv->data_gpio))
> + return PTR_ERR(priv->data_gpio);
> +
> /* KEYBOARD */
> kb_serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
> if (!kb_serio)
> --
> 2.19.0
>
--
Dmitry
next prev parent reply other threads:[~2018-10-10 17:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 14:24 [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes Lubomir Rintel
2018-10-10 14:24 ` [PATCH v2 1/8] dt-bindings: olpc,ap-sp: add clock Lubomir Rintel
2018-11-04 11:41 ` Pavel Machek
2018-10-10 14:24 ` [PATCH v2 2/8] dt-bindings: olpc,ap-sp: add GPIO lines Lubomir Rintel
2018-11-04 11:49 ` Pavel Machek
2018-10-10 14:24 ` [PATCH v2 3/8] dt-bindings: marvell,mmp2: Add clock id for the SP clock Lubomir Rintel
2018-11-04 11:48 ` Pavel Machek
2018-10-10 14:25 ` [PATCH v2 4/8] clk: mmp2: add " Lubomir Rintel
2018-11-04 11:48 ` Pavel Machek
2018-10-10 14:25 ` [PATCH v2 5/8] Input: olpc_apsp: depend on CONFIG_OF Lubomir Rintel
2018-10-10 17:18 ` Dmitry Torokhov
2018-11-04 11:50 ` Pavel Machek
2018-10-10 14:25 ` [PATCH v2 6/8] Input: olpc_apsp: check FIFO status on open(), not probe() Lubomir Rintel
2018-10-10 14:25 ` [PATCH v2 7/8] Input: olpc_apsp: enable the SP clock Lubomir Rintel
2018-10-10 17:09 ` Dmitry Torokhov
2018-11-04 11:53 ` Pavel Machek
2018-10-10 14:25 ` [PATCH v2 8/8] Input: olpc_apsp: allocate the GPIOs used Lubomir Rintel
2018-10-10 17:10 ` Dmitry Torokhov [this message]
2018-10-10 17:11 ` Dmitry Torokhov
2018-10-11 8:38 ` Linus Walleij
2018-11-04 11:55 ` Pavel Machek
2018-10-15 19:56 ` [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes Pavel Machek
2018-10-16 9:44 ` Lubomir Rintel
2018-10-30 10:01 ` Pavel Machek
2018-10-30 10:26 ` Pavel Machek
2018-10-30 19:40 ` Lubomir Rintel
2018-10-31 3:37 ` James Cameron
2018-10-31 12:46 ` Pavel Machek
2018-10-31 11:54 ` Pavel Machek
2018-11-01 13:47 ` Pavel Machek
2018-10-30 23:54 ` James Cameron
2018-10-31 12:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010171013.GD47260@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=quozl@laptop.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).