From: Peter Zijlstra <peterz@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: Ingo Molnar <mingo@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"acme@kernel.org" <acme@kernel.org>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"eranian@google.com" <eranian@google.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"alexey.budankov@linux.intel.com"
<alexey.budankov@linux.intel.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"megha.dey@intel.com" <megha.dey@intel.com>,
"frederic@kernel.org" <frederic@kernel.org>
Subject: Re: [RFC][PATCH] perf: Rewrite core context handling
Date: Fri, 12 Oct 2018 16:25:56 +0200 [thread overview]
Message-ID: <20181012142556.GD9885@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181012095001.GG9867@hirez.programming.kicks-ass.net>
On Fri, Oct 12, 2018 at 11:50:01AM +0200, Peter Zijlstra wrote:
>
> Can we please not top-post?
>
> On Thu, Oct 11, 2018 at 10:37:14PM +0000, Song Liu wrote:
> > Thanks Peter! These are really really helpful.
> >
> > I am trying to think through the case of a group of two events on two
> > separate hardware PMUs. In current implementation, this will not trigger
> > move_group,
>
> Right, currently this is disallowed (or should be, I'll need to double
> check the code).
>
> > so they will not be able to rotate together? And actually,
> > they may not be able to run at all? Maybe this case is never supported?
>
> Indeed, we do not allow mixing events of different PMUs, with the
> explicit exception of software events. Since software events must always
> schedule, they're allowed to be fitted into any group.
>
> > On the other hand, would something like this work:
> >
> > perf_cpu_context <-[1:2]-> perf_event_context <-[1:n]-> perf_event
> > | |
> > `----[1:n]----> pmu <----- [1:n]----------'
> >
> > 1. Every cpu has only one perf_cpu_context. No perf_cpu_pmu_context.
>
> The perf_event_pmu_context is currently needed to efficiently track
> which events are active. And to determine if rotation is needed at all.
>
> And the perf_cpu_pmu_context is needed because the rotation is per PMU
> in ABI.
>
> > 2. perf_cpu_context has two perf_event_context, one for the cpu, the
> > other for the task.
>
> That doesn't work (or I'm not understanding), tasks come and go on CPUs,
> at best it has a reference to the current active task's context. But it
> already had that, and it still does, see perf_cpu_context::task_ctx.
>
> > 3. Each perf_event_context has 3 perf_event_groups, pinned_groups,
> > flexible_groups, and software_groups (for sw event only groups).
>
> So I'm thinking you want to split off the software groups because they
> don't need rotation?
>
> While doing this patch I noticed that we need to ignore attr.exclusive
> for software events. Not sure that was intentional or not, but certainly
> inconsistent.
That sentence is confused; what I meant to say was that I noticed that
attr.exclusive for software events is currently confused.
> > 4. All flexible_groups of the same cpu rotate a the same time. If
> > there are two hardware PMUs on the cpu, the rotation will look
> > like: 1) stop both PMUs; 2) rotate events; 3) start both PMUs.
>
> ABI precludes that currently, we have per PMU rotation intervals exposed
> in sysfs.
>
> > I feel this will make the implementation simpler. Is it too broken in
> > some cases? Or did I miss anything obvious? One thing I noticed is
> > that we need to drop per PMU config perf_event_mux_interval_ms.
>
> Right that. People added that for a reason (although it eludes me atm).
> I don't think we can drop that easily.
next prev parent reply other threads:[~2018-10-12 14:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 10:45 [RFC][PATCH] perf: Rewrite core context handling Peter Zijlstra
2018-10-11 7:50 ` Song Liu
2018-10-11 9:29 ` Peter Zijlstra
2018-10-11 22:37 ` Song Liu
2018-10-12 9:50 ` Peter Zijlstra
2018-10-12 14:25 ` Peter Zijlstra [this message]
2018-10-13 8:31 ` Song Liu
2018-10-16 9:50 ` Peter Zijlstra
2018-10-16 16:34 ` Song Liu
2018-10-16 18:10 ` Peter Zijlstra
2018-10-16 18:24 ` Song Liu
2018-10-12 7:04 ` Alexey Budankov
2018-10-12 11:54 ` Peter Zijlstra
2018-10-15 7:26 ` Alexey Budankov
2018-10-15 8:34 ` Peter Zijlstra
2018-10-15 8:53 ` Peter Zijlstra
2018-10-15 17:29 ` Alexey Budankov
2018-10-15 18:31 ` Stephane Eranian
2018-10-16 6:39 ` Alexey Budankov
2018-10-16 9:32 ` Peter Zijlstra
2018-10-15 22:09 ` Song Liu
2018-10-16 18:28 ` Song Liu
2018-10-17 11:06 ` Peter Zijlstra
2018-10-17 16:43 ` Song Liu
2018-10-17 17:19 ` Peter Zijlstra
2018-10-17 18:33 ` Peter Zijlstra
2018-10-17 18:57 ` Song Liu
2018-10-16 16:26 ` Mark Rutland
2018-10-16 18:07 ` Peter Zijlstra
2018-10-17 8:57 ` Alexey Budankov
2018-10-17 15:01 ` Alexander Shishkin
2018-10-17 15:58 ` Alexey Budankov
2018-10-17 16:30 ` Peter Zijlstra
2018-10-18 7:05 ` Alexey Budankov
2018-10-22 13:26 ` Alexander Shishkin
2018-10-23 6:13 ` Song Liu
2018-10-23 6:55 ` Peter Zijlstra
2019-05-15 11:17 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012142556.GD9885@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=eranian@google.com \
--cc=frederic@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=megha.dey@intel.com \
--cc=mingo@kernel.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).