* [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
@ 2018-10-09 23:42 Rajmohan Mani
2018-10-11 9:33 ` Kieran Bingham
0 siblings, 1 reply; 5+ messages in thread
From: Rajmohan Mani @ 2018-10-09 23:42 UTC (permalink / raw)
To: linux-media, linux-kernel, Sakari Ailus, Mauro Carvalho Chehab,
Yong Zhi, Bingbu Cao, Tian Shu Qiu, Jian Xu Zheng
Cc: tfiga, Rajmohan Mani
Removed redundant CIO2_IMAGE_MAX_* definitions
Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com>
---
drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
index 240635be7a31..7caab9b8c2b9 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
@@ -10,8 +10,6 @@
#define CIO2_PCI_ID 0x9d32
#define CIO2_PCI_BAR 0
#define CIO2_DMA_MASK DMA_BIT_MASK(39)
-#define CIO2_IMAGE_MAX_WIDTH 4224
-#define CIO2_IMAGE_MAX_LENGTH 3136
#define CIO2_IMAGE_MAX_WIDTH 4224
#define CIO2_IMAGE_MAX_LENGTH 3136
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
2018-10-09 23:42 [PATCH] media: intel-ipu3: cio2: Remove redundant definitions Rajmohan Mani
@ 2018-10-11 9:33 ` Kieran Bingham
2018-10-11 9:53 ` Bing Bu Cao
0 siblings, 1 reply; 5+ messages in thread
From: Kieran Bingham @ 2018-10-11 9:33 UTC (permalink / raw)
To: Rajmohan Mani, linux-media, linux-kernel, Sakari Ailus,
Mauro Carvalho Chehab, Yong Zhi, Bingbu Cao, Tian Shu Qiu,
Jian Xu Zheng
Cc: tfiga
Hi Rajmohan
Thank you for the patch,
On 10/10/18 00:42, Rajmohan Mani wrote:
> Removed redundant CIO2_IMAGE_MAX_* definitions
>
> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
>
> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Looks like this {sh,c}ould be bundled in with
"[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration.
--
Regards
Kieran Bingham
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> index 240635be7a31..7caab9b8c2b9 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> @@ -10,8 +10,6 @@
> #define CIO2_PCI_ID 0x9d32
> #define CIO2_PCI_BAR 0
> #define CIO2_DMA_MASK DMA_BIT_MASK(39)
> -#define CIO2_IMAGE_MAX_WIDTH 4224
> -#define CIO2_IMAGE_MAX_LENGTH 3136
>
> #define CIO2_IMAGE_MAX_WIDTH 4224
> #define CIO2_IMAGE_MAX_LENGTH 3136
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
2018-10-11 9:33 ` Kieran Bingham
@ 2018-10-11 9:53 ` Bing Bu Cao
2018-10-12 19:00 ` Mani, Rajmohan
0 siblings, 1 reply; 5+ messages in thread
From: Bing Bu Cao @ 2018-10-11 9:53 UTC (permalink / raw)
To: kieran.bingham+renesas, Rajmohan Mani, linux-media, linux-kernel,
Sakari Ailus, Mauro Carvalho Chehab, Yong Zhi, Bingbu Cao,
Tian Shu Qiu, Jian Xu Zheng
Cc: tfiga
On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> Hi Rajmohan
>
> Thank you for the patch,
>
> On 10/10/18 00:42, Rajmohan Mani wrote:
>> Removed redundant CIO2_IMAGE_MAX_* definitions
>>
>> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
>>
>> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Looks like this {sh,c}ould be bundled in with
> "[PATCH 0/2] Trivial CIO2 patches" from Sakari at integration.
Raj and Sakari, I think this change could be bundled into the Trivial
patch sets, what do you think?
>
> --
> Regards
>
> Kieran Bingham
>
>> ---
>> drivers/media/pci/intel/ipu3/ipu3-cio2.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> index 240635be7a31..7caab9b8c2b9 100644
>> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
>> @@ -10,8 +10,6 @@
>> #define CIO2_PCI_ID 0x9d32
>> #define CIO2_PCI_BAR 0
>> #define CIO2_DMA_MASK DMA_BIT_MASK(39)
>> -#define CIO2_IMAGE_MAX_WIDTH 4224
>> -#define CIO2_IMAGE_MAX_LENGTH 3136
>>
>> #define CIO2_IMAGE_MAX_WIDTH 4224
>> #define CIO2_IMAGE_MAX_LENGTH 3136
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
2018-10-11 9:53 ` Bing Bu Cao
@ 2018-10-12 19:00 ` Mani, Rajmohan
2018-10-13 21:01 ` Sakari Ailus
0 siblings, 1 reply; 5+ messages in thread
From: Mani, Rajmohan @ 2018-10-12 19:00 UTC (permalink / raw)
To: Bing Bu Cao, kieran.bingham+renesas, linux-media, linux-kernel,
Sakari Ailus, Mauro Carvalho Chehab, Zhi, Yong, Cao, Bingbu, Qiu,
Tian Shu, Zheng, Jian Xu
Cc: tfiga
Hi Bingbu, Kieren,
> Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
>
>
>
> On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> > Hi Rajmohan
> >
> > Thank you for the patch,
> >
> > On 10/10/18 00:42, Rajmohan Mani wrote:
> >> Removed redundant CIO2_IMAGE_MAX_* definitions
> >>
> >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2
> >> driver")
> >>
> >> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com>
> > Reviewed-by: Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>
> >
> > Looks like this {sh,c}ould be bundled in with "[PATCH 0/2] Trivial
> > CIO2 patches" from Sakari at integration.
> Raj and Sakari, I think this change could be bundled into the Trivial patch sets,
> what do you think?
> >
Sounds good to me.
I will leave this up to Sakari.
Thanks
Raj
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
2018-10-12 19:00 ` Mani, Rajmohan
@ 2018-10-13 21:01 ` Sakari Ailus
0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2018-10-13 21:01 UTC (permalink / raw)
To: Mani, Rajmohan
Cc: Bing Bu Cao, kieran.bingham+renesas, linux-media, linux-kernel,
Sakari Ailus, Mauro Carvalho Chehab, Zhi, Yong, Cao, Bingbu, Qiu,
Tian Shu, Zheng, Jian Xu, tfiga
On Fri, Oct 12, 2018 at 07:00:44PM +0000, Mani, Rajmohan wrote:
> Hi Bingbu, Kieren,
>
> > Subject: Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions
> >
> >
> >
> > On 10/11/2018 05:33 PM, Kieran Bingham wrote:
> > > Hi Rajmohan
> > >
> > > Thank you for the patch,
> > >
> > > On 10/10/18 00:42, Rajmohan Mani wrote:
> > >> Removed redundant CIO2_IMAGE_MAX_* definitions
> > >>
> > >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2
> > >> driver")
> > >>
> > >> Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com>
> > > Reviewed-by: Kieran Bingham
> > <kieran.bingham+renesas@ideasonboard.com>
> > >
> > > Looks like this {sh,c}ould be bundled in with "[PATCH 0/2] Trivial
> > > CIO2 patches" from Sakari at integration.
> > Raj and Sakari, I think this change could be bundled into the Trivial patch sets,
> > what do you think?
> > >
>
> Sounds good to me.
> I will leave this up to Sakari.
Yes, these are all in my branch for 4.21.
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-13 21:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 23:42 [PATCH] media: intel-ipu3: cio2: Remove redundant definitions Rajmohan Mani
2018-10-11 9:33 ` Kieran Bingham
2018-10-11 9:53 ` Bing Bu Cao
2018-10-12 19:00 ` Mani, Rajmohan
2018-10-13 21:01 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).