* [PATCH net-next] net: aquantia: make function aq_fw2x_update_stats static
@ 2018-10-16 10:50 YueHaibing
2018-10-16 17:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-10-16 10:50 UTC (permalink / raw)
To: davem, igor.russkikh, nikita.danilov
Cc: linux-kernel, netdev, yana.esina, andrew, YueHaibing
Fixes the following sparse warning:
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c:282:5: warning:
symbol 'aq_fw2x_update_stats' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c
index c056846..096ca57 100644
--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c
@@ -279,7 +279,7 @@ static int aq_fw2x_get_mac_permanent(struct aq_hw_s *self, u8 *mac)
return err;
}
-int aq_fw2x_update_stats(struct aq_hw_s *self)
+static int aq_fw2x_update_stats(struct aq_hw_s *self)
{
int err = 0;
u32 mpi_opts = aq_hw_read_reg(self, HW_ATL_FW2X_MPI_CONTROL2_ADDR);
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: aquantia: make function aq_fw2x_update_stats static
2018-10-16 10:50 [PATCH net-next] net: aquantia: make function aq_fw2x_update_stats static YueHaibing
@ 2018-10-16 17:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-16 17:00 UTC (permalink / raw)
To: yuehaibing
Cc: igor.russkikh, nikita.danilov, linux-kernel, netdev, yana.esina, andrew
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 16 Oct 2018 18:50:56 +0800
> Fixes the following sparse warning:
>
> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c:282:5: warning:
> symbol 'aq_fw2x_update_stats' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-16 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 10:50 [PATCH net-next] net: aquantia: make function aq_fw2x_update_stats static YueHaibing
2018-10-16 17:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).