* [PATCH] m68k: remove redundant 'default n' from Kconfig [not found] <CGME20181016133400eucas1p2f5bab263e70ed0308ce47544fb64a57f@eucas1p2.samsung.com> @ 2018-10-16 13:33 ` Bartlomiej Zolnierkiewicz 2018-12-03 12:29 ` Geert Uytterhoeven 0 siblings, 1 reply; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-10-16 13:33 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: linux-m68k, linux-kernel 'default n' is the default value for any bool or tristate Kconfig setting so there is no need to write it explicitly. Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO is not set' for visible symbols") the Kconfig behavior is the same regardless of 'default n' being present or not: ... One side effect of (and the main motivation for) this change is making the following two definitions behave exactly the same: config FOO bool config FOO bool default n With this change, neither of these will generate a '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). That might make it clearer to people that a bare 'default n' is redundant. ... Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- arch/m68k/Kconfig.machine | 2 -- 1 file changed, 2 deletions(-) Index: b/arch/m68k/Kconfig.machine =================================================================== --- a/arch/m68k/Kconfig.machine 2018-09-03 18:11:11.397792454 +0200 +++ b/arch/m68k/Kconfig.machine 2018-10-16 15:32:04.359635259 +0200 @@ -317,7 +317,6 @@ config UBOOT help If you say Y here kernel will try to collect command line parameters from the initial u-boot stack. - default n config 4KSTACKS bool "Use 4Kb for kernel stacks instead of 8Kb" @@ -395,7 +394,6 @@ comment "ROM configuration" config ROM bool "Specify ROM linker regions" - default n help Define a ROM region for the linker script. This creates a kernel that can be stored in flash, with possibly the text, and data ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] m68k: remove redundant 'default n' from Kconfig 2018-10-16 13:33 ` [PATCH] m68k: remove redundant 'default n' from Kconfig Bartlomiej Zolnierkiewicz @ 2018-12-03 12:29 ` Geert Uytterhoeven 0 siblings, 0 replies; 2+ messages in thread From: Geert Uytterhoeven @ 2018-12-03 12:29 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz; +Cc: linux-m68k, Linux Kernel Mailing List On Tue, Oct 16, 2018 at 3:34 PM Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible symbols") the Kconfig behavior is the same > regardless of 'default n' being present or not: > > ... > One side effect of (and the main motivation for) this change is making > the following two definitions behave exactly the same: > > config FOO > bool > > config FOO > bool > default n > > With this change, neither of these will generate a > '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). > That might make it clearer to people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> I.e., applied and queued for v4.21. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-03 12:29 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CGME20181016133400eucas1p2f5bab263e70ed0308ce47544fb64a57f@eucas1p2.samsung.com> 2018-10-16 13:33 ` [PATCH] m68k: remove redundant 'default n' from Kconfig Bartlomiej Zolnierkiewicz 2018-12-03 12:29 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).