From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <shuah@kernel.org>
Cc: "Daniel Díaz" <daniel.diaz@linaro.org>,
linux-kselftest@vger.kernel.org, "Ingo Molnar" <mingo@redhat.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/ftrace: Use colored output when available
Date: Tue, 16 Oct 2018 14:34:04 -0400 [thread overview]
Message-ID: <20181016143404.6847beb4@gandalf.local.home> (raw)
In-Reply-To: <037e072a-5695-1343-35d1-37b9450581d4@kernel.org>
On Tue, 16 Oct 2018 11:43:29 -0600
Shuah Khan <shuah@kernel.org> wrote:
> On 10/16/2018 11:02 AM, Daniel Díaz wrote:
> > If test is being directly executed (with stdout opened on the
> > terminal) and the terminal capabilities indicate enough
> > colors, then use the existing scheme of green, red, and blue
> > to show when tests pass, fail or end in a different way.
> >
> > When running the tests redirecting the stdout, for instance,
> > to a file, then colors are not shown, thus producing a more
> > readable output.
> >
> > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> > ---
>
> Hi Daniel,
>
> Thanks for the patch. Steve is working on adding this functionality. Please
> see the latest linux-kselftest next for the patch.
>
> Steve just sent an update to the patch to fix an issue. Please test and see
> if that solves the problem you are trying address with this patch.
>
Hi Shuah,
I think this patch actually addresses the issue of my last patch, and I
haven't sent another one.
I'm waiting to hear from Masami if it fixes the issues he saw.
-- Steve
next prev parent reply other threads:[~2018-10-16 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 17:02 [PATCH] selftests/ftrace: Use colored output when available Daniel Díaz
2018-10-16 17:09 ` Steven Rostedt
2018-10-17 1:03 ` Masami Hiramatsu
2018-10-17 3:33 ` [PATCH] selftests/ftrace: Strip escape sequences for log file Masami Hiramatsu
2018-10-17 20:45 ` Steven Rostedt
2018-10-17 23:02 ` Shuah Khan
2018-10-16 17:43 ` [PATCH] selftests/ftrace: Use colored output when available Shuah Khan
2018-10-16 18:20 ` Daniel Díaz
2018-10-16 18:34 ` Steven Rostedt [this message]
2018-10-17 15:19 ` Shuah Khan
2018-10-17 20:41 ` Steven Rostedt
2018-10-17 23:01 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016143404.6847beb4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=daniel.diaz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).