From: Shuah Khan <shuah@kernel.org>
To: "Steven Rostedt" <rostedt@goodmis.org>,
"Daniel Díaz" <daniel.diaz@linaro.org>
Cc: linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
open list <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests/ftrace: Use colored output when available
Date: Wed, 17 Oct 2018 17:01:46 -0600 [thread overview]
Message-ID: <ba605b17-9de2-3fc8-4b2a-daf9edfa96c9@kernel.org> (raw)
In-Reply-To: <20181017164103.4fb8692f@gandalf.local.home>
On 10/17/2018 02:41 PM, Steven Rostedt wrote:
> On Tue, 16 Oct 2018 12:02:20 -0500
> Daniel Díaz <daniel.diaz@linaro.org> wrote:
>
>> If test is being directly executed (with stdout opened on the
>> terminal) and the terminal capabilities indicate enough
>> colors, then use the existing scheme of green, red, and blue
>> to show when tests pass, fail or end in a different way.
>>
>> When running the tests redirecting the stdout, for instance,
>> to a file, then colors are not shown, thus producing a more
>> readable output.
>>
>> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Shuah, can you pull this into your tree?
>
Applied to linux-ksefltest next for 4.20-rc1
thanks,
-- Shuah
prev parent reply other threads:[~2018-10-17 23:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 17:02 [PATCH] selftests/ftrace: Use colored output when available Daniel Díaz
2018-10-16 17:09 ` Steven Rostedt
2018-10-17 1:03 ` Masami Hiramatsu
2018-10-17 3:33 ` [PATCH] selftests/ftrace: Strip escape sequences for log file Masami Hiramatsu
2018-10-17 20:45 ` Steven Rostedt
2018-10-17 23:02 ` Shuah Khan
2018-10-16 17:43 ` [PATCH] selftests/ftrace: Use colored output when available Shuah Khan
2018-10-16 18:20 ` Daniel Díaz
2018-10-16 18:34 ` Steven Rostedt
2018-10-17 15:19 ` Shuah Khan
2018-10-17 20:41 ` Steven Rostedt
2018-10-17 23:01 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba605b17-9de2-3fc8-4b2a-daf9edfa96c9@kernel.org \
--to=shuah@kernel.org \
--cc=daniel.diaz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).