linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ake@igel.co.jp
Cc: jasowang@redhat.com, mst@redhat.com,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] virtio_net: avoid using netif_tx_disable() for serializing tx routine
Date: Wed, 17 Oct 2018 22:30:01 -0700 (PDT)	[thread overview]
Message-ID: <20181017.223001.1576138840071012489.davem@davemloft.net> (raw)
In-Reply-To: <20181017104419.13003-1-ake@igel.co.jp>

From: Ake Koomsin <ake@igel.co.jp>
Date: Wed, 17 Oct 2018 19:44:12 +0900

> Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset")
> introduces netif_tx_disable() after netif_device_detach() in order to
> avoid use-after-free of tx queues. However, there are two issues.
> 
> 1) Its operation is redundant with netif_device_detach() in case the
>    interface is running.
> 2) In case of the interface is not running before suspending and
>    resuming, the tx does not get resumed by netif_device_attach().
>    This results in losing network connectivity.
> 
> It is better to use netif_tx_lock_bh()/netif_tx_unlock_bh() instead for
> serializing tx routine during reset. This also preserves the symmetry
> of netif_device_detach() and netif_device_attach().
> 
> Fixes commit 713a98d90c5e ("virtio-net: serialize tx routine during reset")
> Signed-off-by: Ake Koomsin <ake@igel.co.jp>

Applied and queued up for -stable.

      parent reply	other threads:[~2018-10-18  5:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  7:51 [PATCH] virtio_net: enable tx after resuming from suspend Ake Koomsin
2018-10-11  9:44 ` Jason Wang
2018-10-11 10:22   ` ake
2018-10-11 13:06     ` Jason Wang
2018-10-12  4:30       ` ake
2018-10-12  8:23         ` Jason Wang
2018-10-12  9:18           ` ake
2018-10-15 10:08             ` ake
2018-10-16  8:53               ` Jason Wang
2018-10-16 10:15                 ` ake
2018-10-17  6:18                   ` Jason Wang
2018-10-17  7:59                     ` [PATCH v2] virtio_net: avoid using netif_tx_disable() for serializing tx routine Ake Koomsin
2018-10-17  9:02                       ` Jason Wang
2018-10-17 10:44                         ` [PATCH v3] " Ake Koomsin
2018-10-17 12:30                           ` Jason Wang
2018-10-17 15:09                           ` Michael S. Tsirkin
2018-10-18  3:25                             ` ake
2018-10-18  5:30                           ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181017.223001.1576138840071012489.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ake@igel.co.jp \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).