linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Ake Koomsin <ake@igel.co.jp>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_net: enable tx after resuming from suspend
Date: Thu, 11 Oct 2018 17:44:01 +0800	[thread overview]
Message-ID: <dd530053-efab-b661-3423-1faaab8fb12f@redhat.com> (raw)
In-Reply-To: <20181011075127.2608-1-ake@igel.co.jp>



On 2018年10月11日 15:51, Ake Koomsin wrote:
> commit 713a98d90c5e ("virtio-net: serialize tx routine during reset")
> disabled the virtio tx before going to suspend to avoid a use after free.
> However, after resuming, it causes the virtio_net device to lose its
> network connectivity.
>
> To solve the issue, we need to enable tx after resuming.
>
> Fixes commit 713a98d90c5e ("virtio-net: serialize tx routine during reset")
> Signed-off-by: Ake Koomsin <ake@igel.co.jp>
> ---
>   drivers/net/virtio_net.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index dab504ec5e50..3453d80f5f81 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2256,6 +2256,7 @@ static int virtnet_restore_up(struct virtio_device *vdev)
>   	}
>   
>   	netif_device_attach(vi->dev);
> +	netif_start_queue(vi->dev);

I believe this is duplicated with netif_tx_wake_all_queues() in 
netif_device_attach() above?

Thanks

>   	return err;
>   }
>   


  reply	other threads:[~2018-10-11  9:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  7:51 [PATCH] virtio_net: enable tx after resuming from suspend Ake Koomsin
2018-10-11  9:44 ` Jason Wang [this message]
2018-10-11 10:22   ` ake
2018-10-11 13:06     ` Jason Wang
2018-10-12  4:30       ` ake
2018-10-12  8:23         ` Jason Wang
2018-10-12  9:18           ` ake
2018-10-15 10:08             ` ake
2018-10-16  8:53               ` Jason Wang
2018-10-16 10:15                 ` ake
2018-10-17  6:18                   ` Jason Wang
2018-10-17  7:59                     ` [PATCH v2] virtio_net: avoid using netif_tx_disable() for serializing tx routine Ake Koomsin
2018-10-17  9:02                       ` Jason Wang
2018-10-17 10:44                         ` [PATCH v3] " Ake Koomsin
2018-10-17 12:30                           ` Jason Wang
2018-10-17 15:09                           ` Michael S. Tsirkin
2018-10-18  3:25                             ` ake
2018-10-18  5:30                           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd530053-efab-b661-3423-1faaab8fb12f@redhat.com \
    --to=jasowang@redhat.com \
    --cc=ake@igel.co.jp \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).