From: Greg KH <gregkh@linuxfoundation.org>
To: kys@microsoft.com
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
sthemmin@microsoft.com, Michael.H.Kelley@microsoft.com,
vkuznets@redhat.com, Haiyang Zhang <haiyangz@microsoft.com>,
Stable@vger.kernel.org
Subject: Re: [PATCH 5/5] Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1
Date: Wed, 17 Oct 2018 07:07:28 +0200 [thread overview]
Message-ID: <20181017050728.GF22447@kroah.com> (raw)
In-Reply-To: <20181017031406.773-5-kys@linuxonhyperv.com>
On Wed, Oct 17, 2018 at 03:14:06AM +0000, kys@linuxonhyperv.com wrote:
> From: Dexuan Cui <decui@microsoft.com>
>
> The patch fixes:
>
> hv_kvp_daemon.c: In function 'kvp_set_ip_info':
> hv_kvp_daemon.c:1305:2: note: 'snprintf' output between 41 and 4136 bytes
> into a destination of size 4096
>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: <Stable@vger.kernel.org>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> tools/hv/hv_kvp_daemon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index bbb2a8ef367c..b7c2cf7eaba5 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1176,7 +1176,7 @@ static int kvp_set_ip_info(char *if_name, struct hv_kvp_ipaddr_value *new_val)
> int error = 0;
> char if_file[PATH_MAX];
> FILE *file;
> - char cmd[PATH_MAX];
> + char cmd[PATH_MAX * 2];
Overkill?
next prev parent reply other threads:[~2018-10-17 5:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 3:12 [PATCH 0/5] Drivers: hv: Miscellaneous fixes kys
2018-10-17 3:14 ` [PATCH 1/5] Drivers: hv: vmbus: Get rid of unnecessary state in hv_context kys
2018-10-17 3:14 ` [PATCH 2/5] hv_utils: update name in struct hv_driver util_drv kys
2018-10-17 3:14 ` [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up kys
2018-10-17 5:07 ` Greg KH
2018-10-17 5:11 ` Gustavo A. R. Silva
2018-10-17 6:02 ` KY Srinivasan
2018-10-17 17:56 ` Dexuan Cui
2018-10-17 6:22 ` Dan Carpenter
2018-10-20 14:42 ` Miguel Ojeda
2018-10-20 19:22 ` Dan Carpenter
2018-10-21 4:15 ` Miguel Ojeda
2018-10-17 18:01 ` Dexuan Cui
2018-10-17 3:14 ` [PATCH 4/5] Drivers: hv: kvp: Use %u to print U32 kys
2018-10-17 5:04 ` Greg KH
2018-10-17 5:59 ` KY Srinivasan
2018-10-17 3:14 ` [PATCH 5/5] Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1 kys
2018-10-17 5:07 ` Greg KH [this message]
2018-10-17 19:57 ` Dexuan Cui
2018-10-17 5:04 ` [PATCH 1/5] Drivers: hv: vmbus: Get rid of unnecessary state in hv_context Greg KH
2018-10-17 5:59 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017050728.GF22447@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.H.Kelley@microsoft.com \
--cc=Stable@vger.kernel.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).