From: Dexuan Cui <decui@microsoft.com>
To: KY Srinivasan <kys@microsoft.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: "olaf@aepfle.de" <olaf@aepfle.de>,
Stephen Hemminger <sthemmin@microsoft.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Stable@vger.kernel.org" <Stable@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
"apw@canonical.com" <apw@canonical.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
vkuznets <vkuznets@redhat.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: RE: [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up
Date: Wed, 17 Oct 2018 17:56:15 +0000 [thread overview]
Message-ID: <PU1P153MB01698636C27A6DC822370379BFFF0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <SN6PR2101MB1118766D1B569319FDB8E5FCA0FF0@SN6PR2101MB1118.namprd21.prod.outlook.com>
> From: devel <driverdev-devel-bounces@linuxdriverproject.org> On Behalf Of
> KY Srinivasan
> Sent: Tuesday, October 16, 2018 23:02
> > > --- a/drivers/hv/hv_kvp.c
> > > +++ b/drivers/hv/hv_kvp.c
> > > @@ -353,6 +353,9 @@ static void process_ib_ipinfo(void *in_msg, void
> > *out_msg, int op)
> > >
> > > out->body.kvp_ip_val.dhcp_enabled = in-
> > >kvp_ip_val.dhcp_enabled;
> > >
> > > + __attribute__ ((fallthrough));
> >
> > The comment should be sufficient for this, right? I haven't seen many
> > uses of this attribute before, how common is it?
>
> Yes; a common should be sufficient.
You all are right.
Right now, I realized the gcc warning can also be suppressed by a simple line
of comment:
/* fallthrough */
It looks gcc treats this comment specially.
If I add something more in the comment, like
/* add fallthrough */
, the warning can not be suppressed. :-)
I'll do a new version for KY.
Thank you all!
-- Dexuan
next prev parent reply other threads:[~2018-10-17 17:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 3:12 [PATCH 0/5] Drivers: hv: Miscellaneous fixes kys
2018-10-17 3:14 ` [PATCH 1/5] Drivers: hv: vmbus: Get rid of unnecessary state in hv_context kys
2018-10-17 3:14 ` [PATCH 2/5] hv_utils: update name in struct hv_driver util_drv kys
2018-10-17 3:14 ` [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up kys
2018-10-17 5:07 ` Greg KH
2018-10-17 5:11 ` Gustavo A. R. Silva
2018-10-17 6:02 ` KY Srinivasan
2018-10-17 17:56 ` Dexuan Cui [this message]
2018-10-17 6:22 ` Dan Carpenter
2018-10-20 14:42 ` Miguel Ojeda
2018-10-20 19:22 ` Dan Carpenter
2018-10-21 4:15 ` Miguel Ojeda
2018-10-17 18:01 ` Dexuan Cui
2018-10-17 3:14 ` [PATCH 4/5] Drivers: hv: kvp: Use %u to print U32 kys
2018-10-17 5:04 ` Greg KH
2018-10-17 5:59 ` KY Srinivasan
2018-10-17 3:14 ` [PATCH 5/5] Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1 kys
2018-10-17 5:07 ` Greg KH
2018-10-17 19:57 ` Dexuan Cui
2018-10-17 5:04 ` [PATCH 1/5] Drivers: hv: vmbus: Get rid of unnecessary state in hv_context Greg KH
2018-10-17 5:59 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PU1P153MB01698636C27A6DC822370379BFFF0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM \
--to=decui@microsoft.com \
--cc=Stable@vger.kernel.org \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).