From: Sudeep Holla <sudeep.holla@arm.com>
To: Huacai Chen <chenhc@lemote.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Huacai Chen <chenhuacai@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails
Date: Wed, 17 Oct 2018 10:35:40 +0100 [thread overview]
Message-ID: <20181017093540.GB16320@e107155-lin> (raw)
In-Reply-To: <1539739563-1886-1-git-send-email-chenhc@lemote.com>
On Wed, Oct 17, 2018 at 09:26:03AM +0800, Huacai Chen wrote:
> Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
> property_read_u32 instead of get_property,read_number") makes cache
> size and number_of_sets be 0 if DT doesn't provide there values. I
> think this is unreasonable so make them keep the old values, which is
> the same as old kernels.
>
What old values does the kernel have ? Which architecture are you referring ?
If DT doesn't have entry then we can't expose sysfs, hence 0.
Please provide more details on the issue you are seeing.
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-10-17 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 1:26 [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails Huacai Chen
2018-10-17 9:35 ` Sudeep Holla [this message]
2018-10-18 1:28 ` Huacai Chen
2018-10-18 9:15 ` Sudeep Holla
2018-10-19 6:23 ` [PATCH] cacheinfo: Keep the old value if of_property_read_u32fails 陈华才
2018-10-19 9:18 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017093540.GB16320@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).