linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: 陈华才 <chenhc@lemote.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, zhangfx <zhangfx@lemote.com>,
	wuzhangjin <wuzhangjin@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32fails
Date: Fri, 19 Oct 2018 10:18:59 +0100	[thread overview]
Message-ID: <20181019091859.GA17312@e107155-lin> (raw)
In-Reply-To: <tencent_618B672134A6B5732D255D23@qq.com>

Hi,

On Fri, Oct 19, 2018 at 02:23:27PM +0800, 陈华才 wrote:
> Hi, Sudeep,
>
> I use MIPS, and there is no "size" in
> /sys/devices/system/cpu/cpuX/cache/indexX/ file after your patch. Because
> the DT node only has "next-level-cache = <&L2>;"  but has no "size"
> information.
>
Thanks for the confirmation and your time. I was worried if this was ARM64
with local patches.

You can add:
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

Also please add:
Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")

--
Regards,
Sudeep

      reply	other threads:[~2018-10-19  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  1:26 [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails Huacai Chen
2018-10-17  9:35 ` Sudeep Holla
2018-10-18  1:28   ` Huacai Chen
2018-10-18  9:15     ` Sudeep Holla
2018-10-19  6:23       ` [PATCH] cacheinfo: Keep the old value if of_property_read_u32fails 陈华才
2018-10-19  9:18         ` Sudeep Holla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019091859.GA17312@e107155-lin \
    --to=sudeep.holla@arm.com \
    --cc=chenhc@lemote.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=wuzhangjin@gmail.com \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).