From: Rob Herring <robh@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Can Guo <cang@codeaurora.org>,
evgreen@chromium.org, Vivek Gautam <vivek.gautam@codeaurora.org>,
linux-arm-msm@vger.kernel.org, sayalil@codeaurora.org,
asutoshd@codeaurora.org, Douglas Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, liwei <liwei213@huawei.com>,
linux-kernel@vger.kernel.org,
Mathieu Malaterre <malat@debian.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] dt-bindings: ufs: Fix the compatible string definition
Date: Wed, 17 Oct 2018 19:42:14 -0500 [thread overview]
Message-ID: <20181018004214.GA5937@bogus> (raw)
In-Reply-To: <20181012213926.253765-1-dianders@chromium.org>
On Fri, 12 Oct 2018 14:39:26 -0700, Douglas Anderson wrote:
> If you look at the bindings for the UFS Host Controller it says:
>
> - compatible: must contain "jedec,ufs-1.1" or "jedec,ufs-2.0", may
> also list one or more of the following:
> "qcom,msm8994-ufshc"
> "qcom,msm8996-ufshc"
> "qcom,ufshc"
>
> My reading of that is that it's fine to just have either of these:
> 1. "qcom,msm8996-ufshc", "jedec,ufs-2.0"
> 2. "qcom,ufshc", "jedec,ufs-2.0"
>
> As far as I can tell neither of the above is actually a good idea.
>
> For #1 it turns out that the driver currently only keys off the
> compatible string "qcom,ufshc" so it won't actually probe.
>
> For #2 the driver won't probe but it's not a good idea to keep the SoC
> name out of the compatible string.
>
> Let's update the compatible string to make it really explicit. We'll
> include a nod to the existing driver and the old binding and say that
> we should always include the "qcom,ufshc" string in addition to the
> SoC compatible string.
>
> While we're at it we'll also include another example SoC known to have
> UFS: sdm845.
>
> Fixes: 47555a5c8a11 ("scsi: ufs: make the UFS variant a platform device")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-10-18 0:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 21:39 [PATCH] dt-bindings: ufs: Fix the compatible string definition Douglas Anderson
2018-10-15 15:23 ` Vivek Gautam
2018-10-15 17:23 ` Doug Anderson
2018-10-16 5:51 ` Vivek Gautam
2018-10-16 16:59 ` Doug Anderson
2018-10-17 6:28 ` Vivek Gautam
2018-10-17 16:11 ` Doug Anderson
2018-10-18 7:52 ` Vivek Gautam
2019-01-23 22:17 ` Evan Green
2018-10-18 0:42 ` Rob Herring [this message]
2019-02-06 13:59 ` Marc Gonzalez
2019-02-08 22:40 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018004214.GA5937@bogus \
--to=robh@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=sayalil@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).