* [PATCH] docs: Fix typos in histogram.rst
@ 2018-10-13 1:30 Masanari Iida
2018-10-13 1:35 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Masanari Iida @ 2018-10-13 1:30 UTC (permalink / raw)
To: corbet, rostedt, linux-kernel, mchehab+samsung; +Cc: Masanari Iida
This patch fixes some spelling typos.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
Documentation/trace/histogram.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
index 5ac724baea7d..7dda76503127 100644
--- a/Documentation/trace/histogram.rst
+++ b/Documentation/trace/histogram.rst
@@ -1765,7 +1765,7 @@ For example, here's how a latency can be calculated::
# echo 'hist:keys=pid,prio:ts0=common_timestamp ...' >> event1/trigger
# echo 'hist:keys=next_pid:wakeup_lat=common_timestamp-$ts0 ...' >> event2/trigger
-In the first line above, the event's timetamp is saved into the
+In the first line above, the event's timestamp is saved into the
variable ts0. In the next line, ts0 is subtracted from the second
event's timestamp to produce the latency, which is then assigned into
yet another variable, 'wakeup_lat'. The hist trigger below in turn
@@ -1811,7 +1811,7 @@ the command that defined it with a '!'::
/sys/kernel/debug/tracing/synthetic_events
At this point, there isn't yet an actual 'wakeup_latency' event
-instantiated in the event subsytem - for this to happen, a 'hist
+instantiated in the event subsystem - for this to happen, a 'hist
trigger action' needs to be instantiated and bound to actual fields
and variables defined on other events (see Section 2.2.3 below on
how that is done using hist trigger 'onmatch' action). Once that is
@@ -1837,7 +1837,7 @@ output can be displayed by reading the event's 'hist' file.
A hist trigger 'action' is a function that's executed whenever a
histogram entry is added or updated.
-The default 'action' if no special function is explicity specified is
+The default 'action' if no special function is explicitly specified is
as it always has been, to simply update the set of values associated
with an entry. Some applications, however, may want to perform
additional actions at that point, such as generate another event, or
--
2.19.1.328.g5a0cc8aca797
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: Fix typos in histogram.rst
2018-10-13 1:30 [PATCH] docs: Fix typos in histogram.rst Masanari Iida
@ 2018-10-13 1:35 ` Randy Dunlap
2018-10-13 2:04 ` Steven Rostedt
2018-10-18 18:33 ` Jonathan Corbet
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2018-10-13 1:35 UTC (permalink / raw)
To: Masanari Iida, corbet, rostedt, linux-kernel, mchehab+samsung
On 10/12/18 6:30 PM, Masanari Iida wrote:
> This patch fixes some spelling typos.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> Documentation/trace/histogram.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Randy Dunlap <rdunlap@infradead.org>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: Fix typos in histogram.rst
2018-10-13 1:30 [PATCH] docs: Fix typos in histogram.rst Masanari Iida
2018-10-13 1:35 ` Randy Dunlap
@ 2018-10-13 2:04 ` Steven Rostedt
2018-10-18 18:33 ` Jonathan Corbet
2 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2018-10-13 2:04 UTC (permalink / raw)
To: Masanari Iida; +Cc: corbet, linux-kernel, mchehab+samsung, Tom Zanussi
On Sat, 13 Oct 2018 10:30:57 +0900
Masanari Iida <standby24x7@gmail.com> wrote:
> This patch fixes some spelling typos.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> Documentation/trace/histogram.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
> index 5ac724baea7d..7dda76503127 100644
> --- a/Documentation/trace/histogram.rst
> +++ b/Documentation/trace/histogram.rst
> @@ -1765,7 +1765,7 @@ For example, here's how a latency can be calculated::
> # echo 'hist:keys=pid,prio:ts0=common_timestamp ...' >> event1/trigger
> # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp-$ts0 ...' >> event2/trigger
>
> -In the first line above, the event's timetamp is saved into the
> +In the first line above, the event's timestamp is saved into the
> variable ts0. In the next line, ts0 is subtracted from the second
> event's timestamp to produce the latency, which is then assigned into
> yet another variable, 'wakeup_lat'. The hist trigger below in turn
> @@ -1811,7 +1811,7 @@ the command that defined it with a '!'::
> /sys/kernel/debug/tracing/synthetic_events
>
> At this point, there isn't yet an actual 'wakeup_latency' event
> -instantiated in the event subsytem - for this to happen, a 'hist
> +instantiated in the event subsystem - for this to happen, a 'hist
The first two appear to show that Tom has a faulty 's' key ;-)
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> trigger action' needs to be instantiated and bound to actual fields
> and variables defined on other events (see Section 2.2.3 below on
> how that is done using hist trigger 'onmatch' action). Once that is
> @@ -1837,7 +1837,7 @@ output can be displayed by reading the event's 'hist' file.
> A hist trigger 'action' is a function that's executed whenever a
> histogram entry is added or updated.
>
> -The default 'action' if no special function is explicity specified is
> +The default 'action' if no special function is explicitly specified is
> as it always has been, to simply update the set of values associated
> with an entry. Some applications, however, may want to perform
> additional actions at that point, such as generate another event, or
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: Fix typos in histogram.rst
2018-10-13 1:30 [PATCH] docs: Fix typos in histogram.rst Masanari Iida
2018-10-13 1:35 ` Randy Dunlap
2018-10-13 2:04 ` Steven Rostedt
@ 2018-10-18 18:33 ` Jonathan Corbet
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2018-10-18 18:33 UTC (permalink / raw)
To: Masanari Iida; +Cc: rostedt, linux-kernel, mchehab+samsung
On Sat, 13 Oct 2018 10:30:57 +0900
Masanari Iida <standby24x7@gmail.com> wrote:
> This patch fixes some spelling typos.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-18 18:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-13 1:30 [PATCH] docs: Fix typos in histogram.rst Masanari Iida
2018-10-13 1:35 ` Randy Dunlap
2018-10-13 2:04 ` Steven Rostedt
2018-10-18 18:33 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).