From: Mark Brown <broonie@kernel.org>
To: Pascal PAILLET-LME <p.paillet@st.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"benjamin.gaignard@linaro.org" <benjamin.gaignard@linaro.org>,
"eballetbo@gmail.com" <eballetbo@gmail.com>
Subject: Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver
Date: Fri, 19 Oct 2018 12:50:15 +0100 [thread overview]
Message-ID: <20181019115015.GC5895@sirena.org.uk> (raw)
In-Reply-To: <1539853324-29051-5-git-send-email-p.paillet@st.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Thu, Oct 18, 2018 at 09:02:12AM +0000, Pascal PAILLET-LME wrote:
> + for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) {
> + /* Parse DT & find regulators to register */
> + init_data = stpmic1_regulators_matches[i].init_data;
> + if (init_data)
> + init_data->regulator_init = &stpmic1_regulator_parse_dt;
> +
> + rdev = stpmic1_regulator_register(pdev, i, init_data, regul);
> + if (IS_ERR(rdev))
> + return PTR_ERR(rdev);
This looks mostly good, the only big thing is this - the default is to
just unconditionally register all the regulators that exist rather than
only those that are configured on that particular platform. This is a
bit simpler and means that all the readback of the configuration for the
unconfigured regulators is available for diagnostics. Is there a reason
not to do that?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-10-19 11:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 9:02 [PATCH v4 0/8] Introduce STPMIC1 PMIC Driver Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 2/8] mfd: stpmic1: add stpmic1 driver Pascal PAILLET-LME
2018-10-25 11:21 ` Lee Jones
2018-10-25 12:40 ` Benjamin Gaignard
2018-10-26 7:17 ` Lee Jones
2018-10-18 9:02 ` [PATCH v4 1/8] dt-bindings: mfd: document stpmic1 Pascal PAILLET-LME
2018-10-18 18:47 ` Rob Herring
2018-10-25 9:44 ` Lee Jones
2018-10-25 12:57 ` Rob Herring
2018-10-26 6:46 ` Lee Jones
2018-10-26 9:48 ` Pascal PAILLET-LME
2018-10-26 11:46 ` Lee Jones
2018-10-18 9:02 ` [PATCH v4 3/8] dt-bindings: regulator: document stpmic1 pmic regulators Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver Pascal PAILLET-LME
2018-10-19 11:50 ` Mark Brown [this message]
2018-10-24 12:54 ` Pascal PAILLET-LME
2018-10-24 13:17 ` Mark Brown
2018-10-25 13:23 ` Pascal PAILLET-LME
2018-10-26 20:33 ` Mark Brown
2018-10-18 9:02 ` [PATCH v4 6/8] input: stpmic1: add stpmic1 onkey driver Pascal PAILLET-LME
2018-10-18 18:12 ` dmitry.torokhov
2018-10-18 9:02 ` [PATCH v4 7/8] dt-bindings: watchdog: document stpmic1 pmic watchdog Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 5/8] dt-bindings: input: document stpmic1 pmic onkey Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 8/8] watchdog: stpmic1: add stpmic1 watchdog driver Pascal PAILLET-LME
2018-10-18 13:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019115015.GC5895@sirena.org.uk \
--to=broonie@kernel.org \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).