* [PATCH] power: max8925: mark expected switch fall-through
@ 2018-10-04 13:56 Gustavo A. R. Silva
2018-10-21 19:34 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-04 13:56 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-pm, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 201510 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/power/supply/max8925_power.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/supply/max8925_power.c b/drivers/power/supply/max8925_power.c
index 3b94620..39b4d5b 100644
--- a/drivers/power/supply/max8925_power.c
+++ b/drivers/power/supply/max8925_power.c
@@ -124,6 +124,7 @@ static irqreturn_t max8925_charger_handler(int irq, void *data)
case MAX8925_IRQ_VCHG_THM_OK_F:
/* Battery is not ready yet */
dev_dbg(chip->dev, "Battery temperature is out of range\n");
+ /* Fall through */
case MAX8925_IRQ_VCHG_DC_OVP:
dev_dbg(chip->dev, "Error detection\n");
__set_charger(info, 0);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: max8925: mark expected switch fall-through
2018-10-04 13:56 [PATCH] power: max8925: mark expected switch fall-through Gustavo A. R. Silva
@ 2018-10-21 19:34 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2018-10-21 19:34 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
Hi,
On Thu, Oct 04, 2018 at 03:56:36PM +0200, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 201510 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/max8925_power.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/max8925_power.c b/drivers/power/supply/max8925_power.c
> index 3b94620..39b4d5b 100644
> --- a/drivers/power/supply/max8925_power.c
> +++ b/drivers/power/supply/max8925_power.c
> @@ -124,6 +124,7 @@ static irqreturn_t max8925_charger_handler(int irq, void *data)
> case MAX8925_IRQ_VCHG_THM_OK_F:
> /* Battery is not ready yet */
> dev_dbg(chip->dev, "Battery temperature is out of range\n");
> + /* Fall through */
> case MAX8925_IRQ_VCHG_DC_OVP:
> dev_dbg(chip->dev, "Error detection\n");
> __set_charger(info, 0);
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-21 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-04 13:56 [PATCH] power: max8925: mark expected switch fall-through Gustavo A. R. Silva
2018-10-21 19:34 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).