linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH 0/2] i2c: enable buses to save their clock frequency in adapter
@ 2018-10-23  9:20 Tudor.Ambarus
  2018-10-23  9:20 ` [RESEND PATCH 1/2] " Tudor.Ambarus
  2018-10-23  9:20 ` [RESEND PATCH 2/2] i2c: at91: Save the bus " Tudor.Ambarus
  0 siblings, 2 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2018-10-23  9:20 UTC (permalink / raw)
  To: wsa, Ludovic.Desroches, Nicolas.Ferre, alexandre.belloni,
	linux-i2c, linux-arm-kernel, linux-kernel
  Cc: Tudor.Ambarus

The clock-frequency property is not mandatory for the i2c buses. If it's
not present in the device tree, the buses __usually__ assume it's 100kHZ
(see altera, at91, axxia, etc.). Broadcom uses a 375kHZ default
clock-frequency, so the default clock frequency varies from bus to bus.

There are i2c clients that need to know the bus clock frequency in order to
compute their wake token (see atecc508a i2c client).

The clock-frequency value has to be propagated to the i2c clients, otherwise,
if they will not find the i2c bus clock frequency in the device tree, they
will have to make their own assumption of the clock frequency.

Spare the i2c clients of making wrong assumptions of the i2c bus clock
frequency and enable the buses to save their clock frequency in adapter.

since rfc:
- reword commit messages

Tudor Ambarus (2):
  i2c: enable buses to save their clock frequency in adapter
  i2c: at91: Save the bus clock frequency in adapter

 drivers/i2c/busses/i2c-at91.c | 1 +
 include/linux/i2c.h           | 1 +
 2 files changed, 2 insertions(+)

-- 
2.9.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RESEND PATCH 1/2] i2c: enable buses to save their clock frequency in adapter
  2018-10-23  9:20 [RESEND PATCH 0/2] i2c: enable buses to save their clock frequency in adapter Tudor.Ambarus
@ 2018-10-23  9:20 ` Tudor.Ambarus
  2018-10-29 14:49   ` Ludovic Desroches
  2018-10-23  9:20 ` [RESEND PATCH 2/2] i2c: at91: Save the bus " Tudor.Ambarus
  1 sibling, 1 reply; 4+ messages in thread
From: Tudor.Ambarus @ 2018-10-23  9:20 UTC (permalink / raw)
  To: wsa, Ludovic.Desroches, Nicolas.Ferre, alexandre.belloni,
	linux-i2c, linux-arm-kernel, linux-kernel
  Cc: Tudor.Ambarus

The clock-frequency property is not mandatory for the i2c buses. If it's
not present in the device tree, the buses __usually__ assume it's 100kHZ
(see altera, at91, axxia, etc.). Broadcom uses a 375kHZ default
clock-frequency, so the default clock frequency varies from bus to bus.

There are i2c clients that need to know the bus clock frequency in order to
compute their wake token (see atecc508a i2c client).

The clock-frequency value has to be propagated to the i2c clients, otherwise,
if they will not find the i2c bus clock frequency in the device tree, they
will have to make their own assumption of the clock frequency.

Spare the i2c clients of making wrong assumptions of the i2c bus clock
frequency and enable the buses to save their clock frequency in adapter.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 include/linux/i2c.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 65b4eaed1d96..f238da204c49 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -677,6 +677,7 @@ struct i2c_adapter {
 	struct rt_mutex bus_lock;
 	struct rt_mutex mux_lock;
 
+	u32 bus_freq_hz;
 	int timeout;			/* in jiffies */
 	int retries;
 	struct device dev;		/* the adapter device */
-- 
2.9.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RESEND PATCH 2/2] i2c: at91: Save the bus clock frequency in adapter
  2018-10-23  9:20 [RESEND PATCH 0/2] i2c: enable buses to save their clock frequency in adapter Tudor.Ambarus
  2018-10-23  9:20 ` [RESEND PATCH 1/2] " Tudor.Ambarus
@ 2018-10-23  9:20 ` Tudor.Ambarus
  1 sibling, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2018-10-23  9:20 UTC (permalink / raw)
  To: wsa, Ludovic.Desroches, Nicolas.Ferre, alexandre.belloni,
	linux-i2c, linux-arm-kernel, linux-kernel
  Cc: Tudor.Ambarus

The clock-frequency property is not mandatory for the i2c buses. If it's
not present in the device tree, the buses __usually__ assume it's 100kHZ
(see altera, at91, axxia, etc.). Broadcom uses a 375kHZ default
clock-frequency, so the default clock frequency varies from bus to bus.

There are i2c clients that need to know the bus clock frequency in order to
compute their wake token (see atecc508a i2c client).

The clock-frequency value has to be propagated to the i2c clients, otherwise,
if they will not find the i2c bus clock frequency in the device tree, they
will have to make their own assumption of the clock frequency.

Spare the i2c clients of making wrong assumptions of the i2c bus clock
frequency and provide the bus clock frequency in adapter.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
 drivers/i2c/busses/i2c-at91.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 3f3e8b3bf5ff..9aa0937817ac 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -1124,6 +1124,7 @@ static int at91_twi_probe(struct platform_device *pdev)
 	dev->adapter.quirks = &at91_twi_quirks;
 	dev->adapter.dev.parent = dev->dev;
 	dev->adapter.nr = pdev->id;
+	dev->adapter.bus_freq_hz = bus_clk_rate;
 	dev->adapter.timeout = AT91_I2C_TIMEOUT;
 	dev->adapter.dev.of_node = pdev->dev.of_node;
 
-- 
2.9.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RESEND PATCH 1/2] i2c: enable buses to save their clock frequency in adapter
  2018-10-23  9:20 ` [RESEND PATCH 1/2] " Tudor.Ambarus
@ 2018-10-29 14:49   ` Ludovic Desroches
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Desroches @ 2018-10-29 14:49 UTC (permalink / raw)
  To: Tudor Ambarus - M18064
  Cc: wsa, Nicolas Ferre - M43238, alexandre.belloni, linux-i2c,
	linux-arm-kernel, linux-kernel

On Tue, Oct 23, 2018 at 11:20:39AM +0200, Tudor Ambarus - M18064 wrote:
> The clock-frequency property is not mandatory for the i2c buses. If it's
> not present in the device tree, the buses __usually__ assume it's 100kHZ
> (see altera, at91, axxia, etc.). Broadcom uses a 375kHZ default
> clock-frequency, so the default clock frequency varies from bus to bus.
> 
> There are i2c clients that need to know the bus clock frequency in order to
> compute their wake token (see atecc508a i2c client).
> 
> The clock-frequency value has to be propagated to the i2c clients, otherwise,
> if they will not find the i2c bus clock frequency in the device tree, they
> will have to make their own assumption of the clock frequency.
> 
> Spare the i2c clients of making wrong assumptions of the i2c bus clock
> frequency and enable the buses to save their clock frequency in adapter.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviwed-by: Ludovic Desroches <ludovic.desroches@microchip.com>

> ---
>  include/linux/i2c.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 65b4eaed1d96..f238da204c49 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -677,6 +677,7 @@ struct i2c_adapter {
>  	struct rt_mutex bus_lock;
>  	struct rt_mutex mux_lock;
>  
> +	u32 bus_freq_hz;
>  	int timeout;			/* in jiffies */
>  	int retries;
>  	struct device dev;		/* the adapter device */
> -- 
> 2.9.4
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-29 14:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23  9:20 [RESEND PATCH 0/2] i2c: enable buses to save their clock frequency in adapter Tudor.Ambarus
2018-10-23  9:20 ` [RESEND PATCH 1/2] " Tudor.Ambarus
2018-10-29 14:49   ` Ludovic Desroches
2018-10-23  9:20 ` [RESEND PATCH 2/2] i2c: at91: Save the bus " Tudor.Ambarus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).