From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Gavin Schenk <g.schenk@eckelmann.de>,
Oleksij Rempel <ore@pengutronix.de>
Subject: Re: [PATCH] ARM: dts: fix imx7d boot spi dma setup error
Date: Tue, 23 Oct 2018 12:13:03 +0200 [thread overview]
Message-ID: <20181023101302.ttniiewnouyrufdg@pengutronix.de> (raw)
In-Reply-To: <20181023083356.17579-1-xiaoning.wang@nxp.com>
On Tue, Oct 23, 2018 at 08:36:17AM +0000, Clark Wang wrote:
> Add dmas and dma-names for ecspi1~4 to fix kernel boot error:
> "spi_imx 30840000.ecspi: dma setup error -19, use pio".
Actually this should not be an error and the message is supposed to say:
Unable to setup DMA, falling back to PIO
So IMHO this should be downgraded from dev_err to dev_info and reworded.
Maybe even try DMA-setup on devices where it is known to fail and don't
emit a message on -ENODEV at all.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2018-10-23 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 8:36 [PATCH] ARM: dts: fix imx7d boot spi dma setup error Clark Wang
2018-10-23 10:13 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023101302.ttniiewnouyrufdg@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=g.schenk@eckelmann.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ore@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).