From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Benjamin Peterson <benjamin@python.org>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf trace beautify: Beautify flags of mount(2) and umount(2).
Date: Wed, 24 Oct 2018 17:18:04 -0300 [thread overview]
Message-ID: <20181024201804.GG15106@kernel.org> (raw)
In-Reply-To: <1540262435.2865915.1551182688.3057DD9D@webmail.messagingengine.com>
Em Mon, Oct 22, 2018 at 07:40:35PM -0700, Benjamin Peterson escreveu:
>
>
> On Wed, Oct 10, 2018, at 05:55, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Oct 09, 2018 at 08:52:26PM -0700, Benjamin Peterson escreveu:
> > > Hi Arnaldo,
> > > Did you get a chance to look at this again?
> > Thanks, for pinging me about it, will check.
> Will the main part of my patch manage to make the cut for 4.20?
The functionality will, but I'm implementing it differently, the model
you used to create the patch is being phased out, now we're unsing a
model that create tables from the header files where those flags are
defined, so that when a new one gets added, we get it included
automatically, please take a look at:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/trace.mount_flags
More specifically this one:
https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/trace.mount_flags&id=341628af5643adbaa78097d528f34b4b16aa908f
That will be used by one like tools/perf/trace/beauty/pkey_alloc.c, that
goes looking if the bits are set and if so, get the strings from the
table, etc.
In time pkey_alloc__scnprintf_access_rights() will be further
generalized, as all it needs is a strarray + the flags integer to
produce a simbolic or-ed flags string.
Sorry for taking so long, kept being sidetracked with other stuff...
- Arnaldo
next prev parent reply other threads:[~2018-10-24 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 3:53 [PATCH] perf trace beautify: Beautify flags of mount(2) and umount(2) Benjamin Peterson
2018-08-30 18:28 ` Arnaldo Carvalho de Melo
2018-08-30 21:50 ` Benjamin Peterson
2018-10-10 3:52 ` Benjamin Peterson
2018-10-10 12:55 ` Arnaldo Carvalho de Melo
2018-10-10 12:56 ` Arnaldo Carvalho de Melo
2018-10-23 2:40 ` Benjamin Peterson
2018-10-24 20:18 ` Arnaldo Carvalho de Melo [this message]
2018-10-26 6:23 ` Benjamin Peterson
2018-09-06 13:44 ` [tip:perf/core] perf trace beauty: Alias 'umount' to 'umount2' tip-bot for Benjamin Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024201804.GG15106@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=benjamin@python.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).