* [PATCH] sched/rt: Fix a comment in pick_next_task_rt()
@ 2018-10-27 3:05 Muchun Song
2018-10-29 11:34 ` [tip:sched/urgent] sched/rt: Update " tip-bot for Muchun Song
0 siblings, 1 reply; 2+ messages in thread
From: Muchun Song @ 2018-10-27 3:05 UTC (permalink / raw)
To: mingo, peterz; +Cc: linux-kernel
Commit f4ebcbc0d7e0 ("sched/rt: Substract number of tasks of throttled
queues from rq->nr_running") added a new member rt_rq->rt_queued, which
is used to indicate the status of rq->rt enqueue or dequeue. So, the
check rt_nr_running was removed and we now check rt_queued.
Fix the comment in pick_next_task_rt() to avoid confusing.
Signed-off-by: Muchun Song <smuchun@gmail.com>
---
kernel/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 2e2955a8cf8f..a21ea6021929 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1561,7 +1561,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
/*
* We may dequeue prev's rt_rq in put_prev_task().
- * So, we update time before rt_nr_running check.
+ * So, we update time before rt_queued check.
*/
if (prev->sched_class == &rt_sched_class)
update_curr_rt(rq);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:sched/urgent] sched/rt: Update comment in pick_next_task_rt()
2018-10-27 3:05 [PATCH] sched/rt: Fix a comment in pick_next_task_rt() Muchun Song
@ 2018-10-29 11:34 ` tip-bot for Muchun Song
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Muchun Song @ 2018-10-29 11:34 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, torvalds, linux-kernel, smuchun, mingo, peterz, hpa
Commit-ID: a68d75081aeccfb169575bea6f452a5a12b9f49b
Gitweb: https://git.kernel.org/tip/a68d75081aeccfb169575bea6f452a5a12b9f49b
Author: Muchun Song <smuchun@gmail.com>
AuthorDate: Sat, 27 Oct 2018 11:05:17 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 29 Oct 2018 07:18:04 +0100
sched/rt: Update comment in pick_next_task_rt()
Commit:
f4ebcbc0d7e0 ("sched/rt: Substract number of tasks of throttled queues from rq->nr_running")
added a new rt_rq->rt_queued field, which is used to indicate the status of
rq->rt enqueue or dequeue. So, the ->rt_nr_running check was removed and we
now check ->rt_queued instead.
Fix the comment in pick_next_task_rt() as well, which was still referencing
the old logic.
Signed-off-by: Muchun Song <smuchun@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20181027030517.23292-1-smuchun@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 2e2955a8cf8f..a21ea6021929 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1561,7 +1561,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
/*
* We may dequeue prev's rt_rq in put_prev_task().
- * So, we update time before rt_nr_running check.
+ * So, we update time before rt_queued check.
*/
if (prev->sched_class == &rt_sched_class)
update_curr_rt(rq);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-29 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-27 3:05 [PATCH] sched/rt: Fix a comment in pick_next_task_rt() Muchun Song
2018-10-29 11:34 ` [tip:sched/urgent] sched/rt: Update " tip-bot for Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).