* [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node
@ 2018-10-26 12:25 Sibi Sankar
2018-10-29 1:35 ` Bjorn Andersson
2018-10-29 9:32 ` Stanimir Varbanov
0 siblings, 2 replies; 4+ messages in thread
From: Sibi Sankar @ 2018-10-26 12:25 UTC (permalink / raw)
To: andy.gross, david.brown, robh+dt
Cc: bjorn.andersson, dianders, evgreen, benchan, linux-arm-msm,
linux-soc, devicetree, linux-kernel, tsoni, Sibi Sankar
Add SCM DT node to enable SCM functionality on SDM845.
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index b72bdb0a31a5..fad22acfda4d 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -221,6 +221,12 @@
};
};
+ firmware {
+ scm {
+ compatible = "qcom,scm-sdm845", "qcom,scm";
+ };
+ };
+
tcsr_mutex: hwlock {
compatible = "qcom,tcsr-mutex";
syscon = <&tcsr_mutex_regs 0 0x1000>;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node
2018-10-26 12:25 [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node Sibi Sankar
@ 2018-10-29 1:35 ` Bjorn Andersson
2018-10-29 9:32 ` Stanimir Varbanov
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-10-29 1:35 UTC (permalink / raw)
To: Sibi Sankar
Cc: andy.gross, david.brown, robh+dt, dianders, evgreen, benchan,
linux-arm-msm, linux-soc, devicetree, linux-kernel, tsoni
On Fri 26 Oct 05:25 PDT 2018, Sibi Sankar wrote:
> Add SCM DT node to enable SCM functionality on SDM845.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index b72bdb0a31a5..fad22acfda4d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -221,6 +221,12 @@
> };
> };
>
> + firmware {
> + scm {
> + compatible = "qcom,scm-sdm845", "qcom,scm";
> + };
> + };
> +
> tcsr_mutex: hwlock {
> compatible = "qcom,tcsr-mutex";
> syscon = <&tcsr_mutex_regs 0 0x1000>;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node
2018-10-26 12:25 [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node Sibi Sankar
2018-10-29 1:35 ` Bjorn Andersson
@ 2018-10-29 9:32 ` Stanimir Varbanov
2018-10-29 14:54 ` Sibi Sankar
1 sibling, 1 reply; 4+ messages in thread
From: Stanimir Varbanov @ 2018-10-29 9:32 UTC (permalink / raw)
To: Sibi Sankar, andy.gross, david.brown, robh+dt
Cc: bjorn.andersson, dianders, evgreen, benchan, linux-arm-msm,
linux-soc, devicetree, linux-kernel, tsoni
Hi Sibi,
On 10/26/2018 03:25 PM, Sibi Sankar wrote:
> Add SCM DT node to enable SCM functionality on SDM845.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index b72bdb0a31a5..fad22acfda4d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -221,6 +221,12 @@
> };
> };
>
> + firmware {
> + scm {
> + compatible = "qcom,scm-sdm845", "qcom,scm";
> + };
> + };
What will happen if the platform is without tz firmware? I'd move this
DT node in sdm845-mtp.dts or at least make it status = disabled.
--
regards,
Stan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node
2018-10-29 9:32 ` Stanimir Varbanov
@ 2018-10-29 14:54 ` Sibi Sankar
0 siblings, 0 replies; 4+ messages in thread
From: Sibi Sankar @ 2018-10-29 14:54 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: andy.gross, david.brown, robh+dt, bjorn.andersson, dianders,
evgreen, benchan, linux-arm-msm, linux-soc, devicetree,
linux-kernel, tsoni
Hi Stan,
Thanks for the review!
On 2018-10-29 15:02, Stanimir Varbanov wrote:
> Hi Sibi,
>
> On 10/26/2018 03:25 PM, Sibi Sankar wrote:
>> Add SCM DT node to enable SCM functionality on SDM845.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index b72bdb0a31a5..fad22acfda4d 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -221,6 +221,12 @@
>> };
>> };
>>
>> + firmware {
>> + scm {
>> + compatible = "qcom,scm-sdm845", "qcom,scm";
>> + };
>> + };
>
> What will happen if the platform is without tz firmware? I'd move this
> DT node in sdm845-mtp.dts or at least make it status = disabled.
Even in the absence of tz firmware, ATF is expected to implement the
necessary
handlers for the SMC calls so I don't think it is necessary to keep it
disabled.
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-29 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 12:25 [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node Sibi Sankar
2018-10-29 1:35 ` Bjorn Andersson
2018-10-29 9:32 ` Stanimir Varbanov
2018-10-29 14:54 ` Sibi Sankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).