* [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
@ 2018-10-26 17:58 Colin King
2018-10-29 11:35 ` [tip:perf/urgent] perf/headers: Fix spelling mistake in <linux/perf_event.h> comment, " tip-bot for Colin Ian King
2018-10-29 12:28 ` [PATCH] drivers/perf: fix spelling mistake, " Arnaldo Carvalho de Melo
0 siblings, 2 replies; 9+ messages in thread
From: Colin King @ 2018-10-26 17:58 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Alexander Shishkin, Jiri Olsa, Namhyung Kim
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to a spelling mistake of the error access name EACCESS,
rename to EACCES
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
include/linux/perf_event.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 53c500f0ca79..57b07c9ddeb4 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -288,7 +288,7 @@ struct pmu {
* -EBUSY -- @event is for this PMU but PMU temporarily unavailable
* -EINVAL -- @event is for this PMU but @event is not valid
* -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
- * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
+ * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
*
* 0 -- @event is for this PMU and valid
*
--
2.19.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [tip:perf/urgent] perf/headers: Fix spelling mistake in <linux/perf_event.h> comment, EACCESS -> EACCES
2018-10-26 17:58 [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES Colin King
@ 2018-10-29 11:35 ` tip-bot for Colin Ian King
2018-10-29 12:28 ` [PATCH] drivers/perf: fix spelling mistake, " Arnaldo Carvalho de Melo
1 sibling, 0 replies; 9+ messages in thread
From: tip-bot for Colin Ian King @ 2018-10-29 11:35 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, jolsa, torvalds, alexander.shishkin, colin.king, tglx,
mingo, acme, namhyung, linux-kernel, hpa
Commit-ID: 1df02354b42f3f4504b6287c54a8cfbe1533719f
Gitweb: https://git.kernel.org/tip/1df02354b42f3f4504b6287c54a8cfbe1533719f
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Fri, 26 Oct 2018 18:58:39 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 29 Oct 2018 07:21:07 +0100
perf/headers: Fix spelling mistake in <linux/perf_event.h> comment, EACCESS -> EACCES
Trivial fix to a spelling mistake of the error access name 'EACCESS',
rename to EACCES.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/20181026175839.4565-1-colin.king@canonical.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
include/linux/perf_event.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 53c500f0ca79..57b07c9ddeb4 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -288,7 +288,7 @@ struct pmu {
* -EBUSY -- @event is for this PMU but PMU temporarily unavailable
* -EINVAL -- @event is for this PMU but @event is not valid
* -EOPNOTSUPP -- @event is for this PMU, @event is valid, but not supported
- * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
+ * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
*
* 0 -- @event is for this PMU and valid
*
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
2018-10-26 17:58 [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES Colin King
2018-10-29 11:35 ` [tip:perf/urgent] perf/headers: Fix spelling mistake in <linux/perf_event.h> comment, " tip-bot for Colin Ian King
@ 2018-10-29 12:28 ` Arnaldo Carvalho de Melo
2018-10-29 12:33 ` Colin Ian King
` (2 more replies)
1 sibling, 3 replies; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-10-29 12:28 UTC (permalink / raw)
To: Colin King
Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa,
Namhyung Kim, kernel-janitors, linux-kernel
Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to a spelling mistake of the error access name EACCESS,
> rename to EACCES
Thanks, applied.
And I also took the chance to fix another spelling mistake, on this same
line:
- * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
+ * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
^
^
^
^
:-)
- Arnaldo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
2018-10-29 12:28 ` [PATCH] drivers/perf: fix spelling mistake, " Arnaldo Carvalho de Melo
@ 2018-10-29 12:33 ` Colin Ian King
2018-10-29 12:33 ` Arnaldo Carvalho de Melo
2018-10-29 12:35 ` Ingo Molnar
2 siblings, 0 replies; 9+ messages in thread
From: Colin Ian King @ 2018-10-29 12:33 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa,
Namhyung Kim, kernel-janitors, linux-kernel
On 29/10/2018 12:28, Arnaldo Carvalho de Melo wrote:
> Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to a spelling mistake of the error access name EACCESS,
>> rename to EACCES
>
> Thanks, applied.
>
> And I also took the chance to fix another spelling mistake, on this same
> line:
>
> - * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
> + * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
> ^
> ^
> ^
> ^
Nice find, I completely missed that :-)
>
> :-)
>
> - Arnaldo
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
2018-10-29 12:28 ` [PATCH] drivers/perf: fix spelling mistake, " Arnaldo Carvalho de Melo
2018-10-29 12:33 ` Colin Ian King
@ 2018-10-29 12:33 ` Arnaldo Carvalho de Melo
2018-10-29 12:36 ` Ingo Molnar
2018-10-29 12:35 ` Ingo Molnar
2 siblings, 1 reply; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-10-29 12:33 UTC (permalink / raw)
To: Colin King
Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa,
Namhyung Kim, kernel-janitors, linux-kernel
Em Mon, Oct 29, 2018 at 09:28:54AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Trivial fix to a spelling mistake of the error access name EACCESS,
> > rename to EACCES
>
> Thanks, applied.
>
> And I also took the chance to fix another spelling mistake, on this same
> line:
>
> - * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
> + * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
> ^
> ^
> ^
> ^
But I see Ingo has already merged your patch, lets fix that one later
then :-)
- Arnaldo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
2018-10-29 12:28 ` [PATCH] drivers/perf: fix spelling mistake, " Arnaldo Carvalho de Melo
2018-10-29 12:33 ` Colin Ian King
2018-10-29 12:33 ` Arnaldo Carvalho de Melo
@ 2018-10-29 12:35 ` Ingo Molnar
2 siblings, 0 replies; 9+ messages in thread
From: Ingo Molnar @ 2018-10-29 12:35 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Colin King, Peter Zijlstra, Ingo Molnar, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, kernel-janitors, linux-kernel
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Trivial fix to a spelling mistake of the error access name EACCESS,
> > rename to EACCES
>
> Thanks, applied.
>
> And I also took the chance to fix another spelling mistake, on this same
> line:
>
> - * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
> + * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
> ^
> ^
> ^
> ^
>
> :-)
LOL.
I zapped my commit from perf/urgent, because I failed to notice the
second typo :-)
Thanks,
Ingo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
2018-10-29 12:33 ` Arnaldo Carvalho de Melo
@ 2018-10-29 12:36 ` Ingo Molnar
2018-10-29 13:20 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 9+ messages in thread
From: Ingo Molnar @ 2018-10-29 12:36 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Colin King, Peter Zijlstra, Ingo Molnar, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, kernel-janitors, linux-kernel
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Mon, Oct 29, 2018 at 09:28:54AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Trivial fix to a spelling mistake of the error access name EACCESS,
> > > rename to EACCES
> >
> > Thanks, applied.
> >
> > And I also took the chance to fix another spelling mistake, on this same
> > line:
> >
> > - * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
> > + * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
> > ^
> > ^
> > ^
> > ^
>
> But I see Ingo has already merged your patch, lets fix that one later
> then :-)
I zapped my commit, please let's merge your upgraded version.
BTW., while at it, could we also try a header refresh now that a lot of
the merge window changes to headers are behind us, this is from the
perf/urgent build (f0718d792b8a)"
Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h'
diff -u tools/include/uapi/linux/kvm.h include/uapi/linux/kvm.h
Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h'
diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h
Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h
Warning: Kernel ABI header at 'tools/arch/x86/include/uapi/asm/kvm.h' differs from latest version at 'arch/x86/include/uapi/asm/kvm.h'
diff -u tools/arch/x86/include/uapi/asm/kvm.h arch/x86/include/uapi/asm/kvm.h
Warning: Kernel ABI header at 'tools/arch/powerpc/include/uapi/asm/kvm.h' differs from latest version at 'arch/powerpc/include/uapi/asm/kvm.h'
diff -u tools/arch/powerpc/include/uapi/asm/kvm.h arch/powerpc/include/uapi/asm/kvm.h
Warning: Kernel ABI header at 'tools/arch/s390/include/uapi/asm/kvm.h' differs from latest version at 'arch/s390/include/uapi/asm/kvm.h'
diff -u tools/arch/s390/include/uapi/asm/kvm.h arch/s390/include/uapi/asm/kvm.h
Warning: Kernel ABI header at 'tools/arch/arm64/include/uapi/asm/unistd.h' differs from latest version at 'arch/arm64/include/uapi/asm/unistd.h'
diff -u tools/arch/arm64/include/uapi/asm/unistd.h arch/arm64/include/uapi/asm/unistd.h
Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/unistd.h' differs from latest version at 'include/uapi/asm-generic/unistd.h'
diff -u tools/include/uapi/asm-generic/unistd.h include/uapi/asm-generic/unistd.h
Warning: Kernel ABI header at 'tools/include/uapi/linux/mman.h' differs from latest version at 'include/uapi/linux/mman.h'
diff -u tools/include/uapi/linux/mman.h include/uapi/linux/mman.h
?
Thanks!
Ingo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
2018-10-29 12:36 ` Ingo Molnar
@ 2018-10-29 13:20 ` Arnaldo Carvalho de Melo
2018-10-29 14:19 ` Ingo Molnar
0 siblings, 1 reply; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-10-29 13:20 UTC (permalink / raw)
To: Ingo Molnar
Cc: Colin King, Peter Zijlstra, Ingo Molnar, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, kernel-janitors, linux-kernel
Em Mon, Oct 29, 2018 at 01:36:56PM +0100, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> > Em Mon, Oct 29, 2018 at 09:28:54AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
> > > > From: Colin Ian King <colin.king@canonical.com>
> > > >
> > > > Trivial fix to a spelling mistake of the error access name EACCESS,
> > > > rename to EACCES
> > >
> > > Thanks, applied.
> > >
> > > And I also took the chance to fix another spelling mistake, on this same
> > > line:
> > >
> > > - * -EACCESS -- @event is for this PMU, @event is valid, but no privilidges
> > > + * -EACCES -- @event is for this PMU, @event is valid, but no privilidges
> > > ^
> > > ^
> > > ^
> > > ^
> >
> > But I see Ingo has already merged your patch, lets fix that one later
> > then :-)
>
> I zapped my commit, please let's merge your upgraded version.
>
> BTW., while at it, could we also try a header refresh now that a lot of
> the merge window changes to headers are behind us, this is from the
> perf/urgent build (f0718d792b8a)"
>
> Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h'
> diff -u tools/include/uapi/linux/kvm.h include/uapi/linux/kvm.h
> Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h'
> diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h
> Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
> diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h
> Warning: Kernel ABI header at 'tools/arch/x86/include/uapi/asm/kvm.h' differs from latest version at 'arch/x86/include/uapi/asm/kvm.h'
> diff -u tools/arch/x86/include/uapi/asm/kvm.h arch/x86/include/uapi/asm/kvm.h
> Warning: Kernel ABI header at 'tools/arch/powerpc/include/uapi/asm/kvm.h' differs from latest version at 'arch/powerpc/include/uapi/asm/kvm.h'
> diff -u tools/arch/powerpc/include/uapi/asm/kvm.h arch/powerpc/include/uapi/asm/kvm.h
> Warning: Kernel ABI header at 'tools/arch/s390/include/uapi/asm/kvm.h' differs from latest version at 'arch/s390/include/uapi/asm/kvm.h'
> diff -u tools/arch/s390/include/uapi/asm/kvm.h arch/s390/include/uapi/asm/kvm.h
> Warning: Kernel ABI header at 'tools/arch/arm64/include/uapi/asm/unistd.h' differs from latest version at 'arch/arm64/include/uapi/asm/unistd.h'
> diff -u tools/arch/arm64/include/uapi/asm/unistd.h arch/arm64/include/uapi/asm/unistd.h
> Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/unistd.h' differs from latest version at 'include/uapi/asm-generic/unistd.h'
> diff -u tools/include/uapi/asm-generic/unistd.h include/uapi/asm-generic/unistd.h
> Warning: Kernel ABI header at 'tools/include/uapi/linux/mman.h' differs from latest version at 'include/uapi/linux/mman.h'
> diff -u tools/include/uapi/linux/mman.h include/uapi/linux/mman.h
>
> ?
>
> Thanks!
Ok, I'll put together a perf/urgent with those things resolved, may take
a day or two as I'm working on addressing DaveM's reported issues and in
fixing the regressions that that "remove fallback to kallsyms for
userspace addresses" patch caused.
- Arnaldo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES
2018-10-29 13:20 ` Arnaldo Carvalho de Melo
@ 2018-10-29 14:19 ` Ingo Molnar
0 siblings, 0 replies; 9+ messages in thread
From: Ingo Molnar @ 2018-10-29 14:19 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Colin King, Peter Zijlstra, Ingo Molnar, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, kernel-janitors, linux-kernel
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Ok, I'll put together a perf/urgent with those things resolved, may take
> a day or two as I'm working on addressing DaveM's reported issues and in
> fixing the regressions that that "remove fallback to kallsyms for
> userspace addresses" patch caused.
Sure thing, no rush!
Thanks,
Ingo
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-10-29 14:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 17:58 [PATCH] drivers/perf: fix spelling mistake, EACCESS -> EACCES Colin King
2018-10-29 11:35 ` [tip:perf/urgent] perf/headers: Fix spelling mistake in <linux/perf_event.h> comment, " tip-bot for Colin Ian King
2018-10-29 12:28 ` [PATCH] drivers/perf: fix spelling mistake, " Arnaldo Carvalho de Melo
2018-10-29 12:33 ` Colin Ian King
2018-10-29 12:33 ` Arnaldo Carvalho de Melo
2018-10-29 12:36 ` Ingo Molnar
2018-10-29 13:20 ` Arnaldo Carvalho de Melo
2018-10-29 14:19 ` Ingo Molnar
2018-10-29 12:35 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).