From: Dean Wallace <duffydack73@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
Stable <stable@vger.kernel.org>,
Johannes Stezenbach <js@sig21.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mogens Jensen <mogens-jensen@protonmail.com>
Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)
Date: Thu, 1 Nov 2018 14:28:59 +0000 [thread overview]
Message-ID: <20181101142859.oxtuhbwtt44h2u3r@picard> (raw)
In-Reply-To: <37e44480-44d3-9355-6119-ae46bb38678a@redhat.com>
On 01-11-18, Hans de Goede wrote:
> Hi,
>
> On 01-11-18 11:37, Dean Wallace wrote:
> > On 31-10-18, Pierre-Louis Bossart wrote:
> > >
> > > > Just thought it worth mentioning, this new patch that fixes sound
> > > > again, seems to have ressurected an old issue with PLL unlock. I'm
> > > > seeing journal entries after fresh boot ......
> > > >
> > > > ```
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard systemd[462]: Started Sound Service.
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > picard kernel: max98090_pll_work: 141 callbacks suppressed
> > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked
> > > > ```
> > > >
> > > > sound is ok, but sometimes plugging in headphones spams journal with
> > > > those PLL messages, and sound turns into "daleks", and I have to
> > > > remove/insert headphones few times or stop/start audio to fix it.
> > > > It's a very old issue, maybe you'd know more about it.
> > >
> > > I noticed this error on my Orco device used for tests many moons ago, but I
> > > could never find out what led to this error case, it wasn't deterministic
> > > and didn't impact the audio quality. All I could do is rate_limit it... If
> > > we have an A vs. B situation it'd be really helpful to diagnose further.
> > >
> > > Is there really a causality between the changes from Hans and this PLL
> > > unlock error? Are you 100% sure this was not present in the previous install
> > > you used (4.18.14 as mentioned earlier in the thread)?
> > >
> > > Thanks
> > >
> > > -Pierre
> > >
> > Well, numerous boots, kernels, headphone inserting - no PLL or
> > 'Daleks'. My laptop must have been haunted that day (halloween).
> > I'll put it to bed.
>
> So you can no longer reproduce. Bummer. Note this might be caused by
> the temperature of the laptop when you were running the tests...
>
> Anyways if you hit this again and you can reproduce it, please
> give adding a msleep(10) after code mucking with the clk a try.
>
> Regards,
>
> Hans
>
Right then, I can make it unlock and 'daleks' by going into
pavucontrol and switching the Profile back and forth from Stereo
Output to Stereo Output+Analog Mono Input, which is actually something
I've done to make it correct itself as well. I don't use the mic or
anything so I've had it set to Stereo Ouput only which I 'think' has
somehow made it more stable for me. With all my playing around, one
of the things I did was clean out my .config/pulse folder which meant
by default the 'Profile' in pavucontrol was set to Output+Input, which
seems to help trigger the PLL issue when inserting headphones.
So what would you like me to do, as I can trigger it on demand it
seems.
--
Dean
next prev parent reply other threads:[~2018-11-01 14:29 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181025232517.ywnw54qibemosjws@picard>
2018-10-29 17:45 ` Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL) Stephen Boyd
2018-10-29 17:52 ` Andy Shevchenko
2018-10-29 18:04 ` Andy Shevchenko
2018-10-29 19:08 ` Dean Wallace
2018-10-29 22:03 ` Pierre-Louis Bossart
2018-10-30 10:17 ` Hans de Goede
2018-10-30 11:05 ` Hans de Goede
2018-10-30 16:24 ` Andy Shevchenko
2018-10-30 11:19 ` Hans de Goede
2018-10-30 14:38 ` Dean Wallace
2018-10-30 14:48 ` Hans de Goede
2018-10-30 15:03 ` Andy Shevchenko
2018-10-30 15:25 ` Pierre-Louis Bossart
2018-10-30 15:04 ` Pierre-Louis Bossart
2018-10-30 15:46 ` Hans de Goede
2018-10-30 16:02 ` Hans de Goede
2018-10-30 16:27 ` Pierre-Louis Bossart
2018-10-30 18:31 ` Hans de Goede
2018-10-30 16:03 ` Pierre-Louis Bossart
2018-10-30 16:04 ` Hans de Goede
2018-10-30 16:15 ` Dean Wallace
2018-10-31 11:04 ` Hans de Goede
2018-10-31 12:45 ` Dean Wallace
2018-10-31 20:07 ` Dean Wallace
2018-10-31 22:27 ` Pierre-Louis Bossart
2018-10-31 23:57 ` Dean Wallace
2018-11-01 10:37 ` Dean Wallace
2018-11-01 13:57 ` Hans de Goede
2018-11-01 14:28 ` Dean Wallace [this message]
2018-11-01 14:49 ` Hans de Goede
2018-11-01 15:29 ` Dean Wallace
2018-11-01 15:39 ` Dean Wallace
2018-11-01 15:50 ` Dean Wallace
2018-11-02 10:27 ` Hans de Goede
2018-11-02 11:15 ` Dean Wallace
2018-11-01 13:56 ` Hans de Goede
2018-10-30 18:56 ` Mogens Jensen
2018-10-30 19:10 ` Hans de Goede
2018-10-31 6:02 ` Mogens Jensen
2018-10-31 9:29 ` Hans de Goede
2018-10-31 10:03 ` Dean Wallace
2018-11-01 6:55 ` Mogens Jensen
2018-12-02 12:25 ` Hans de Goede
2019-01-17 5:58 ` Mogens Jensen
2019-01-17 9:12 ` Dean Wallace
2019-01-17 12:05 ` Hans de Goede
2019-01-17 13:05 ` Johannes Stezenbach
2019-01-17 13:16 ` Dean Wallace
2019-01-18 15:33 ` Hans de Goede
2019-01-17 19:30 ` Mogens Jensen
2019-01-18 15:35 ` Hans de Goede
2019-01-21 5:55 ` Mogens Jensen
2019-01-22 19:27 ` Pierre-Louis Bossart
2019-01-25 5:16 ` Mogens Jensen
2019-01-25 14:12 ` Pierre-Louis Bossart
2019-01-25 17:57 ` Pierre-Louis Bossart
2019-01-25 20:30 ` Andy Shevchenko
2019-01-24 10:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101142859.oxtuhbwtt44h2u3r@picard \
--to=duffydack73@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=js@sig21.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mogens-jensen@protonmail.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).